Re: [OE-core] ✗ patchtest: failure for systemd: backport patch to fix sysctl warning on boot

2019-07-15 Thread Richard Purdie
On Mon, 2019-07-15 at 11:53 +0200, Matthias Schiffer wrote:
> On Wed, 2019-07-10 at 14:40 +0200, Matthias Schiffer wrote:
> > On Wed, 2019-07-10 at 12:31 +, Patchwork wrote:
> > > * Issue Series cannot be parsed correctly due to
> > > malformed diff lines [test_mbox_format] 
> > >   Suggested fixCreate the series again using git-format-patch
> > > and
> > > ensure it can be applied using git am
> > >   Diff lineHunk is shorter than expected
> > > 
> > > * Issue Series does not apply on top of target branch
> > > [test_series_merge_on_head] 
> > >   Suggested fixRebase your series on top of targeted branch
> > >   Targeted branch  master (currently at 4cbb7392c7)
> > 
> > I'm not sure what is going on here, the patch applies fine for me.
> > 
> > Is it possible that the patchtest stumbles over unicode characters
> > in
> > the added patch file? I don't see how that could be avoided, as the
> > patch touches a line where an emoji was used in a comment...
> > 
> > Kind regards,
> > Matthias
> 
> Ah, the issue is patchwork, not patchtest - the mbox download is cut
> off at the non-ASCII character. Should I try resending the patch with
> something like --transfer-encoding=quoted-printable ?

I've queued the patch for testing, the patch itself applies fine so we
can handle it, it just doesn't get the automated testing.

Cheers,

Richard

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] ✗ patchtest: failure for systemd: backport patch to fix sysctl warning on boot

2019-07-15 Thread Matthias Schiffer
On Wed, 2019-07-10 at 14:40 +0200, Matthias Schiffer wrote:
> On Wed, 2019-07-10 at 12:31 +, Patchwork wrote:
> > * Issue Series cannot be parsed correctly due to
> > malformed diff lines [test_mbox_format] 
> >   Suggested fixCreate the series again using git-format-patch
> > and
> > ensure it can be applied using git am
> >   Diff lineHunk is shorter than expected
> > 
> > * Issue Series does not apply on top of target branch
> > [test_series_merge_on_head] 
> >   Suggested fixRebase your series on top of targeted branch
> >   Targeted branch  master (currently at 4cbb7392c7)
> 
> I'm not sure what is going on here, the patch applies fine for me.
> 
> Is it possible that the patchtest stumbles over unicode characters in
> the added patch file? I don't see how that could be avoided, as the
> patch touches a line where an emoji was used in a comment...
> 
> Kind regards,
> Matthias

Ah, the issue is patchwork, not patchtest - the mbox download is cut
off at the non-ASCII character. Should I try resending the patch with
something like --transfer-encoding=quoted-printable ?


-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] ✗ patchtest: failure for systemd: backport patch to fix sysctl warning on boot

2019-07-10 Thread Matthias Schiffer
On Wed, 2019-07-10 at 12:31 +, Patchwork wrote:
> == Series Details ==
> 
> Series: systemd: backport patch to fix sysctl warning on boot
> Revision: 1
> URL   : https://patchwork.openembedded.org/series/18605/
> State : failure
> 
> == Summary ==
> 
> 
> Thank you for submitting this patch series to OpenEmbedded Core. This
> is
> an automated response. Several tests have been executed on the
> proposed
> series by patchtest resulting in the following failures:
> 
> 
> 
> * Issue Series cannot be parsed correctly due to
> malformed diff lines [test_mbox_format] 
>   Suggested fixCreate the series again using git-format-patch and
> ensure it can be applied using git am
>   Diff lineHunk is shorter than expected
> 
> * Issue Series does not apply on top of target branch
> [test_series_merge_on_head] 
>   Suggested fixRebase your series on top of targeted branch
>   Targeted branch  master (currently at 4cbb7392c7)

I'm not sure what is going on here, the patch applies fine for me.

Is it possible that the patchtest stumbles over unicode characters in
the added patch file? I don't see how that could be avoided, as the
patch touches a line where an emoji was used in a comment...

Kind regards,
Matthias


> 
> 
> 
> If you believe any of these test results are incorrect, please reply
> to the
> mailing list (openembedded-core@lists.openembedded.org) raising your
> concerns.
> Otherwise we would appreciate you correcting the issues and
> submitting a new
> version of the patchset if applicable. Please ensure you
> add/increment the
> version number when sending the new version (i.e. [PATCH] -> [PATCH
> v2] ->
> [PATCH v3] -> ...).
> 
> ---
> Guidelines: 
> https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
> Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
> Test suite: 
> http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
> 

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core