Re: [oe] [RFC meta-gnome][PATCH 03/16] gjs: add a recipe for gjs (Gnome JavaScript engine)
Sounds good I will refresh that change into a patch. Thanks, Brendan On Mon, Oct 29, 2018 at 2:07 PM Burton, Ross wrote: > On Mon, 29 Oct 2018 at 16:42, brendank310 wrote: > > > +do_configure_prepend() { > > + export > GI_DATADIR="${RECIPE_SYSROOT_NATIVE}${datadir}/gobject-introspection-1.0" > > + sed -i 's#mozjs-17#mozjs-52#g' ${S}/configure.ac > > +} > > Personally I prefer patches to sed in do_configure, as nobody will > notice when the sed isn't required anymore and the point of the change > isn't always obvious. > > Ross > -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [RFC meta-gnome][PATCH 03/16] gjs: add a recipe for gjs (Gnome JavaScript engine)
On Mon, 29 Oct 2018 at 16:42, brendank310 wrote: > +do_configure_prepend() { > + export > GI_DATADIR="${RECIPE_SYSROOT_NATIVE}${datadir}/gobject-introspection-1.0" > + sed -i 's#mozjs-17#mozjs-52#g' ${S}/configure.ac > +} Personally I prefer patches to sed in do_configure, as nobody will notice when the sed isn't required anymore and the point of the change isn't always obvious. Ross -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel