Re: [oe] [meta-oe][PATCH 04/10] libreport: add PACKCONFIG for gtk

2018-04-09 Thread akuster808


On 04/09/2018 05:29 PM, Anuj Mittal wrote:
> On 04/10/2018 08:22 AM, Armin Kuster wrote:
>> needed when no X11 in DISTRO_FEATURES
>>
>> Signed-off-by: Armin Kuster 
>> ---
>>  meta-oe/recipes-extended/libreport/libreport_2.9.2.bb | 5 -
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta-oe/recipes-extended/libreport/libreport_2.9.2.bb 
>> b/meta-oe/recipes-extended/libreport/libreport_2.9.2.bb
>> index 525437b..e963014 100644
>> --- a/meta-oe/recipes-extended/libreport/libreport_2.9.2.bb
>> +++ b/meta-oe/recipes-extended/libreport/libreport_2.9.2.bb
>> @@ -5,7 +5,7 @@ HOMEPAGE = "https://abrt.readthedocs.org/";
>>  LICENSE = "GPLv2+"
>>  DEPENDS = "xmlrpc-c xmlrpc-c-native intltool-native \
>>  json-c libtar libnewt libproxy rpm \
>> -augeas satyr systemd gtk+3 \
>> +augeas satyr systemd \
>>  "
>>  
>>  LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
>> @@ -26,6 +26,9 @@ REQUIRED_DISTRO_FEATURES = "systemd"
>>  
>>  inherit gettext autotools python3native pkgconfig
>>  
>> +PACKAGECONFIGS ??= 
>> "${@bb.utils.contains('DISTRO_FEATURES','x11','gtk','',d)}"
> Typo? Should be PACKAGECONFIG.
I would not be surprised. V2 shortly.

thanks for the feedback and review.
Armin

-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


Re: [oe] [meta-oe][PATCH 04/10] libreport: add PACKCONFIG for gtk

2018-04-09 Thread Anuj Mittal
On 04/10/2018 08:22 AM, Armin Kuster wrote:
> needed when no X11 in DISTRO_FEATURES
> 
> Signed-off-by: Armin Kuster 
> ---
>  meta-oe/recipes-extended/libreport/libreport_2.9.2.bb | 5 -
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-oe/recipes-extended/libreport/libreport_2.9.2.bb 
> b/meta-oe/recipes-extended/libreport/libreport_2.9.2.bb
> index 525437b..e963014 100644
> --- a/meta-oe/recipes-extended/libreport/libreport_2.9.2.bb
> +++ b/meta-oe/recipes-extended/libreport/libreport_2.9.2.bb
> @@ -5,7 +5,7 @@ HOMEPAGE = "https://abrt.readthedocs.org/";
>  LICENSE = "GPLv2+"
>  DEPENDS = "xmlrpc-c xmlrpc-c-native intltool-native \
>  json-c libtar libnewt libproxy rpm \
> -augeas satyr systemd gtk+3 \
> +augeas satyr systemd \
>  "
>  
>  LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
> @@ -26,6 +26,9 @@ REQUIRED_DISTRO_FEATURES = "systemd"
>  
>  inherit gettext autotools python3native pkgconfig
>  
> +PACKAGECONFIGS ??= 
> "${@bb.utils.contains('DISTRO_FEATURES','x11','gtk','',d)}"

Typo? Should be PACKAGECONFIG.
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel