Re: [oe] cppzmq: 4.2.3 update

[Justin Bronder]

Please ignore this, I pasted in the wrong sha.  I'll fix and resubmit.

On 02/03/18 15:31 -0500, Justin Bronder wrote:
> Signed-off-by: Justin Bronder 
> ---
>  meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb 
> b/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> index a64745c94..b660b69da 100644
> --- a/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> +++ b/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> @@ -4,8 +4,8 @@ LICENSE = "MIT"
>  LIC_FILES_CHKSUM = "file://LICENSE;md5=db174eaf7b55a34a7c89551197f66e94"
>  DEPENDS = "zeromq"
>  
> -SRCREV = "68a7b09cfce01c4c279fba2cf91686fcfc566848"
> -PV = "4.1.5+git${SRCPV}"
> +SRCREV = "3226b8ebddd9c6c738ba42986822c26418a49afb"
> +PV = "4.2.3+git${SRCPV}"
>  
>  SRC_URI = "git://github.com/zeromq/cppzmq.git"
>  
> -- 
> 2.13.6
> 

-- 
Justin Bronder
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] cppzmq: 4.2.3 update

[Justin Bronder]

On 01/03/18 17:14 +0100, Andreas Oberritter wrote:
> On Thu, 1 Mar 2018 10:47:02 -0500
> Justin Bronder  wrote:
> 
> > On 01/03/18 16:36 +0100, Andreas Oberritter wrote:
> > > Hi Justin,
> > > 
> > > On Mon, 26 Feb 2018 15:16:04 -0500
> > > Justin Bronder  wrote:
> > >   
> > > > Signed-off-by: Justin Bronder 
> > > > ---
> > > >  meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb | 4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > > 
> > > > diff --git a/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb 
> > > > b/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> > > > index a64745c94..9e8ad5151 100644
> > > > --- a/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> > > > +++ b/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> > > > @@ -4,8 +4,8 @@ LICENSE = "MIT"
> > > >  LIC_FILES_CHKSUM = 
> > > > "file://LICENSE;md5=db174eaf7b55a34a7c89551197f66e94"
> > > >  DEPENDS = "zeromq"
> > > >  
> > > > -SRCREV = "68a7b09cfce01c4c279fba2cf91686fcfc566848"
> > > > -PV = "4.1.5+git${SRCPV}"
> > > > +PV = "4.2.3"
> > > > +SRCREV = "v${PV}"  
> > > 
> > > we usually don't use tags in SRCREV, because tags may change over time, 
> > > and
> > > therefore bitbake has to query the server each time it parses the recipe, 
> > > IIRC.  
> > 
> > Ok.  Should I submit a v2 with the file rename that akuster808 suggested and
> > pulling a tarball instead?
> 
> I'd say keep the filename and just update PV to 4.2.3+git${SRCPV} in v2. This
> reduces the number of changed lines in case SRCREV gets advanced to a commit
> between 4.2.3 and a future release.

Thanks, v2 sent.

-- 
Justin Bronder
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] cppzmq: 4.2.3 update

[Andreas Oberritter]

On Thu, 1 Mar 2018 10:47:02 -0500
Justin Bronder  wrote:

> On 01/03/18 16:36 +0100, Andreas Oberritter wrote:
> > Hi Justin,
> > 
> > On Mon, 26 Feb 2018 15:16:04 -0500
> > Justin Bronder  wrote:
> >   
> > > Signed-off-by: Justin Bronder 
> > > ---
> > >  meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb 
> > > b/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> > > index a64745c94..9e8ad5151 100644
> > > --- a/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> > > +++ b/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> > > @@ -4,8 +4,8 @@ LICENSE = "MIT"
> > >  LIC_FILES_CHKSUM = "file://LICENSE;md5=db174eaf7b55a34a7c89551197f66e94"
> > >  DEPENDS = "zeromq"
> > >  
> > > -SRCREV = "68a7b09cfce01c4c279fba2cf91686fcfc566848"
> > > -PV = "4.1.5+git${SRCPV}"
> > > +PV = "4.2.3"
> > > +SRCREV = "v${PV}"  
> > 
> > we usually don't use tags in SRCREV, because tags may change over time, and
> > therefore bitbake has to query the server each time it parses the recipe, 
> > IIRC.  
> 
> Ok.  Should I submit a v2 with the file rename that akuster808 suggested and
> pulling a tarball instead?

I'd say keep the filename and just update PV to 4.2.3+git${SRCPV} in v2. This
reduces the number of changed lines in case SRCREV gets advanced to a commit
between 4.2.3 and a future release.

Regards,
Andreas
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] cppzmq: 4.2.3 update

[Justin Bronder]

On 01/03/18 16:36 +0100, Andreas Oberritter wrote:
> Hi Justin,
> 
> On Mon, 26 Feb 2018 15:16:04 -0500
> Justin Bronder  wrote:
> 
> > Signed-off-by: Justin Bronder 
> > ---
> >  meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb 
> > b/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> > index a64745c94..9e8ad5151 100644
> > --- a/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> > +++ b/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> > @@ -4,8 +4,8 @@ LICENSE = "MIT"
> >  LIC_FILES_CHKSUM = "file://LICENSE;md5=db174eaf7b55a34a7c89551197f66e94"
> >  DEPENDS = "zeromq"
> >  
> > -SRCREV = "68a7b09cfce01c4c279fba2cf91686fcfc566848"
> > -PV = "4.1.5+git${SRCPV}"
> > +PV = "4.2.3"
> > +SRCREV = "v${PV}"
> 
> we usually don't use tags in SRCREV, because tags may change over time, and
> therefore bitbake has to query the server each time it parses the recipe, 
> IIRC.

Ok.  Should I submit a v2 with the file rename that akuster808 suggested and
pulling a tarball instead?


-- 
Justin Bronder
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] cppzmq: 4.2.3 update

[Justin Bronder]

On 27/02/18 21:51 -0800, akuster808 wrote:
> 
> 
> On 02/26/2018 12:16 PM, Justin Bronder wrote:
> > Signed-off-by: Justin Bronder 
> > ---
> >  meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb 
> > b/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> > index a64745c94..9e8ad5151 100644
> > --- a/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> > +++ b/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> > @@ -4,8 +4,8 @@ LICENSE = "MIT"
> >  LIC_FILES_CHKSUM = "file://LICENSE;md5=db174eaf7b55a34a7c89551197f66e94"
> >  DEPENDS = "zeromq"
> >  
> > -SRCREV = "68a7b09cfce01c4c279fba2cf91686fcfc566848"
> > -PV = "4.1.5+git${SRCPV}"
> > +PV = "4.2.3"
> If the recipe is renamed to cppzmq_4.2.3.bb, will that work too?

Keep the patch and also rename?  Yeah, I'd find that more clear but I wasn't
sure if using the git checkout (and hence _git suffix) was a feature so I didn't
want to change it.

> 
> - armin
> > +SRCREV = "v${PV}"
> >  
> >  SRC_URI = "git://github.com/zeromq/cppzmq.git"
> >  
> 

-- 
Justin Bronder
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel