[Openerp-community] [Merge] lp:~camptocamp/openerp-product-attributes/7.0-attribute-set-create-1256023 into lp:openerp-product-attributes

2013-11-28 Thread Guewen Baconnier @ Camptocamp
Guewen Baconnier @ Camptocamp has proposed merging lp:~camptocamp/openerp-product-attributes/7.0-attribute-set-create-1256023 into lp:openerp-product-attributes. Commit message: [FIX] prevent KeyError if no 'attribute_ids' is present in 'vals' Requested reviews: Product Core Editors

Re: [Openerp-community] [Merge] lp:~camptocamp/openerp-product-attributes/7.0-attribute-set-create-1256023 into lp:openerp-product-attributes

2013-11-28 Thread Pedro Manuel Baeza
Review: Approve code review, no test LGTM -- https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-attribute-set-create-1256023/+merge/197092 Your team OpenERP Community is subscribed to branch lp:openerp-product-attributes. ___

Re: [Openerp-community] [Merge] lp:~camptocamp/openerp-product-attributes/7.0-attribute-set-create-1256023 into lp:openerp-product-attributes

2013-11-28 Thread Alex Comba - Agile BG
Review: Approve code review, no test -- https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-attribute-set-create-1256023/+merge/197092 Your team OpenERP Community is subscribed to branch lp:openerp-product-attributes. ___ Mailing

Re: [Openerp-community] [Merge] lp:~camptocamp/openerp-product-attributes/7.0-attribute-set-create-1256023 into lp:openerp-product-attributes

2013-11-28 Thread Sébastien BEAU - http : //www . akretion . com
Review: Approve (code review, no test) LGTM -- https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-attribute-set-create-1256023/+merge/197092 Your team OpenERP Community is subscribed to branch lp:openerp-product-attributes. ___

[Openerp-community] Crowdfunding campaign for manufacturing modules

2013-11-28 Thread Pedro Manuel Baeza Romero
Hi, community! I want to announce to you one initiative that Avanzoschttp://www.avanzosc.es/and I http://serviciosbaeza.com/en/ have launched today: a crowdfunding campaign to migrate and enhance modules that extend manufacturing features of OpenERP. We have called it with the original name

Re: [Openerp-community] Crowdfunding campaign for manufacturing modules

2013-11-28 Thread Eric Caudal
Title: Eric CAUDAL Hi Pedro, That sounds like a good initiative. We can help on definition and of course with the many contributions done so far (split MO, split procurement, automatic MO etc.). Besides it would be interesting to know what are the

[Openerp-community-reviewer] [Bug 1188528] Re: [7.0, trunk] sale - wizard sale_line_invoice uses internal reference instead of customer reference

2013-11-28 Thread Martin Trigaux (OpenERP)
Thanks for the patch, merged in 7.0 revno: 9657 [merge] revision-id: m...@openerp.com-20131128113232-aun2h9fbrfxwffqt ** Changed in: openobject-addons Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of OpenERP Community Backports

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-add-delivery_carrier_label_laposte-yvr into lp:carriers-deliveries

2013-11-28 Thread Guewen Baconnier @ Camptocamp
https://bitbucket.org/jurko/suds/src/627c4f4e2aed730aab9d0632fab9ac7383c74230/ suds/client.py?at=default#cl-676 I'm receiving this kind of Exceptions from suds. I fear, it isn't fully implemented yet. Arg. Ok, so :-) --

[Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-pending-merge into lp:margin-analysis

2013-11-28 Thread Joël Grand-Guillaume
The proposal to merge lp:~camptocamp/margin-analysis/7.0-pending-merge into lp:margin-analysis has been updated. Description changed to: * Improve logger * Add a basic YML test case for product_historical_margin * Propagate the context on browse * Improve the usability of

Re: [Openerp-community-reviewer] [Merge] lp:~the-clone-master/oemedical/oemedical_module_split into lp:oemedical

2013-11-28 Thread Mario Arias
Hi Pedro, I can't find how to solve these conflicts... Could you (or any other fellow bzr guru) please enlighten me ? Regards, -Mario -- https://code.launchpad.net/~the-clone-master/oemedical/oemedical_module_split/+merge/196469 Your team OEmedical Commiter is subscribed to branch

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-pending-merge into lp:margin-analysis

2013-11-28 Thread Pedro Manuel Baeza
Review: Needs Fixing Hi, Joël, thanks for the contribution. Can you please check: - l.74: You forget the ')' at the end. - l.98: 'products' is not a list? - l.173, l.177: Can you use DATETIME variable? And now a little off-topic: I'm seeing some MPs for your part with history properties. Don't

Re: [Openerp-community-reviewer] [Merge] lp:~the-clone-master/oemedical/oemedical_module_split into lp:oemedical

2013-11-28 Thread Pedro Manuel Baeza
You can make this: - Execute this command over your branch: bzr diff -r x..y diff.patch where x and y are the revisions where your changes starts and ends respectively. Make sure you don't forget any revision. - Then, take official branch and apply the patch: patch -p0 diff.patch

Re: [Openerp-community-reviewer] [Merge] lp:~initos.com/account-analytic/7.0 into lp:account-analytic

2013-11-28 Thread Markus Schneider
i have fix it and have PEP8 fully covered -- https://code.launchpad.net/~initos.com/account-analytic/7.0/+merge/195362 Your team Account Core Editors is subscribed to branch lp:account-analytic. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-product-attributes/7.0-attribute-set-create-1256023 into lp:openerp-product-attributes

2013-11-28 Thread Guewen Baconnier @ Camptocamp
Guewen Baconnier @ Camptocamp has proposed merging lp:~camptocamp/openerp-product-attributes/7.0-attribute-set-create-1256023 into lp:openerp-product-attributes. Commit message: [FIX] prevent KeyError if no 'attribute_ids' is present in 'vals' Requested reviews: Product Core Editors

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-financial-tools/70-always-check-date into lp:account-financial-tools

2013-11-28 Thread Sylvain LE GAL (GRAP)
Review: Needs Information Hi, About the debate on init function : Why not doing the following : 1/ keep the code : - _defaults [...] - def _allow_date_always_active [...] - _constraints [...] 2/ remove the code : - def init [...] the init function only does a mass edit, it isn't ? So it's

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-financial-tools/70-always-check-date into lp:account-financial-tools

2013-11-28 Thread Alexis de Lattre
@Nhomar : I don't understand your answer. My collegues at Akretion France don't understand it either. Could you explain it again ? @Sylvain : Of course, I could use the mass edit module to set all journals to allow_date=True. But it find your suggestion too complicated for such a simple

Re: [Openerp-community-reviewer] [Merge] lp:~vauxoo/account-financial-report/7.0-afr_GB_partner-dev-hbto into lp:account-financial-report

2013-11-28 Thread Julio Serna-http://www.vauxoo.com
Review: Approve -- https://code.launchpad.net/~vauxoo/account-financial-report/7.0-afr_GB_partner-dev-hbto/+merge/196764 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~vauxoo/account-financial-report/7.0-afr_GB_partner-dev-hbto into lp:account-financial-report

2013-11-28 Thread Moisés López - http : //www . vauxoo . com
Review: Approve Now same report but with partner data like account (without a particular partner's account.account, only with res.partner) -- https://code.launchpad.net/~vauxoo/account-financial-report/7.0-afr_GB_partner-dev-hbto/+merge/196764 Your team Account Report Core Editors is

Re: [Openerp-community-reviewer] [Merge] lp:~vauxoo/account-financial-report/7.0-afr_GB_partner-dev-hbto into lp:account-financial-report

2013-11-28 Thread Pedro Manuel Baeza
Review: Abstain I still see some lines very long, but it's better than previously. I'm going to abstain for now, until I have some time to check it functionally. Regards. -- https://code.launchpad.net/~vauxoo/account-financial-report/7.0-afr_GB_partner-dev-hbto/+merge/196764 Your team Account

[Openerp-community-reviewer] [Merge] lp:~vauxoo/account-financial-report/7.0-afr_GB_partner-dev-hbto into lp:account-financial-report

2013-11-28 Thread noreply
The proposal to merge lp:~vauxoo/account-financial-report/7.0-afr_GB_partner-dev-hbto into lp:account-financial-report has been updated. Status: Needs review = Merged For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~hirt/ocb-addons/6.1_fix_mailaddress-parsing into lp:ocb-addons/6.1

2013-11-28 Thread Pedro Manuel Baeza
Review: Approve Thanks for the MP, Etienne. Regards. -- https://code.launchpad.net/~hirt/ocb-addons/6.1_fix_mailaddress-parsing/+merge/194030 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: