Guewen Baconnier @ Camptocamp has proposed merging
lp:~camptocamp/account-financial-report/7.0-export-add-statement into
lp:account-financial-report.
Requested reviews:
Account Report Core Editors (account-report-core-editor)
For more details, see:
https://code.launchpad.net/~camptocamp
Moved to https://github.com/OCA/web/pull/4
--
https://code.launchpad.net/~camptocamp/web-addons/7.0-web_translate_dialog-no-readonly-gbr/+merge/224780
Your team Web-Addons Core Editors is subscribed to branch
lp:~webaddons-core-editors/web-addons/7.0.
--
Mailing list:
The proposal to merge
lp:~camptocamp/web-addons/7.0-web_translate_dialog-no-readonly-gbr into
lp:~webaddons-core-editors/web-addons/7.0 has been updated.
Status: Needs review = Rejected
For more details, see:
Review: Approve code review
Thanks
--
https://code.launchpad.net/~camptocamp/stock-logistic-report/7.0-replace-print-actions-mdh/+merge/225126
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-report.
--
Mailing list:
The proposal to merge
lp:~camptocamp/web-addons/7.0-web_translate_dialog-no-readonly-gbr into
lp:web-addons has been updated.
Commit Message changed to:
Do not display readonly translatable fields in the translate dialog
For more details, see:
Hi,
It seems nice.
I left a few comments in the diff. I won't really block on them but you should
have a look.
Diff comments:
=== added directory 'cmis_read'
=== added file 'cmis_read/__init__.py'
--- cmis_read/__init__.py 1970-01-01 00:00:00 +
+++ cmis_read/__init__.py
Review: Approve code review
--
https://code.launchpad.net/~pedro.baeza/ocb-addons/7.0-lp1122155/+merge/217629
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Needs Fixing
Hi,
I left some diff comments.
I'm also annoyed by the incompatibily introduced by this module (override of
amount_all and amount_line), but on the other hand there is maybe no other way
to do that.
Thanks Pedro
Diff comments:
=== added directory 'purchase_discount'
Review: Approve code review
Great, thanks!
--
https://code.launchpad.net/~pedro.baeza/purchase-wkfl/7.0-purchase_discount/+merge/217030
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
** Changed in: ocb-addons/6.1
Status: Fix Committed = Fix Released
--
You received this bug notification because you are a member of OpenERP
Community Backports, which is subscribed to OpenERP Community Backports
(Addons).
https://bugs.launchpad.net/bugs/1008513
Title:
Review: Approve code review
LGTM
--
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM/+merge/223928
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post
Review: Approve code review
Hi Augustin,
LGTM finally!
Thanks for you work.
Since Sylvain's comments have been addressed, I'll merge it.
--
https://code.launchpad.net/~ajite/web-addons/7.0-web-addons-add-0001/+merge/210620
Your team Web-Addons Core Editors is subscribed to branch
Yannick, you need to save the sales order to see the prices. That seems a
usability issue.
I'm not sure that we can deal with that properly with onchanges though.
--
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-add-last_sale_price-yvr/+merge/223704
Your team Sale Core Editors is
On 06/17/2014 09:29 PM, Stéphane Bidoul (Acsone) wrote:
Review: Needs Fixing test
Hi,
Is it just me or this MP broke afr with ocb 7.0?
Traceback (most recent call last):
File
Review: Approve code review
--
https://code.launchpad.net/~akretion-team/partner-contact-management/partner-firstname-inheritable/+merge/222730
Your team Partner and Contact Core Editors is subscribed to branch
lp:partner-contact-management.
--
Mailing list:
Guewen Baconnier @ Camptocamp has proposed merging
lp:~camptocamp/ocb-addons/7.0-send-message-slow-1311087 into lp:ocb-addons.
Requested reviews:
OpenERP Community Backports (ocb)
For more details, see:
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-send-message-slow-1311087/+merge
Guewen Baconnier @ Camptocamp has proposed merging
lp:~camptocamp/account-financial-report/7.0-account_export_csv-select-periods
into lp:account-financial-report.
Requested reviews:
Account Report Core Editors (account-report-core-editor)
For more details, see:
https://code.launchpad.net
Review: Approve code review, test
LGTM.
Thanks!
--
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fill-inventory-OOM/+merge/217049
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post
** Changed in: ocb-addons
Status: Fix Committed = In Progress
** Changed in: ocb-addons
Status: In Progress = Fix Released
--
You received this bug notification because you are a member of OpenERP
Community Backports, which is subscribed to OpenERP Community Backports
(Addons).
Review: Approve
LGTM
Thanks
--
https://code.launchpad.net/~wiz-keed/ocb-addons/7.0-delivery-carrier-multi-company-awareness/+merge/214176
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to
Review: Approve code review
LGTM
--
https://code.launchpad.net/~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7/+merge/213867
Your team Stock and Logistic Core Editors is subscribed to branch
lp:carriers-deliveries.
--
Mailing list:
Review: Needs Information
Isn't Outgoing a negative value?
I think that stock_qty['qty_available'] + stock_qty['outgoing_qty'] is
correct to compute an immediately usable quantity. Am I wrong?
--
Review: Approve code review
Thanks!
LGTM
--
https://code.launchpad.net/~camptocamp/department-mgmt/add-account-department-fix-default-anyltic-jge/+merge/218807
Your team Department Core Editors is subscribed to branch lp:department-mgmt.
--
Mailing list:
Review: Needs Fixing
l.21: context propagation is missing
l.25-25: indentation could be aligned
l.37: if the department of the account changes, the analytic lines won't be
changed. That's maybe what is wanted though. I propose either to add triggers,
either to add a comment why the departement
Review: Approve code review
--
https://code.launchpad.net/~camptocamp/department-mgmt/add-dep-on-project-task-jge/+merge/217068
Your team Department Core Editors is subscribed to branch lp:department-mgmt.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve code review
Excellent. Thanks
--
https://code.launchpad.net/~camptocamp/partner-contact-management/add-base_partner_merge/+merge/189616
Your team Partner and Contact Core Editors is subscribed to branch
lp:partner-contact-management.
--
Mailing list:
Review: Approve code review
--
https://code.launchpad.net/~stefan-therp/ocb-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain/+merge/216877
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list:
Review: Approve
--
https://code.launchpad.net/~camptocamp/account-budgeting/7.0-fix-store-fields-mdh/+merge/216849
Your team Account Core Editors is subscribed to branch lp:account-budgeting.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve
--
https://code.launchpad.net/~acsone-openerp/account-analytic/account_analytic_required-test_suite-sbi/+merge/216451
Your team Account Core Editors is subscribed to branch lp:account-analytic.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve
--
https://code.launchpad.net/~numerigraphe-team/report-print-send/7.0-default-bool-required-lp1308614-ls/+merge/216354
Your team Report Printing and Sending Core Editors is subscribed to branch
lp:report-print-send.
--
Mailing list:
Review: Approve code review
--
https://code.launchpad.net/~numerigraphe-team/report-print-send/7.0-user-browse-lp1116672-ls/+merge/216356
Your team Report Printing and Sending Core Editors is subscribed to branch
lp:report-print-send.
--
Mailing list:
Review: Approve code review
--
https://code.launchpad.net/~acsone-openerp/web-addons/web_easy_switch_company-userform-fix-sbi/+merge/216170
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve
--
https://code.launchpad.net/~onnis-roberto/web-addons/web-addons/+merge/214906
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Guewen Baconnier @ Camptocamp has proposed merging
lp:~camptocamp/web-addons/7.0-add-web_send_message_popup into lp:web-addons.
Commit message:
Add module web_send_message_popup changing the 'Send a message' link to open
directly the full featured message popup
Requested reviews:
Web-Addons
Sandy, is it ok for you now?
--
https://code.launchpad.net/~camptocamp/lp-community-utils/nag-user-specific-info/+merge/209665
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:lp-community-utils.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post
Yannick, you will need to rebase unfortunately, the head diverged.
--
https://code.launchpad.net/~camptocamp/lp-community-utils/nag-user-specific-info/+merge/209665
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:lp-community-utils.
--
Mailing list:
Guewen Baconnier @ Camptocamp has proposed merging
lp:~camptocamp/lp-community-utils/nag-nameerror-1312682 into
lp:lp-community-utils.
Requested reviews:
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c): code review, no test
Related bugs:
Bug #1312682 in OpenERP Launchpad Community
Review: Approve code review
LGTM
--
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-picking-custom-default-origin/+merge/210559
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
** Changed in: ocb-addons
Status: Fix Committed = Fix Released
--
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Addons).
https://bugs.launchpad.net/bugs/1098557
Title:
Can't set a
** Changed in: ocb-server
Status: Confirmed = Fix Released
--
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Server).
https://bugs.launchpad.net/bugs/1274997
Title:
Same task executed
Review: Needs Information
Couldn't a composed index on the columns inventory_id, location_name,
product_code, product_name, prodlot_name be useful?
--
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-inventory-lines-sorted/+merge/210467
Your team OpenERP Community Backports Team
Review: Approve
--
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-stock-latest-move/+merge/210795
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
** Changed in: ocb-addons
Status: Fix Committed = Fix Released
--
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Addons).
https://bugs.launchpad.net/bugs/1291986
Title:
Last Product
** Changed in: ocb-addons/7.0
Status: New = Fix Released
--
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Addons).
https://bugs.launchpad.net/bugs/1192115
Title:
[trunk/7.0] carrier
Review: Approve
LGTM
--
https://code.launchpad.net/~acsone-openerp/account-financial-tools/allow_date_fy-sbi/+merge/213644
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Review: Approve code review
--
https://code.launchpad.net/~numerigraphe-team/account-financial-tools/7.0-l10n_fr_siret-view+company/+merge/212920
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list:
Review: Approve
--
https://code.launchpad.net/~therp-nl/account-invoicing/7.0-lp1294623-invoic_id_on_analytic_line/+merge/211708
Your team Account Core Editors is subscribed to branch lp:account-invoicing.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve code review
--
https://code.launchpad.net/~stefan-therp/ocb-web/7.0-lp1293085-binary_field_widget_in_list_views/+merge/211489
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-web.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post
Hmm, conflict :-(
The line
t t-set=fileupload_style t-translation=offwidth: 83px;/t
became
t t-set=fileupload_style t-translation=offoverflow-x: hidden/t
Id doesn't seem to be related to your fix though (changed in revisions
3745.2.424 and 3745.2.426)
Can you resolve the conflict?
--
Review: Approve
--
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-fix-product_historical_margin-no-product-yvr/+merge/211354
Your team Margin Analysis Core Editors is subscribed to branch
lp:margin-analysis.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post
Review: Approve
--
https://code.launchpad.net/~camptocamp/account-financial-report/7.0-add-reference-field-mdh/+merge/214897
Your team Account Report Core Editors is subscribed to branch
lp:account-financial-report.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to
Review: Approve code review
LGTM
--
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1311004_account_move_line_index-afe/+merge/216686
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list:
** Also affects: ocb-addons
Importance: Undecided
Status: New
** Also affects: ocb-addons/6.1
Importance: Undecided
Status: New
** Also affects: ocb-addons/7.0
Importance: Undecided
Status: New
** Changed in: ocb-addons/6.1
Status: New = Fix Committed
**
Guewen Baconnier @ Camptocamp has proposed merging
lp:~camptocamp/margin-analysis/7.0-product_get_cost_field-standard_price-1308584
into lp:margin-analysis.
Requested reviews:
Margin Analysis Core Editors (margin-analysis-core-editors)
Related bugs:
Bug #1308584 in Financial controlling
Review: Approve code review
Of course.
--
https://code.launchpad.net/~camptocamp/ocb-server/7.0-fix_1305653-afe/+merge/215121
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-server.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
- wouldn't it be the same to write result = list(ids) at line 21?
`list(ids)` wouldn't keep the order of ids.
--
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1302630_document_search_order_by-rde/+merge/214486
Your team OpenERP Community Backports Team is requested to review
Review: Approve
Thanks
--
https://code.launchpad.net/~camptocamp/server-env-tools/7.0-fix-1302500/+merge/214250
Your team Server Environment And Tools Core Editors is subscribed to branch
lp:server-env-tools.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Thanks! LGTM
--
https://code.launchpad.net/~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge/+merge/214719
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Needs Fixing
The name is mandatory, so you can simplify this:
${line.name and line.name.replace('\n','br/') or '' | n}
by that:
${line.name.replace('\n','br/') | n}
--
https://code.launchpad.net/~camptocamp/purchase-report/purchase_report_carriage_return_vre/+merge/214030
Your
On 04/02/2014 03:40 AM, Augustin Cisterne-Kaas - www.elico-corp.com wrote:
Hi Guewen,
Thanks for your feedback.
Do you mean by manifest the __openerp__.py ?
Kind regards,
Augustin Cisterne-Kaas
Yes
--
Guewen Baconnier @ Camptocamp has proposed merging
lp:~camptocamp/web-addons/7.0-web_translate_dialog-sync-current-view-1301218-gbr
into lp:web-addons.
Commit message:
Propagate back and forth edited fields on the current language between the
current view and the translate dialog.
Requested
Review: Needs Fixing
Rising my Needs Fixing flag, I won't approve for the merge until the portal
module is removed from the dependencies.
There is no point to force the installation of the portal in order to merge
partners.
The message added in base_partner_merge/wizard/portal_wizard.py does
Maxime, can you check again regarding your comment?
--
https://code.launchpad.net/~camptocamp/partner-contact-management/add-base_partner_merge/+merge/189616
Your team Partner and Contact Core Editors is subscribed to branch
lp:partner-contact-management.
--
Mailing list:
Review: Approve
Hello,
actually, the goal is, on the contrary, to have all products set to False
after install. Only a very small subset of products are to be considered for
the hours block.
That is our use case, not necessarily the same for everybody.
Setting all products to True would be
The proposal to merge lp:~agilebg/server-env-tools/add_textual_database_name
into lp:server-env-tools has been updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~agilebg/server-env-tools/add_textual_database_name/+merge/209184
--
Actually I prefer not to delete the MP in order not to lose the discussion. I
prefer to set it 'rejected', but I dont' have the rights, so I wait for a
community reviewer.
Done.
--
https://code.launchpad.net/~agilebg/server-env-tools/add_textual_database_name/+merge/209184
Your team Server
Review: Approve code review
I see no reason to change the lines 11-19, but I won't block the MP for that.
Thanks
--
https://code.launchpad.net/~akretion-team/carriers-deliveries/7.0-add-description-field-dbl/+merge/209728
Your team Stock and Logistic Core Editors is subscribed to branch
Review: Disapprove
Hi,
It checks pep8 on the entire modified file, which is very likely to print way
too many errors/warnings: the projects currently are far to be
pep8-errors-prone and we don't expect for a merge proposal to fix all the pep8
errors in the modified files. Considering that, I
Guewen Baconnier @ Camptocamp has proposed merging
lp:~camptocamp/product-kitting/7.0-bom_stock-no-lines-1298860-gbr into
lp:product-kitting.
Commit message:
Error when computing bom_stock on a bill of material without lines.
When a bill of material has no lines, it can't produce more products
Hello Guewen,
just a little fix
line 39: trackings is actually a list of browse records
Thanks
Hello,
Nice catch. That's changed.
Thanks for your review
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_postlogistics-tracking_ids/+merge/207202
Your
Guewen Baconnier @ Camptocamp has proposed merging
lp:~camptocamp/stock-logistic-flows/7.0-stock_picking_priority-ids-domain-1297220-gbr
into lp:stock-logistic-flows.
Requested reviews:
Stock and Logistic Core Editors (stock-logistic-core-editors)
Related bugs:
Bug #1297220 in Stock
Review: Approve
On 03/23/2014 11:42 PM, Sylvain LE GAL (GRAP) wrote:
Hi Guewen,
I changed import call.
About the reload, the self.do_action('reload') doesn't work. I think because
I'm in a instance.web.Widget class.
Can you say me how to call this function ? I 'rgreped' 'do_action' in
Review: Approve
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 03/24/2014 10:27 AM, Luc De Meyer (Noviat) wrote:
Period is a char field to facilitate the search on all periods in a
given fiscal year (assuming of course that the fiscal year name is
consistently used in the naming of the
Review: Approve
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
LGTM
Thanks
review approve
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iF4EAREIAAYFAlMwNg0ACgkQszJ8Bz35XNGDcwD+Pei37W6y9PvZfOw+JQ5YPBir
Review: Needs Information code review, test
Hi,
Sounds good. It would be so nice to have autocompletion on the fields (but
could be a new feature to add later, that's good enough now). I'm just
wondering why the 'period' field is a char field and not a selection field like
in the standard
Review: Needs Information
There is no technical reason that it cannot be moved here. It will be
beneficial to have it here instead of OCB
We have a few options:
1/ If openobject-addons MP changes, keep up with those changes, if it gets
merged, remove it from here
2/ Ask that the
Review: Approve code review
Thanks
--
https://code.launchpad.net/~ajite/product-kitting/7.0-product-kitting-fix-0001/+merge/209636
Your team Product Core Editors is subscribed to branch lp:product-kitting.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
** Changed in: ocb-addons/6.1
Status: Fix Committed = Fix Released
--
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Addons).
https://bugs.launchpad.net/bugs/1104097
Title:
pricelist
Review: Needs Information
As you needed to rewrite the query, isn't in an opportunity to remove the
injection of the ids in the query and use params in execute()? Even though
categ_ids are supposed to be safe here, the correct way is to use the query
parameters.
--
Review: Needs Fixing code review
Hi,
there is a client action for reloading the application (called after the
installation of a module for instance).
Asking a reload from the server can be done by returning:
return {
'type': 'ir.actions.client',
'tag':
Review: Approve
--
https://code.launchpad.net/~stefan-therp/ocb-web/7.0-lp1167429-binary_fields_in_o2m_representation_and_unnecessary_preloading/+merge/210432
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-web.
--
Mailing list:
** Also affects: ocb-web
Importance: Undecided
Status: New
** Changed in: ocb-web
Status: New = Fix Released
--
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Web).
Review: Approve
--
https://code.launchpad.net/~camptocamp/product-kitting/7.0-fix_1293524-afe/+merge/211311
Your team Product Core Editors is subscribed to branch lp:product-kitting.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
The proposal to merge lp:~yannick-buron/sale-wkfl/sale-wkfl into lp:sale-wkfl
has been updated.
Status: Needs review = Work in progress
For more details, see:
https://code.launchpad.net/~yannick-buron/sale-wkfl/sale-wkfl/+merge/207468
--
Hi,
Based on the previous comments, I set the status of this proposal to Work in
progress so it will go out of the reviewers' radar. Feel free to change the
status to Needs Review if you think that this module should be merged as-is
or when it is ready to land.
Thanks
--
Review: Approve code review, test
Thanks
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_postlogistics-fix-street2/+merge/208451
Your team Stock and Logistic Core Editors is subscribed to branch
lp:carriers-deliveries.
--
Mailing list:
Review: Approve code review
Thanks
Notes (but I won't block the MP for that):
You don't need to do
176 + if context is None:
177 + context = {}
When the context is not accessed within the method.
You should prefer self.pool['product.customer.code'] over
Review: Approve code review
Thanks!
--
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-fix_1295706-rde/+merge/212175
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve code review
LGTM
--
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-1287072/+merge/209183
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list:
The proposal to merge lp:~scigghia/ocb-addons/7.0_prop_supplier_invoice_number
into lp:ocb-addons has been updated.
Status: Needs review = Work in progress
For more details, see:
https://code.launchpad.net/~scigghia/ocb-addons/7.0_prop_supplier_invoice_number/+merge/208934
--
Hi there,
Thanks for your proposal. As Stefan stated, you need to propose the same code
on lp:openobject-addons to be in line with the OCB policy. I set this merge
proposal to Work in progress, please put it back to Needs Review and write
the link the other propolal once done.
--
Review: Approve code review
We thought about doing the same module - we are annoyed by this default
behavior - and you did it! So nice ;-)
LGTM
Thanks
--
https://code.launchpad.net/~therp-nl/account-financial-tools/7.0-add_move_line_no_default_search_period_journal/+merge/207841
Your team
Review: Approve code review
LTGM Thanks
--
https://code.launchpad.net/~akretion-team/stock-logistic-flows/61-invoice-link-updated/+merge/204977
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-flows/6.1.
--
Mailing list:
Review: Needs Information
Seems ok to me. I wonder if we shouldn't add a migration script to set
is_in_hours_block to True on all products so the behavior does not change after
the update of the module, avoiding to perturb users. What do you think?
--
Review: Approve code review
I checked and Yannick is right. The rev66 has been merged already. A bit weird
to see it in the diff though.
Thanks, LGTM
--
https://code.launchpad.net/~camptocamp/account-financial-report/7.0-add-ref-in-open-invoice-jge/+merge/204890
Your team Account Report Core
I didn't know that OCB is mandatory for OCA modules.
They shouldn't require OCB. If you see incompatibilities in modules with the
OpenERP branches (not OCB), please report them as bugs.
Regarding your proposal, I can't help.
--
Review: Needs Information
Would not web_polymorphic_many2one be a better name (more generic) ?
I think so.
Could you document in the manifest how the field should be declared in python
(in `_columns`)?
Thanks
--
Review: Approve
--
https://code.launchpad.net/~camptocamp/lp-community-utils/add-multi-company/+merge/209654
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:lp-community-utils.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Guewen Baconnier @ Camptocamp has proposed merging
lp:~camptocamp/margin-analysis/7.0-product_price_history-failing-test-1295137
into lp:margin-analysis.
Requested reviews:
Margin Analysis Core Editors (margin-analysis-core-editors)
Related bugs:
Bug #1295137 in Financial controlling
Review: Approve
--
https://code.launchpad.net/~therp-nl/server-env-tools/6.1-mass_editing-fix_dataloss/+merge/201321
Your team OpenERP Community is subscribed to branch
lp:~openerp-community/server-env-tools/6.1-mass_editing.
___
Mailing list:
1 - 100 of 422 matches
Mail list logo
