Re: [Openerp-community-reviewer] [Merge] lp:~hbrunn/ocb-addons/6.1-knowledge_attachment_create_fix_duplicate_check into lp:ocb-addons/6.1

2016-02-10 Thread Holger Brunn (Therp)
check_duplication takes care for missing values itself, so I don't think we need a new branch for that. And yes, that's what happens, which is quite broken in my opinion. But well, with this patch, it's less broken. --

[Openerp-community-reviewer] [Merge] lp:~hbrunn/ocb-addons/6.1-knowledge_attachment_create_fix_duplicate_check into lp:ocb-addons/6.1

2016-02-08 Thread Holger Brunn (Therp)
Holger Brunn (Therp) has proposed merging lp:~hbrunn/ocb-addons/6.1-knowledge_attachment_create_fix_duplicate_check into lp:ocb-addons/6.1. Requested reviews: OpenERP Community Backports (ocb) For more details, see: https://code.launchpad.net/~hbrunn/ocb-addons/6.1

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-server/6.1-private_fields into lp:ocb-server/6.1

2015-08-07 Thread Holger Brunn (Therp)
Pedro, please. You know where this PR comes from, let's let it pass without checking the spelling or wording in error messages -- https://code.launchpad.net/~therp-nl/ocb-server/6.1-private_fields/+merge/267344 Your team OpenERP Community Backports is subscribed to branch lp:ocb-server/6.1. --

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-web/6.1-content_type_bwrsandman into lp:ocb-web/6.1

2015-02-05 Thread Holger Brunn (Therp)
Review: Approve code review -- https://code.launchpad.net/~therp-nl/ocb-web/6.1-content_type_bwrsandman/+merge/248786 Your team OpenERP Community Backports is subscribed to branch lp:ocb-web/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

[Openerp-community-reviewer] [Merge] lp:~credativ/ocb-addons/7.0-ocb-lp1164572 into lp:ocb-addons

2014-11-24 Thread Holger Brunn (Therp)
The proposal to merge lp:~credativ/ocb-addons/7.0-ocb-lp1164572 into lp:ocb-addons has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~credativ/ocb-addons/7.0-ocb-lp1164572/+merge/217564 -- Your team OpenERP Community Backports is subscribed

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/lp754339 into lp:ocb-addons

2014-11-24 Thread Holger Brunn (Therp)
Review: Disapprove Development for 7.0 has moved to github on https://github.com/OCA/ocb - please move your merge proposal there if it is still valid. (I close and reject this in order to have a cleaner overview for 6.1 MPs which indeed have to be done on launchpad) --

[Openerp-community-reviewer] [Merge] lp:~lmi/ocb-addons/7.0-opw-596916-rgo into lp:ocb-addons

2014-11-24 Thread Holger Brunn (Therp)
The proposal to merge lp:~lmi/ocb-addons/7.0-opw-596916-rgo into lp:ocb-addons has been updated. Status: Approved = Rejected For more details, see: https://code.launchpad.net/~lmi/ocb-addons/7.0-opw-596916-rgo/+merge/218476 -- Your team OpenERP Community Backports is subscribed to branch

Re: [Openerp-community-reviewer] [Merge] lp:~credativ/ocb-addons/7.0-ocb-lp1164572 into lp:ocb-addons

2014-11-24 Thread Holger Brunn (Therp)
Review: Disapprove Development for 7.0 has moved to github on https://github.com/OCA/ocb - please move your merge proposal there if it is still valid. (I close and reject this in order to have a cleaner overview for 6.1 MPs which indeed have to be done on launchpad) --

Re: [Openerp-community-reviewer] [Merge] lp:~alhashash/ocb-addons/7.0-bug-1219204 into lp:ocb-addons

2014-11-24 Thread Holger Brunn (Therp)
Review: Disapprove Development for 7.0 has moved to github on https://github.com/OCA/ocb - please move your merge proposal there if it is still valid. (I close and reject this in order to have a cleaner overview for 6.1 MPs which indeed have to be done on launchpad) --

[Openerp-community-reviewer] [Merge] lp:~alhashash/ocb-addons/7.0-bug-1317455-check-show-amount-in-words into lp:ocb-addons

2014-11-24 Thread Holger Brunn (Therp)
The proposal to merge lp:~alhashash/ocb-addons/7.0-bug-1317455-check-show-amount-in-words into lp:ocb-addons has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~alhashash/ocb-addons/7.0-bug-1317455-check-show-amount-in-words/+merge/218930 --

Re: [Openerp-community-reviewer] [Merge] lp:~cedric-lebrouster/ocb-web/ocb-7.0-bug-1163912-calendar-view into lp:ocb-web

2014-11-24 Thread Holger Brunn (Therp)
Review: Disapprove Development for 7.0 has moved to github on https://github.com/OCA/ocb - please move your merge proposal there if it is still valid. (I close and reject this in order to have a cleaner overview for 6.1 MPs which indeed have to be done on launchpad) --

[Openerp-community-reviewer] [Merge] lp:~credativ/ocb-web/7.0-lp1153853 into lp:ocb-web

2014-11-24 Thread Holger Brunn (Therp)
The proposal to merge lp:~credativ/ocb-web/7.0-lp1153853 into lp:ocb-web has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~credativ/ocb-web/7.0-lp1153853/+merge/222935 -- Your team OpenERP Community Backports is subscribed to branch

[Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-server/6.1-lp1255612 into lp:ocb-server/6.1

2014-11-24 Thread Holger Brunn (Therp)
The proposal to merge lp:~therp-nl/ocb-server/6.1-lp1255612 into lp:ocb-server/6.1 has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~therp-nl/ocb-server/6.1-lp1255612/+merge/196958 -- Your team OpenERP Community Backports is subscribed to

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-send-message-slow-1311087 into lp:ocb-addons

2014-11-24 Thread Holger Brunn (Therp)
Review: Disapprove Development for 7.0 has moved to github on https://github.com/OCA/ocb - please move your merge proposal there if it is still valid. (I close and reject this in order to have a cleaner overview for 6.1 MPs which indeed have to be done on launchpad) --

Re: [Openerp-community-reviewer] [Merge] lp:~credativ/ocb-server/7.0-no-workers-no-listen into lp:ocb-server

2014-11-24 Thread Holger Brunn (Therp)
Review: Disapprove Development for 7.0 has moved to github on https://github.com/OCA/ocb - please move your merge proposal there if it is still valid. (I close and reject this in order to have a cleaner overview for 6.1 MPs which indeed have to be done on launchpad) --

[Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-server/7.0_lp1321675_crash_on_copy into lp:ocb-server

2014-11-24 Thread Holger Brunn (Therp)
The proposal to merge lp:~therp-nl/ocb-server/7.0_lp1321675_crash_on_copy into lp:ocb-server has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~therp-nl/ocb-server/7.0_lp1321675_crash_on_copy/+merge/220427 -- Your team OpenERP Community

Re: [Openerp-community-reviewer] [Merge] lp:~cedric-lebrouster/ocb-server/ocb-7.0-bug-1322191-db_maxconn into lp:ocb-server

2014-11-24 Thread Holger Brunn (Therp)
Review: Disapprove Development for 7.0 has moved to github on https://github.com/OCA/ocb - please move your merge proposal there if it is still valid. (I close and reject this in order to have a cleaner overview for 6.1 MPs which indeed have to be done on launchpad) --

[Openerp-community-reviewer] [Merge] lp:~arthru/ocb-addons/fix-1334665 into lp:ocb-addons

2014-11-24 Thread Holger Brunn (Therp)
The proposal to merge lp:~arthru/ocb-addons/fix-1334665 into lp:ocb-addons has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~arthru/ocb-addons/fix-1334665/+merge/224625 -- Your team OpenERP Community Backports is subscribed to branch

[Openerp-community-reviewer] [Merge] lp:~cedric-lebrouster/ocb-server/ocb-7.0-bug-1322191-db_maxconn into lp:ocb-server

2014-11-24 Thread Holger Brunn (Therp)
The proposal to merge lp:~cedric-lebrouster/ocb-server/ocb-7.0-bug-1322191-db_maxconn into lp:ocb-server has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~cedric-lebrouster/ocb-server/ocb-7.0-bug-1322191-db_maxconn/+merge/220666 -- Your

[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1311087-rgo into lp:ocb-addons

2014-11-24 Thread Holger Brunn (Therp)
The proposal to merge lp:~camptocamp/ocb-addons/7.0-fix-1311087-rgo into lp:ocb-addons has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1311087-rgo/+merge/224247 -- Your team OpenERP Community Backports is

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-inventory-readonly-lines into lp:ocb-addons

2014-11-24 Thread Holger Brunn (Therp)
Review: Disapprove Development for 7.0 has moved to github on https://github.com/OCA/ocb - please move your merge proposal there if it is still valid. (I close and reject this in order to have a cleaner overview for 6.1 MPs which indeed have to be done on launchpad) --

[Openerp-community-reviewer] [Merge] lp:~arthru/ocb-addons/fix-1334657 into lp:ocb-addons

2014-11-24 Thread Holger Brunn (Therp)
The proposal to merge lp:~arthru/ocb-addons/fix-1334657 into lp:ocb-addons has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~arthru/ocb-addons/fix-1334657/+merge/224623 -- Your team OpenERP Community Backports is subscribed to branch

[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-inventory-readonly-lines into lp:ocb-addons

2014-11-24 Thread Holger Brunn (Therp)
The proposal to merge lp:~numerigraphe-team/ocb-addons/7.0-inventory-readonly-lines into lp:ocb-addons has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-inventory-readonly-lines/+merge/210207 -- Your team

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-inventory-dummy-moves-test into lp:ocb-addons

2014-11-24 Thread Holger Brunn (Therp)
Review: Disapprove Development for 7.0 has moved to github on https://github.com/OCA/ocb - please move your merge proposal there if it is still valid. (I close and reject this in order to have a cleaner overview for 6.1 MPs which indeed have to be done on launchpad) --

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1311087-rgo into lp:ocb-addons

2014-11-24 Thread Holger Brunn (Therp)
Review: Disapprove Development for 7.0 has moved to github on https://github.com/OCA/ocb - please move your merge proposal there if it is still valid. (I close and reject this in order to have a cleaner overview for 6.1 MPs which indeed have to be done on launchpad) --

[Openerp-community-reviewer] [Merge] lp:~alhashash/ocb-addons/7.0-bug-1194640-lot_qty_has_no_UoM into lp:ocb-addons

2014-11-24 Thread Holger Brunn (Therp)
The proposal to merge lp:~alhashash/ocb-addons/7.0-bug-1194640-lot_qty_has_no_UoM into lp:ocb-addons has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~alhashash/ocb-addons/7.0-bug-1194640-lot_qty_has_no_UoM/+merge/217682 -- Your team

[Openerp-community-reviewer] [Merge] lp:~cedric-lebrouster/ocb-server/ocb-7.0-bug-1253052-parent-order into lp:ocb-server

2014-11-24 Thread Holger Brunn (Therp)
The proposal to merge lp:~cedric-lebrouster/ocb-server/ocb-7.0-bug-1253052-parent-order into lp:ocb-server has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~cedric-lebrouster/ocb-server/ocb-7.0-bug-1253052-parent-order/+merge/209708 --

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/ocb-addons/70-addons-fix-payment-acls-bank into lp:ocb-addons

2014-11-24 Thread Holger Brunn (Therp)
Review: Disapprove Development for 7.0 has moved to github on https://github.com/OCA/ocb - please move your merge proposal there if it is still valid. (I close and reject this in order to have a cleaner overview for 6.1 MPs which indeed have to be done on launchpad) --

[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/ocb-server/ocb-add-fr_CA into lp:ocb-server

2014-11-24 Thread Holger Brunn (Therp)
The proposal to merge lp:~savoirfairelinux-openerp/ocb-server/ocb-add-fr_CA into lp:ocb-server has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~savoirfairelinux-openerp/ocb-server/ocb-add-fr_CA/+merge/212742 -- Your team OpenERP Community

[Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-server/7.0_lp1298258_join_and_sleep into lp:ocb-server

2014-11-24 Thread Holger Brunn (Therp)
The proposal to merge lp:~therp-nl/ocb-server/7.0_lp1298258_join_and_sleep into lp:ocb-server has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~therp-nl/ocb-server/7.0_lp1298258_join_and_sleep/+merge/221357 -- Your team OpenERP Community

[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1223922-yvr into lp:ocb-addons

2014-11-24 Thread Holger Brunn (Therp)
The proposal to merge lp:~camptocamp/ocb-addons/7.0-fix-1223922-yvr into lp:ocb-addons has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1223922-yvr/+merge/224312 -- Your team OpenERP Community Backports is

[Openerp-community-reviewer] [Merge] lp:~wiz-keed/ocb-addons/7.0-delivery-carrier-multi-company-awareness into lp:ocb-addons

2014-11-24 Thread Holger Brunn (Therp)
The proposal to merge lp:~wiz-keed/ocb-addons/7.0-delivery-carrier-multi-company-awareness into lp:ocb-addons has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~wiz-keed/ocb-addons/7.0-delivery-carrier-multi-company-awareness/+merge/214176

[Openerp-community-reviewer] [Merge] lp:~akretion-team/ocb-addons/70-addons-fix-payment-acls-bank into lp:ocb-addons

2014-11-24 Thread Holger Brunn (Therp)
The proposal to merge lp:~akretion-team/ocb-addons/70-addons-fix-payment-acls-bank into lp:ocb-addons has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~akretion-team/ocb-addons/70-addons-fix-payment-acls-bank/+merge/208021 -- Your team

[Openerp-community-reviewer] [Merge] lp:~hbrunn/ocb-addons/trunk-lp1252652 into lp:ocb-addons

2014-11-24 Thread Holger Brunn (Therp)
The proposal to merge lp:~hbrunn/ocb-addons/trunk-lp1252652 into lp:ocb-addons has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~hbrunn/ocb-addons/trunk-lp1252652/+merge/210981 -- Your team OpenERP Community Backports is subscribed to

[Openerp-community-reviewer] [Merge] lp:~alhashash/ocb-addons/7.0-bug-1219204 into lp:ocb-addons

2014-11-24 Thread Holger Brunn (Therp)
The proposal to merge lp:~alhashash/ocb-addons/7.0-bug-1219204 into lp:ocb-addons has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~alhashash/ocb-addons/7.0-bug-1219204/+merge/217676 -- Your team OpenERP Community Backports is subscribed

Re: [Openerp-community-reviewer] [Merge] lp:~alhashash/ocb-addons/7.0-bug-1194640-lot_qty_has_no_UoM into lp:ocb-addons

2014-11-24 Thread Holger Brunn (Therp)
Review: Disapprove Development for 7.0 has moved to github on https://github.com/OCA/ocb - please move your merge proposal there if it is still valid. (I close and reject this in order to have a cleaner overview for 6.1 MPs which indeed have to be done on launchpad) --

Re: [Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/7.0-bug-1104766-ignore-canceled-moves into lp:ocb-addons

2014-11-24 Thread Holger Brunn (Therp)
Review: Disapprove Development for 7.0 has moved to github on https://github.com/OCA/ocb - please move your merge proposal there if it is still valid. (I close and reject this in order to have a cleaner overview for 6.1 MPs which indeed have to be done on launchpad) --

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1223922-yvr into lp:ocb-addons

2014-11-24 Thread Holger Brunn (Therp)
Review: Disapprove Development for 7.0 has moved to github on https://github.com/OCA/ocb - please move your merge proposal there if it is still valid. (I close and reject this in order to have a cleaner overview for 6.1 MPs which indeed have to be done on launchpad) --

Re: [Openerp-community-reviewer] [Merge] lp:~lmi/ocb-addons/7.0-opw-596916-rgo into lp:ocb-addons

2014-11-24 Thread Holger Brunn (Therp)
Review: Disapprove Development for 7.0 has moved to github on https://github.com/OCA/ocb - please move your merge proposal there if it is still valid. (I close and reject this in order to have a cleaner overview for 6.1 MPs which indeed have to be done on launchpad) --

[Openerp-community-reviewer] [Merge] lp:~acsone-openerp/ocb-addons/7.0-bug-796570-amu into lp:ocb-addons

2014-11-24 Thread Holger Brunn (Therp)
The proposal to merge lp:~acsone-openerp/ocb-addons/7.0-bug-796570-amu into lp:ocb-addons has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~acsone-openerp/ocb-addons/7.0-bug-796570-amu/+merge/203378 -- Your team OpenERP Community Backports

[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1335887 into lp:ocb-addons

2014-11-24 Thread Holger Brunn (Therp)
The proposal to merge lp:~camptocamp/ocb-addons/7.0-fix-1335887 into lp:ocb-addons has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1335887/+merge/225028 -- Your team OpenERP Community Backports is subscribed

[Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/7.0-bug-1169074-pricelist-category-depth into lp:ocb-addons

2014-11-24 Thread Holger Brunn (Therp)
The proposal to merge lp:~yann-papouin/ocb-addons/7.0-bug-1169074-pricelist-category-depth into lp:ocb-addons has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~yann-papouin/ocb-addons/7.0-bug-1169074-pricelist-category-depth/+merge/210163

[Openerp-community-reviewer] [Merge] lp:~cedric-lebrouster/ocb-web/ocb-7.0-bug-1163912-calendar-view into lp:ocb-web

2014-11-24 Thread Holger Brunn (Therp)
The proposal to merge lp:~cedric-lebrouster/ocb-web/ocb-7.0-bug-1163912-calendar-view into lp:ocb-web has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~cedric-lebrouster/ocb-web/ocb-7.0-bug-1163912-calendar-view/+merge/215111 -- Your team

[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/ocb-web/translate_warnings_1297525 into lp:ocb-web

2014-11-24 Thread Holger Brunn (Therp)
The proposal to merge lp:~savoirfairelinux-openerp/ocb-web/translate_warnings_1297525 into lp:ocb-web has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~savoirfairelinux-openerp/ocb-web/translate_warnings_1297525/+merge/212739 -- Your team

[Openerp-community-reviewer] [Merge] lp:~hbrunn/ocb-addons/6.1-lp1376743 into lp:ocb-addons/6.1

2014-10-02 Thread Holger Brunn (Therp)
Holger Brunn (Therp) has proposed merging lp:~hbrunn/ocb-addons/6.1-lp1376743 into lp:ocb-addons/6.1. Requested reviews: OpenERP Community Backports (ocb) Related bugs: Bug #1376743 in OpenERP Community Backports (Addons): space at the end of user names confuse users_ldap https

[Openerp-community-reviewer] [Bug 1376743] [NEW] space at the end of user names confuse users_ldap

2014-10-02 Thread Holger Brunn (Therp)
Public bug reported: see https://github.com/odoo/odoo/pull/2865 ** Affects: ocb-addons Importance: Undecided Status: New ** Affects: ocb-addons/6.1 Importance: Low Assignee: Holger Brunn (Therp) (hbrunn) Status: Fix Committed ** Also affects: ocb-addons/6.1

Re: [Openerp-community-reviewer] [Merge] lp:~hbrunn/ocb-addons/6.1-lp1376743 into lp:ocb-addons/6.1

2014-10-02 Thread Holger Brunn (Therp)
see https://github.com/odoo/odoo/pull/2865 -- https://code.launchpad.net/~hbrunn/ocb-addons/6.1-lp1376743/+merge/236886 Your team OpenERP Community Backports is requested to review the proposed merge of lp:~hbrunn/ocb-addons/6.1-lp1376743 into lp:ocb-addons/6.1. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/7.0-lp1303724 into lp:ocb-addons

2014-07-21 Thread Holger Brunn (Therp)
https://github.com/OCA/OCB/pull/21 -- https://code.launchpad.net/~therp-nl/ocb-addons/7.0-lp1303724/+merge/214510 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-web/7.0_lp1340813 into lp:ocb-web

2014-07-21 Thread Holger Brunn (Therp)
git, so I'm rejecting this one. -- https://code.launchpad.net/~therp-nl/ocb-web/7.0_lp1340813/+merge/226488 Your team OpenERP Community Backports is subscribed to branch lp:ocb-web. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-web/6.1_lp1340813 into lp:ocb-web/6.1

2014-07-21 Thread Holger Brunn (Therp)
6.1 still lives on launchpad, so we can process with this one here. -- https://code.launchpad.net/~therp-nl/ocb-web/6.1_lp1340813/+merge/226487 Your team OpenERP Community Backports is subscribed to branch lp:ocb-web/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-web/lp1303829 into lp:ocb-web

2014-07-21 Thread Holger Brunn (Therp)
https://github.com/OCA/OCB/pull/22 -- https://code.launchpad.net/~therp-nl/ocb-web/lp1303829/+merge/214542 Your team OpenERP Community Backports is requested to review the proposed merge of lp:~therp-nl/ocb-web/lp1303829 into lp:ocb-web. -- Mailing list:

[Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-web/7.0-form_destroy_buttons into lp:ocb-web

2014-07-21 Thread Holger Brunn (Therp)
The proposal to merge lp:~therp-nl/ocb-web/7.0-form_destroy_buttons into lp:ocb-web has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~therp-nl/ocb-web/7.0-form_destroy_buttons/+merge/216898 --

Re: [Openerp-community-reviewer] [Merge] lp:~credativ/ocb-web/7.0-lp1153853 into lp:ocb-web

2014-07-21 Thread Holger Brunn (Therp)
please make a pull request for https://github.com/OCA/OCB if you still consider this fix relevant. -- https://code.launchpad.net/~credativ/ocb-web/7.0-lp1153853/+merge/222935 Your team OpenERP Community Backports is requested to review the proposed merge of lp:~credativ/ocb-web/7.0-lp1153853

[Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-web/7.0_lp1340813 into lp:ocb-web

2014-07-21 Thread Holger Brunn (Therp)
The proposal to merge lp:~therp-nl/ocb-web/7.0_lp1340813 into lp:ocb-web has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~therp-nl/ocb-web/7.0_lp1340813/+merge/226488 --

Re: [Openerp-community-reviewer] [Merge] lp:~cedric-lebrouster/ocb-web/ocb-7.0-bug-1163912-calendar-view into lp:ocb-web

2014-07-21 Thread Holger Brunn (Therp)
please make a pull request for https://github.com/OCA/OCB if you still consider this fix relevant. -- https://code.launchpad.net/~cedric-lebrouster/ocb-web/ocb-7.0-bug-1163912-calendar-view/+merge/215111 Your team OpenERP Community Backports is subscribed to branch lp:ocb-web. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-web/7.0-form_destroy_buttons into lp:ocb-web

2014-07-21 Thread Holger Brunn (Therp)
https://github.com/OCA/OCB/pull/23 -- https://code.launchpad.net/~therp-nl/ocb-web/7.0-form_destroy_buttons/+merge/216898 Your team OpenERP Community Backports is subscribed to branch lp:ocb-web. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

[Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-web/lp1303829 into lp:ocb-web

2014-07-21 Thread Holger Brunn (Therp)
The proposal to merge lp:~therp-nl/ocb-web/lp1303829 into lp:ocb-web has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~therp-nl/ocb-web/lp1303829/+merge/214542 -- https://code.launchpad.net/~therp-nl/ocb-web/lp1303829/+merge/214542 Your

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/ocb-web/translate_warnings_1297525 into lp:ocb-web

2014-07-21 Thread Holger Brunn (Therp)
please make a pull request for https://github.com/OCA/OCB if you still consider this fix relevant. -- https://code.launchpad.net/~savoirfairelinux-openerp/ocb-web/translate_warnings_1297525/+merge/212739 Your team OpenERP Community Backports is subscribed to branch lp:ocb-web. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/ocb-web/7.0-web_calendar-fix-1306136 into lp:ocb-web

2014-07-21 Thread Holger Brunn (Therp)
please make a pull request for https://github.com/OCA/OCB if you still consider this fix relevant. -- https://code.launchpad.net/~pedro.baeza/ocb-web/7.0-web_calendar-fix-1306136/+merge/215256 Your team OpenERP Community Backports is subscribed to branch lp:ocb-web. -- Mailing list:

[Openerp-community-reviewer] [Merge] lp:~therp-nl/partner-contact-management/7.0-firstname_display_name_trigger_prepare_name into lp:partner-contact-management

2014-07-17 Thread Holger Brunn (Therp)
Holger Brunn (Therp) has proposed merging lp:~therp-nl/partner-contact-management/7.0-firstname_display_name_trigger_prepare_name into lp:partner-contact-management. Requested reviews: Partner and Contact Core Editors (partner-contact-core-editors) For more details, see: https

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/partner-contact-management/7.0-firstname_display_name_trigger_prepare_name into lp:partner-contact-management

2014-07-17 Thread Holger Brunn (Therp)
That's not intentional. I currently can't see the problem, could you elaborate? -- https://code.launchpad.net/~therp-nl/partner-contact-management/7.0-firstname_display_name_trigger_prepare_name/+merge/227152 Your team Partner and Contact Core Editors is subscribed to branch

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/partner-contact-management/7.0-firstname_display_name_trigger_prepare_name into lp:partner-contact-management

2014-07-17 Thread Holger Brunn (Therp)
now I got it, thanks! Now launchpad still talks about that link, but the merge itself is clean as far as I see. -- https://code.launchpad.net/~therp-nl/partner-contact-management/7.0-firstname_display_name_trigger_prepare_name/+merge/227152 Your team Partner and Contact Core Editors is

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-web/7.0_lp1340813 into lp:ocb-web

2014-07-15 Thread Holger Brunn (Therp)
https://github.com/OCA/OCB/pull/18 Thanks, I'm still confused which is the leading branch with the different projects -- https://code.launchpad.net/~therp-nl/ocb-web/7.0_lp1340813/+merge/226488 Your team OpenERP Community Backports is subscribed to branch lp:ocb-web. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/6.1-lp1342360-fetchmail_file_storage_duplicate_attachment_ids into lp:ocb-addons/6.1

2014-07-15 Thread Holger Brunn (Therp)
What is the deduplication based on? If it's the file's name, we'd rather have to turn that off. For a mail, it's perfectly valid to have two times 'attachment.pdf' containing different documents. --

[Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/6.1_lp1340105 into lp:ocb-addons/6.1

2014-07-11 Thread Holger Brunn (Therp)
The proposal to merge lp:~therp-nl/ocb-addons/6.1_lp1340105 into lp:ocb-addons/6.1 has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~therp-nl/ocb-addons/6.1_lp1340105/+merge/226263 --

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/6.1_lp1340105 into lp:ocb-addons/6.1

2014-07-11 Thread Holger Brunn (Therp)
Review: Disapprove See https://bugs.launchpad.net/ocb-web/+bug/1340813 -- https://code.launchpad.net/~therp-nl/ocb-addons/6.1_lp1340105/+merge/226263 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1. -- Mailing list:

[Openerp-community-reviewer] [Bug 1340105] Re: [6.1][account] error when printing partner balance or aged partner balance

2014-07-11 Thread Holger Brunn (Therp)
** No longer affects: openobject-addons -- You received this bug notification because you are a member of OpenERP Community Backports, which is subscribed to OpenERP Community Backports (Web). https://bugs.launchpad.net/bugs/1340105 Title: [6.1][account] error when printing partner balance or

[Openerp-community-reviewer] [Bug 1340813] [NEW] [6.1][7.0] regression: Printing reports from models with incorrect/missing _rec_name causes a traceback

2014-07-11 Thread Holger Brunn (Therp)
Public bug reported: When printing a report, revisions 4197 (7.0) and 2522 (6.1) try to write up a better filename by calling name_get. This goes wrong if _rec_name points to a non-existing field ('name' by default). This usually would be the case with wizards usually. ** Affects: ocb-web

[Openerp-community-reviewer] [Bug 1340105] Re: [6.1][account] error when printing partner balance or aged partner balance

2014-07-11 Thread Holger Brunn (Therp)
see https://bugs.launchpad.net/ocb-web/+bug/1340813 ** Changed in: ocb-web Status: New = Invalid ** Changed in: ocb-web/6.1 Status: New = Invalid -- You received this bug notification because you are a member of OpenERP Community Backports, which is subscribed to OpenERP

[Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-web/6.1_lp1340813 into lp:ocb-web/6.1

2014-07-11 Thread Holger Brunn (Therp)
Holger Brunn (Therp) has proposed merging lp:~therp-nl/ocb-web/6.1_lp1340813 into lp:ocb-web/6.1. Requested reviews: OpenERP Community Backports (ocb) Related bugs: Bug #1340813 in OpenERP Community Backports (Web): [6.1][7.0] regression: Printing reports from models with incorrect/missing

[Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-web/7.0_lp1340813 into lp:ocb-web

2014-07-11 Thread Holger Brunn (Therp)
Holger Brunn (Therp) has proposed merging lp:~therp-nl/ocb-web/7.0_lp1340813 into lp:ocb-web. Requested reviews: OpenERP Community Backports (ocb) Related bugs: Bug #1340813 in OpenERP Community Backports (Web): [6.1][7.0] regression: Printing reports from models with incorrect/missing

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-web/7.0_lp1340813 into lp:ocb-web

2014-07-11 Thread Holger Brunn (Therp)
[...] the report's name [...] -- https://code.launchpad.net/~therp-nl/ocb-web/7.0_lp1340813/+merge/226488 Your team OpenERP Community Backports is subscribed to branch lp:ocb-web. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

[Openerp-community-reviewer] [Bug 1340105] [NEW] [6.1][account] error when printing partner balance or aged partner balance

2014-07-10 Thread Holger Brunn (Therp)
Public bug reported: When printing one of the two reports, I get 'Uncaught SyntaxError: Unexpected end of input' in the UI and KeyError: 'name' in the logfile. Someone does a name_get on the wizard models used here, so the fix is to set _rec_name to something sensible. I couldn't figure out

[Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/6.1_lp1340105 into lp:ocb-addons/6.1

2014-07-10 Thread Holger Brunn (Therp)
Holger Brunn (Therp) has proposed merging lp:~therp-nl/ocb-addons/6.1_lp1340105 into lp:ocb-addons/6.1. Requested reviews: OpenERP Community Backports (ocb) Related bugs: Bug #1340105 in OpenERP Community Backports (Web): [6.1][account] error when printing partner balance or aged partner

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/server-env-tools/6.1-web_base_url_freeze into lp:server-env-tools/6.1

2014-07-07 Thread Holger Brunn (Therp)
It's 6.1, nothing is going to happen with that from Odoo's side. It might be worth a try to propose to 6.1-ocb, but that will clash with the no new features policy, so I think an addon is the way to go. --

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/6.1-web_print_from_browser-hide_kanban_controls into lp:~webaddons-core-editors/web-addons/6.1

2014-07-07 Thread Holger Brunn (Therp)
Review: Resubmit This project is now hosted on https://github.com/OCA/web. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub --

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/7.0-web_relativedelta into lp:~webaddons-core-editors/web-addons/7.0

2014-07-07 Thread Holger Brunn (Therp)
Review: Resubmit This project is now hosted on https://github.com/OCA/web. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub --

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/web-addons/7.0-web_translate_dialog-no-readonly-gbr into lp:~webaddons-core-editors/web-addons/7.0

2014-07-07 Thread Holger Brunn (Therp)
Review: Resubmit This project is now hosted on https://github.com/OCA/web. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub --

Re: [Openerp-community-reviewer] [Merge] lp:~aristobulo/web-addons/web-addons into lp:~webaddons-core-editors/web-addons/7.0

2014-07-07 Thread Holger Brunn (Therp)
Review: Resubmit This project is now hosted on https://github.com/OCA/web. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub -- https://code.launchpad.net/~aristobulo/web-addons/web-addons/+merge/217277

Re: [Openerp-community-reviewer] [Merge] lp:~trobz/web-addons/web-unleashed into lp:~webaddons-core-editors/web-addons/7.0

2014-07-07 Thread Holger Brunn (Therp)
Review: Resubmit This project is now hosted on https://github.com/OCA/web. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub -- https://code.launchpad.net/~trobz/web-addons/web-unleashed/+merge/195542

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/7.0-web_tree_many2one_clickable into lp:~webaddons-core-editors/web-addons/7.0

2014-07-07 Thread Holger Brunn (Therp)
Review: Resubmit This project is now hosted on https://github.com/OCA/web. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub --

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/7.0-add_percentage_widget into lp:~webaddons-core-editors/web-addons/7.0

2014-07-07 Thread Holger Brunn (Therp)
Review: Resubmit This project is now hosted on https://github.com/OCA/web. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub --

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/6.1-web_widget_classes_viewmanager into lp:~webaddons-core-editors/web-addons/6.1

2014-07-07 Thread Holger Brunn (Therp)
Review: Resubmit This project is now hosted on https://github.com/OCA/web. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub --

Re: [Openerp-community-reviewer] [Merge] lp:~aristobulo/web-addons/web_fields_masks into lp:~webaddons-core-editors/web-addons/7.0

2014-07-07 Thread Holger Brunn (Therp)
Review: Resubmit This project is now hosted on https://github.com/OCA/web. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub --

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/6.1-web_widget_classes_viewmanager into lp:~webaddons-core-editors/web-addons/6.1

2014-07-07 Thread Holger Brunn (Therp)
https://github.com/OCA/web/pull/8 -- https://code.launchpad.net/~therp-nl/web-addons/6.1-web_widget_classes_viewmanager/+merge/217724 Your team Web-Addons Core Editors is subscribed to branch lp:~webaddons-core-editors/web-addons/6.1. -- Mailing list:

[Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/6.1-web_print_from_browser-hide_kanban_controls into lp:~webaddons-core-editors/web-addons/6.1

2014-07-07 Thread Holger Brunn (Therp)
The proposal to merge lp:~therp-nl/web-addons/6.1-web_print_from_browser-hide_kanban_controls into lp:~webaddons-core-editors/web-addons/6.1 has been updated. Status: Needs review = Rejected For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/6.1-web_print_from_browser-hide_kanban_controls into lp:~webaddons-core-editors/web-addons/6.1

2014-07-07 Thread Holger Brunn (Therp)
https://github.com/OCA/web/pull/7 -- https://code.launchpad.net/~therp-nl/web-addons/6.1-web_print_from_browser-hide_kanban_controls/+merge/203916 Your team Web-Addons Core Editors is subscribed to branch lp:~webaddons-core-editors/web-addons/6.1. -- Mailing list:

[Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/6.1-web_widget_classes_viewmanager into lp:~webaddons-core-editors/web-addons/6.1

2014-07-07 Thread Holger Brunn (Therp)
The proposal to merge lp:~therp-nl/web-addons/6.1-web_widget_classes_viewmanager into lp:~webaddons-core-editors/web-addons/6.1 has been updated. Status: Needs review = Rejected For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/7.0-web_relativedelta into lp:~webaddons-core-editors/web-addons/7.0

2014-07-07 Thread Holger Brunn (Therp)
https://github.com/OCA/web/pull/9 -- https://code.launchpad.net/~therp-nl/web-addons/7.0-web_relativedelta/+merge/217653 Your team Web-Addons Core Editors is subscribed to branch lp:~webaddons-core-editors/web-addons/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post

[Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/7.0-web_relativedelta into lp:~webaddons-core-editors/web-addons/7.0

2014-07-07 Thread Holger Brunn (Therp)
The proposal to merge lp:~therp-nl/web-addons/7.0-web_relativedelta into lp:~webaddons-core-editors/web-addons/7.0 has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~therp-nl/web-addons/7.0-web_relativedelta/+merge/217653 --

[Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/7.0-web_tree_many2one_clickable into lp:~webaddons-core-editors/web-addons/7.0

2014-07-07 Thread Holger Brunn (Therp)
The proposal to merge lp:~therp-nl/web-addons/7.0-web_tree_many2one_clickable into lp:~webaddons-core-editors/web-addons/7.0 has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~therp-nl/web-addons/7.0-web_tree_many2one_clickable/+merge/217655

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/7.0-web_tree_many2one_clickable into lp:~webaddons-core-editors/web-addons/7.0

2014-07-07 Thread Holger Brunn (Therp)
https://github.com/OCA/web/pull/10 -- https://code.launchpad.net/~therp-nl/web-addons/7.0-web_tree_many2one_clickable/+merge/217655 Your team Web-Addons Core Editors is subscribed to branch lp:~webaddons-core-editors/web-addons/7.0. -- Mailing list:

[Openerp-community-reviewer] [Merge] lp:~therp-nl/server-env-tools/6.1-web_base_url_freeze into lp:server-env-tools/6.1

2014-07-04 Thread Holger Brunn (Therp)
Holger Brunn (Therp) has proposed merging lp:~therp-nl/server-env-tools/6.1-web_base_url_freeze into lp:server-env-tools/6.1. Requested reviews: Server Environment And Tools Core Editors (server-env-tools-core-editors) For more details, see: https://code.launchpad.net/~therp-nl/server-env

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/server-env-tools/6.1-web_base_url_freeze into lp:server-env-tools/6.1

2014-07-04 Thread Holger Brunn (Therp)
I know it's expensive, but it only happens once and only when admin logs in. The reason to use it is that I couldn't find a better way to figure out if set_param is called by authenticate. If authenticate passed on a context, I could override that, set someting in the context and check in

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/7.0-web_tree_many2one_clickable into lp:web-addons

2014-06-20 Thread Holger Brunn (Therp)
Thanks for your review Pedro! I basically rewrote the code, you might want to have another test. The two colons are rst for preformatted text: http://docutils.sourceforge.net/docs/user/rst/quickref.html#literal-blocks --

[Openerp-community-reviewer] [Merge] lp:~therp-nl/partner-contact-management/7.0_partner_relations into lp:partner-contact-management

2014-06-19 Thread Holger Brunn (Therp)
The proposal to merge lp:~therp-nl/partner-contact-management/7.0_partner_relations into lp:partner-contact-management has been updated. Status: Merged = Needs review For more details, see: https://code.launchpad.net/~therp-nl/partner-contact-management/7.0_partner_relations/+merge/223734

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/partner-contact-management/add-partner_relation into lp:partner-contact-management

2014-06-19 Thread Holger Brunn (Therp)
Sorry Alexis for my late reply! Meanwhile, we added quite a bit to our approach to partner relations, so I made an alternative MP: https://code.launchpad.net/~therp-nl/partner-contact-management/7.0_partner_relations/+merge/223734 The differences are: We use views to duplicate data instead of

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/partner-contact-management/add-partner_relation into lp:partner-contact-management

2014-06-02 Thread Holger Brunn (Therp)
as we discussed before, here my take to the same problem: https://code.launchpad.net/~hbrunn/+junk/partner_relations maybe we can throw that together -- https://code.launchpad.net/~akretion-team/partner-contact-management/add-partner_relation/+merge/220726 Your team Partner and Contact Core

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/account-invoicing/7.0-account_cash_discount into lp:account-invoicing

2014-05-26 Thread Holger Brunn (Therp)
Erwin, thanks a lot for having a look! I corrected the example. Support for payment orders will happen sooner or later, but currently I think it will be rather later than sooner. This module is meant to deal with the situation in Austria and Germany, there you are legally required to jump

Re: [Openerp-community-reviewer] [Merge] lp:~aristobulo/web-addons/web-addons into lp:web-addons

2014-05-12 Thread Holger Brunn (Therp)
Review: Approve code review -- https://code.launchpad.net/~aristobulo/web-addons/web-addons/+merge/217277 Your team Web-Addons Core Editors is subscribed to branch lp:web-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

  1   2   3   4   5   >