Re: [Openerp-community] Maintainers needed for aeroo reports in OCA

2015-01-19 Thread Joël Grand-Guillaume
-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp -- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com

Re: [Openerp-community] Odoo web multi-lang CSS

2015-01-05 Thread Joël Grand-Guillaume
*Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp

Re: [Openerp-community] OCA Taiwan

2014-11-12 Thread Joël Grand-Guillaume
BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com 10DB4BDD2DD24642854B730390A3E7DF.png Description: Binary data 0DE343CC6F2DFA411EC1662DD02BCBE0.png Description: Binary data ___ Mailing

Re: [Openerp-community] Proposing Pedro M. Baeza as Openerp Spain OCA project team leader

2014-10-06 Thread Joël Grand-Guillaume
-community More help : https://help.launchpad.net/ListHelp -- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com ___ Mailing list: https

Re: [Openerp-community] odoo vertical-medical

2014-08-08 Thread Joël Grand-Guillaume
SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https

Re: [Openerp-community] pull request reviews

2014-08-05 Thread Joël Grand-Guillaume
SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-consolidation/7.0-fix-1334645-elbati into lp:~account-core-editors/account-consolidation/7.0

2014-07-18 Thread Joël Grand-Guillaume
This project is now hosted on https://github.com/OCA/account-consolidation. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub --

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-consolidation/7.0-fix_1334639-afe into lp:~account-core-editors/account-consolidation/6.1

2014-07-18 Thread Joël Grand-Guillaume
This project is now hosted on https://github.com/OCA/account-consolidation. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub --

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/rma-fix-lp1311520_rde into lp:~openerprma/openerp-rma/7.0

2014-07-16 Thread Joël Grand-Guillaume
The proposal to merge lp:~camptocamp/openerp-rma/rma-fix-lp1311520_rde into lp:~openerprma/openerp-rma/7.0 has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~camptocamp/openerp-rma/rma-fix-lp1311520_rde/+merge/216839 --

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/7.0-crm_claim_rma-fix-lp1317045_rde into lp:~openerprma/openerp-rma/7.0

2014-07-16 Thread Joël Grand-Guillaume
This project is now hosted on https://github.com/OCA/rma. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub --

Re: [Openerp-community] Reopen a paid invoice

2014-07-15 Thread Joël Grand-Guillaume
-- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/ngo-addons-add_other_procurement_method-nbi into lp:openerp-humanitarian-ngo

2014-07-10 Thread Joël Grand-Guillaume
Review: Approve code review, no tests LGTM, thanks a lot -- https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/ngo-addons-add_other_procurement_method-nbi/+merge/205155 Your team OpenERP for Humanitarian Core Editors is subscribed to branch lp:openerp-humanitarian-ngo. -- Mailing

Re: [Openerp-community] GitHub Projects: rename master to 8.0?

2014-07-03 Thread Joël Grand-Guillaume
: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp -- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume

Re: [Openerp-community] github migration: proposale for helper for travis configuration

2014-07-02 Thread Joël Grand-Guillaume
-- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community

Re: [Openerp-community] OCA repositories naming convention

2014-07-01 Thread Joël Grand-Guillaume
Nhomar G. Hernandez M. +58-414-4110269 Skype: nhomar00 Web-Blog: http://geronimo.com.ve Servicios IT: http://vauxoo.com Linux-Counter: 467724 Correos: nho...@openerp.com.ve nho...@vauxoo.com twitter @nhomar -- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand

Re: [Openerp-community] OCA repositories naming convention

2014-06-30 Thread Joël Grand-Guillaume
/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp -- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business

Re: [Openerp-community] OCA: transition from Launchpad to Github

2014-06-27 Thread Joël Grand-Guillaume
___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp -- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand

Re: [Openerp-community] OCA repositories naming convention

2014-06-27 Thread Joël Grand-Guillaume
More help : https://help.launchpad.net/ListHelp -- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com ___ Mailing list: https://launchpad.net

Re: [Openerp-community] OCA: transition from Launchpad to Github

2014-06-25 Thread Joël Grand-Guillaume
to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp -- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28

Re: [Openerp-community] OCA: transition from Launchpad to Github

2014-06-24 Thread Joël Grand-Guillaume
for your support. Regards, Joël On Tue, Jun 24, 2014 at 12:47 AM, Sandy Carter sandy.car...@savoirfairelinux.com wrote: I do not have the rights to add repos to OCA, but runbot-addons has a nice ring to it ;) -- Sandy - Mail original - De: Joël Grand-Guillaume

[Openerp-community] OCA Website

2014-06-24 Thread Joël Grand-Guillaume
Dear Community, I have the pleasure to announce you the launched of our new OCA website: odoo-community.org Enjoy ! Joël for the OCA Board -- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28

Re: [Openerp-community] Code Review Process :: Suggestion

2014-06-23 Thread Joël Grand-Guillaume
-community More help : https://help.launchpad.net/ListHelp -- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com ___ Mailing list: https

Re: [Openerp-community] OCA: transition from Launchpad to Github

2014-06-23 Thread Joël Grand-Guillaume
Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp -- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619

Re: [Openerp-community] Best temporary practice for v8 OCA modules before a decision is taken

2014-06-23 Thread Joël Grand-Guillaume
-community More help : https://help.launchpad.net/ListHelp -- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com ___ Mailing list: https

Re: [Openerp-community] OCA: transition from Launchpad to Github

2014-06-23 Thread Joël Grand-Guillaume
-- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community

Re: [Openerp-community] OCA: transition from Launchpad to Github

2014-06-23 Thread Joël Grand-Guillaume
. -- Sandy - Mail original - De: Joël Grand-Guillaume joel.grandguilla...@camptocamp.com À: Sandy Carter sandy.car...@savoirfairelinux.com Cc: Moises Lopez moylop...@vauxoo.com, openerp-community openerp-community@lists.launchpad.net Envoyé: Lundi 23 Juin 2014 14:43:11 Objet: Re

Re: [Openerp-community] Multi-company cost calculation

2014-06-20 Thread Joël Grand-Guillaume
-- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community

Re: [Openerp-community] sale_split_bom and anglosaxon accounting

2014-06-12 Thread Joël Grand-Guillaume
*Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp

Re: [Openerp-community] OCA press release: make your-self heard

2014-06-02 Thread Joël Grand-Guillaume
No Lorenzo, it is not required, it's the same form, just renamed OpenERP for Odoo, that's it ! Cheers, Joël On Fri, May 30, 2014 at 9:17 AM, Lorenzo Battistini lorenzo.battist...@agilebg.com wrote: On 05/26/2014 06:12 PM, Joël Grand-Guillaume wrote: Dear community, Here is the press

[Openerp-community] OCA press release: make your-self heard

2014-05-26 Thread Joël Grand-Guillaume
SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe

Re: [Openerp-community] OCA 8.0 Suggestion: use travis-ci.org for testing addons

2014-05-21 Thread Joël Grand-Guillaume
Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community

Re: [Openerp-community] Could oca adopt report_webkit before v8

2014-05-21 Thread Joël Grand-Guillaume
Thanks for your point of view, at least it is clear : the decision is done. I understand your need to move fast and that giving time to deprecate something costs you. Of course it is easier to drop it ! I hope you are aware that lots of your partners and the whole community rely on your work. If

Re: [Openerp-community] OCA LP Project migration to Github

2014-05-21 Thread Joël Grand-Guillaume
-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp -- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21

Re: [Openerp-community-reviewer] [Openerp-community] OCA LP Project migration to Github

2014-05-21 Thread Joël Grand-Guillaume
and consultant http://twitter.com/rvalyi http://twitter.com/#!/rvalyi +55 21 3942-2434 www.akretion.com On Tue, May 20, 2014 at 7:18 AM, Joël Grand-Guillaume joel.grandguilla...@camptocamp.com wrote: Dear all, Thanks a lot for all your feedback here. So, to summarize opinions here

Re: [Openerp-community] OCA LP Project migration to Github

2014-05-20 Thread Joël Grand-Guillaume
/ListHelp -- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp

Re: [Openerp-community-reviewer] [Openerp-community] OCA LP Project migration to Github

2014-05-20 Thread Joël Grand-Guillaume
/ListHelp -- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-improve-preq-cancel-nbi into lp:openerp-humanitarian-ngo/purchase-wkfl

2014-05-19 Thread Joël Grand-Guillaume
Review: Approve code review, no tests As the next MP is WIP, I merge this one to move further ! -- https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-improve-preq-cancel-nbi/+merge/217948 Your team OpenERP for Humanitarian Core Editors is subscribed to branch

[Openerp-community] OCA LP Project migration to Github

2014-05-16 Thread Joël Grand-Guillaume
://github.com/termie/lp2gh/blob/master/docs/moving_branches.rst -- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com ___ Mailing list: https

[Openerp-community-reviewer] OCA LP Project migration to Github

2014-05-16 Thread Joël Grand-Guillaume
://github.com/termie/lp2gh/blob/master/docs/moving_branches.rst -- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post

[Openerp-community-reviewer] [Merge] lp:~akretion-team/openerp-rma/add-crm-claim-rma-repair into lp:openerp-rma

2014-05-13 Thread Joël Grand-Guillaume
The proposal to merge lp:~akretion-team/openerp-rma/add-crm-claim-rma-repair into lp:openerp-rma has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~akretion-team/openerp-rma/add-crm-claim-rma-repair/+merge/215976 --

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde into lp:openerp-rma

2014-05-13 Thread Joël Grand-Guillaume
Review: Approve code review, no tests -- https://code.launchpad.net/~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde/+merge/218666 Your team OpenERP RMA is subscribed to branch lp:openerp-rma. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/rma-fix-lp1311520_rde into lp:openerp-rma

2014-05-13 Thread Joël Grand-Guillaume
Review: Approve code review, no tests Hi Romain, Thanks for this improvements. LGTM ! Regards, -- https://code.launchpad.net/~camptocamp/openerp-rma/rma-fix-lp1311520_rde/+merge/216839 Your team OpenERP RMA is subscribed to branch lp:openerp-rma. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/7.0-crm_claim_rma-fix-lp1317045_rde into lp:openerp-rma

2014-05-13 Thread Joël Grand-Guillaume
Review: Approve code review + test Hi Romain, Thanks for the fix, after testing and looking with other customers uses cases, I approve this improvement. Regards -- https://code.launchpad.net/~camptocamp/openerp-rma/7.0-crm_claim_rma-fix-lp1317045_rde/+merge/218595 Your team OpenERP RMA is

Re: [Openerp-community-reviewer] [Merge] lp:~jb.eficent/department-mgmt/department-mgmt-bugfixes_analytic into lp:department-mgmt

2014-05-13 Thread Joël Grand-Guillaume
Review: Disapprove code review + test Hi, As this MP :https://code.launchpad.net/~camptocamp/department-mgmt/add-account-department-fix-default-anyltic-jge/+merge/218807 Has been merged, I mark this one as disapproved. Reply in there if anything wrong with that. Regards, Joël --

[Openerp-community-reviewer] [Merge] lp:~jb.eficent/department-mgmt/department-mgmt-bugfixes_analytic into lp:department-mgmt

2014-05-13 Thread Joël Grand-Guillaume
The proposal to merge lp:~jb.eficent/department-mgmt/department-mgmt-bugfixes_analytic into lp:department-mgmt has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~jb.eficent/department-mgmt/department-mgmt-bugfixes_analytic/+merge/212299 --

[Openerp-community-reviewer] [Merge] lp:~camptocamp/department-mgmt/analytic_department_vre into lp:department-mgmt

2014-05-12 Thread Joël Grand-Guillaume
The proposal to merge lp:~camptocamp/department-mgmt/analytic_department_vre into lp:department-mgmt has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~camptocamp/department-mgmt/analytic_department_vre/+merge/218976 --

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/department-mgmt/add-account-department-fix-default-anyltic-jge into lp:department-mgmt

2014-05-12 Thread Joël Grand-Guillaume
Hi, Thanks for the review I missed the trigger :( I corrected all the points. Regards, Joël -- https://code.launchpad.net/~camptocamp/department-mgmt/add-account-department-fix-default-anyltic-jge/+merge/218807 Your team Department Core Editors is subscribed to branch lp:department-mgmt. --

[Openerp-community-reviewer] [Merge] lp:~elicoidal/multi-company/multi-company into lp:multi-company

2014-05-09 Thread Joël Grand-Guillaume
The proposal to merge lp:~elicoidal/multi-company/multi-company into lp:multi-company has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~elicoidal/multi-company/multi-company/+merge/179623 --

Re: [Openerp-community-reviewer] [Merge] lp:~elicoidal/multi-company/multi-company into lp:multi-company

2014-05-09 Thread Joël Grand-Guillaume
Hi, For all this discussion, I close this MP as a new module using the connector is out . Regards, -- https://code.launchpad.net/~elicoidal/multi-company/multi-company/+merge/179623 Your team Multi Company Core Editors is subscribed to branch lp:multi-company. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~mikel-martin/purchase-wkfl/6.1-purchase_landed_costs into lp:purchase-wkfl/6.1

2014-05-09 Thread Joël Grand-Guillaume
Review: Approve code review, no tests Hi, Thanks for the contribution. I approve this MP's, but I'm also in-line with Guewen. You should have sued the extraction tools located here : https://launchpad.net/bazaar-extractor to replay the commit of this module in that branch. This way we don't

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/lp-community-utils/pep394 into lp:lp-community-utils

2014-05-09 Thread Joël Grand-Guillaume
Review: Abstain Hi, Honestly no idea what's better here, so I go for abstain as well.. -- https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/pep394/+merge/204535 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:lp-community-utils. -- Mailing

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/hr-timesheet/imp_hr_attendance_analysis_roundings into lp:hr-timesheet

2014-05-09 Thread Joël Grand-Guillaume
Review: Approve code review, no tests LGTM, thanks ! -- https://code.launchpad.net/~agilebg/hr-timesheet/imp_hr_attendance_analysis_roundings/+merge/206493 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:hr-timesheet. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date into lp:purchase-wkfl

2014-05-09 Thread Joël Grand-Guillaume
Review: Needs Fixing code review, no tests Hi Lionel, Thanks for the contrib ! A few remarks concerning community guideline: * L32 : use from . import purchase * L95 : use full path instead : from openerp.osv import orm * L114 : use let a print, remove it please Otherwise, LGTM, Regards,

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/sale-wkfl/sale-wkfl-sale-multi-journal into lp:sale-wkfl

2014-05-09 Thread Joël Grand-Guillaume
Review: Needs Information Hi, Thanks for the contrib ! I also agree with Pedro and using sale_journal_shop as module name make more sense to me than using sale_multi_journal.. We do not have various journal right ? Only one by shop ? Thanks for the feed-back, Regards, Joël --

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/account-invoicing/account_invoice_line_merge into lp:account-invoicing

2014-05-09 Thread Joël Grand-Guillaume
Review: Needs Fixing code review, no tests Hi, Thanks for the contrib. It seems to me that you have a strange diff here, like if files or folder have been here more than once ? Can you check and clean the MP ? Otherwise, the code is looking good to me. Regards, Joël --

Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-analytic/7.0-hr_expense_analytic_plans into lp:account-analytic

2014-05-09 Thread Joël Grand-Guillaume
Review: Approve code review, no tests LGTM, thanks ! -- https://code.launchpad.net/~pedro.baeza/account-analytic/7.0-hr_expense_analytic_plans/+merge/216469 Your team Account Core Editors is subscribed to branch lp:account-analytic. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-tools/account_partner_required-sbi into lp:account-financial-tools

2014-05-09 Thread Joël Grand-Guillaume
Review: Approve code review, no tests Hi Stéphane, Thanks for the contrib, and as usual, thanks for providing tests :) LGMT, Regards, Joël -- https://code.launchpad.net/~acsone-openerp/account-financial-tools/account_partner_required-sbi/+merge/216442 Your team OpenERP Community

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/account-invoice-report/account-invoice-report-7.0_delivery_address into lp:account-invoice-report

2014-05-09 Thread Joël Grand-Guillaume
Review: Approve code review, no tests Hi, Thanks for the contrib ! LGTM, Regards, Joël -- https://code.launchpad.net/~therp-nl/account-invoice-report/account-invoice-report-7.0_delivery_address/+merge/207915 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch

Re: [Openerp-community-reviewer] [Merge] lp:~david-cormier-j/sale-wkfl/sale_landed_costs into lp:sale-wkfl

2014-05-09 Thread Joël Grand-Guillaume
Review: Needs Fixing code review, no tests Hi David, Thanks for porting this module. A few remarks: * Would you please consider using the BZR extractor (https://launchpad.net/bazaar-extractor) to put this module in that branch ? This will then keep the commite message insead of having just

Re: [Openerp-community-reviewer] [Merge] lp:~sistemas-adhoc/account-financial-tools/currency_update into lp:account-financial-tools

2014-05-09 Thread Joël Grand-Guillaume
Review: Approve code review, no tests Hi, Thanks for the explanation. LGTM, Regards, Joël -- https://code.launchpad.net/~sistemas-adhoc/account-financial-tools/currency_update/+merge/204759 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools.

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/openerp-manufacturing/70-add-mrp-product-serial into lp:openerp-manufacturing

2014-05-09 Thread Joël Grand-Guillaume
Review: Approve code review, no tests LGTM, this other MP is now ok -- https://code.launchpad.net/~akretion-team/openerp-manufacturing/70-add-mrp-product-serial/+merge/211689 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:openerp-manufacturing. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/web-addons/7.0-add-web_send_message_popup into lp:web-addons

2014-05-09 Thread Joël Grand-Guillaume
Review: Approve code review, no tests LGTM, thanks ! -- https://code.launchpad.net/~camptocamp/web-addons/7.0-add-web_send_message_popup/+merge/217188 Your team Web-Addons Core Editors is subscribed to branch lp:web-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer

Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix into lp:account-financial-tools

2014-05-09 Thread Joël Grand-Guillaume
Review: Approve code review, no tests Hi Perdo, Thanks for the contribution, it LGTM. Regards, -- https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix/+merge/214832 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-improve-preq-cancel-nbi into lp:openerp-humanitarian-ngo/purchase-wkfl

2014-05-08 Thread Joël Grand-Guillaume
Review: Needs Fixing code review, no tests Hi, Needs an update to be adapted to last lp:openerp-humanitarian-ngo/addons-backport Especially the call to tender_cancel must also use the mtehod _requisition_procurement_cancel Regards, --

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-improve-preq-cancel-nbi into lp:openerp-humanitarian-ngo/purchase-wkfl

2014-05-08 Thread Joël Grand-Guillaume
Moreover, we have no call to super in tender_cancel -- https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-improve-preq-cancel-nbi/+merge/217948 Your team OpenERP for Humanitarian Core Editors is subscribed to branch lp:openerp-humanitarian-ngo/purchase-wkfl. --

Re: [Openerp-community-reviewer] [Merge] lp:~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055 into lp:department-mgmt

2014-05-08 Thread Joël Grand-Guillaume
Review: Approve code review, no tests LGTM, thanks ! -- https://code.launchpad.net/~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055/+merge/212286 Your team Department Core Editors is subscribed to branch lp:department-mgmt. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055 into lp:department-mgmt

2014-05-08 Thread Joël Grand-Guillaume
Review: Needs Fixing code review, no tests Hi, Sorry I miss something : Line 24 and 55, if employee has no department_id define, the code will break. Can you please add a test on department_id. Regards, --

Re: [Openerp-community-reviewer] [Merge] lp:~jb.eficent/department-mgmt/department-mgmt-bugfixes_analytic into lp:department-mgmt

2014-05-08 Thread Joël Grand-Guillaume
Review: Needs Information code review + test Hi, As suggested in the MP related to task's department (https://code.launchpad.net/~camptocamp/department-mgmt/add-dep-on-project-task-jge/+merge/217068) I think we have 2 important informations in analytic line,. * The first one is the user's

[Openerp-community-reviewer] [Merge] lp:~camptocamp/department-mgmt/add-account-department-fix-default-anyltic-jge into lp:department-mgmt

2014-05-08 Thread Joël Grand-Guillaume
Joël Grand-Guillaume @ camptocamp has proposed merging lp:~camptocamp/department-mgmt/add-account-department-fix-default-anyltic-jge into lp:department-mgmt. Requested reviews: Department Core Editors (department-core-editors) Related bugs: Bug #1296109 in Department Management

Re: [Openerp-community] [Openerp-community-reviewer] New reviewer

2014-05-02 Thread Joël Grand-Guillaume
-- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/department-mgmt/add-dep-on-project-task-jge into lp:department-mgmt

2014-04-28 Thread Joël Grand-Guillaume
I agree with you guys, thanks for the review. Project departement is better. I'll make the modifications. -- https://code.launchpad.net/~camptocamp/department-mgmt/add-dep-on-project-task-jge/+merge/217068 Your team Department Core Editors is subscribed to branch lp:department-mgmt. --

Re: [Openerp-community-reviewer] [Merge] lp:~yannick-buron/contract-management/contract-management into lp:contract-management

2014-04-25 Thread Joël Grand-Guillaume
Review: Approve code review, no tests LGTM now, thanks ! -- https://code.launchpad.net/~yannick-buron/contract-management/contract-management/+merge/207630 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:contract-management. -- Mailing list:

Re: [Openerp-connector-community] Automatically link imported products on existing ones by SKU

2014-04-24 Thread Joël Grand-Guillaume
More help : https://help.launchpad.net/ListHelp -- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com -- Mailing list: https://launchpad.net/~openerp-connector-community Post

[Openerp-community-reviewer] [Merge] lp:~camptocamp/department-mgmt/add-dep-on-project-task-jge into lp:department-mgmt

2014-04-24 Thread Joël Grand-Guillaume
Joël Grand-Guillaume @ camptocamp has proposed merging lp:~camptocamp/department-mgmt/add-dep-on-project-task-jge into lp:department-mgmt. Requested reviews: Department Core Editors (department-core-editors) For more details, see: https://code.launchpad.net/~camptocamp/department-mgmt/add

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/7.0-crm_claim_rma-add-picking-buttons into lp:openerp-rma

2014-04-23 Thread Joël Grand-Guillaume
Review: Approve code review, no tests LGTM. Thanks ! -- https://code.launchpad.net/~camptocamp/openerp-rma/7.0-crm_claim_rma-add-picking-buttons/+merge/208334 Your team OpenERP RMA is subscribed to branch lp:openerp-rma. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup into lp:openerp-rma

2014-04-23 Thread Joël Grand-Guillaume
Review: Needs Fixing code review, no tests Hi, Thanks for improving the module. I may not have the time to read all carefully, just what I saw in a few minutes here: * L269 : For the method _get_default_warehouse, I prefer to get the WH through the user because take one from

Re: [Openerp-community] Rationale for proposing the project openerp-nomenclature to join the OCA projects

2014-04-22 Thread Joël Grand-Guillaume
Sorry for that, I was on holidays. Thanks for handling this. On Tue, Mar 25, 2014 at 5:39 PM, Lionel Sausin l...@numerigraphe.com wrote: Le 19/03/2014 10:18, Joël Grand-Guillaume a écrit : Hi Franco, That would be a good idea IMO to have such project. Currently we have those

Re: [Openerp-community] Rationale for proposing the project openerp-nomenclature to join the OCA projects

2014-03-19 Thread Joël Grand-Guillaume
SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https

Re: [Openerp-community-reviewer] Sylvain LE GAL application to OpenERP Community Reviewer / Maintainer

2014-03-14 Thread Joël Grand-Guillaume
://help.launchpad.net/ListHelp -- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer

[Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge into lp:sale-wkfl

2014-03-12 Thread Joël Grand-Guillaume
Joël Grand-Guillaume @ camptocamp has proposed merging lp:~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge into lp:sale-wkfl. Commit message: [ADD] sale_jit_on_services module that provide the mrp_jit feature but only on product of type service. Requested reviews: Sandy Carter

Re: [Openerp-community-reviewer] [Merge] lp:~rruebner/server-env-tools/7.0_fix_mass_editing into lp:server-env-tools

2014-03-11 Thread Joël Grand-Guillaume
Review: Approve code review + tests Hi, I just checked that path and it work perfectly. I had the trouble in editing the email template, when you search for a field and ask for search more... you get this crash : Server Traceback (most recent call last): File

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/add-variant-dispach-report-jge into lp:stock-logistic-flows

2014-02-26 Thread Joël Grand-Guillaume
Hi Pedro, You're right, but the thing is, you may have some product that have a variant and some no. So I though it would be more clear to always have the column.. No ? Regards, -- https://code.launchpad.net/~camptocamp/stock-logistic-flows/add-variant-dispach-report-jge/+merge/207961 Your

[Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/add-variant-dispach-report-jge into lp:stock-logistic-flows

2014-02-24 Thread Joël Grand-Guillaume
Joël Grand-Guillaume @ camptocamp has proposed merging lp:~camptocamp/stock-logistic-flows/add-variant-dispach-report-jge into lp:stock-logistic-flows. Commit message: [IMP] Add the variant in the dispatch report Requested reviews: Stock and Logistic Core Editors (stock-logistic-core-editors

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_postlogistics-pep8 into lp:carriers-deliveries

2014-02-18 Thread Joël Grand-Guillaume
Review: Approve code review, no tests LGTM -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_postlogistics-pep8/+merge/205631 Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~alejandrosantana/openerp-humanitarian-ngo/7.0-purchase-wkfl--fix-1277236 into lp:openerp-humanitarian-ngo/purchase-wkfl

2014-02-07 Thread Joël Grand-Guillaume
Hi, Thanks a lot for the fix ! Seems like it's fixed. -- https://code.launchpad.net/~alejandrosantana/openerp-humanitarian-ngo/7.0-purchase-wkfl--fix-1277236/+merge/205280 Your team OpenERP for Humanitarian Core Editors is requested to review the proposed merge of

Re: [Openerp-community-reviewer] [Merge] lp:~yannick-buron/contract-management/contract-management into lp:contract-management

2014-02-06 Thread Joël Grand-Guillaume
Hi Ronald and Yannick, Ok, after coming back on this one, I agree with you Ronald. We should leave it as is, so fixes will be much easier to port ! So @Yannick, if you can just correct 1st and 4th point and it ok for me. Regards, Joël --

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/ngo-addons-add_agreement_sourcing-nbi into lp:openerp-humanitarian-ngo

2014-02-06 Thread Joël Grand-Guillaume
Review: Approve code review + test Hi, This LGTM, as all the correction have been made here : https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/ngo-addons-add_other_procurement_method-nbi/+merge/205123 So I suggest merging this one first in the trunk and then proposed the

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-fix_copy_origin-rde into lp:openerp-humanitarian-ngo/purchase-wkfl

2014-02-06 Thread Joël Grand-Guillaume
Review: Approve code review + no tests LGTM thanks -- https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-fix_copy_origin-rde/+merge/203584 Your team OpenERP for Humanitarian Core Editors is subscribed to branch lp:openerp-humanitarian-ngo/purchase-wkfl. -- Mailing

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/addons-backport-improve_on_change-nbi into lp:openerp-humanitarian-ngo/addons-backport

2014-02-06 Thread Joël Grand-Guillaume
Review: Approve code review, no tests LGTM, thanks ! -- https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/addons-backport-improve_on_change-nbi/+merge/195007 Your team OpenERP for Humanitarian Core Editors is subscribed to branch lp:openerp-humanitarian-ngo/addons-backport. --

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-fix_1250507-nbi into lp:openerp-humanitarian-ngo/purchase-wkfl

2014-02-06 Thread Joël Grand-Guillaume
Review: Approve code review + test LGTM, thanks ! -- https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-fix_1250507-nbi/+merge/195006 Your team OpenERP for Humanitarian Core Editors is subscribed to branch lp:openerp-humanitarian-ngo/purchase-wkfl. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/add-bid_selected_state_on_po-nbi into lp:openerp-humanitarian-ngo/purchase-wkfl

2014-02-06 Thread Joël Grand-Guillaume
Review: Approve code review + test LGTM, Thanks ! -- https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/add-bid_selected_state_on_po-nbi/+merge/200799 Your team OpenERP for Humanitarian Core Editors is subscribed to branch lp:openerp-humanitarian-ngo/purchase-wkfl. -- Mailing

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-add_framework_agreement-nbi into lp:purchase-wkfl

2014-02-06 Thread Joël Grand-Guillaume
Review: Approve code review + test Hi, This LGTM. I just have the little remark I already made: * Adding a LTA on a product should add a supplierinfo entry as well. A part from that, LGTM. I don't want to block it for that. Just to let you know. Regards, --

Re: [Openerp-community] Multi-packaging

2014-02-03 Thread Joël Grand-Guillaume
: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp -- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-reporting-engines/7.0-add-base_report_assembler-yvr into lp:openerp-reporting-engines

2014-01-31 Thread Joël Grand-Guillaume
Review: Approve code review, no tests LGTM, thanks -- https://code.launchpad.net/~camptocamp/openerp-reporting-engines/7.0-add-base_report_assembler-yvr/+merge/194304 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:openerp-reporting-engines. -- Mailing list:

Re: [Openerp-community] v7: contact working for two companies? Possible?

2014-01-30 Thread Joël Grand-Guillaume
Hi, For base_contact module, there is a MP here : https://code.launchpad.net/~openerp-dev/openobject-addons/7.0-base-contact-xal/+merge/192129 Still under review, but no more news for month now. Would be great to comment in there so people will see it ! Regards, Joël attachment:

Re: [Openerp-community] V8: shop_id gone - are shops deprecated?

2014-01-30 Thread Joël Grand-Guillaume
-community More help : https://help.launchpad.net/ListHelp -- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com ___ Mailing list: https

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-invoice-report/7.0-invoice-webkit-add-reference into lp:account-invoice-report

2014-01-29 Thread Joël Grand-Guillaume
Review: Approve code review, no tests LGTM -- https://code.launchpad.net/~camptocamp/account-invoice-report/7.0-invoice-webkit-add-reference/+merge/203085 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list:

Re: [Openerp-community] Customizing quants with quality status (Re: New WMS. Call for testers.)

2014-01-28 Thread Joël Grand-Guillaume
-- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community

Re: [Openerp-community] tests/feedbacks for the new reporting

2014-01-28 Thread Joël Grand-Guillaume
SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net

Re: [Openerp-community] tests/feedbacks for the new reporting

2014-01-28 Thread Joël Grand-Guillaume
, but without any entries, it still take around 45 sec to print ! May be something strange here... Good luck ! Regards, Joël On Tue, Jan 28, 2014 at 9:33 AM, Joël Grand-Guillaume joel.grandguilla...@camptocamp.com wrote: Hello Fabien, Thanks for that answer, I do now understand more

  1   2   3   4   >