Review: Resubmit
Hi! Development of OCA modules has moved to Github nowadays. Parthiv, Nhomar,
and others, is this still of interest? In that case, could someone move it to
github? Ping me if you need help. Thanks!
--
Ajit, AFAIK this has never been moved to github. What I said is that someone
could do it if there is still interest in it.
https://github.com/OCA/maintainer-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
--
https://code.launchpad.net/~parthiv-patel/web-addons/web-addons/+merge/179846
Your
migrated to https://github.com/OCA/sale-workflow/pull/74
--
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-add-sale-default-discount-lep/+merge/227214
Your team Sale Core Editors is subscribed to branch
lp:~sale-core-editors/sale-wkfl/7.0.
--
Mailing list:
The proposal to merge
lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_budget_limit into
lp:~purchase-core-editors/purchase-wkfl/7.0 has been updated.
Status: Needs review = Rejected
For more details, see:
Hi Carlos,
this is an old merge proposal. The module has been moved to github at
https://github.com/OCA/web/tree/7.0/web_export_view
Please post there. Thanks!
--
https://code.launchpad.net/~domsense/web-addons/7.0-web_export_view/+merge/169000
Your team Web-Addons Core Editors is subscribed
The proposal to merge lp:~camptocamp/sale-wkfl/7.0-dropshipping-merge-po-lep
into lp:~sale-core-editors/sale-wkfl/7.0 has been updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-dropshipping-merge-po-lep/+merge/216756
--
Moved to https://github.com/OCA/sale-workflow/pull/27
--
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-dropshipping-merge-po-lep/+merge/216756
Your team Sale Core Editors is subscribed to branch
lp:~sale-core-editors/sale-wkfl/7.0.
--
Mailing list:
migrated to
https://github.com/OCA/sale-workflow/pull/44
--
https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/222111
Your team Sale Core Editors is subscribed to branch
lp:~sale-core-editors/sale-wkfl/7.0.
--
Mailing list:
The proposal to merge lp:~camptocamp/sale-wkfl/product_procurement_type into
lp:~sale-core-editors/sale-wkfl/7.0 has been updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/222111
--
The proposal to merge
lp:~camptocamp/ocb-addons/7.0-fix-report-inactive-journals-mdh into
lp:ocb-addons has been updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-report-inactive-journals-mdh/+merge/232175
--
Review: Disapprove
Hi, OCB is now on github. Thanks!
--
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-report-inactive-journals-mdh/+merge/232175
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list:
Leonardo Pistone - camptocamp has proposed merging
lp:~camptocamp/openobject-doc/6.1-add-outdated-links-warning-lep into
lp:~openerp-community/openobject-doc/6.1.
Requested reviews:
OpenERP Community (openerp-community)
For more details, see:
https://code.launchpad.net/~camptocamp/openobject
Review: Needs Fixing
In __openerp__.py there are some 's that should be removed.
Thanks
--
https://code.launchpad.net/~sylvain-legal/openerp-pos/7.0_pos_select_customer/+merge/228826
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:openerp-pos.
--
Mailing list:
Pedro,
I renamed the field as you suggested.
The default in the line works because of the attribute context in sale.xml.
Thanks to Romain Deheele for showing me that.
I also added two tests, and got a bit frustrated when I realized that the YAML
test does not get the same behaviour of manual
Yann,
you are right. Still, this module came out from a situation where pricelists
were already used for other things, and a simple default discount was useful
anyway.
--
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-add-sale-default-discount-lep/+merge/227214
Your team Sale Core
Review: Needs Fixing
Apparently a symlink is gone in that commit.
The diff also says === target was u'base_location' which I don't understand.
If that is intentional, can you please split into another commit and elaborate
in the commit message?
Thanks!
--
I think the the symlink was intentionally there for backwards compatibility
when the module better_zip was renamed to base_location.
I now understand the second line of the diff - it has to be read as one
sentence (removed symlink better_zip, target was base_location).
I suggest you start
Review: Approve
+1
--
https://code.launchpad.net/~therp-nl/partner-contact-management/7.0-firstname_display_name_trigger_prepare_name/+merge/227152
Your team Partner and Contact Core Editors is subscribed to branch
lp:partner-contact-management.
--
Mailing list:
Leonardo Pistone - camptocamp has proposed merging
lp:~camptocamp/sale-wkfl/7.0-add-sale-default-discount-lep into lp:sale-wkfl.
Requested reviews:
Sale Core Editors (sale-core-editors)
For more details, see:
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-add-sale-default-discount-lep
Review: Needs Fixing
Hi.
l27: where you do '\n'.join I would feel more confortable having u'\n'.join
because char fields are unicode, at least with translated fields (by the way,
at least is a bad inconsistency in the framework).
l32: context={} - context=None
self.pool.get - self.pool[]
Review: Needs Information
thanks for the fix Lorenzo.
Can you confirm that the test is correct and production code was actually
broken?
--
https://code.launchpad.net/~agilebg/account-consolidation/7.0-fix-1334645-elbati/+merge/225266
Your team Account Core Editors is subscribed to branch
Review: Needs Fixing
Hi Hugo.
can you include an automated test to show which situation breaks and is fixed
with the patch?
--
https://code.launchpad.net/~factorlibre/account-invoicing/account-invoicing-fix-merge-7.0/+merge/225271
Your team Account Core Editors is subscribed to branch
Review: Needs Fixing
Hi Lorenzo,
I am still non convinced :)
This way the test is not actually testing a useful workflow, but just a return
True workaround.
I'd be happier if the yaml test actually tested a realistic case. (or at least,
clarify in the yaml file what's going on)
Thanks!
--
Review: Approve
Stéphane,
Maybe you could refactor a bit with:
cur_year = time.strftime('%Y')
and then use it later?
being that a small change, I approve anyway
--
https://code.launchpad.net/~acsone-openerp/account-financial-report/7.0-bug-1281579-sbi2/+merge/225620
Your team Account Report
Hi Sylvain,
no, in the end we decided to move 7.0 to github as well.
Of course, in situations like that one where reviews were already done, we'll
continue from where we are (no need to duplicate reviews).
--
Review: Needs Fixing
Thanks Lorenzo.
maybe you could refactor a bit putting
parent_parallel_tax_code_id = False
in an else: block a few lines down? otherwise, lgtm
--
https://code.launchpad.net/~agilebg/account-consolidation/7.0-fix-1334645-elbati/+merge/225266
Your team Account Core Editors
Review: Approve
Hi,
I agree with a lint-only MP like that one (as soon as it doesn't introduce new
problems).
Thanks!
--
https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-flake8/+merge/225456
Your team Server Environment And Tools Core Editors is subscribed to branch
Review: Approve
thanks
--
https://code.launchpad.net/~agilebg/account-consolidation/7.0-fix-1334645-elbati/+merge/225266
Your team Account Core Editors is subscribed to branch
lp:account-consolidation/7.0.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Alexis, They don't! :)
On Thu, Jul 3, 2014 at 6:16 PM, Alexis de Lattre ale...@via.ecp.fr
wrote:
Well... product_serial will have to be largely re-written for v8, given all
the big changes in stock management. If the modules in v7.0 stay on LP, we
could keep this branch here.
--
Review: Approve
lgtm
--
https://code.launchpad.net/~camptocamp/stock-logistic-report/7.0-replace-print-actions-mdh/+merge/225126
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-report.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post
I moved that to https://github.com/OCA/stock-logistics-reporting/pull/2
As it was approved here, I will merge it as soon as the tests pass.
Thanks!
--
https://code.launchpad.net/~camptocamp/stock-logistic-report/7.0-replace-print-actions-mdh/+merge/225126
Your team Stock and Logistic Core
Review: Needs Information
Hi Yannick,
so this is already on the v7 on github. Now that OCB migration to github is in
progress,
should we merge that in ocb on launchpad?
Other than that, I would approve the change.
Thanks!
--
Review: Disapprove
Hi Vincent,
Being an invoice an official document, It is a good idea to store the report
generated when the invoice was confirmed.
If, for example, the customer data, the product name, taxes, company
name/header change, the invoice document should not change. The current
Review: Approve
Thanks a lot Stefan.
--
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1311087-rgo/+merge/224247
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve
Romain,
I approve your changes, thanks
--
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-dropshipping-merge-po-lep/+merge/216756
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to
Review: Approve
+1
--
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM/+merge/223928
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Needs Fixing
l63 sellerman - salesman
l63 ordrer - ordered
hint of - a hint about
those information - that information
in sale - in the sale
Review: Approve
Thanks Yannick.
I agree with Guewen an onchange would be a better UI, but I'm not blocking on
this.
--
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-add-last_sale_price-yvr/+merge/223704
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list:
Review: Approve code review
Last few remarks to the end of the diff:
- 1407 the line is perhaps unintentional?
- 1299 typo initialize
- 2343 typo bypasses.
These are just small doc typos, so I'm
Review: Needs Fixing
Thanks Nicolas. A few small remarks up to line 1300:
- l138 typo
- l143 seems like you are copying twice
Review: Approve
lgtm thanks
--
https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-fix-button-visibility/+merge/205304
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve
LGTM
--
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1319109/+merge/219473
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
The proposal to merge lp:~camptocamp/ocb-addons/7.0-fix-1319109 into
lp:ocb-addons has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1319109/+merge/219473
--
The proposal to merge lp:~camptocamp/ocb-addons/7.0-fix-1319095 into
lp:ocb-addons has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1319095/+merge/219476
--
The proposal to merge
lp:~camptocamp/partner-contact-management/add-base_partner_merge into
lp:partner-contact-management has been updated.
Status: Needs review = Approved
For more details, see:
As Maxime's remarks should have been addressed, I proceed with the merge.
Thank you
--
https://code.launchpad.net/~camptocamp/partner-contact-management/add-base_partner_merge/+merge/189616
Your team Partner and Contact Core Editors is subscribed to branch
lp:partner-contact-management.
--
Review: Approve code review
ok, thanks
--
https://code.launchpad.net/~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde/+merge/218666
Your team OpenERP RMA is subscribed to branch lp:openerp-rma.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Lionel, I rejected this following your comments.
Thanks
--
https://code.launchpad.net/~numerigraphe-team/ocb-web/7.0-hide-oe_read_only/+merge/213016
Your team OpenERP Community Backports is subscribed to branch lp:ocb-web.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post
Review: Approve
If I understand correctly, we are trading a small smoothness advantage for old
distributions vs. more up-to-date ones that received pep394.
I lean a bit for calling python2 explicitly. I prefer those with old
distributions to go through some (easy) hoops to comply with
highlights from the similar MP on trunk: Olivier Dony said they will merge on
the core in trunk but not in 7.0, so this extra addon for 7.0 makes sense.
Olivier made some remarks I agree with, they'll be fixed here as well ASAP.
thanks!
--
Martin,
I am not convinced we need mutability here. Couldn't we still do return res +
('c',)?
--
https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
--
Mailing list:
- l282: syntax
- l177 typo
- can you please run flake8 on the module? there are some little issues here
and there.
- (non-blocking) if some methods are copied to just override a small thing, it
would help to have a precise reference to the original one.
- there are a couple of very long methods
Martin, can you please reconsider your review? your points should be fixed now.
--
https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
--
Mailing list:
Review: Approve
thanks romain
--
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_picking_oriented_use-rde/+merge/215147
Your team Stock and Logistic Core Editors is requested to review the proposed
merge of
Review: Approve code review
ok, code-wise
--
https://code.launchpad.net/~camptocamp/openerp-rma/rma-fix-lp1311520_rde/+merge/216839
Your team OpenERP RMA is subscribed to branch lp:openerp-rma.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Leonardo Pistone - camptocamp has proposed merging
lp:~camptocamp/openerp-product-attributes/7.0-fix-field-acl-lep into
lp:openerp-product-attributes.
Requested reviews:
Product Core Editors (product-core-editors)
Related bugs:
Bug #1316672 in OpenERP Product Attributes
I fixed martin's remarks, and added a new unit test. We're back into needs
review.
--
https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
--
Mailing list:
Leonardo Pistone - camptocamp has proposed merging
lp:~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep into lp:purchase-wkfl.
Requested reviews:
martin (riess82)
Romain Deheele - Camptocamp (romaindeheele)
Pedro Manuel Baeza (pedro.baeza)
Related bugs:
Bug #1217869 in OpenERP Addons
You are right Martin, thanks.
You can set review: Needs fixing and press save comment (no comment is OK
because you already commented).
--
https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745
Your team Purchase Core Editors is subscribed to branch
Leonardo Pistone - camptocamp has proposed merging
lp:~camptocamp/openerp-product-attributes/7.0-partner-attributes-lep into
lp:openerp-product-attributes.
Requested reviews:
Product Core Editors (product-core-editors)
For more details, see:
https://code.launchpad.net/~camptocamp/openerp
Leonardo Pistone - camptocamp has proposed merging
lp:~camptocamp/openerp-product-attributes/7.0-del-text-workaround-lep into
lp:openerp-product-attributes.
Requested reviews:
Product Core Editors (product-core-editors)
For more details, see:
https://code.launchpad.net/~camptocamp/openerp
Your point makes sense, Romain.
I would rather leave it as it is, since:
1. This is just a refactor with a few tests added. It is probably better to
keep the existing functionality for now.
2. I'm not sure that can happen often in practice, and the implementation could
use string manipulation
Pedro, I proposed this to core trunk:
https://code.launchpad.net/~camptocamp/openobject-addons/trunk-refactor-po-merge-lep/+merge/216841
--
https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745
Your team Purchase Core Editors is subscribed to branch
this depends on
https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745
--
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-dropshipping-merge-po-lep/+merge/216756
Your team Sale Core Editors is requested to review the proposed merge of
thanks Matthieu.
I'm also not a fan of the SQL if I don't have a gun pointed at me. Hopefully
with the test it will be easier to improve that.
--
https://code.launchpad.net/~camptocamp/account-budgeting/7.0-fix-store-fields-mdh/+merge/216849
Your team Account Core Editors is subscribed to
Review: Approve code review
thanks
--
https://code.launchpad.net/~camptocamp/ocb-web/7.0-fix_1190236_opw-595981-msh/+merge/216664
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-web.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Leonardo Pistone - camptocamp has proposed merging
lp:~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep into lp:purchase-wkfl.
Requested reviews:
Purchase Core Editors (purchase-core-editors)
For more details, see:
https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep
Hi Pedro.
For trunk, I am actually going to propose it in the official branches tomorrow.
See lp:~camptocamp/openobject-addons/trunk-refactor-po-merge-lep
For 7.0, I thought it would be easier to do an extra module.
Thanks!
--
Leonardo Pistone - camptocamp has proposed merging
lp:~camptocamp/sale-wkfl/7.0-add-dropshipping-merge-check-lep into lp:sale-wkfl.
Requested reviews:
Sale Core Editors (sale-core-editors)
For more details, see:
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-add-dropshipping-merge-check
The proposal to merge
lp:~camptocamp/sale-wkfl/7.0-add-dropshipping-merge-check-lep into lp:sale-wkfl
has been updated.
Status: Needs review = Work in progress
For more details, see:
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-add-dropshipping-merge-check-lep/+merge/216420
--
Review: Disapprove
After discussion with Alexandre Fayolle, I am convinced this has to be replaced
with a new, extendible make_po.
--
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-add-dropshipping-merge-check-lep/+merge/216420
Your team Sale Core Editors is requested to review the
Review: Approve
On a low-level, I see that elements of curr_ids that are not in ids should not
change the result. So I approve the fix.
On the other hand, I don't get what the method does. Could you take the
occasion to add a docstring or comment, and maybe rename tid, ids, curr_ids ...
Review: Needs Fixing code review
Thanks Romain
77 +test: [],
--
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_picking_oriented_use-rde/+merge/215147
Your team Stock and Logistic Core Editors is requested to review the proposed
merge of
Review: Approve
thanks
--
https://code.launchpad.net/~camptocamp/ocb-server/7.0-fix_1305872-afe/+merge/215176
Your team OpenERP Community Backports Team is requested to review the proposed
merge of lp:~camptocamp/ocb-server/7.0-fix_1305872-afe into lp:ocb-server.
--
Mailing list:
Review: Approve code review
ok thanks
--
https://code.launchpad.net/~camptocamp/account-financial-report/7.0-add-reference-field-mdh/+merge/214897
Your team Account Report Core Editors is subscribed to branch
lp:account-financial-report.
--
Mailing list:
Review: Approve
Thanks Holger.
It's actually more then 5: the pending votes are from people like me that
approved the old version of the proposal (i'm approving again here). The new
proposal looks identical, what happened?
--
Review: Approve code review
same as
https://code.launchpad.net/~camptocamp/openobject-addons/7.0_fix-document-search-order-by_rde/+merge/214483
--
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1302630_document_search_order_by-rde/+merge/214486
Your team OpenERP Community
Review: Approve code review
thanks!
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/6.1-change-class-name-to-avoid-error_rde/+merge/213883
Your team Stock and Logistic Core Editors is subscribed to branch
lp:carriers-deliveries/6.1.
--
Mailing list:
Review: Approve
thanks
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde/+merge/213881
Your team Stock and Logistic Core Editors is subscribed to branch
lp:carriers-deliveries.
--
Mailing list:
Stefan, what I mean is that I prefer CamelCase too, but I abstain here because
SA uses underscores all over the place.
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde/+merge/213881
Your team Stock and Logistic Core Editors is subscribed to
Review: Needs Information
Thanks Vincent.
I don't know the module affected, but shouldn't the contact (now a res.partner
and not a res.partner.address) be handled somehow?
--
https://code.launchpad.net/~camptocamp/project-reporting/blank_invoice_vre/+merge/213842
Your team Project Core Editors
Review: Approve code review
thanks
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-add-state-field-to-avoid-js-error-on-wizard-launch_rde/+merge/213019
Your team Stock and Logistic Core Editors is requested to review the proposed
merge of
Thanks Romain.
Are tests green?
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-v7-port-base_delivery_carrier_files_document-addon_rde/+merge/213083
Your team Stock and Logistic Core Editors is requested to review the proposed
merge of
Review: Approve code review
LGTM thanks.
--
https://code.launchpad.net/~camptocamp/account-financial-tools/fix_bug_1297369/+merge/212648
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list:
Review: Approve
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-needed_changes_to_fit_with_stock_picking_v7_changes-rde/+merge/211056
Your team Stock and Logistic Core Editors is requested to review the proposed
merge of
Thanks Pedro.
The 6.1 version of production_lot_custom_attributes has an extra feature in
addition to the one in v7.0: the search in all attributes. That uses the
original _.
In any case my editor checks flake8, and that should point out unused imports.
--
Review: Approve code review
thanks
--
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-product_price_history-failing-test-1295137/+merge/211942
Your team Margin Analysis Core Editors is requested to review the proposed
merge of
Leonardo Pistone - camptocamp has proposed merging
lp:~camptocamp/openerp-product-attributes/6.1-fix-translate-view-lep into
lp:openerp-product-attributes/6.1.
Requested reviews:
Product Core Editors (product-core-editors)
Related bugs:
Bug #1294745 in OpenERP Product Attributes: [6.1] [7.0
Review: Approve code review
ok
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/6.1-fix-base_delivery_carrier_files-rde/+merge/210772
Your team Stock and Logistic Core Editors is subscribed to branch
lp:carriers-deliveries/6.1.
--
Mailing list:
Leonardo Pistone - camptocamp has proposed merging
lp:~camptocamp/openerp-product-attributes/7.0-fix-translate-view-lep into
lp:openerp-product-attributes.
Requested reviews:
Product Core Editors (product-core-editors)
Related bugs:
Bug #1294745 in OpenERP Product Attributes: [6.1] [7.0
Leonardo Pistone - camptocamp has proposed merging
lp:~camptocamp/openerp-product-attributes/6.1-fix-translate-view-lep into
lp:openerp-product-attributes/6.1.
Requested reviews:
Product Core Editors (product-core-editors)
Related bugs:
Bug #1294745 in OpenERP Product Attributes: [6.1] [7.0
Note: similar fix already merged on v7
https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-rights-attribute_set-1254609/+merge/196481
--
https://code.launchpad.net/~camptocamp/openerp-product-attributes/6.1-rights-attribute_set-1254609/+merge/210809
Your team OpenERP Community
Leonardo Pistone - camptocamp has proposed merging
lp:~camptocamp/ocb-server/6.1-leaner-bzrignore-lep into lp:ocb-server/6.1.
Requested reviews:
OpenERP Community Backports Team (ocb)
Related bugs:
Bug #1293461 in OpenERP Server: .bzrignore ignores all addons
https://bugs.launchpad.net
Leonardo Pistone - camptocamp has proposed merging
lp:~camptocamp/ocb-server/7.0-leaner-bzrignore-lep into lp:ocb-server.
Requested reviews:
OpenERP Community Backports Team (ocb)
Related bugs:
Bug #1293461 in OpenERP Server: .bzrignore ignores all addons
https://bugs.launchpad.net
Sandy,
1. Do you think there is a use case where you want to have .swp files around
but you want bzr status to tell you all is good and clean?
2. What do you think about the other two removals? I'm happy to remove only
what we find an agreement on.
Thanks!
--
Review: Approve code review
Good point Alexandre.
But unless someone can come up with a practical case where this specific
example of schema change could be a problem (I don't), I approve.
--
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo/+merge/209917
Your team
Leonardo Pistone - camptocamp has proposed merging
lp:~camptocamp/openerp-product-attributes/6.1-rights-attribute_set-1254609 into
lp:openerp-product-attributes/6.1.
Requested reviews:
Product Core Editors (product-core-editors)
Related bugs:
Bug #1254609 in OpenERP Product Attributes
Review: Approve code review
LGTM, thanks
--
https://code.launchpad.net/~camptocamp/stock-logistic-flows/70-improve-dispatch-jge/+merge/210598
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-flows.
--
Mailing list:
Leonardo Pistone - camptocamp has proposed merging
lp:~camptocamp/openerp-product-attributes/6.1-rights-attribute_set-1254609 into
lp:openerp-product-attributes/6.1.
Requested reviews:
Product Core Editors (product-core-editors)
Related bugs:
Bug #1254609 in OpenERP Product Attributes
Review: Approve code review
--
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_action_rule_processing_lp1190592-afe/+merge/209086
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
1 - 100 of 207 matches
Mail list logo
