Ciao banane,
you have to use
from openerp.tools.translate import _ (see for instance
https://github.com/OCA/account-invoice-reporting/blob/7.0/invoice_webkit/invoice.py#L52
)
Anyway, the project has moved to github. Please open an issue (or better a PR)
at
Done at https://github.com/OCA/purchase-reporting/pull/1
--
https://code.launchpad.net/~agilebg/purchase-report/7_fix_1331394/+merge/223799
Your team Purchase Core Editors is subscribed to branch
lp:~purchase-core-editors/purchase-report/7.0.
--
Mailing list:
Review: Disapprove
moved to https://github.com/OCA/sale-workflow/pull/9
--
https://code.launchpad.net/~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7/+merge/223538
Your team Sale Core Editors is requested to review the proposed merge of
Review: Disapprove
moved to https://github.com/OCA/account-invoicing/pull/9
--
https://code.launchpad.net/~agilebg/account-invoicing/adding_invoice_line_no_picking_name_7/+merge/220289
Your team Account Core Editors is subscribed to branch
lp:~account-core-editors/account-invoicing/7.0.
--
PR for v8 at https://github.com/OCA/partner-contact/pull/22
--
https://code.launchpad.net/~akretion-team/partner-contact-management/base-location-geonames-import/+merge/214564
Your team Partner and Contact Core Editors is subscribed to branch
The proposal to merge
lp:~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7 into
lp:sale-wkfl has been updated.
Status: Needs review = Work in progress
For more details, see:
Review: Abstain
Setting WIP because this will need refactoring after
https://github.com/eLBati/sale-workflow/tree/7.0_add_price_propreties_based
--
https://code.launchpad.net/~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7/+merge/223538
Your team Sale Core Editors is requested
Done
https://github.com/OCA/sale-reporting/pull/13
--
https://code.launchpad.net/~agilebg/sale-reports/7_fix_1315445/+merge/223795
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:~sale-core-editors/sale-reports/7.0.
--
Mailing list:
Review: Resubmit
This project is now hosted on https://github.com/OCA/partner-contact. Please
move your proposal there. This guide may help you
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
--
Review: Resubmit
This project is now hosted on https://github.com/OCA/partner-contact. Please
move your proposal there. This guide may help you
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
--
Review: Resubmit
This project is now hosted on https://github.com/OCA/partner-contact. Please
move your proposal there. This guide may help you
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
--
Review: Resubmit
This project is now hosted on https://github.com/OCA/partner-contact. Please
move your proposal there. This guide may help you
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
--
Review: Resubmit
This project is now hosted on https://github.com/OCA/partner-contact. Please
move your proposal there. This guide may help you
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
--
Review: Resubmit
This project is now hosted on https://github.com/OCA/partner-contact. Please
move your proposal there. This guide may help you
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
--
Review: Resubmit
This project is now hosted on https://github.com/OCA/partner-contact. Please
move your proposal there. This guide may help you
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
--
Review: Resubmit
This project is now hosted on https://github.com/OCA/partner-contact. Please
move your proposal there. This guide may help you
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
--
Review: Resubmit
This project is now hosted on https://github.com/OCA/partner-contact. Please
move your proposal there. This guide may help you
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
--
Review: Resubmit
This project is now hosted on https://github.com/OCA/partner-contact. Please
move your proposal there. This guide may help you
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
--
Review: Resubmit
This project is now hosted on https://github.com/OCA/partner-contact. Please
move your proposal there. This guide may help you
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
--
Review: Resubmit
This project is now hosted on https://github.com/OCA/partner-contact. Please
move your proposal there. This guide may help you
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
--
Moved to https://github.com/OCA/account-consolidation/pull/3
--
https://code.launchpad.net/~agilebg/account-consolidation/7.0-fix-1334645-elbati/+merge/225266
Your team Account Core Editors is subscribed to branch
lp:~account-core-editors/account-consolidation/7.0.
--
Mailing list:
I confirm.
Note that the bug only occurs when you create a new tax code without parent.
--
https://code.launchpad.net/~agilebg/account-consolidation/7.0-fix-1334645-elbati/+merge/225266
Your team Account Core Editors is subscribed to branch
lp:account-consolidation/7.0.
--
Mailing list:
On 07/07/2014 03:00 PM, Leonardo Pistone - camptocamp wrote:
maybe you could refactor a bit putting
parent_parallel_tax_code_id = False
in an else: block a few lines down? otherwise, lgtm
Done
--
https://code.launchpad.net/~agilebg/account-consolidation/7.0-fix-1334645-elbati/+merge/225266
Sorry Lorenzo didn't had the time to look closely at this MP again. Can we
continue this on github ?
Gladly!
Here it is
https://github.com/OCA/account-invoice-reporting/pull/2
--
https://code.launchpad.net/~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs/+merge/205204
Lorenzo Battistini - Agile BG has proposed merging
lp:~agilebg/account-consolidation/7.0-fix-1334645-elbati into
lp:account-consolidation/7.0.
Requested reviews:
Account Core Editors (account-core-editors)
Related bugs:
Bug #1334645 in Account - Consolidation: account_parallel_currency
The proposal to merge
lp:~agilebg/hr-timesheet/hr_attendance_analysis-imp-time_difference-message
into lp:hr-timesheet has been updated.
Description changed to:
This allows, when time diff errors are raised, to identify the raising
attendance
For more details, see:
Review: Approve
--
https://code.launchpad.net/~agilebg/purchase-wkfl/imp_product_by_supplier/+merge/225197
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
The proposal to merge
lp:~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7 into
lp:sale-wkfl has been updated.
Status: Needs review = Work in progress
For more details, see:
Review: Resubmit
wrong target
--
https://code.launchpad.net/~camptocamp/account-consolidation/7.0-fix_1334639-afe/+merge/224629
Your team Account Core Editors is requested to review the proposed merge of
lp:~camptocamp/account-consolidation/7.0-fix_1334639-afe into
lp:account-consolidation.
2014-06-22 23:10 GMT+02:00 Alex Comba - Agile BG alex.co...@agilebg.com:
Lorenzo,
please have a look at my last commit, now it should be ok.
Thanks Alex,
maybe we could handle even more particular cases by using the address_get
method to retrieve the company?
--
Hello Alexis, many thanks for the module.
What do you think about creating the res.country.state records if they don't
exist, before mapping them in the 'states' dictionary?
The current version is supposed to correctly work with states if you first
create states data by modules like
Review: Needs Fixing
/data/ should be /data
--
https://code.launchpad.net/~agilebg/sale-reports/7_fix_1331541/+merge/223871
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:sale-reports.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve code review
--
https://code.launchpad.net/~agilebg/stock-logistic-report/7_fix_1331543/+merge/223878
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-report.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Hello Sébastien,
some PEP8 improvements here
https://code.launchpad.net/~agilebg/server-env-tools/binary_field_pep8/+merge/223935
--
https://code.launchpad.net/~akretion-team/server-env-tools/server-env-tools/+merge/91
Your team Server Environment And Tools Core Editors is subscribed to
Lorenzo Battistini - Agile BG has proposed merging
lp:~agilebg/account-invoice-report/7_fix_1221570 into lp:account-invoice-report.
Requested reviews:
Account Core Editors (account-core-editors)
Related bugs:
Bug #1221570 in Account - Invoicing Reports: [7.0] invoice_webkit overwrites
Lorenzo Battistini - Agile BG has proposed merging
lp:~agilebg/sale-reports/7_fix_1315445 into lp:sale-reports.
Requested reviews:
Sale Core Editors (sale-core-editors)
Related bugs:
Bug #1315445 in Sales - Reports: [7.0] sale_order_webkit - 'Description'
field overlaps the next one 'Qty
Lorenzo Battistini - Agile BG has proposed merging
lp:~agilebg/purchase-report/7_fix_1331394 into lp:purchase-report.
Requested reviews:
Purchase Core Editors (purchase-core-editors)
Related bugs:
Bug #1331394 in Purchase - Reports: [7.0] purchase_order_webkit -
'Description' field overlaps
The proposal to merge
lp:~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order into
lp:purchase-report has been updated.
Description changed to:
[FIX] purchase-report-7.0/purchase_order_webkit/__init__.py, line 31, in
module
from . import purchase_order
ImportError: cannot
Lorenzo Battistini - Agile BG has proposed merging
lp:~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order into
lp:purchase-report.
Requested reviews:
Purchase Core Editors (purchase-core-editors)
For more details, see:
https://code.launchpad.net/~agilebg/purchase-report
Hello Yannick and Vincent,
I renamed list_invoice_table to list_main_table.
As you saw, in order to fix bug 1277024 we had to remove the nested tables but
this reintroduced the bug 1231329.
In order to fix bug 1231329, I moved the formatted_note within the 'nobreak'
div containing line.name
Review: Needs Fixing code review
Hello Romain and Alexandre,
diff comments + some PEP8 remarks
product_procurement_type/product.py:27:1: E302 expected 2 blank lines, found 1
product_procurement_type/product.py:34:1: E302 expected 2 blank lines, found 1
product_procurement_type/product.py:99:13:
On 06/03/2014 10:35 PM, Sergio Corato wrote:
Hi Nicola, Lorenzo, Holger,
what about delete commercial_month field and put this code instead?
if line.months != 0:
And in the view set the field days required if months if false and
viceversa:
field name=months
On 06/04/2014 08:18 AM, Sergio Corato wrote:
In everyway, I overwritten the function (instead of overriden) and cover
the case of 'days' too (for other purposes).
2014-06-04 8:12 GMT+02:00 Sergio Corato sergiocor...@gmail.com:
Ciao Lorenzo,
they aren't mutually exclusive, in this way only
Review: Approve code review
--
https://code.launchpad.net/~nicolariolini/account-invoicing/add_module_account_payment_term_month/+merge/212400
Your team Account Core Editors is subscribed to branch lp:account-invoicing.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post
Ah, sure. It is so already.
See
http://bazaar.launchpad.net/~agilebg/hr-timesheet/fix-hr_attendance_analysis-bracket/view/69/hr_attendance_analysis/hr_attendance.py#L401
By writing the 'action' field without changing it, I'm forcing the
'_get_attendance_duration' to be executed.
I'm doing this
Hello Pedro,
what do you mean by store triggers?
I'm triggering recomputing because 'action' is in the store dictionary:
'hr.attendance': (_get_attendances, ['name', 'action', 'employee_id'], 20),
--
The proposal to merge
lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-bracket into
lp:hr-timesheet has been updated.
Description changed to:
[FIX] wrong opening bracket due to PEP8 restyle:
http://bazaar.launchpad.net/~hr-core-editors/hr-timesheet/7.0/revision/40.2.21
[ADD]
Lorenzo Battistini - Agile BG has proposed merging
lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-report-timezone into
lp:hr-timesheet.
Requested reviews:
HR Core Editors (hr-core-editors)
Alex Comba - Agile BG (tafaru)
For more details, see:
https://code.launchpad.net/~agilebg/hr
You have been requested to review the proposed merge of
lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-report-timezone into
lp:hr-timesheet.
For more details, see:
https://code.launchpad.net/~agilebg/hr-timesheet/fix-hr_attendance_analysis-report-timezone/+merge/221374
[FIX]
Lorenzo Battistini - Agile BG has proposed merging
lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-reference-is-not-defined
into lp:hr-timesheet.
Requested reviews:
HR Core Editors (hr-core-editors)
For more details, see:
https://code.launchpad.net/~agilebg/hr-timesheet/fix
Lorenzo Battistini - Agile BG has proposed merging
lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-bracket into
lp:hr-timesheet.
Requested reviews:
Alex Comba - Agile BG (tafaru)
HR Core Editors (hr-core-editors)
For more details, see:
https://code.launchpad.net/~agilebg/hr-timesheet
Ciao Nicola.
Just refactored the compute method and added tests with
https://code.launchpad.net/~agilebg/account-invoicing/add_module_account_payment_term_month_improvements/+merge/221124
--
Review: Approve code review
--
https://code.launchpad.net/~agilebg/account-invoicing/adding_invoice_line_no_picking_name_7/+merge/220289
Your team Account Core Editors is requested to review the proposed merge of
lp:~agilebg/account-invoicing/adding_invoice_line_no_picking_name_7 into
Hello Pedro,
just modified the name_search.
Thanks
--
https://code.launchpad.net/~agilebg/purchase-wkfl/imp_product_by_supplier/+merge/219017
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to
Hello Pedro and Yannick,
I made the changes.
Thanks
--
https://code.launchpad.net/~agilebg/hr-timesheet/imp_hr_attendance_analysis_roundings/+merge/206493
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:hr-timesheet.
--
Mailing list:
Review: Approve code review
--
https://code.launchpad.net/~agilebg/stock-logistic-flows/adding_picking_line_description_7/+merge/219800
Your team Stock and Logistic Core Editors is requested to review the proposed
merge of lp:~agilebg/stock-logistic-flows/adding_picking_line_description_7
Review: Approve code review
--
https://code.launchpad.net/~agilebg/openerp-manufacturing/adding_mrp_production_properties_7/+merge/219559
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:openerp-manufacturing.
--
Mailing list:
Ok, thanks.
What about the
amount_untaxed, amount_tax, amount_total
fields repeated 2 times?
--
https://code.launchpad.net/~pedro.baeza/purchase-wkfl/7.0-purchase_discount/+merge/217030
Your team Purchase Core Editors is requested to review the proposed merge of
Review: Approve code review
--
https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date/+merge/211374
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to
Review: Needs Fixing
Thanks Vincent,
some style fixes:
account_invoice_analytic_required/__init__.py:3:2: W291 trailing whitespace
account_invoice_analytic_required/__init__.py:19:75: W291 trailing whitespace
account_invoice_analytic_required/__init__.py:23:14: E271 multiple spaces after
Review: Needs Fixing
line 35: missing description
--
https://code.launchpad.net/~savoirfairelinux-openerp/purchase-wkfl/pallet-delivery-missing-security-access/+merge/218508
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
--
Mailing list:
Dear Yannick,
I don't think this MP would break compatibility with
account_financial_report_webkit.
I installed account_financial_report_webkit and account_parralel_currency and I
can use them without problems.
It just doesn't copy the centralized field to the parallel accounts. For that,
a
Review: Needs Fixing
Thanks Pedro,
line 349: I think discount should not be -100 too
line 399: amount_untaxed and following fields are present 2 times
some PEP8:
purchase_discount/__openerp__.py:21:1: O603 Manifest license key is missing
purchase_discount/__openerp__.py:29:5: O600 Warning
Lorenzo Battistini - Agile BG has proposed merging
lp:~agilebg/purchase-wkfl/imp_product_by_supplier into lp:purchase-wkfl.
Requested reviews:
Purchase Core Editors (purchase-core-editors)
For more details, see:
https://code.launchpad.net/~agilebg/purchase-wkfl/imp_product_by_supplier/+merge
Review: Approve code review
--
https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve code review
Thanks
--
https://code.launchpad.net/~akretion-team/sale-wkfl/70-add-sale_order_revision/+merge/202735
Your team Sale Core Editors is requested to review the proposed merge of
lp:~akretion-team/sale-wkfl/70-add-sale_order_revision into lp:sale-wkfl.
--
Mailing
Review: Approve code review
Ok :-)
--
https://code.launchpad.net/~acsone-openerp/account-financial-tools/account_partner_required-sbi/+merge/216442
Your team Account Core Editors is requested to review the proposed merge of
lp:~acsone-openerp/account-financial-tools/account_partner_required-sbi
Review: Needs Information
Thanks Alex,
why did you remove the 'images' and 'sequence' items?
--
https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061
Your team Purchase Core Editors is requested to review the proposed merge of
Review: Needs Information
Hello Stéphane,
why not using '_constraints' member instead of overriding create and write
methods?
Is there any technical reason to avoid YAML tests?
Thanks!
--
The proposal to merge
lp:~openerp-community/hotel-management-system/porting-to-7-branch into
lp:hotel-management-system/7.0 has been updated.
Status: Needs review = Work in progress
For more details, see:
The proposal to merge
lp:~openerp-community/hotel-management-system/porting-to-7-branch into
lp:hotel-management-system/7.0 has been updated.
Status: Needs review = Work in progress
For more details, see:
Review: Abstain
I suspect the modules contained in lp:hotel-management-system/7.0 are not ready
for v7
I would test the modules contained in
lp:~serpentcs/hotel-management-system/hotel-7.0 and possibly merge them into
lp:hotel-management-system/7.0
--
Review: Approve code review
just remove name = '' at line 110
Thanks!
--
https://code.launchpad.net/~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico/+merge/208753
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-invoice-report.
--
Mailing list:
Review: Approve code review
--
https://code.launchpad.net/~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7/+merge/213987
Your team Account Core Editors is subscribed to branch lp:account-invoicing.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to
Review: Approve
Thanks to openerp-conventions
https://github.com/nbessi/openerp-conventions
I see
delivery_optional_invoice_line/__openerp__.py:43:5: O600 Warning unknown
Manifest key ('active')
Apart from this, LGTM
--
Actually I prefer not to delete the MP in order not to lose the discussion. I
prefer to set it 'rejected', but I dont' have the rights, so I wait for a
community reviewer.
--
https://code.launchpad.net/~agilebg/server-env-tools/add_textual_database_name/+merge/209184
Your team Server
Review: Approve code review
--
https://code.launchpad.net/~acsone-openerp/account-financial-tools/allow_date_fy-sbi/+merge/213644
Your team Account Core Editors is requested to review the proposed merge of
lp:~acsone-openerp/account-financial-tools/allow_date_fy-sbi into
On 04/01/2014 03:28 PM, Guewen Baconnier @ Camptocamp wrote:
Actually I prefer not to delete the MP in order not to lose the discussion. I
prefer to set it 'rejected', but I dont' have the rights, so I wait for a
community reviewer.
Done.
Thanks :-)
--
I don't know why I thought it didn't work
I suspect it was due to bug 1268510
--
https://code.launchpad.net/~agilebg/server-env-tools/add_textual_database_name/+merge/209184
Your team Server Environment And Tools Core Editors is requested to review the
proposed merge of
Review: Disapprove
Hello Thomas,
what is the purpose of this merge proposal?
Please take a look at https://doc.openerp.com/contribute/ about how to
contribute.
Thanks
--
https://code.launchpad.net/~hr-core-editors/hr-timesheet/6.1/+merge/213140
Your team HR Core Editors is subscribed to branch
Review: Needs Fixing
Hello Guewen,
just a little fix
line 39: trackings is actually a list of browse records
Thanks
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_postlogistics-tracking_ids/+merge/207202
Your team Stock and Logistic Core Editors is
Review: Approve code review
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_postlogistics-tracking_ids/+merge/207202
Your team Stock and Logistic Core Editors is subscribed to branch
lp:carriers-deliveries.
--
Mailing list:
Review: Approve code review
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-base_delivery_carrier_label-tracking_ids/+merge/207199
Your team Stock and Logistic Core Editors is subscribed to branch
lp:carriers-deliveries.
--
Mailing list:
Review: Disapprove
Actually, this module does just the same as setting
list_db = False
I don't know why I thought it didn't work...
This module is useless
--
https://code.launchpad.net/~agilebg/server-env-tools/add_textual_database_name/+merge/209184
Your team Server Environment And Tools Core
See discussion at
https://code.launchpad.net/~icsergio/account-payment/commercial-year-payment/+merge/210700
--
https://code.launchpad.net/~nicolariolini/account-invoicing/add_module_account_payment_term_month/+merge/212400
Your team Account Core Editors is requested to review the proposed merge
Lorenzo Battistini - Agile BG has proposed merging
lp:~agilebg/account-consolidation/7.0-bug-1296740-elbati into
lp:account-consolidation/7.0.
Requested reviews:
Account Core Editors (account-core-editors)
Related bugs:
Bug #1296740 in Account - Consolidation: 7.0 account_parallel_currency
Review: Approve test
--
https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/checkout-pep8/+merge/211098
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:lp-community-utils.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post
Review: Needs Fixing
Hello Alexandre,
just checked with
https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/checkout-pep8
$ ./checkout-flake8.sh
lp:~camptocamp/openerp-mrp-reports/7.0-add_serpentcs_mrp_repair_webkit-afe
mrp_repair_webkit
Making a temp directory
On 03/21/2014 05:51 PM, Yannick Vaucher @ Camptocamp wrote:
mrp_repair_webkit/__init__.py:5:80: E501 line too long (95 79 characters)
mrp_repair_webkit/__openerp__.py:5:80: E501 line too long (95 79 characters)
mrp_repair_webkit/report/__init__.py:5:80: E501 line too long (95 79
Review: Needs Information
Hello Alexandre,
line 223: if vals['type'] == 'service', should we run _compute_procurement_vals
anyway?
lines 585 and 597: as 'product_procurement_type_dropshipping' depends on
'product_procurement_type', why do the write and create methods call the
Lorenzo Battistini - Agile BG has proposed merging
lp:~agilebg/server-env-tools/add_textual_database_name into lp:server-env-tools.
Requested reviews:
Server Environment And Tools Core Editors (server-env-tools-core-editors)
For more details, see:
https://code.launchpad.net/~agilebg/server
On 03/04/2014 09:21 AM, Guewen Baconnier @ Camptocamp wrote:
Hello,
What is the use case for that?
Hi,
the use case is: you have one openerp instance with serveral databases
for several companies and you don't want users to see the other
databases names (other companies names). With this
Review: Needs Fixing
Whithin the _prepare_invoice method I see tabs and spaces mixed
--
https://code.launchpad.net/~agilebg/account-invoicing/7.0-bug-1287179-hurrinico/+merge/209207
Your team Account Core Editors is subscribed to branch lp:account-invoicing.
--
Mailing list:
Review: Approve code review
Thanks Roberto.
Would this be applicable to v7 too?
--
https://code.launchpad.net/~onnis-roberto/web-addons/6.1/+merge/207662
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons/6.1.
--
Mailing list:
Review: Needs Fixing
line 418: added file 'mrp_webkit/report/.DS_Store'
line 594: there's something wrong with symlink
--
https://code.launchpad.net/~agilebg/openerp-mrp-reports/adding_mrp_webkit/+merge/207471
Your team OpenERP Community Reviewer/Maintainer is requested to review the
proposed
Review: Needs Fixing
Ciao Nico
you should remove mrp_webkit/.DS_Store
and run a PEP8 validator
When importing Python modules from the same addon, use explicit relative import
rather than absolute import, example in __init__.py, do not use:
import sale
But
from . import sale
line
Lorenzo Battistini - Agile BG has proposed merging
lp:~agilebg/contract-management/7.0-bug-1280998-elbati into
lp:contract-management.
Requested reviews:
Contract Management Core Editors (contract-management-core-editors)
Related bugs:
Bug #1280998 in Contract management: Can't install
Lorenzo Battistini - Agile BG has proposed merging
lp:~agilebg/hr-timesheet/imp_hr_attendance_analysis_roundings into
lp:hr-timesheet.
Requested reviews:
HR Core Editors (hr-core-editors)
For more details, see:
https://code.launchpad.net/~agilebg/hr-timesheet
Review: Approve code review
--
https://code.launchpad.net/~pedro.baeza/openerp-product-attributes/7.0-product_pricelist_fixed_price/+merge/205045
Your team OpenERP Community is subscribed to branch
lp:openerp-product-attributes.
___
Mailing list:
Review: Needs Fixing
l 324: p class=std_text${inv.note2 | n}/ should be p
class=std_text${inv.note2 | n} /
--
https://code.launchpad.net/~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs/+merge/205204
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
1 - 100 of 155 matches
Mail list logo
