[Openerp-community] Swiss Localization upgrade

2015-02-25 Thread Nicolas Bessi
will probably be merged next week and may impact code that is based on current version of the localization. Regards Nicolas -- Nicolas Bessi Senior ERP consultant Business Solution technical manager Camptocamp SA PSE A CH-1015 Lausanne http://openerp.camptocamp.com Direct: +41 21 619 10 26 Office

Re: [Openerp-community] l10n-switzerland for version 8

2014-11-14 Thread Nicolas Bessi
for the work, way to go folks. You will find attached the log of the chat. Regards Nicolas 2014-11-10 9:01 GMT+01:00 Nicolas Bessi nicolas.be...@camptocamp.com: Hello, Using framadate we can schedule the meeting this friday at 14:00 GMT+1 Regards Nicolas 2014-11-07 8:43 GMT+01:00 Nicolas

Re: [Openerp-community] l10n-switzerland for version 8

2014-11-10 Thread Nicolas Bessi
Hello, Using framadate we can schedule the meeting this friday at 14:00 GMT+1 Regards Nicolas 2014-11-07 8:43 GMT+01:00 Nicolas Bessi nicolas.be...@camptocamp.com: Dear community, I would like to make a point of advancement and organize review of Swiss localisation next week. I propose

Re: [Openerp-community] l10n-switzerland for version 8

2014-10-14 Thread Nicolas Bessi
://github.com/eLBati -- Nicolas Bessi Senior ERP consultant Business Solution technical manager Camptocamp SA PSE A CH-1015 Lausanne http://openerp.camptocamp.com Direct: +41 21 619 10 26 Office: +41 21 619 10 10 ___ Mailing list: https://launchpad.net

Re: [Openerp-community] l10n-switzerland for version 8

2014-10-14 Thread Nicolas Bessi
future PR. Regards Nicolas 2014-10-14 8:56 GMT+02:00 Nicolas Bessi nicolas.be...@camptocamp.com: Hello, Thanks for your help. We still need someone to port l10n_ch_dta and fix the exisiting tests. If you can do it, it will be of a great help. Regards Nicolas 2014-10-13 18:10 GMT+02

Re: [Openerp-community] l10n-switzerland for version 8

2014-10-10 Thread Nicolas Bessi
Dear community, You will find below the meeting minutes of the first OCA l10n_switzerland project meeting. The main topic of the meeting was to organize the migration to version 8.0 *Participants* - Paul Catinean - Brain-tec: Philipp Fux, A. Stauder - Camptocamp: Nicolas Bessi, Guewen

Re: [Openerp-community] l10n-switzerland for version 8

2014-10-06 Thread Nicolas Bessi
. Regards, *Wyden Silvan* | Leiter Software Engineering Eidg. dipl. Informatiker brain-tec AG | Überlandstrasse 10, CH-3900 Brig Tel: +41 27 552 02 20 | Dir: +41 27 552 02 15 http://www.brain-tec.ch/ 2014-09-26 12:14 GMT+02:00 Nicolas Bessi nicolas.be...@camptocamp.com: Hello, The first step

[Openerp-community] l10n-switzerland for version 8

2014-09-26 Thread Nicolas Bessi
have sign the OCA CLA http://odoo-community.org/page/website.cla Regards Nicolas Bessi -- Nicolas Bessi Senior ERP consultant Business Solution technical manager Camptocamp SA PSE A CH-1015 Lausanne http://openerp.camptocamp.com Direct: +41 21 619 10 26 Office: +41 21 619 10 10

Re: [Openerp-community] l10n-switzerland for version 8

2014-09-26 Thread Nicolas Bessi
/ -- Forwarded message -- From: Nicolas Bessi nicolas.be...@camptocamp.com Date: 2014-09-26 9:50 GMT+02:00 Subject: [Openerp-community] l10n-switzerland for version 8 To: openerp-community@lists.launchpad.net openerp-community@lists.launchpad.net, OpenERP S.A. Community commun...@mail.odoo.com

Re: [Openerp-community] Reclaiming context

2014-08-29 Thread Nicolas Bessi
to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp -- Nicolas Bessi Senior ERP consultant Business Solution technical manager Camptocamp SA PSE A CH-1015 Lausanne http://openerp.camptocamp.com

[Openerp-community] Use of new odoo API when porting OCA addons

2014-08-12 Thread Nicolas Bessi
organize a poll on this topic. My two cents Nicolas -- Nicolas Bessi Senior ERP consultant Business Solution technical manager Camptocamp SA PSE A CH-1015 Lausanne http://openerp.camptocamp.com Direct: +41 21 619 10 26 Office: +41 21 619 10 10

[Openerp-community] OCA/l10n_switzerland Release 7.3

2014-07-10 Thread Nicolas Bessi
with this release. For more details about this topic please refer to following announcement: https://launchpad.net/openerp-swiss-localization/+announcement/12568. No special migration steps should be required. Regards Nicolas -- Nicolas Bessi Senior ERP consultant Business Solution technical

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/server-env-tools/6.1-web_base_url_freeze into lp:server-env-tools/6.1

2014-07-04 Thread Nicolas Bessi - Camptocamp
Review: Needs Information Why using traceback module ?? -- https://code.launchpad.net/~therp-nl/server-env-tools/6.1-web_base_url_freeze/+merge/225651 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools/6.1. -- Mailing list:

Re: [Openerp-community] OCA: transition from Launchpad to Github

2014-07-03 Thread Nicolas Bessi
, Jul 3, 2014 at 5:57 PM, Nicolas Bessi nicolas.be...@camptocamp.com wrote: Hello, I need advice to setup travis for account financial tools. The addon account_constraints adds a lot of constraints and make other addons tests fails. We have a case of incompatibiliy of addons. One solution

Re: [Openerp-community] OCA: transition from Launchpad to Github

2014-07-03 Thread Nicolas Bessi
the failing tests to satisfy the constraints? -sbi On Thu, Jul 3, 2014 at 7:57 AM, Nicolas Bessi nicolas.be...@camptocamp.com wrote: Hello, I need advice to setup travis for account financial tools. The addon account_constraints adds a lot of constraints and make other addons tests fails. We

Re: [Openerp-community] github migration: proposale for helper for travis configuration

2014-07-02 Thread Nicolas Bessi
: https://help.launchpad.net/ListHelp -- Nicolas Bessi Senior ERP consultant Business Solution technical manager Camptocamp SA PSE A CH-1015 Lausanne http://openerp.camptocamp.com Direct: +41 21 619 10 26 Office: +41 21 619 10 10 ___ Mailing

Re: [Openerp-community] OCA repositories naming convention

2014-06-30 Thread Nicolas Bessi
-- Nicolas Bessi Senior ERP consultant Business Solution technical manager Camptocamp SA PSE A CH-1015 Lausanne http://openerp.camptocamp.com Direct: +41 21 619 10 26 Office: +41 21 619 10 10 ___ Mailing list: https://launchpad.net/~openerp-community Post

[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/account-financial-tools/7.0-add-account_budget_purchase into lp:~account-core-editors/account-financial-tools/7.0

2014-06-30 Thread Nicolas Bessi - Camptocamp
The proposal to merge lp:~numerigraphe-team/account-financial-tools/7.0-add-account_budget_purchase into lp:~account-core-editors/account-financial-tools/7.0 has been updated. Status: Needs review = Rejected For more details, see:

[Openerp-community-reviewer] [Merge] lp:~akretion-team/account-financial-tools/account-financial-tools-check-deposit into lp:~account-core-editors/account-financial-tools/7.0

2014-06-30 Thread Nicolas Bessi - Camptocamp
The proposal to merge lp:~akretion-team/account-financial-tools/account-financial-tools-check-deposit into lp:~account-core-editors/account-financial-tools/7.0 has been updated. Status: Needs review = Rejected For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-financial-tools/account-financial-tools-check-deposit into lp:~account-core-editors/account-financial-tools/7.0

2014-06-30 Thread Nicolas Bessi - Camptocamp
The project has moved to Github https://github.com/OCA/account-financial-tools. Please resubmit your MP on github using following procedure https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub. I put this MP in rejected in the meanwhile. Regards --

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-financial-tools/7-account-journal-sale-refund-link-cde into lp:~account-core-editors/account-financial-tools/7.0

2014-06-30 Thread Nicolas Bessi - Camptocamp
The project has moved to Github https://github.com/OCA/account-financial-tools. Please resubmit your MP on github using following procedure https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub. I put this MP in rejected in the meanwhile. Regards --

[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0_override_menu_for_search_improvement_mdh into lp:~account-core-editors/account-financial-tools/7.0

2014-06-30 Thread Nicolas Bessi - Camptocamp
The proposal to merge lp:~camptocamp/account-financial-tools/7.0_override_menu_for_search_improvement_mdh into lp:~account-core-editors/account-financial-tools/7.0 has been updated. Status: Needs review = Rejected For more details, see:

Re: [Openerp-community] OCA: transition from Launchpad to Github

2014-06-27 Thread Nicolas Bessi
- ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp -- Nicolas Bessi Senior ERP consultant Business Solution

[Openerp-community] Migrating OCA mailing list

2014-06-27 Thread Nicolas Bessi
-- Nicolas Bessi Senior ERP consultant Business Solution technical manager Camptocamp SA PSE A CH-1015 Lausanne http://openerp.camptocamp.com Direct: +41 21 619 10 26 Office: +41 21 619 10 10 ___ Mailing list: https://launchpad.net/~openerp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-reports/vre-sale_order_proformat into lp:sale-reports

2014-06-27 Thread Nicolas Bessi - Camptocamp
Review: Approve LGTM -- https://code.launchpad.net/~camptocamp/sale-reports/vre-sale_order_proformat/+merge/223563 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:sale-reports. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community] OCA: transition from Launchpad to Github

2014-06-25 Thread Nicolas Bessi
___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp -- Nicolas Bessi Senior ERP consultant

Re: [Openerp-community] OCA: transition from Launchpad to Github

2014-06-25 Thread Nicolas Bessi
in pre-isntall: http://docs.travis-ci.com/user/installing-dependencies/ geojson, being a python package, can be installed in the install section with pip -- Sandy - Mail original - De: Nicolas Bessi nicolas.be...@camptocamp.com À: Joël Grand-Guillaume joel.grandguilla

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde into lp:stock-logistic-flows

2014-06-25 Thread Nicolas Bessi - Camptocamp
Review: Approve -- https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde/+merge/214568 Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-flows. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-tools/7.0-account_invoice_currency-fix into lp:account-financial-tools

2014-06-25 Thread Nicolas Bessi - Camptocamp
Review: Approve -- https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account_invoice_currency-fix/+merge/211845 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-tools/7.0-account_invoice_currency-fix into lp:account-financial-tools

2014-06-25 Thread Nicolas Bessi - Camptocamp
LGTM -- https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account_invoice_currency-fix/+merge/211845 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-github-650 into lp:ocb-addons

2014-06-19 Thread Nicolas Bessi - Camptocamp
Review: Approve LGTM -- https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-github-650/+merge/223727 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-threaded-dispatch-label-generation into lp:carriers-deliveries

2014-06-16 Thread Nicolas Bessi - Camptocamp
Review: Approve LGTM -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-threaded-dispatch-label-generation/+merge/215184 Your team Stock and Logistic Core Editors is requested to review the proposed merge of

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde into lp:stock-logistic-flows

2014-06-13 Thread Nicolas Bessi - Camptocamp
Review: Needs Fixing Need fixing. Set has a better performance than list and it should avoid duplicate. Please see inline comment Diff comments: === added directory 'picking_dispatch_wave' === added file 'picking_dispatch_wave/__init__.py' --- picking_dispatch_wave/__init__.py 1970-01-01

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde into lp:stock-logistic-flows

2014-06-13 Thread Nicolas Bessi - Camptocamp
https://wiki.python.org/moin/TimeComplexity -- https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde/+merge/214568 Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-flows. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-report/7.0-account_export_csv-select-periods into lp:account-financial-report

2014-06-11 Thread Nicolas Bessi - Camptocamp
Review: Approve LGTM -- https://code.launchpad.net/~camptocamp/account-financial-report/7.0-account_export_csv-select-periods/+merge/222806 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/add-manual-line-and-fees-nbi into lp:account-financial-tools

2014-05-27 Thread Nicolas Bessi - Camptocamp
Hello thanks for the review. I fixed you remarks. for l145 as I'm copying data, I want to stay polite and do not remove an expected key ba an other piece of code. Regards Nicolas -- https://code.launchpad.net/~camptocamp/account-financial-tools/add-manual-line-and-fees-nbi/+merge/218584

[Openerp-community-reviewer] [Merge] lp:~camptocamp/partner-contact-management/7.0-add_birthdate_nbi into lp:partner-contact-management

2014-05-22 Thread Nicolas Bessi - Camptocamp
Nicolas Bessi - Camptocamp has proposed merging lp:~camptocamp/partner-contact-management/7.0-add_birthdate_nbi into lp:partner-contact-management. Requested reviews: Partner and Contact Core Editors (partner-contact-core-editors) For more details, see: https://code.launchpad.net/~camptocamp

Re: [Openerp-community] Could oca adopt report_webkit before v8

2014-05-21 Thread Nicolas Bessi
inheritance. The codebase is also smaller. report_webkit was a source inspiration when we developed the v8 pdf report generation. And i would like to thanks its author Nicolas Bessi. On github we already have 2 pull requests (PR) about it, i dont want my developers to spend time on code

Re: [Openerp-community] Could oca adopt report_webkit before v8

2014-05-21 Thread Nicolas Bessi
. See you in june ! Joël On Wed, May 21, 2014 at 8:28 AM, Nicolas Bessi nicolas.be...@camptocamp.com mailto:nicolas.be...@camptocamp.com wrote: Hello Anthony, I will just quote you: Here is my plan: v8

Re: [Openerp-community] [Openerp-community-reviewer] OCA LP Project migration to Github

2014-05-20 Thread Nicolas Bessi
do not see any problem with a mirror of old branches. Git and Github have very strong features for handling with multiple branches: you can easily compare them, switch etc on github, and on the command line too. Best On Tue, May 20, 2014 at 1:26 PM, Nicolas Bessi nicolas.be

Re: [Openerp-community-reviewer] [Openerp-community] OCA LP Project migration to Github

2014-05-20 Thread Nicolas Bessi
to : openerp-commun...@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp -- Nicolas Bessi Senior ERP consultant Business Solution technical manager Camptocamp SA PSE A CH-1015 Lausanne http://openerp.camptocamp.com

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1319109 into lp:ocb-addons

2014-05-14 Thread Nicolas Bessi - Camptocamp
Review: Approve no test, code review Thanks for providing the patch as disscussed. Just a little little indent 49 uid, 50 self.name2, 51 context=context) else LGTM -- https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1319109/+merge/219473 Your team OpenERP Community Backports is

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1319095 into lp:ocb-addons

2014-05-14 Thread Nicolas Bessi - Camptocamp
Review: Approve no test, code review Thanks for the fix. LGTM This patch will not be backportable as is to version 6.1, 6.0 as it is not Python 2.5 compliant Regards Nicolas -- https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1319095/+merge/219476 Your team OpenERP Community

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1319095 into lp:ocb-addons

2014-05-14 Thread Nicolas Bessi - Camptocamp
Good catch -- https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1319095/+merge/219476 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-threaded-dispatch-label-generation into lp:carriers-deliveries

2014-05-09 Thread Nicolas Bessi - Camptocamp
Review: Needs Fixing Hello, Thank for the patch Small PEP8 in manifest also noticed that the title underline is not correct [Link module] Carrier labels - Picking dispatch

Re: [Openerp-community] Evolution of Swiss localization

2014-05-07 Thread Nicolas Bessi
announcement: https://launchpad.net/openerp-swiss-localization/+announcement/12568. Regards Nicolas 2014-04-02 11:07 GMT+02:00 Lorenzo Battistini lorenzo.battist...@agilebg.com: On 04/02/2014 10:53 AM, Nicolas Bessi wrote: Dear community, The Swiss localization addons needs to evolve to fits new

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report

2014-05-07 Thread Nicolas Bessi - Camptocamp
Thanks I will have a look on https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix2/+merge/216380 ASAP --

[Openerp-community-reviewer] New reviewer

2014-05-01 Thread Nicolas Bessi
/+activereviews Regards Nicolas -- Nicolas Bessi Senior ERP consultant Business Solution technical manager Camptocamp SA PSE A CH-1015 Lausanne http://openerp.camptocamp.com Direct: +41 21 619 10 26 Office: +41 21 619 10 10 -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/server-env-tools/7.0-monitoring into lp:server-env-tools

2014-05-01 Thread Nicolas Bessi - Camptocamp
I can confirm I got the same bug as Daniel. -- https://code.launchpad.net/~camptocamp/server-env-tools/7.0-monitoring/+merge/215138 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/credit_control_report_improvement_vre into lp:account-financial-tools

2014-05-01 Thread Nicolas Bessi - Camptocamp
Review: Disapprove -- https://code.launchpad.net/~camptocamp/account-financial-tools/credit_control_report_improvement_vre/+merge/201920 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list:

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-improve-preq-cancel-nbi into lp:openerp-humanitarian-ngo/purchase-wkfl

2014-05-01 Thread Nicolas Bessi - Camptocamp
Nicolas Bessi - Camptocamp has proposed merging lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-improve-preq-cancel-nbi into lp:openerp-humanitarian-ngo/purchase-wkfl. Requested reviews: OpenERP for Humanitarian Core Editors (humanitarian-core-editors) For more details, see: https

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-improve-preq-cancel-nbi into lp:openerp-humanitarian-ngo/purchase-wkfl

2014-05-01 Thread Nicolas Bessi - Camptocamp
The proposal to merge lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-improve-preq-cancel-nbi into lp:openerp-humanitarian-ngo/purchase-wkfl has been updated. Description changed to: Fix and improve the process of cancelling a purchase requisition For more details, see:

[Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-fix-agreement-trigger-nbi into lp:purchase-wkfl

2014-04-30 Thread Nicolas Bessi - Camptocamp
Nicolas Bessi - Camptocamp has proposed merging lp:~camptocamp/purchase-wkfl/7.0-fix-agreement-trigger-nbi into lp:purchase-wkfl. Requested reviews: Purchase Core Editors (purchase-core-editors) For more details, see: https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-fix-agreement

[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/fix-1308364-nbi into lp:ocb-addons

2014-04-16 Thread Nicolas Bessi - Camptocamp
Nicolas Bessi - Camptocamp has proposed merging lp:~camptocamp/ocb-addons/fix-1308364-nbi into lp:ocb-addons. Requested reviews: OpenERP Community Backports Team (ocb) Related bugs: Bug #1308364 in OpenERP Addons: [7.0] [trunk] report_webkit precise mode does not take in account set_context

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/partner-contact-management/base-location-geonames-import into lp:partner-contact-management

2014-04-16 Thread Nicolas Bessi - Camptocamp
Hello, Thank for the fixes. The UPDATE NO WAIT will lock the selected rows at postgres database level. It will avoid a process using the base_location data to alter flushed entries. It will also avoiding having many concurrent instance of the wizard running on the same rows. In this case I

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/partner-contact-management/base-location-geonames-import into lp:partner-contact-management

2014-04-11 Thread Nicolas Bessi - Camptocamp
Review: Needs Fixing Oups I missed that. Actually, I do not agrees with you, but I won't argue too long on this as for me the branch organisation problem is more deep. Let's see what other think about it. Some comments Belows: Some PEP8 in manifest: 328 +_(The content of

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/ocb-7.0-595240-opw-skh_fix_1192115-afe into lp:ocb-addons

2014-04-11 Thread Nicolas Bessi - Camptocamp
Review: Approve no test, code review LGTM -- https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-595240-opw-skh_fix_1192115-afe/+merge/211264 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-server/7.0-fix_1305653-afe into lp:ocb-server

2014-04-10 Thread Nicolas Bessi - Camptocamp
Review: Approve LGTM -- https://code.launchpad.net/~camptocamp/ocb-server/7.0-fix_1305653-afe/+merge/215121 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/server-env-tools/7.0-monitoring into lp:server-env-tools

2014-04-10 Thread Nicolas Bessi - Camptocamp
Review: Needs Fixing Hello, Thanks for the module, it is really a valuable tool. Some comments below: Some PEP8 error in manifest 728+ name = '%s.%s' % (cls.__module__, cls.__name__) There is a logical risk that cls is not initialized if it is not an old/new style class. 729 +

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report

2014-04-10 Thread Nicolas Bessi - Camptocamp
hello, Any news on this one -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/server-env-tools/7.0-monitoring into lp:server-env-tools

2014-04-10 Thread Nicolas Bessi - Camptocamp
Review: Approve Ahh tests, I'm feeling better now. Thanks for the fixes LGTM :-D -- https://code.launchpad.net/~camptocamp/server-env-tools/7.0-monitoring/+merge/215138 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-report/purchase_report_carriage_return_vre into lp:purchase-report

2014-04-09 Thread Nicolas Bessi - Camptocamp
LGTM -- https://code.launchpad.net/~camptocamp/purchase-report/purchase_report_carriage_return_vre/+merge/214030 Your team Purchase Core Editors is subscribed to branch lp:purchase-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-report/purchase_report_carriage_return_vre into lp:purchase-report

2014-04-09 Thread Nicolas Bessi - Camptocamp
Review: Approve -- https://code.launchpad.net/~camptocamp/purchase-report/purchase_report_carriage_return_vre/+merge/214030 Your team Purchase Core Editors is subscribed to branch lp:purchase-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/partner-contact-management/base-location-geonames-import into lp:partner-contact-management

2014-04-08 Thread Nicolas Bessi - Camptocamp
Review: Needs Information Hello thanks for the patch. Is there a good reason not to merge it here: https://launchpad.net/geospatial-addons ? Some tests would also be a nice addition. --

[Openerp-community] Evolution of Swiss localization

2014-04-02 Thread Nicolas Bessi
Dear community, The Swiss localization addons needs to evolve to fits new business requirements. Changes will land on code base during following months. Be sure that we will keep community inform as they arrive. The next evolution to come will be the integration with the banking addons and the

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/credit_control_report_improvement_vre into lp:account-financial-tools

2014-03-24 Thread Nicolas Bessi - Camptocamp
Review: Needs Fixing Sorry I have to withdraw my approve, After proofreading the credit communication code I can not accept you patch. A credit communication is an aggregation of credit lines per partner per policy level. That means related credit lines can be related to many invoices that

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-report/add_aged_partner_ledger-nbi into lp:account-financial-report

2014-03-24 Thread Nicolas Bessi - Camptocamp
Alexandre, As for all webkit report if you do not set explicitly path to wkhtml2pdf in an ir.config.parameter you have to have a wkhtml2pdf command in your executable path. Nicolas -- https://code.launchpad.net/~camptocamp/account-financial-report/add_aged_partner_ledger-nbi/+merge/211040

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-report/add_aged_partner_ledger-nbi into lp:account-financial-report

2014-03-24 Thread Nicolas Bessi - Camptocamp
Frederic The reports are functional on addons branch, only the tests failed because on official addons in demo data all periods are special. -- https://code.launchpad.net/~camptocamp/account-financial-report/add_aged_partner_ledger-nbi/+merge/211040 Your team Account Report Core Editors is

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-base_delivery_carrier_label-tracking_ids into lp:carriers-deliveries

2014-03-24 Thread Nicolas Bessi - Camptocamp
Review: Approve no test, code review LGTM -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-base_delivery_carrier_label-tracking_ids/+merge/207199 Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-base_delivery_carrier_label-change-carrier into lp:carriers-deliveries

2014-03-24 Thread Nicolas Bessi - Camptocamp
Review: Approve no test, code review A lot of code repretition but no real clean alternative with those out/in/internal stock picking model. LGTM Nicolas -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-base_delivery_carrier_label-change-carrier/+merge/208367 Your team Stock

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-add-delivery_carrier_label_postlogistics_shop_logo-yvr into lp:carriers-deliveries

2014-03-24 Thread Nicolas Bessi - Camptocamp
I would add more precision on manifest description. When will the shop logo will be used -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-add-delivery_carrier_label_postlogistics_shop_logo-yvr/+merge/196859 Your team Stock and Logistic Core Editors is subscribed to branch

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-report/add_aged_partner_ledger-nbi into lp:account-financial-report

2014-03-19 Thread Nicolas Bessi - Camptocamp
Hello, Stéphan is right, Test runs perfectly on OCB, that is the branches I used to developp communitiy addons. Regards Nicolas 2014-03-18 15:53:58,357 27853 INFO test_aged_partner openerp.modules.loading: module account_financial_report_webkit: loading tests/aged_trial_balance.yml

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/improve_auth_crypt-nbi into lp:ocb-addons

2014-03-19 Thread Nicolas Bessi - Camptocamp
Hello Stefan, I prefer to do it in an other MP, in order to fix the case of plain password as soon as possible. Also the refactoring using the passlib will probably be done against the trunk branch as there is some difference in implementation and I'm not sure at the current time they are

[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/improve_auth_crypt-nbi into lp:ocb-addons

2014-03-19 Thread Nicolas Bessi - Camptocamp
The proposal to merge lp:~camptocamp/ocb-addons/improve_auth_crypt-nbi into lp:ocb-addons has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~camptocamp/ocb-addons/improve_auth_crypt-nbi/+merge/206364 --

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/improve_auth_crypt-nbi into lp:ocb-addons

2014-03-19 Thread Nicolas Bessi - Camptocamp
Ho I got your point Stefan, I missed the answer of Olivier on addons MP For this part, your init() method looks fine, but there are already multiple instances of the salting+hashing dance. As you're adding one more, it seems a good opportunity to refactor a bit and extract that pattern into a

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/improve_auth_crypt-nbi into lp:ocb-addons

2014-03-19 Thread Nicolas Bessi - Camptocamp
I have done the small refactor proposed by Olivier (not the one with passlib). Please redo a quick review before merging. Regards Nicolas -- https://code.launchpad.net/~camptocamp/ocb-addons/improve_auth_crypt-nbi/+merge/206364 Your team OpenERP Community Backports Team is subscribed to branch

[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/improve_auth_crypt-nbi into lp:ocb-addons

2014-03-19 Thread Nicolas Bessi - Camptocamp
Nicolas Bessi - Camptocamp has proposed merging lp:~camptocamp/ocb-addons/improve_auth_crypt-nbi into lp:ocb-addons. Requested reviews: Nicolas Bessi - Camptocamp (nbessi-c2c) Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c): code review, no test Stefan Rijnhart (Therp) (stefan-therp

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report

2014-03-18 Thread Nicolas Bessi - Camptocamp
Hello, The parameter/fallback solution seems reasonable assuming that period parameter is not mandatory. For me you can update the MP with that solution. Also as the change will alter data structure the revision number of the module must be increased in MP. I'm putting the MP in work in

Re: [Openerp-community-reviewer] [Merge] lp:~openerp-community/server-env-tools/7.0-modules-from-openobject-extension into lp:server-env-tools

2014-03-18 Thread Nicolas Bessi - Camptocamp
Review: Approve LGTM -- https://code.launchpad.net/~openerp-community/server-env-tools/7.0-modules-from-openobject-extension/+merge/200744 Your team Server Environment And Tools Core Editors is requested to review the proposed merge of

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/credit_control_report_improvement_vre into lp:account-financial-tools

2014-03-18 Thread Nicolas Bessi - Camptocamp
Review: Approve code review, no test LGTM, Thanks -- https://code.launchpad.net/~camptocamp/account-financial-tools/credit_control_report_improvement_vre/+merge/201920 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report

2014-03-18 Thread Nicolas Bessi - Camptocamp
Review: Needs Fixing -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-report/add_aged_partner_ledger-nbi into lp:account-financial-report

2014-03-18 Thread Nicolas Bessi - Camptocamp
Hello, Fixes done and basic tests added -- https://code.launchpad.net/~camptocamp/account-financial-report/add_aged_partner_ledger-nbi/+merge/211040 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list:

[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-report/add_aged_partner_ledger-nbi into lp:account-financial-report

2014-03-17 Thread Nicolas Bessi - Camptocamp
Nicolas Bessi - Camptocamp has proposed merging lp:~camptocamp/account-financial-report/add_aged_partner_ledger-nbi into lp:account-financial-report. Commit message: [ADD] Aged Partner Balance webkit report. Report inherit Open Invoice Report and uses previously computed ledger lines

[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-fix-credit-control-scenarios-nbi into lp:account-financial-tools

2014-03-04 Thread Nicolas Bessi - Camptocamp
The proposal to merge lp:~camptocamp/account-financial-tools/7.0-fix-credit-control-scenarios-nbi into lp:account-financial-tools has been updated. Description changed to: Fix credit control scenario: Force scenarios to be done on exercice 2013 as they are based on base finance setup porvided

[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-fix-1287072 into lp:account-financial-tools

2014-03-03 Thread Nicolas Bessi - Camptocamp
Nicolas Bessi - Camptocamp has proposed merging lp:~camptocamp/account-financial-tools/7.0-fix-1287072 into lp:account-financial-tools. Requested reviews: Account Core Editors (account-core-editors) For more details, see: https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-fix-post-deleted-move-lep into lp:account-financial-tools

2014-02-28 Thread Nicolas Bessi - Camptocamp
Review: Approve no test, code review LGTM -- https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-post-deleted-move-lep/+merge/208360 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-batch-validate-log-more-lep into lp:account-financial-tools

2014-02-28 Thread Nicolas Bessi - Camptocamp
Review: Approve no test, code review LGTM -- https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-batch-validate-log-more-lep/+merge/208420 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-batch-validate-replace-menuitem-lep into lp:account-financial-tools

2014-02-28 Thread Nicolas Bessi - Camptocamp
Review: Approve no test, code review LGTM -- https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-batch-validate-replace-menuitem-lep/+merge/208412 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-batch_validate-delay-delaying-second-attempt-lep into lp:account-financial-tools

2014-02-28 Thread Nicolas Bessi - Camptocamp
Review: Approve no test, code review This one is funny :) LGTM -- https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-batch_validate-delay-delaying-second-attempt-lep/+merge/208614 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools.

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge into lp:sale-wkfl

2014-02-27 Thread Nicolas Bessi - Camptocamp
Review: Approve code review, no test Just fixed some PEP8 issues. LGTM -- https://code.launchpad.net/~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge/+merge/198960 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge into lp:sale-wkfl

2014-02-27 Thread Nicolas Bessi - Camptocamp
I would greatly appreciate some tests on the module, before merging it. -- https://code.launchpad.net/~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge/+merge/198960 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list:

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-fix-domain-nbi into lp:openerp-humanitarian-ngo/purchase-wkfl

2014-02-20 Thread Nicolas Bessi - Camptocamp
Nicolas Bessi - Camptocamp has proposed merging lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-fix-domain-nbi into lp:openerp-humanitarian-ngo/purchase-wkfl. Requested reviews: OpenERP for Humanitarian Core Editors (humanitarian-core-editors) For more details, see: https

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/ocb-7.0-fix_1281687-afe into lp:ocb-addons

2014-02-19 Thread Nicolas Bessi - Camptocamp
Review: Approve no test, code review LGTM -- https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1281687-afe/+merge/207116 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to

Re: [Openerp-community] report_webkit future

2014-02-18 Thread Nicolas Bessi
Hello, Maybe my intentions were not clear enough, actually I was not comparing wkhtmltopdf and Qweb but the module report_webkit with new QWeb repot system. The objective of this thread is to disambiguate the current situation with the two reports system, and inform community that Camptocamp will

Re: [Openerp-community] report_webkit future

2014-02-18 Thread Nicolas Bessi
Hello, No offense Fabien, but such an unilateral announce may not be the proper way to manage this kind of announcement... I'm also a little bit confused about our v6, v6.1, v7, customer that have support contract. How OpenERP SA intend migration as report_webkit is in official addons

Re: [Openerp-community] report_webkit future

2014-02-18 Thread Nicolas Bessi
Hello Niels, You have a interesting question here, maybe we should create a new thread about it on expert mailing list. Regards Nicolas 2014-02-18 17:01 GMT+01:00 Niels Huylebroeck n...@agaplan.eu: Would it not be more appropriate to simply allow easier definition of html rendering

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/ngo-addons-small-xml-improvement-rde into lp:openerp-humanitarian-ngo

2014-02-18 Thread Nicolas Bessi - Camptocamp
Review: Approve code review, no test LGTM -- https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/ngo-addons-small-xml-improvement-rde/+merge/205711 Your team OpenERP for Humanitarian Core Editors is subscribed to branch lp:openerp-humanitarian-ngo. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-reports/7.0-conditional_discount_print-rde into lp:sale-reports

2014-02-18 Thread Nicolas Bessi - Camptocamp
Review: Approve code review, no test LGTM -- https://code.launchpad.net/~camptocamp/sale-reports/7.0-conditional_discount_print-rde/+merge/206678 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:sale-reports. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/7.0-avoid_sale_lines_dropshipping_make_to_order_without_supplierinfos-rde into lp:sale-wkfl

2014-02-18 Thread Nicolas Bessi - Camptocamp
Review: Approve code review, no test Ok, there is no test on module, my fault. LGTM -- https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-avoid_sale_lines_dropshipping_make_to_order_without_supplierinfos-rde/+merge/205623 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. --

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-reports/typo_groups_id-rde into lp:sale-reports

2014-02-18 Thread Nicolas Bessi - Camptocamp
Review: Approve LGTM -- https://code.launchpad.net/~camptocamp/sale-reports/typo_groups_id-rde/+merge/206874 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:sale-reports. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

  1   2   >