Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/server-env-tools/server-env-tools into lp:server-env-tools

2014-07-04 Thread Sébastien BEAU - http : //www . akretion . com
Hi I have finish the storage refactor, so please give me your feedback ! Also I have move this MP on github so let's comment here = https://github.com/OCA/server-tools/pull/1 -- https://code.launchpad.net/~akretion-team/server-env-tools/server-env-tools/+merge/91 Your team Server Environment

[Openerp-community-reviewer] [Merge] lp:~sebastien.beau/hr-timesheet/hr-timesheet-fix-project-id-not-required into lp:hr-timesheet

2014-06-24 Thread Sébastien BEAU - http : //www . akretion . com
Sébastien BEAU - http://www.akretion.com has proposed merging lp:~sebastien.beau/hr-timesheet/hr-timesheet-fix-project-id-not-required into lp:hr-timesheet. Requested reviews: HR Core Editors (hr-core-editors) Related bugs: Bug #1333639 in HR - Timesheet Management: Fail to create/modifiy a

[Openerp-community-reviewer] [Merge] lp:~sebastien.beau/hr-timesheet/hr-timesheet-fix-project-id-not-required into lp:hr-timesheet

2014-06-24 Thread Sébastien BEAU - http : //www . akretion . com
The proposal to merge lp:~sebastien.beau/hr-timesheet/hr-timesheet-fix-project-id-not-required into lp:hr-timesheet has been updated. Description changed to: Fix, by default project id is not required and can be empty For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~sebastien.beau/hr-timesheet/hr-timesheet-fix-project-id-not-required into lp:hr-timesheet

2014-06-24 Thread Sébastien BEAU - http : //www . akretion . com
Sorry Alex, I just realise that the fix was already here with the last commit. -- https://code.launchpad.net/~sebastien.beau/hr-timesheet/hr-timesheet-fix-project-id-not-required/+merge/224268 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:hr-timesheet. -- Mailing

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/carriers-deliveries/7-split-default-option-state-from-deliv-method-dbl into lp:carriers-deliveries

2014-06-23 Thread Sébastien BEAU - http : //www . akretion . com
Review: Needs Fixing Hi You don't have to test if available_option.mandatory is True but you can only use if available_option.mandatory as it's a boolean the is True is useless. --

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/carriers-deliveries/7-split-default-option-state-from-deliv-method-dbl into lp:carriers-deliveries

2014-06-23 Thread Sébastien BEAU - http : //www . akretion . com
Review: Approve code review, no test LGTM -- https://code.launchpad.net/~akretion-team/carriers-deliveries/7-split-default-option-state-from-deliv-method-dbl/+merge/224027 Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/partner-contact-management/7.0-partner-helper-dbl into lp:partner-contact-management

2014-06-19 Thread Sébastien BEAU - http : //www . akretion . com
Review: Approve test, review As it's a small abstract feature, I think it make sense to create a helper module for all similary one. The aim is just to have one module which is a toolbox with all abstract feature (not user feature) that can be use everythere. Description is clear now so I

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/carriers-deliveries/7-base-delivery-carrier-dbl into lp:carriers-deliveries

2014-06-19 Thread Sébastien BEAU - http : //www . akretion . com
Review: Approve LGTM, I agree too. It's only an abstract module that provider a standard API for real implementation -- https://code.launchpad.net/~akretion-team/carriers-deliveries/7-base-delivery-carrier-dbl/+merge/221226 Your team Stock and Logistic Core Editors is subscribed to branch

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/server-env-tools/server-env-tools into lp:server-env-tools

2014-06-13 Thread Sébastien BEAU - http : //www . akretion . com
Hi I am asking myself about adding an object storage.configuration and a field storing_configuration_id on the model ir.model.fields. The idea will to use a default storing configuration for every field (on file sytem for exemple) but after we will be able to customise on every field from the

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/server-env-tools/server-env-tools into lp:server-env-tools

2014-06-08 Thread Sébastien BEAU - http : //www . akretion . com
Hi Georges, Sorry I fix the description. In my case I want to store every binary/image field on the file system and not in postgresql. And this not only for attachement but for every image/binary field (image field on product, on category) I want this because I want to serve my image

[Openerp-community-reviewer] [Merge] lp:~akretion-team/server-env-tools/server-env-tools into lp:server-env-tools

2014-06-06 Thread Sébastien BEAU - http : //www . akretion . com
The proposal to merge lp:~akretion-team/server-env-tools/server-env-tools into lp:server-env-tools has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~akretion-team/server-env-tools/server-env-tools/+merge/91 --

[Openerp-community-reviewer] [Merge] lp:~akretion-team/server-env-tools/server-env-tools into lp:server-env-tools

2014-06-06 Thread Sébastien BEAU - http : //www . akretion . com
Sébastien BEAU - http://www.akretion.com has proposed merging lp:~akretion-team/server-env-tools/server-env-tools into lp:server-env-tools. Requested reviews: Server Environment And Tools Core Editors (server-env-tools-core-editors) For more details, see:

[Openerp-community-reviewer] [Merge] lp:~akretion-team/server-env-tools/server-env-tools into lp:server-env-tools

2014-06-06 Thread Sébastien BEAU - http : //www . akretion . com
The proposal to merge lp:~akretion-team/server-env-tools/server-env-tools into lp:server-env-tools has been updated. Description changed to: Here is a proposal too add new fields for image and binary. There is a example module so you can try it. But before merging I propose to remove it. For

[Openerp-community-reviewer] [Merge] lp:~akretion-team/server-env-tools/server-env-tools into lp:server-env-tools

2014-06-06 Thread Sébastien BEAU - http : //www . akretion . com
Sébastien BEAU - http://www.akretion.com has proposed merging lp:~akretion-team/server-env-tools/server-env-tools into lp:server-env-tools. Requested reviews: Server Environment And Tools Core Editors (server-env-tools-core-editors) For more details, see:

[Openerp-community-reviewer] [Merge] lp:~akretion-team/openerp-product-attributes/openerp-product-attributes-product-image into lp:openerp-product-attributes

2014-06-06 Thread Sébastien BEAU - http : //www . akretion . com
Sébastien BEAU - http://www.akretion.com has proposed merging lp:~akretion-team/openerp-product-attributes/openerp-product-attributes-product-image into lp:openerp-product-attributes. Requested reviews: Product Core Editors (product-core-editors) For more details, see:

[Openerp-community-reviewer] [Merge] lp:~akretion-team/account-financial-tools/account-financial-tools-account-writeoff-autodelete into lp:account-financial-tools

2014-05-17 Thread Sébastien BEAU - http : //www . akretion . com
The proposal to merge lp:~akretion-team/account-financial-tools/account-financial-tools-account-writeoff-autodelete into lp:account-financial-tools has been updated. Status: Needs review = Work in progress For more details, see:

[Openerp-community-reviewer] [Merge] lp:~akretion-team/account-financial-tools/account-financial-tools-account-writeoff-autodelete into lp:account-financial-tools

2014-05-17 Thread Sébastien BEAU - http : //www . akretion . com
Sébastien BEAU - http://www.akretion.com has proposed merging lp:~akretion-team/account-financial-tools/account-financial-tools-account-writeoff-autodelete into lp:account-financial-tools. Requested reviews: Account Core Editors (account-core-editors) For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7 into lp:carriers-deliveries

2014-05-02 Thread Sébastien BEAU - http : //www . akretion . com
Review: Approve code review, no test Thanks for this module. Having an additionnal delivery cost is a pain, your module make it optional it's ok for me. LGTM -- https://code.launchpad.net/~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7/+merge/213867 Your team Stock and

[Openerp-community-reviewer] [Merge] lp:~akretion-team/project-service/project-service-base-sale-project into lp:project-service

2014-03-20 Thread Sébastien BEAU - http : //www . akretion . com
Sébastien BEAU - http://www.akretion.com has proposed merging lp:~akretion-team/project-service/project-service-base-sale-project into lp:project-service. Requested reviews: Project Core Editors (project-core-editors) For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/sale-wkfl/7.0-add-sale_group into lp:sale-wkfl

2014-01-10 Thread Sébastien BEAU - http : //www . akretion . com
Hi Raph, Can you just update the __openerp__.py file with the OpenERP V7 still (removing xml_demo, xml_update... with data...) Otherwise it's good for me Thanks -- https://code.launchpad.net/~akretion-team/sale-wkfl/7.0-add-sale_group/+merge/201017 Your team Sale Core Editors is requested to

Re: [Openerp-community] [Merge] lp:~openerp-community/openerp-product-attributes/7.0-product_custom_attributes-allow-to-bind-on-existing-field into lp:openerp-product-attributes

2013-12-10 Thread Sébastien BEAU - http : //www . akretion . com
Review: Approve code review, no test Good improvement. Thanks -- https://code.launchpad.net/~openerp-community/openerp-product-attributes/7.0-product_custom_attributes-allow-to-bind-on-existing-field/+merge/190146 Your team OpenERP Community is subscribed to branch

Re: [Openerp-community] [Merge] lp:~camptocamp/openerp-product-attributes/7.0-attribute-set-create-1256023 into lp:openerp-product-attributes

2013-11-28 Thread Sébastien BEAU - http : //www . akretion . com
Review: Approve (code review, no test) LGTM -- https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-attribute-set-create-1256023/+merge/197092 Your team OpenERP Community is subscribed to branch lp:openerp-product-attributes. ___

[Openerp-community-reviewer] [Merge] lp:~sebastien.beau/openerp-fiscal-rules/openerp-fiscal-rules-fix-multicompany into lp:openerp-fiscal-rules

2013-11-18 Thread Sébastien BEAU - http : //www . akretion . com
Sébastien BEAU - http://www.akretion.com has proposed merging lp:~sebastien.beau/openerp-fiscal-rules/openerp-fiscal-rules-fix-multicompany into lp:openerp-fiscal-rules. Requested reviews: Account Core Editors (account-core-editors) For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~openerp-community-reviewer/e-commerce-addons/move_sale_exception_to_sale_wkfl_branches-jge into lp:e-commerce-addons

2013-11-04 Thread Sébastien BEAU - http : //www . akretion . com
Hi, I am working on the split of sale_exception in two module sale_exception and exception_rule. The aim is to have the exception on different object like purchase_order, stock_picking, invoice ... (already implemented on purchase_order and soon on picking). If we put the module sale_exception

Re: [Openerp-community-reviewer] [Merge] lp:~openerp-community-reviewer/sale-wkfl/move_sale_exception_module_from_e-commerce-addons-jge into lp:sale-wkfl

2013-11-04 Thread Sébastien BEAU - http : //www . akretion . com
After my split I have around 140 ligne of python in exception_rule and around 40 in sale_exception so I really think it's worth to split it because we will avoid to duplicate the 140 ligne in every module for nothing, it's not a lot but it's always better to no duplicate the code (on

Re: [Openerp-community-reviewer] [Merge] lp:~openerp-community-reviewer/sale-wkfl/move_sale_exception_module_from_e-commerce-addons-jge into lp:sale-wkfl

2013-11-04 Thread Sébastien BEAU - http : //www . akretion . com
Sorry I made a mistake around 180 line in the generic module -- https://code.launchpad.net/~openerp-community-reviewer/sale-wkfl/move_sale_exception_module_from_e-commerce-addons-jge/+merge/193567 Your team OpenERP Community Reviewer is subscribed to branch

Re: [Openerp-community-reviewer] [Merge] lp:~extra-addons-commiter/e-commerce-addons/7.0-sale-method into lp:e-commerce-addons

2013-10-13 Thread Sébastien BEAU - http : //www . akretion . com
Hi Guewen, As talk before it's better to link the account_move_line instead of the account_move (indeed a move can have X line and each line can be linked to a specific sale order). I made the change and also I add the possibility to specify a description. For the migration script I don't

Re: [Openerp-community] [Merge] lp:~sebastien.beau/openerp-product-attributes/openerp-product-attributes-product-dimension into lp:openerp-product-attributes

2013-10-07 Thread Sébastien BEAU - http : //www . akretion . com
Hi sorry for my late answer. @Marc, I didn't know about this existing module http://bazaar.launchpad.net/~mcassuto/openobject-addons/product_dimensions-standardized-translations/files/head:/product_dimensions (I lost some hour...) @Maxime regarding the product_size, I agree with Humberto I

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/server-env-tools/70-scheduler-error-mailer into lp:server-env-tools

2013-10-02 Thread Sébastien BEAU - http : //www . akretion . com
Review: Approve Thanks for the update Alexis -- https://code.launchpad.net/~akretion-team/server-env-tools/70-scheduler-error-mailer/+merge/188240 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list:

[Openerp-community] [Merge] lp:~sebastien.beau/openerp-product-attributes/openerp-product-attributes-product-dimension into lp:openerp-product-attributes

2013-06-24 Thread Sébastien BEAU - http : //www . akretion . com
Sébastien BEAU - http://www.akretion.com has proposed merging lp:~sebastien.beau/openerp-product-attributes/openerp-product-attributes-product-dimension into lp:openerp-product-attributes. Requested reviews: Product Core Editors (product-core-editors) For more details, see:

Re: [Openerp-community] [Merge] lp:~akretion-team/openerp-product-attributes/mixin-extraction into lp:openerp-product-attributes

2013-06-17 Thread Sébastien BEAU - http : //www . akretion . com
Thanks Guewen for your remark. It's fix now. -- https://code.launchpad.net/~akretion-team/openerp-product-attributes/mixin-extraction/+merge/151333 Your team OpenERP Community is subscribed to branch lp:openerp-product-attributes. ___ Mailing list:

Re: [Openerp-community] [Merge] lp:~akretion-team/openerp-product-attributes/mixin-extraction into lp:openerp-product-attributes

2013-06-15 Thread Sébastien BEAU - http : //www . akretion . com
Hi all I merge the improvement done by Benoit https://code.launchpad.net/~akretion-team/openerp-product-attributes/openerp-product-attributes-fix-view/+merge/168461 https://code.launchpad.net/~akretion-team/openerp-product-attributes/openerp-product-attributes-fix-view/+merge/168461 I extract

Re: [Openerp-community] [Merge] lp:~camptocamp/openerp-product-attributes/7.0-product_images-migr into lp:openerp-product-attributes

2013-01-30 Thread Sébastien BEAU - http : //www . akretion . com
Alexandre yes your right, I did a mistake on number version. I don't use anymore this version number now. Only two digit is the correct way. See you -- https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-product_images-migr/+merge/145630 Your team OpenERP Community is subscribed