Review: Resubmit
Please move this MP to https://github.com/OCA/l10n-canada
More info at
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
--
https://code.launchpad.net/~openerp-community/openerp-canada/7.0-missing-payroll-access/+merge/226187
Your team
Review: Resubmit
This PR has been moved to https://github.com/OCA/connector-sage-50/pull/7
Please continue further development there.
--
https://code.launchpad.net/~savoirfairelinux-openerp/openerp-sage-50/7.0-exportsage50/+merge/191893
Your team OpenERP Community Reviewer/Maintainer is
The proposal to merge
lp:~savoirfairelinux-openerp/knowledge-addons/document_multiple_records into
lp:knowledge-addons/7.0 has been updated.
Status: Approved = Rejected
For more details, see:
Review: Resubmit
This MP have been moved to MP to https://github.com/OCA/knowledge/pull/5
--
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/document_multiple_records/+merge/206960
Your team OpenERP Community Reviewer/Maintainer is requested to review the
proposed merge
Review: Resubmit
This MP have been moved to MP to https://github.com/OCA/knowledge/pull/6
--
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis/+merge/212258
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:knowledge-addons/7.0.
--
Mailing
The proposal to merge lp:~savoirfairelinux-openerp/knowledge-addons/cmis into
lp:knowledge-addons/7.0 has been updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis/+merge/212258
--
Review: Resubmit
This MP have been moved to MP to https://github.com/OCA/knowledge/pull/7
--
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_read/+merge/212260
Your team OpenERP Community Reviewer/Maintainer is requested to review the
proposed merge of
The proposal to merge lp:~savoirfairelinux-openerp/knowledge-addons/cmis_read
into lp:knowledge-addons/7.0 has been updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_read/+merge/212260
--
The proposal to merge lp:~savoirfairelinux-openerp/knowledge-addons/cmis_write
into lp:knowledge-addons/7.0 has been updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_write/+merge/213940
--
This is for cases where one partner (Mike Fletcher President of Agrolait) can
be part of another company (Mike Fletcher VP of AsusTEK) in a different
function.
The module helps track these functions.
--
Ported to https://github.com/OCA/hr/pull/3
--
https://code.launchpad.net/~savoirfairelinux-openerp/openerp-hr/hr_employee_firstname/+merge/204065
Your team HR Core Editors is requested to review the proposed merge of
lp:~savoirfairelinux-openerp/openerp-hr/hr_employee_firstname into
The proposal to merge
lp:~savoirfairelinux-openerp/openerp-hr/hr_employee_firstname into
lp:openerp-hr has been updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/openerp-hr/hr_employee_firstname/+merge/204065
--
Review: Approve
--
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/document_multiple_records/+merge/206960
Your team OpenERP Community Reviewer/Maintainer is requested to review the
proposed merge of
lp:~savoirfairelinux-openerp/knowledge-addons/document_multiple_records
The proposal to merge
lp:~savoirfairelinux-openerp/knowledge-addons/document_multiple_records into
lp:knowledge-addons/7.0 has been updated.
Status: Needs review = Approved
For more details, see:
You have been requested to review the proposed merge of
lp:~savoirfairelinux-openerp/openerp-hr/hr_employee_firstname into
lp:openerp-hr.
For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/openerp-hr/hr_employee_firstname/+merge/204065
Add hr_employee_firstname module;
Diff comments:
=== added directory 'cmis_write'
=== added file 'cmis_write/__init__.py'
--- cmis_write/__init__.py1970-01-01 00:00:00 +
+++ cmis_write/__init__.py2014-05-29 22:13:35 +
@@ -0,0 +1,26 @@
+# -*- encoding: utf-8 -*-
Thank you for your review, Guewen, I learned a few things.
Diff comments:
=== added directory 'cmis_read'
=== added file 'cmis_read/__init__.py'
--- cmis_read/__init__.py 1970-01-01 00:00:00 +
+++ cmis_read/__init__.py 2014-06-12 19:57:17 +
@@ -0,0 +1,25 @@
+# -*- encoding:
Looking a lot better, still issues about the comments preceding functions which
would be more useful as docstrings.
Diff comments:
=== added directory 'cmis'
=== added file 'cmis/__init__.py'
--- cmis/__init__.py 1970-01-01 00:00:00 +
+++ cmis/__init__.py 2014-06-12 19:47:23 +
@@
Review: Approve
Looking better
--
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_read/+merge/212260
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:knowledge-addons/7.0.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
You have been requested to review the proposed merge of
lp:~savoirfairelinux-openerp/knowledge-addons/cmis_read into
lp:knowledge-addons/7.0.
For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_read/+merge/212260
Add cmis_read; It allows to use the
Review: Needs Fixing
Diff comments:
=== modified file 'l10n_ca_hr_payroll/__openerp__.py'
--- l10n_ca_hr_payroll/__openerp__.py 2013-02-27 20:02:47 +
+++ l10n_ca_hr_payroll/__openerp__.py 2014-06-11 15:00:16 +
@@ -38,6 +38,7 @@
'l10n_ca_toponyms',
],
'data': [
Review: Needs Fixing
For better usability and security, your sanitize function should wrap the query
function, the same way OE does, so that there is no way to call the query the
wrong way.
Something along the lines of
safe_query( SELECT cmis:name, cmis:createdBy, cmis:objectId,
Review: Needs Information
l.225,259 can you please explain what you do here. It seems you attempt to
write to a directory to test if you have write permission, surely there are
safer ways of doing this.
In you unittest, can you test more of your functions, I know there is a
challenge of not
Review: Needs Fixing
l.469,502: Queries are still not fully sanitized, any quotes or percent sizes
in the input will result in unexpected behaviour. This is a security risk and a
major bug potential.
I highly recommend you to add a function to sanitize input in the cmis module
for queries and
@Stefan, yes that would work, we could even be backwards compatible and have a
symlink
openerp_nag - openerp_nag.py
--
https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/nag_refactor/+merge/214445
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
Review: Needs Fixing code review, no test
l.288 looks like you forgot to put anything in for group_id:id
purchase_profit_forecast/__openerp__.py:
Manifest license key is missing
Deprecated Manifest key ('active')
Deprecated Manifest key ('certificate')
Flake8:
report/analytic.py:3:1: E302
Review: Needs Fixing code review, pep8
l.112,464,2878 You can remove these empty files
Flake8
delivery_editable_dates/__openerp__.py:22:1: O603 Manifest license key is
missing
delivery_editable_dates/__openerp__.py:28:5: O600 Warning unknown Manifest key
('caterogy')
Review: Needs Fixing
Flake8:
cmis/connector.py:23:1: F401 'fields' imported but unused
cmis/connector.py:23:1: F401 'orm' imported but unused
l.270 you still need to escape literals
http://wiki.alfresco.com/wiki/CMIS_Query_Language#Literals
Review: Needs Fixing
l.416 Missing context propagation
Spelling:
You wrote OpenErp a few times. This should be OpenERP.
The description is oddly formulated, you may want it proofread.
Flake8:
cmis_write/__openerp__.py:58:26: W291 trailing whitespace
cmis_write/ir_attachment.py:125:5: E265 block
Still no unittests
--
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_write/+merge/213940
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:knowledge-addons/7.0.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Needs Fixing
l.471 Still severe bug and injection potential
Try:
filename = sql%' OR '1' = '1' OR '%injection
CMIS must provide a code escape function, otherwise use OpenERP's. It is
important that you don't do this manually.
https://en.wikipedia.org/wiki/Sql_injection
There are also
Review: Needs Fixing
except_osv is depricated, please use except_orm
l.213 missing context propagation
l.276 POSSIBLE SQL INJECTION with filenames which contain quotes, please use
appropriate code escapes from the library (don't write your own)
No Unittests
Flake8:
cmis/cmis_model.py:25:1: F401
Review: Needs Fixing
This MP should have a prerequisite branch:
lp:~savoirfairelinux-openerp/knowledge-addons/cmis
l.301 missing context propagation
No unittests
Flake8
cmis_write/ir_attachment.py:73:45: W291 trailing whitespace
cmis_write/ir_attachment.py:74:53: W291 trailing whitespace
Review: Needs Fixing
Missing security model for cmis.backend
--
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis/+merge/212258
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:knowledge-addons/7.0.
--
Mailing list:
Review: Needs Fixing
l.377 osv.TransientModel should be orm.TransientModel
l.504 POSSIBLE SQL INJECTION: (with quotes in a filename) please use the
library's code escapes, don't write your own
Flake8:
cmis_read/wizard/document_wizard.py:102:9: F841 local variable 'file_name' is
assigned to but
Review: Needs Fixing
openerp.modules.loading: The transient model ir.attachment.dms
(ir.attachment.dms) should not have explicit access rules!
--
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_read/+merge/212260
Your team OpenERP Community Reviewer/Maintainer is
Injection is still possible. It is an entry point for malicious queries or
accidental breaks.
--
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_read/+merge/212260
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:knowledge-addons/7.0.
--
Sorry. I didn't explain very well.
I have MPs for OCB, 7.0 and trunk for this bug.
OE trunk doesn't have both MP (server and web) because it too much, therefore
web doesn't have an MP.
As for server, commits up to r5297 ([FIX] Fixed instance of ValidateError not
being translated) have been
Review: Needs Fixing pep8
crm_firstname/__openerp__.py:22:1: O603 Manifest license key is missing
crm_firstname/__openerp__.py:35:19: E231 missing whitespace after ','
crm_firstname/__openerp__.py:37:11: E126 continuation line over-indented for
hanging indent
crm_firstname/__openerp__.py:39:11:
It would make the tests fail, but this problem is widespread in OE.
For example test_20_message_post
(openerp.addons.mail.tests.test_mail_features.test_mail) fails when a
translator changes the value. It just doesn't fail in en_US because the values
haven't changed. The same is not true for
I have already made some MPs for upstream, but the code is pretty different.
--
https://code.launchpad.net/~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk/+merge/212736
Your team OpenERP Community Reviewer/Maintainer is requested to review the
proposed merge of
Review: Approve
LGTM, thanks
The future module is worth looking at for future.str_as_unicode
https://pypi.python.org/pypi/future/0.3.1
--
https://code.launchpad.net/~openerp-community/openerp-canada/7.0-l10n_ca_account_check_writing/+merge/216708
Your team OpenERP Community is subscribed to
Review: Needs Information
@Stefan they give a satisfactory message when translated (no update to .po
needed)
I don't want to change too much from the original code, but if you feel it's
really needed, I can replace them with your suggestions.
--
You have been requested to review the proposed merge of
lp:~savoirfairelinux-openerp/ocb-web/translate_warnings_1297525 into lp:ocb-web.
For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/ocb-web/translate_warnings_1297525/+merge/212739
Allows the title of warning boxes
You have been requested to review the proposed merge of
lp:~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk into
lp:ocb-server.
For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk/+merge/212736
When
Review: Abstain
--
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_modules/+merge/217775
Your team Partner and Contact Core Editors is requested to review the proposed
merge of
You have been requested to review the proposed merge of
lp:~savoirfairelinux-openerp/knowledge-addons/cmis_write into
lp:knowledge-addons/7.0.
For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_write/+merge/213940
Add cmis_write: It allows to
Done.
Please make sure this doesn't have funny side effects and translates properly.
--
https://code.launchpad.net/~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk/+merge/212736
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-server.
--
Mailing
The tests fail anyway in any other language, especially in yml tests
Should I fix that assert too.
--
https://code.launchpad.net/~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk/+merge/212736
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-server.
Basically, if I change the labels, I would change the message in the tests.
Ideally, an assertRaises should be used there, but I have no idea if yml tests
support that.
--
https://code.launchpad.net/~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk/+merge/212736
Your team
Review: Approve
--
https://code.launchpad.net/~camptocamp/lp-community-utils/nag-nameerror-1312682/+merge/217216
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:lp-community-utils.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
You have been requested to review the proposed merge of
lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact
into lp:partner-contact-management.
For more details, see:
Review: Abstain
@Holger, took your comments into consideration
Taking myself out of the Reviewer list since I have contributed.
--
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/document_multiple_records/+merge/206960
Your team OpenERP Community Reviewer/Maintainer is
You have been requested to review the proposed merge of
lp:~savoirfairelinux-openerp/knowledge-addons/document_multiple_records into
lp:knowledge-addons/7.0.
For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/document_multiple_records/+merge/206960
Blueprint changed by Sandy Carter (http://www.savoirfairelinux.com):
Whiteboard changed:
Gather information about an OpenERP addon MP
* Has this MP been reviewed before by an automated script?
- * Does it contain message identifying as automated?
- * Has there been a new commit since last
Review: Needs Fixing
@Yannick,
Thank you for pointing that out. Indeed, maiden name might be a charged,
non-gender neutral name for the field and should be changed.
--
Review: Approve
l.120 is CamelCase the standard now?
--
https://code.launchpad.net/~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge/+merge/214719
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
@Yannick Good to know, thank you.
--
https://code.launchpad.net/~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge/+merge/214719
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Sandy Carter (http://www.savoirfairelinux.com) has proposed merging
lp:~savoirfairelinux-openerp/lp-community-utils/nag_refactor into
lp:lp-community-utils.
Requested reviews:
OpenERP Community Reviewer/Maintainer (openerp-community-reviewer)
Guewen Baconnier @ Camptocamp (gbaconnier-c2c
You have been requested to review the proposed merge of
lp:~savoirfairelinux-openerp/lp-community-utils/nag_refactor into
lp:lp-community-utils.
For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/nag_refactor/+merge/214445
Moved functions used in
Blueprint changed by Sandy Carter (http://www.savoirfairelinux.com):
Whiteboard set to:
Gather information about an OpenERP addon MP
* Has this MP been reviewed before by an automated script?
* Does it contain message identifying as automated?
* Has there been a new commit since last
Blueprint changed by Sandy Carter (http://www.savoirfairelinux.com):
Whiteboard changed:
Gather information about an OpenERP addon MP
* Has this MP been reviewed before by an automated script?
* Does it contain message identifying as automated?
* Has there been a new commit since last
Two commits have been added:
r5296 from OpenERP's support
r5297 from our team for a case I missed of error message translation
--
https://code.launchpad.net/~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk/+merge/212736
Your team OpenERP Community Backports Team is subscribed
The proposal to merge
lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_partner_member_observer
into lp:partner-contact-management has been updated.
Status: Needs review = Rejected
For more details, see:
@Guewen, thank you for the link, I was wondering if such a tool existed.
--
https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/branch_pep8/+merge/205260
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:lp-community-utils.
--
Mailing list:
Review: Approve
--
https://code.launchpad.net/~therp-nl/server-env-tools/7.0-auth_from_http_basic/+merge/202316
Your team Server Environment And Tools Core Editors is subscribed to branch
lp:server-env-tools.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
@yanina-aular thank you for fixing that, please backport that commit here
--
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-project_fix_doc_count-lp1251773-vauxoo+afe/+merge/209010
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list:
Sandy Carter (http://www.savoirfairelinux.com) has proposed merging
lp:~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk into
lp:ocb-server.
Requested reviews:
OpenERP Community Backports Team (ocb)
Related bugs:
Bug #1297525 in OpenERP Web: Title of except_orm Warning
Sandy Carter (http://www.savoirfairelinux.com) has proposed merging
lp:~savoirfairelinux-openerp/openerp-hr/department_sequence_concatination_NoneType
into lp:openerp-hr.
Requested reviews:
HR Core Editors (hr-core-editors)
For more details, see:
https://code.launchpad.net/~savoirfairelinux
For one, I do not use OCB, so there would be no point for me to propose a merge
into it if I want to use it. ;)
Second, I made a mistake in my comment when saying OCB, I meant
OpenObject-Addons.
You are absolutely right about the authorship, I will fix that. Thanks for
pointing that out with a
@Guewen
I reconstructed the history to the best of my abilities.
--
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact/+merge/203979
Your team Partner and Contact Core Editors is subscribed to branch
Community, any update on this?
--
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_partner_member_observer/+merge/204041
Your team Partner and Contact Core Editors is requested to review the proposed
merge of
Community, any update on this?
--
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_res_bank_account/+merge/204047
Your team Partner and Contact Core Editors is requested to review the proposed
merge of
Review: Approve
--
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_modules/+merge/204016
Your team Partner and Contact Core Editors is requested to review the proposed
merge of
Review: Needs Fixing code review, pep8
Looks, good, just a few pep8 issues:
openerp-nag:72:9: E126 continuation line over-indented for hanging indent
MY_READY: My MPs ready to land,
^
openerp-nag:73:9: E126 continuation line over-indented for hanging indent
MY_PENDING: My
28 + REVIEWED_PENDING: Nothing to do I've already reviewed those,
Nothing to do; I've already reviewed these
--
https://code.launchpad.net/~camptocamp/lp-community-utils/nag-user-specific-info/+merge/209665
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
Review: Approve code review, test
--
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_partner_supplier_information/+merge/204046
Your team Partner and Contact Core Editors is subscribed to branch
You have been requested to review the proposed merge of
lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_partner_supplier_information
into lp:partner-contact-management.
For more details, see:
The proposal to merge
lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_user_firstname
into lp:partner-contact-management has been updated.
Status: Needs review = Rejected
For more details, see:
Review: Disapprove
Superseded by
lp:~acsone-openerp/partner-contact-management/7.0-partner-firstname
--
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_user_firstname/+merge/204049
Your team Partner and Contact Core
Review: Approve
Firstname has been implemented by
lp:~acsone-openerp/partner-contact-management/7.0-partner-firstname
@Yannick, can you rexplain your objection, it seems to have been cut off: «as
maiden name is» ...
--
You have been requested to review the proposed merge of
lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_partner_maiden_name
into lp:partner-contact-management.
For more details, see:
@Yannick, thank you for the review
You might be right about this being too specific.
I will leave this in MP for a few weeks to see if it there is any interest, if
not, I will reject it.
--
Help text and description improved.
I hope this helps for further review.
--
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_res_bank_account/+merge/204047
Your team Partner and Contact Core Editors is subscribed to
You have been requested to review the proposed merge of
lp:~savoirfairelinux-openerp/openerp-hr/hr_employee_firstname into
lp:openerp-hr.
For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/openerp-hr/hr_employee_firstname/+merge/204065
Add hr_employee_firstname module;
You have been requested to review the proposed merge of
lp:~savoirfairelinux-openerp/ocb-addons/crossovered_unicode_1292245 into
lp:ocb-addons.
For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/ocb-addons/crossovered_unicode_1292245/+merge/210926
This fixes bug
The proposal to merge lp:~openerp-community/server-env-tools/6.1-mass_editing
into lp:server-env-tools/6.1 has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~openerp-community/server-env-tools/6.1-mass_editing/+merge/161619
--
The proposal to merge lp:~openerp-community/server-env-tools/6.1-mass_editing
into lp:server-env-tools/6.1 has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~openerp-community/server-env-tools/6.1-mass_editing/+merge/161619
--
Review: Approve
--
https://code.launchpad.net/~openerp-community/server-env-tools/6.1-mass_editing/+merge/161619
Your team OpenERP Community is subscribed to branch
lp:~openerp-community/server-env-tools/6.1-mass_editing.
___
Mailing list:
Review: Approve
--
https://code.launchpad.net/~openerp-community/server-env-tools/6.1-mass_editing/+merge/161619
Your team Server Environment And Tools Core Editors is subscribed to branch
lp:server-env-tools/6.1.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to
You have been requested to review the proposed merge of
lp:~savoirfairelinux-openerp/knowledge-addons/document_multiple_records into
lp:knowledge-addons/7.0.
For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/document_multiple_records/+merge/206960
Review: Needs Fixing code review
@Stefan: I thin you missed the point of vals[model_field]:
There is a chance of a KeyError if model_field not in val and a chance of index
error if len(vals[model_field]) 1 or len(vals[model_field][0]) 3
--
Review: Approve code review, no test
OK, sorry about the misunderstanding.
Nevertheless, I would prefer to see some assertions, gets and tries as this
function looks likely to throw an IndexError.
But I see you've take them into account (removal of redundant checks, values
checking, etc)
--
I've been told it's better to use tools.ustr()
--
https://code.launchpad.net/~savoirfairelinux-openerp/ocb-addons/crossovered_unicode_1292245/+merge/210926
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list:
The proposal to merge
lp:~savoirfairelinux-openerp/ocb-addons/crossovered_unicode_1292245 into
lp:ocb-addons has been updated.
Status: Needs review = Work in progress
For more details, see:
Sandy Carter (http://www.savoirfairelinux.com) has proposed merging
lp:~savoirfairelinux-openerp/ocb-addons/crossovered_unicode_1292245 into
lp:ocb-addons.
Requested reviews:
Holger Brunn (Therp) (hbrunn): code review
Pedro Manuel Baeza (pedro.baeza): code review
Related bugs:
Bug
Review: Needs Information
@Stefan, could you please explain the dataloss issue in this frame, I don't
quite understand.
How does the branch you propose come into play here?
--
https://code.launchpad.net/~openerp-community/server-env-tools/6.1-mass_editing/+merge/161619
Your team OpenERP
Review: Disapprove
I disagree with taking out .swp files.
Having .swp in the ignore file means that we would never want that kind of file
tracked.
I suggest using a different method to track swp files such as:
bzr ignored | grep .swp
--
Review: Needs Fixing code review, pep8
PEP8:
l.9 E231 missing whitespace after ':'
l.10 E128 continuation line under-indented for visual indent
--
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-project_fix_doc_count-lp1251773-vauxoo+afe/+merge/209010
Your team OpenERP Community
Review: Abstain
Thank you for teachning me thing. I had no idea.
--
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-add-variant-dispach-report-resubmit/+merge/210599
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-flows.
--
Mailing list:
1 - 100 of 205 matches
Mail list logo
