Re: [Openerp-community-reviewer] [Merge] lp:~laetitia-gangloff/hr-timesheet/hr_attendance_analysis_externalise_contract_calendar into lp:~hr-core-editors/hr-timesheet/7.0

2014-07-30 Thread Yannick Vaucher @ Camptocamp
This one is set as Superseeded. Seems fine. No change needed. -- https://code.launchpad.net/~laetitia-gangloff/hr-timesheet/hr_attendance_analysis_externalise_contract_calendar/+merge/182565 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch

[Openerp-community-reviewer] [Merge] lp:~sylvain-legal/server-env-tools/7.0-flake8 into lp:server-env-tools

2014-07-07 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~sylvain-legal/server-env-tools/7.0-flake8 into lp:server-env-tools has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-flake8/+merge/225456 --

Re: [Openerp-community-reviewer] [Merge] lp:~sylvain-legal/server-env-tools/7.0-flake8 into lp:server-env-tools

2014-07-07 Thread Yannick Vaucher @ Camptocamp
Completely agree that's why you always have my approval. -- https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-flake8/+merge/225456 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/server-env-tools/6.1-web_base_url_freeze into lp:server-env-tools/6.1

2014-07-04 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no test LGTM -- https://code.launchpad.net/~therp-nl/server-env-tools/6.1-web_base_url_freeze/+merge/225651 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools/6.1. -- Mailing list:

[Openerp-community-reviewer] [Merge] lp:~akretion-team/server-env-tools/module-configuration-helper-dbl into lp:server-env-tools

2014-07-04 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~akretion-team/server-env-tools/module-configuration-helper-dbl into lp:server-env-tools has been updated. Status: Needs review = Approved For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/server-env-tools/module-configuration-helper-dbl into lp:server-env-tools

2014-07-04 Thread Yannick Vaucher @ Camptocamp
Review: Resubmit Hello David, I'm ok to merge this, I even tried to merge it before this project goes on Github. However, it seems you created that module on an empty branch. Could you redo/rebase this? Might be better to do it directly in git ? --

[Openerp-community-reviewer] [Merge] lp:~akretion-team/server-env-tools/module-configuration-helper-dbl into lp:server-env-tools

2014-07-04 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~akretion-team/server-env-tools/module-configuration-helper-dbl into lp:server-env-tools has been updated. Status: Approved = Needs review For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~sylvain-legal/server-env-tools/7.0-flake8 into lp:server-env-tools

2014-07-04 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no test l.330 you need to be sure context is a dict before using get l.536 you can use dict setter dict['split_key'] = [(3, id) for id in vals.get(split_key, False)[0][2]] Thaught this wasn't the target here. I'll approve already as we want

Re: [Openerp-community-reviewer] [Merge] lp:~sylvain-legal/server-env-tools/7.0-flake8 into lp:server-env-tools

2014-07-04 Thread Yannick Vaucher @ Camptocamp
s/Thaught/Though -- https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-flake8/+merge/225456 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/server-env-tools/server-env-tools into lp:server-env-tools

2014-07-04 Thread Yannick Vaucher @ Camptocamp
Review: Resubmit pr created on github -- https://code.launchpad.net/~akretion-team/server-env-tools/server-env-tools/+merge/91 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~serpentcs/sale-reports/sale-serpentcs into lp:~sale-core-editors/sale-reports/7.0

2014-07-02 Thread Yannick Vaucher @ Camptocamp
Review: Resubmit moved on github This project is now hosted on https://github.com/OCA/sale-reports. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub --

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/report-print-send/7.0-no-lock-in-update-1308635-ls into lp:report-print-send

2014-07-02 Thread Yannick Vaucher @ Camptocamp
Review: Needs Fixing LGTM appart for the variable _ though we are not using translation here. -- https://code.launchpad.net/~numerigraphe-team/report-print-send/7.0-no-lock-in-update-1308635-ls/+merge/216353 Your team Report Printing and Sending Core Editors is subscribed to branch

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/report-print-send/7.0-improve-prefs-ui-ls into lp:report-print-send

2014-07-02 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no test Thanks for the changes LGTM -- https://code.launchpad.net/~numerigraphe-team/report-print-send/7.0-improve-prefs-ui-ls/+merge/219787 Your team Report Printing and Sending Core Editors is subscribed to branch lp:report-print-send. -- Mailing list:

[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/report-print-send/7.0-improve-prefs-ui-ls into lp:report-print-send

2014-07-02 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~numerigraphe-team/report-print-send/7.0-improve-prefs-ui-ls into lp:report-print-send has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~numerigraphe-team/report-print-send/7.0-improve-prefs-ui-ls/+merge/219787 --

Re: [Openerp-community-reviewer] [Merge] lp:~bruno-bottacini/report-print-send/7.0-report_webkit_custom_paper_size into lp:~report-print-send-core-editors/report-print-send/7.0

2014-07-02 Thread Yannick Vaucher @ Camptocamp
Review: Resubmit moved on github This project is now hosted on https://github.com/OCA/report-print-send. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub --

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/report-print-send/7.0-no-lock-in-update-1308635-ls into lp:~report-print-send-core-editors/report-print-send/7.0

2014-07-02 Thread Yannick Vaucher @ Camptocamp
Review: Resubmit moved on github This project is now hosted on https://github.com/OCA/report-print-send. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub --

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1335887 into lp:ocb-addons

2014-07-01 Thread Yannick Vaucher @ Camptocamp
Thanks Pedro Change made -- https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1335887/+merge/225028 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-reports/vre-sale_order_proformat into lp:sale-reports

2014-07-01 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no test Fixed mark down in __openerp__.py and improved it a bit. LGTM -- https://code.launchpad.net/~camptocamp/sale-reports/vre-sale_order_proformat/+merge/223563 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:sale-reports. -- Mailing

[Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-reports/vre-sale_order_proformat into lp:sale-reports

2014-07-01 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~camptocamp/sale-reports/vre-sale_order_proformat into lp:sale-reports has been updated. Status: Merged = Approved For more details, see: https://code.launchpad.net/~camptocamp/sale-reports/vre-sale_order_proformat/+merge/223563 --

[Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-reports/vre-sale_order_proformat into lp:sale-reports

2014-07-01 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~camptocamp/sale-reports/vre-sale_order_proformat into lp:sale-reports has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~camptocamp/sale-reports/vre-sale_order_proformat/+merge/223563 --

[Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-reports/vre-sale_order_proformat into lp:sale-reports

2014-07-01 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~camptocamp/sale-reports/vre-sale_order_proformat into lp:sale-reports has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~camptocamp/sale-reports/vre-sale_order_proformat/+merge/223563 --

Re: [Openerp-community-reviewer] [Merge] lp:~initos.com/sale-reports/7.0-fix_lang_for_draft into lp:sale-reports

2014-07-01 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no test LGTM as https://code.launchpad.net/~initos.com/account-invoice-report/7.0-fix_lang_for_draft/+merge/224109 -- https://code.launchpad.net/~initos.com/sale-reports/7.0-fix_lang_for_draft/+merge/224106 Your team OpenERP Community Reviewer/Maintainer is

[Openerp-community-reviewer] [Merge] lp:~initos.com/sale-reports/7.0-fix_lang_for_draft into lp:sale-reports

2014-07-01 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~initos.com/sale-reports/7.0-fix_lang_for_draft into lp:sale-reports has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~initos.com/sale-reports/7.0-fix_lang_for_draft/+merge/224106 --

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/carriers-deliveries/7-add-base-class-for-carrier-configs into lp:~stock-logistic-core-editors/carriers-deliveries/7.0

2014-06-30 Thread Yannick Vaucher @ Camptocamp
This project is now hosted on https://github.com/OCA/carriers-deliveries. Please move your proposal there if you still want to merge it once fixed. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub --

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/carriers-deliveries/7-split-default-option-state-from-deliv-method-dbl into lp:~stock-logistic-core-editors/carriers-deliveries/7.0

2014-06-30 Thread Yannick Vaucher @ Camptocamp
This project is now hosted on https://github.com/OCA/carriers-deliveries. Please move your proposal there if you still want to merge it once fixed. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub (sorry David should have merged it

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_dispatch-output-file-yvr into lp:~stock-logistic-core-editors/carriers-deliveries/7.0

2014-06-30 Thread Yannick Vaucher @ Camptocamp
This project is now hosted on https://github.com/OCA/carriers-deliveries. Please move your proposal there if you still want to merge it once fixed. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub --

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7 into lp:~stock-logistic-core-editors/carriers-deliveries/7.0

2014-06-30 Thread Yannick Vaucher @ Camptocamp
This project is now hosted on https://github.com/OCA/carriers-deliveries. Please move your proposal there if you still want to merge it once fixed. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub --

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-threaded-dispatch-label-generation into lp:~stock-logistic-core-editors/carriers-deliveries/7.0

2014-06-30 Thread Yannick Vaucher @ Camptocamp
Note to myself This project is now hosted on https://github.com/OCA/carriers-deliveries. Please move your proposal there if you still want to merge it once fixed. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub --

[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-invoice-report/vre_account_invoice_report into lp:account-invoice-report

2014-06-30 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~camptocamp/account-invoice-report/vre_account_invoice_report into lp:account-invoice-report has been updated. Status: Needs review = Rejected For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~initos.com/account-invoice-report/7.0-fix_lang_for_draft into lp:account-invoice-report

2014-06-30 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no test LGTM -- https://code.launchpad.net/~initos.com/account-invoice-report/7.0-fix_lang_for_draft/+merge/224109 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list:

[Openerp-community-reviewer] [Merge] lp:~initos.com/account-invoice-report/7.0-fix_lang_for_draft into lp:account-invoice-report

2014-06-30 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~initos.com/account-invoice-report/7.0-fix_lang_for_draft into lp:account-invoice-report has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~initos.com/account-invoice-report/7.0-fix_lang_for_draft/+merge/224109 --

Re: [Openerp-community-reviewer] [Merge] lp:~initos.com/account-invoice-report/7.0-fix_lang_for_draft into lp:account-invoice-report

2014-06-30 Thread Yannick Vaucher @ Camptocamp
Thanks for the fix. -- https://code.launchpad.net/~initos.com/account-invoice-report/7.0-fix_lang_for_draft/+merge/224109 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1311087-rgo into lp:ocb-addons

2014-06-30 Thread Yannick Vaucher @ Camptocamp
Replay isn't working yet and passing from lp to github will make us having to replay all the MP we did. I think that while we don't have OCB fully working on github we can fill the gap by merging that kind of MP in OCB on launchpad. --

[Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-invoice-report/invoice_webkit_fr_translation into lp:account-invoice-report

2014-06-30 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~acsone-openerp/account-invoice-report/invoice_webkit_fr_translation into lp:account-invoice-report has been updated. Status: Needs review = Approved For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-invoice-report/invoice_webkit_fr_translation into lp:account-invoice-report

2014-06-30 Thread Yannick Vaucher @ Camptocamp
I merge this before migration to github. Missing 1 approve but only touch translation so this is not critical. -- https://code.launchpad.net/~acsone-openerp/account-invoice-report/invoice_webkit_fr_translation/+merge/214179 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch

Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-invoice-report/invoice_webkit_fr_translation into lp:account-invoice-report

2014-06-30 Thread Yannick Vaucher @ Camptocamp
Thanks Leatitia for this MP -- https://code.launchpad.net/~acsone-openerp/account-invoice-report/invoice_webkit_fr_translation/+merge/214179 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list:

[Openerp-community-reviewer] [Merge] lp:~therp-nl/account-invoice-report/account-invoice-report-7.0_delivery_address into lp:account-invoice-report

2014-06-30 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~therp-nl/account-invoice-report/account-invoice-report-7.0_delivery_address into lp:account-invoice-report has been updated. Status: Needs review = Approved For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs into lp:~account-core-editors/account-invoice-report/7.0

2014-06-30 Thread Yannick Vaucher @ Camptocamp
This project is now hosted on https://github.com/OCA/account-invoice-reporting. Please move your proposal there if you still want to merge it once fixed. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub Sorry Lorenzo didn't had the

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7 into lp:~stock-logistic-core-editors/carriers-deliveries/7.0

2014-06-30 Thread Yannick Vaucher @ Camptocamp
Sorry for having a bit rushed the migration of this branch. One way or the other we must replicate this MP as a PR on github, now. Can you do this and putting this MP as reference, the PR will be merged fast as it was already approved. --

Re: [Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/7.0-bug-1091268-purchase-merge-no-origin-duplicates into lp:ocb-addons

2014-06-30 Thread Yannick Vaucher @ Camptocamp
This MP introduced a bug If first purchase order has no origin, it will raise ... if not porder.origin in order_infos['origin'] and not order_infos['origin'] in porder.origin: TypeError: argument of type 'bool' is not iterable because order_infos['origin'] will contains False --

[Openerp-community-reviewer] [Bug 1335887] [NEW] [7.0] Merging purchase order will fail when first one has no origin

2014-06-30 Thread Yannick Vaucher @ Camptocamp
Public bug reported: https://code.launchpad.net/~yann-papouin/ocb-addons/7.0-bug-1091268 -purchase-merge-no-origin-duplicates/+merge/210169 Introduced a bug: When first purchase order has no origin, it will raise the following error: OpenERP Server Error Client Traceback (most recent call

[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1335887 into lp:ocb-addons

2014-06-30 Thread Yannick Vaucher @ Camptocamp
Yannick Vaucher @ Camptocamp has proposed merging lp:~camptocamp/ocb-addons/7.0-fix-1335887 into lp:ocb-addons. Commit message: Fix purchase order do_merge w/ 1st origin empty introduced on OCB on rev 10009 Requested reviews: Yann Papouin (yann-papouin) OpenERP Community Backports (ocb

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1335887 into lp:ocb-addons

2014-06-30 Thread Yannick Vaucher @ Camptocamp
Ok I though empty string were store as Null as zero value for integer. Just check and it seems I'm wrong. I'll add a check instead of forcing to empty string. Thanks for the review -- https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1335887/+merge/225028 Your team OpenERP Community

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1335887 into lp:ocb-addons

2014-06-30 Thread Yannick Vaucher @ Camptocamp
@Ronald, I changed the fix according to your review -- https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1335887/+merge/225028 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/7.0-add-last_sale_price-yvr into lp:sale-wkfl

2014-06-27 Thread Yannick Vaucher @ Camptocamp
Ported on github -- https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-add-last_sale_price-yvr/+merge/223704 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

[Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/7.0-add-last_sale_price-yvr into lp:sale-wkfl

2014-06-27 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~camptocamp/sale-wkfl/7.0-add-last_sale_price-yvr into lp:sale-wkfl has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-add-last_sale_price-yvr/+merge/223704 --

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/carriers-deliveries/7-split-default-option-state-from-deliv-method-dbl into lp:carriers-deliveries

2014-06-25 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no tests Just one inline comment Otherwise LGTM -- https://code.launchpad.net/~akretion-team/carriers-deliveries/7-split-default-option-state-from-deliv-method-dbl/+merge/224027 Your team Stock and Logistic Core Editors is subscribed to branch

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/carriers-deliveries/7-split-default-option-state-from-deliv-method-dbl into lp:carriers-deliveries

2014-06-25 Thread Yannick Vaucher @ Camptocamp
Review: Approve Ok failed my inline comment l.102 field name=code readonly=1/ You can remove readonly here as you setted it on model -- https://code.launchpad.net/~akretion-team/carriers-deliveries/7-split-default-option-state-from-deliv-method-dbl/+merge/224027 Your team Stock

[Openerp-community-reviewer] [Bug 1311087] Re: mail: 'Send a message' generates excessively slow queries

2014-06-24 Thread Yannick Vaucher @ Camptocamp
** Also affects: ocb-addons Importance: Undecided Status: New ** Also affects: ocb-addons/7.0 Importance: Undecided Status: New -- You received this bug notification because you are a member of OpenERP Community Backports, which is subscribed to OpenERP Community Backports

[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1311087-rgo into lp:ocb-addons

2014-06-24 Thread Yannick Vaucher @ Camptocamp
Yannick Vaucher @ Camptocamp has proposed merging lp:~camptocamp/ocb-addons/7.0-fix-1311087-rgo into lp:ocb-addons. Requested reviews: OpenERP Community Backports (ocb) Related bugs: Bug #1311087 in OpenERP Community Backports (Addons): mail: 'Send a message' generates excessively slow

[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1223922-yvr into lp:ocb-addons

2014-06-24 Thread Yannick Vaucher @ Camptocamp
Yannick Vaucher @ Camptocamp has proposed merging lp:~camptocamp/ocb-addons/7.0-fix-1223922-yvr into lp:ocb-addons. Requested reviews: OpenERP Community Backports (ocb) Related bugs: Bug #1223922 in OpenERP Community Backports (Addons): [7.0] account - selection of analytic account

[Openerp-community-reviewer] [Bug 1223922] Re: [7.0] account - selection of analytic account on invoice line form shouldn't show closed account

2014-06-24 Thread Yannick Vaucher @ Camptocamp
** Also affects: ocb-addons Importance: Undecided Status: New ** Changed in: ocb-addons Status: New = Fix Committed ** Also affects: ocb-addons/7.0 Importance: Undecided Status: Fix Committed -- You received this bug notification because you are a member of OpenERP

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-barcode/7.0-fix_1330459-sge+afe into lp:stock-logistic-barcode

2014-06-20 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review no tests LGTM thanks -- https://code.launchpad.net/~camptocamp/stock-logistic-barcode/7.0-fix_1330459-sge+afe/+merge/223866 Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-barcode. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-budgeting/vre-budget-responsible-group into lp:account-budgeting

2014-06-20 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, test LGTM Thanks -- https://code.launchpad.net/~camptocamp/account-budgeting/vre-budget-responsible-group/+merge/223705 Your team Account Core Editors is subscribed to branch lp:account-budgeting. -- Mailing list: https://launchpad.net/~openerp-community-reviewer

[Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7_fix_1221570 into lp:account-invoice-report

2014-06-20 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~agilebg/account-invoice-report/7_fix_1221570 into lp:account-invoice-report has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~agilebg/account-invoice-report/7_fix_1221570/+merge/223781 --

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7_fix_1221570 into lp:account-invoice-report

2014-06-20 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no test Thanks LGTM -- https://code.launchpad.net/~agilebg/account-invoice-report/7_fix_1221570/+merge/223781 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7_fix_1221570 into lp:account-invoice-report

2014-06-20 Thread Yannick Vaucher @ Camptocamp
Thanks again Lorenzo, will be a time saver. -- https://code.launchpad.net/~agilebg/account-invoice-report/7_fix_1221570/+merge/223781 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list:

[Openerp-community-reviewer] [Merge] lp:~agilebg/sale-reports/7_fix_1331541 into lp:sale-reports

2014-06-20 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~agilebg/sale-reports/7_fix_1331541 into lp:sale-reports has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~agilebg/sale-reports/7_fix_1331541/+merge/223871 --

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/sale-reports/7_fix_1331541 into lp:sale-reports

2014-06-20 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review -- https://code.launchpad.net/~agilebg/sale-reports/7_fix_1331541/+merge/223871 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:sale-reports. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/sale-reports/7_fix_1331541 into lp:sale-reports

2014-06-20 Thread Yannick Vaucher @ Camptocamp
Thanks for the patch -- https://code.launchpad.net/~agilebg/sale-reports/7_fix_1331541/+merge/223871 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:sale-reports. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/sale-reports/7_fix_1331541 into lp:sale-reports

2014-06-20 Thread Yannick Vaucher @ Camptocamp
Fixed in merge -- https://code.launchpad.net/~agilebg/sale-reports/7_fix_1331541/+merge/223871 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:sale-reports. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/carriers-deliveries/7-base-delivery-carrier-dbl into lp:carriers-deliveries

2014-06-19 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review As itself base_delivery_carrier_label module only provide an interface class, this method here makes sense. LGTM -- https://code.launchpad.net/~akretion-team/carriers-deliveries/7-base-delivery-carrier-dbl/+merge/221226 Your team Stock and Logistic Core Editors is

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-report/7.0-sync-afr_webkit-with-report_webkit into lp:account-financial-report

2014-06-19 Thread Yannick Vaucher @ Camptocamp
This has been fixed by Pedro, some revision were overwritten last week and are now back in OCB. Thanks for noticing it Stéphane -- https://code.launchpad.net/~camptocamp/account-financial-report/7.0-sync-afr_webkit-with-report_webkit/+merge/223058 Your team Account Report Core Editors is

[Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/7.0-add-last_sale_price-yvr into lp:sale-wkfl

2014-06-19 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~camptocamp/sale-wkfl/7.0-add-last_sale_price-yvr into lp:sale-wkfl has been updated. Description changed to: Add a module to show last price defined for customer on sale order line For more details, see:

[Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/7.0-add-last_sale_price-yvr into lp:sale-wkfl

2014-06-19 Thread Yannick Vaucher @ Camptocamp
Yannick Vaucher @ Camptocamp has proposed merging lp:~camptocamp/sale-wkfl/7.0-add-last_sale_price-yvr into lp:sale-wkfl. Commit message: [ADD] module last_sale_price - This module provides new columns in sale order line in order to let the sellerman know if a customer already ordrered

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/7.0-add-last_sale_price-yvr into lp:sale-wkfl

2014-06-19 Thread Yannick Vaucher @ Camptocamp
Thanks for the review. I just fixed the __openerp__.py -- https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-add-last_sale_price-yvr/+merge/223704 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to

[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-github-650 into lp:ocb-addons

2014-06-19 Thread Yannick Vaucher @ Camptocamp
Yannick Vaucher @ Camptocamp has proposed merging lp:~camptocamp/ocb-addons/7.0-fix-github-650 into lp:ocb-addons. Requested reviews: OpenERP Community Backports (ocb) For more details, see: https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-github-650/+merge/223727 Official MP

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_res_bank_account into lp:partner-contact-management

2014-06-18 Thread Yannick Vaucher @ Camptocamp
Thanks for the review Ana My point about title_bank_account is that most of Models have standard `name` and `description` fields. I agree having a second field description is quiet useful to add note on the object when you open it. However as res.partner.bank is already a bank account, naming

[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-report/7.0-fix-1319109 into lp:account-financial-report

2014-06-13 Thread Yannick Vaucher @ Camptocamp
Yannick Vaucher @ Camptocamp has proposed merging lp:~camptocamp/account-financial-report/7.0-fix-1319109 into lp:account-financial-report. Requested reviews: Account Report Core Editors (account-report-core-editor) For more details, see: https://code.launchpad.net/~camptocamp/account

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-threaded-dispatch-label-generation into lp:carriers-deliveries

2014-06-13 Thread Yannick Vaucher @ Camptocamp
fixed except: - except Exception: -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-threaded-dispatch-label-generation/+merge/215184 Your team Stock and Logistic Core Editors is requested to review the proposed merge of

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-threaded-dispatch-label-generation into lp:carriers-deliveries

2014-06-06 Thread Yannick Vaucher @ Camptocamp
Diff comments: === modified file 'delivery_carrier_label_dispatch/__openerp__.py' --- delivery_carrier_label_dispatch/__openerp__.py2014-05-14 14:12:12 + +++ delivery_carrier_label_dispatch/__openerp__.py2014-05-14 14:12:13 + @@ -27,7 +27,7 @@ 'depends':

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/partner-contact-management/7.0_1184983_compute_display_name into lp:partner-contact-management

2014-05-23 Thread Yannick Vaucher @ Camptocamp
Review: Needs Information Doesn't the module firstname_display_name_trigger already does this job? There is already a trigger in it to recompute display_name. -- https://code.launchpad.net/~therp-nl/partner-contact-management/7.0_1184983_compute_display_name/+merge/220629 Your team Partner and

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/partner-contact-management/7.0_1184983_compute_display_name into lp:partner-contact-management

2014-05-23 Thread Yannick Vaucher @ Camptocamp
Review: Disapprove firstname_display_name_trigger should already fix this issue. Thus I disapprove it. -- https://code.launchpad.net/~therp-nl/partner-contact-management/7.0_1184983_compute_display_name/+merge/220629 Your team Partner and Contact Core Editors is subscribed to branch

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/ocb-addons/70-addons-fix-payment-acls-bank into lp:ocb-addons

2014-05-23 Thread Yannick Vaucher @ Camptocamp
Review: Needs Fixing Aggreed with Raphaël, Please provide a bug report and the same MP on official branch Thus the bug report will link ocb and official branch fixes. Cheers -- https://code.launchpad.net/~akretion-team/ocb-addons/70-addons-fix-payment-acls-bank/+merge/208021 Your team

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/ocb-7.0-fix_1302630_document_search_order_by-rde into lp:ocb-addons

2014-05-23 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no test LGTM -- https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1302630_document_search_order_by-rde/+merge/214486 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055 into lp:department-mgmt

2014-05-23 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no test It should be fine. If employee has no department_id, employee. Employee.department_id will return browse_null and browse_null.id will return False -- https://code.launchpad.net/~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055/+merge/212286 Your

[Openerp-community-reviewer] [Merge] lp:~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055 into lp:department-mgmt

2014-05-23 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055 into lp:department-mgmt has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055/+merge/212286 --

Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix into lp:account-financial-tools

2014-05-23 Thread Yannick Vaucher @ Camptocamp
Review: Approve Thanks for the changes Pedro LGTM -- https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix/+merge/214832 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list:

[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde into lp:account-financial-tools

2014-05-23 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde into lp:account-financial-tools has been updated. Status: Needs review = Approved For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-web/7.0_lp1261332_better_report_name into lp:ocb-web

2014-05-23 Thread Yannick Vaucher @ Camptocamp
Review: Approve -- https://code.launchpad.net/~therp-nl/ocb-web/7.0_lp1261332_better_report_name/+merge/219901 Your team OpenERP Community Backports is subscribed to branch lp:ocb-web. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

[Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-tools/7.0-account_chart_update-enhanced into lp:account-financial-tools

2014-05-23 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~pedro.baeza/account-financial-tools/7.0-account_chart_update-enhanced into lp:account-financial-tools has been updated. Status: Needs review = Approved For more details, see:

[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-associate-attachment-and-picking_rde into lp:carriers-deliveries

2014-05-23 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~camptocamp/carriers-deliveries/7.0-associate-attachment-and-picking_rde into lp:carriers-deliveries has been updated. Status: Needs review = Approved For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search into lp:account-financial-tools

2014-05-23 Thread Yannick Vaucher @ Camptocamp
Review: Needs Fixing I set as need fixing after Frederic's comment -- https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch

Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-report/7.0-bug-1312732-lmi into lp:account-financial-report

2014-05-23 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no test LGTM thanks for the contrib! -- https://code.launchpad.net/~acsone-openerp/account-financial-report/7.0-bug-1312732-lmi/+merge/217240 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-report/7.0-bug-1312732-lmi into lp:account-financial-report

2014-05-23 Thread Yannick Vaucher @ Camptocamp
Review: Needs Information You are right forgot that sudden move from Odoo At least it fixes this issue in 7.0 but this would be more effort when porting to 8.0. Thus I revert my review as we need to find an other way of ensuring values are defined. BTW shouldn't store be computed when

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/server-env-tools/module-configuration-helper-dbl into lp:server-env-tools

2014-05-21 Thread Yannick Vaucher @ Camptocamp
Review: Needs Fixing test + code review Used it to create a config and works well. Code review l.161 + l.163 + l.172 please remove commented print line l.226 no need to quote me for this code I took it from addons/account/res_config.py --

[Openerp-community-reviewer] [Bug 1319109] Re: webkit_report - webkit parser is not thread safe because of attribute parser_instance

2014-05-21 Thread Yannick Vaucher @ Camptocamp
** Changed in: ocb-addons/7.0 Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of OpenERP Community Backports, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1319109 Title: webkit_report -

[Openerp-community-reviewer] [Bug 1290820] Re: report_webkit not thread-safe: risk of document corruption

2014-05-21 Thread Yannick Vaucher @ Camptocamp
** Changed in: ocb-addons/7.0 Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of OpenERP Community Backports, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1290820 Title: report_webkit

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/server-env-tools/module-configuration-helper-dbl into lp:server-env-tools

2014-05-21 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review and test still you can remove l.223 Otherwise LGTM -- https://code.launchpad.net/~akretion-team/server-env-tools/module-configuration-helper-dbl/+merge/220392 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. --

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/hr-timesheet/imp_hr_attendance_analysis_roundings into lp:hr-timesheet

2014-05-21 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no test LGTM thanks! -- https://code.launchpad.net/~agilebg/hr-timesheet/imp_hr_attendance_analysis_roundings/+merge/206493 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:hr-timesheet. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-tools/7.0-account_chart_update-enhanced into lp:account-financial-tools

2014-05-20 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no test Seems fine that way ondelete=cascade seems also a better choice. Thanks! LGTM -- https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account_chart_update-enhanced/+merge/212074 Your team OpenERP Community Reviewer/Maintainer is subscribed to

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date into lp:purchase-wkfl

2014-05-19 Thread Yannick Vaucher @ Camptocamp
Here is the reference for this community Guideline. https://doc.openerp.com/contribute/05_developing_modules/#modules-description This has the advantage to show who contributed directly on apps.odoo.com as we don't have such field in manifest. --

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date into lp:purchase-wkfl

2014-05-19 Thread Yannick Vaucher @ Camptocamp
Here is an exemple: http://bazaar.launchpad.net/~report-print-send-core-editors/report-print-send/7.0/view/head:/base_report_to_printer/__openerp__.py -- https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date/+merge/211374 Your team Purchase Core Editors

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date into lp:purchase-wkfl

2014-05-19 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no test Perfect, thanks for the changes Lionel -- https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date/+merge/211374 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde into lp:account-financial-tools

2014-05-19 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no test LGTM Thanks -- https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde/+merge/220090 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep into lp:purchase-wkfl

2014-05-16 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no test LGTM -- https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

[Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep into lp:purchase-wkfl

2014-05-16 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep into lp:purchase-wkfl has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745 --

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/openerp-reporting-engines/7.0-report_xls-tz_fix into lp:openerp-reporting-engines

2014-05-16 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no test LGTM Cheers. -- https://code.launchpad.net/~luc-demeyer/openerp-reporting-engines/7.0-report_xls-tz_fix/+merge/219267 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:openerp-reporting-engines. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date into lp:purchase-wkfl

2014-05-16 Thread Yannick Vaucher @ Camptocamp
Review: Needs Fixing Please don't add AUTHOR.txt file and add Contributors in __openerp__.py For who did exaclty what there is the CVS -- https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date/+merge/211374 Your team Purchase Core Editors is subscribed

Re: [Openerp-community-reviewer] [Merge] lp:~sylvain-legal/server-env-tools/7.0-fix-1319391 into lp:server-env-tools

2014-05-16 Thread Yannick Vaucher @ Camptocamp
Already merged -- https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-fix-1319391/+merge/219530 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

  1   2   3   4   5   6   7   >