guewen: for the record, it is legal to have *args after a kw argument in a
function definition in Python
--
https://code.launchpad.net/~openerp-community/openerp-mgmtsystem/nc-extend/+merge/140259
Your team OpenERP Community is subscribed to branch
Review: Needs Fixing
Needs migration scripts
--
https://code.launchpad.net/~openerp-community/openerp-mgmtsystem/nc-extend/+merge/140259
Your team OpenERP Community is subscribed to branch
lp:~openerp-community/openerp-mgmtsystem/nc-extend.
___
Review: Abstain
--
https://code.launchpad.net/~openerp-community/openerp-mgmtsystem/nc-extend/+merge/139534
Your team OpenERP Community is subscribed to branch
lp:~openerp-community/openerp-mgmtsystem/nc-extend.
___
Mailing list:
Maxime, what do you think on changing the state codes from letters to words?
Do you prefer this to be done now, and you'll include that on the migration
script, or should we postpone for the v7 migration?
--
https://code.launchpad.net/~openerp-community/openerp-mgmtsystem/nc-extend/+merge/139534
Guewen: Thanks for the review; fixes are in progress.
I'd like to know a little more about your remark «On the usage of namespaces,
classes and instanciation of models».
I did some browsing on the official addons, and found some cases where `from
openerp.osv import fields, osv` instead of `from
Maxime, what do you think on changing the state codes from letters to words?
Do you prefer this to be done now, and you'll include that on the migration
script, or should we postpone for the v7 migration?
Let's do it now.
Maxime: should licenses change from GPL3 to AGPL?
Yes!
--
On 14/12/2012 11:24, Daniel Reis (SECURITAS SA) wrote:
Guewen: Thanks for the review; fixes are in progress.
I'd like to know a little more about your remark «On the usage of namespaces,
classes and instanciation of models».
I did some browsing on the official addons, and found some cases
There are some things on the move in the official addons in trunk. I
submitted a merge proposal to clean up modules but it has not been
proposed so far
s/proposed/processed/
--
https://code.launchpad.net/~openerp-community/openerp-mgmtsystem/nc-extend/+merge/139534
Your team OpenERP
Review: Resubmit
Rebased the branch (to r16) and fixed the conflicts.
Please review.
--
https://code.launchpad.net/~openerp-community/openerp-mgmtsystem/nc-extend/+merge/139534
Your team OpenERP Community is subscribed to branch
lp:~openerp-community/openerp-mgmtsystem/nc-extend.
Review: Needs Fixing
Quick eyeball review, I did not reviewed the business aspect.
dubious indentation at l. 647
837 + 'audit_ids':
fields.many2many('mgmtsystem.audit','mgmtsystem_audit_nonconformity_rel','mgmtsystem_audit_id','mgmtsystem_action_id','Related
Audits'),
Just a remark, the
Analysis for the migration of mgmtsystem_nonconformity v0.1 to v0.2:
* effectiveness_* needs to be concatenated into evaluation_comments
* corrective_action_id and preventive_action_id needs to be merged in action_ids
--
Review: Needs Fixing
Can you solve the conflicts and resubmit?
--
https://code.launchpad.net/~openerp-community/openerp-mgmtsystem/nc-extend/+merge/139534
Your team OpenERP Community is subscribed to branch
lp:~openerp-community/openerp-mgmtsystem/nc-extend.
12 matches
Mail list logo
