[Openerp-community] [Merge] lp:~openerp-community/openobject-addons/stefan-therp_lp794450 into lp:openobject-addons

2011-06-15 Thread noreply
The proposal to merge lp:~openerp-community/openobject-addons/stefan-therp_lp794450 into lp:openobject-addons has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~openerp-community/openobject-addons/stefan-therp_lp794450/+merge/63831 -- https

Re: [Openerp-community] [Merge] lp:~openerp-community/openobject-addons/stefan-therp_lp794450 into lp:openobject-addons

2011-06-11 Thread Stefan Rijnhart (Therp)
On 10-06-11 23:46, Olivier Dony (OpenERP) wrote: One more thing occurs to me: since anonymous authentication basically means empty name and password, why not simplify the code and the patch by just removing the required flag on these fields? With clear tooltips on the fields, indicating that

Re: [Openerp-community] [Merge] lp:~openerp-community/openobject-addons/stefan-therp_lp794450 into lp:openobject-addons

2011-06-11 Thread Olivier Dony (OpenERP)
Review: Approve Excellent! Simple, minimalist, obvious: that's how I like patches served :-) -- https://code.launchpad.net/~openerp-community/openobject-addons/stefan-therp_lp794450/+merge/63831 Your team OpenERP Community is subscribed to branch

Re: [Openerp-community] [Merge] lp:~openerp-community/openobject-addons/stefan-therp_lp794450 into lp:openobject-addons

2011-06-10 Thread Olivier Dony (OpenERP)
Review: Needs Information Hello Stefan, Thanks for the nice merge proposal! Your changes make me wonder about a few things, listed below (disclaimer: I haven't tested this, and haven't read the full LDAP RFCs): - It was my understanding that LDAP defines a lot of authentication mechanism

Re: [Openerp-community] [Merge] lp:~openerp-community/openobject-addons/stefan-therp_lp794450 into lp:openobject-addons

2011-06-10 Thread Olivier Dony (OpenERP)
On 06/10/2011 10:57 PM, Stefan Rijnhart (Therp) wrote: LDAPv3 allows for unauthorized access when no bind is performed [1]. Although [2] describes how compatibility with other versions of the protocol can be improved by anonymous binding, the only candidate LDAP version 2 was retired in

[Openerp-community] [Merge] lp:~openerp-community/openobject-addons/stefan-therp_lp794450 into lp:openobject-addons

2011-06-08 Thread Stefan Rijnhart (Therp)
Stefan Rijnhart (Therp) has proposed merging lp:~openerp-community/openobject-addons/stefan-therp_lp794450 into lp:openobject-addons. Requested reviews: OpenERP Core Team (openerp) Related bugs: Bug #794450 in OpenERP Addons: [users_ldap] Wishlist: allow anonymous bind