Review: Approve
Excellent work, Stefan, looks good for merging.
Nice touch with the RFC reference in the docstrings. I didn't know the :rfc:
RST role yet :-)
Thanks a lot for another great contribution!
--
Review: Needs Fixing technical
Hello Stefan,
Wow, very impressive work, thanks!!
Here are a few comments (line numbers are within current diff):
- we're trying to unify out docstring formats (at least for new ones, as indeed
the old ones are still a mess), and trying to use RST docstrings, so
Review: Resubmit
On 06/20/2011 10:21 AM, Stefan Rijnhart (Therp) wrote:
I will therefore reuse this branch to suggest such a breakdown in
separate functions, and leave the added functionality for a separate
module of our own make.
Sounds great, thanks! :-)
Hi Olivier,
this branch now
On 17-06-11 15:51, Olivier Dony (OpenERP) wrote:
Review: Needs Information
Hello Stefan,
I agree with the idea of the bug report wishlist, I wonder, isn't this use
case sufficiently specific that it could be done in a separate module (e.g.
'ldap_import')?
Using the template user system
Review: Needs Information
Hello Stefan,
I agree with the idea of the bug report wishlist, I wonder, isn't this use
case sufficiently specific that it could be done in a separate module (e.g.
'ldap_import')?
Using the template user system alone is perhaps sufficient for the normal
case?
Now,
5 matches
Mail list logo
