Review: Approve
Thanks for having took care of that.
Seems good to me.
--
https://code.launchpad.net/~openerp-community/openobject-doc/7.0-community-review/+merge/186295
Your team OpenERP Community is subscribed to branch
lp:~openerp-community/openobject-doc/7.0-community-review.
Review: Approve
Thanks for the changes!
--
https://code.launchpad.net/~openerp-community/openobject-doc/7.0-community-review/+merge/186295
Your team OpenERP Community is subscribed to branch
lp:~openerp-community/openobject-doc/7.0-community-review.
Thanks for picking up the changes! I am afraid I forgot to mention another one:
in line 40, you mention that the license should be set to 'AGPL'. Maybe change
this to 'AGPL-3' to reflect that this is the exact entry in the module model's
selection field. Modules with a license literally set to
Review: Needs Fixing
Some comments if you have ideas how to improve them:
--
I find this sentence a bit obscure:
Avoid resubmitting a MP if not explicitly intended. The MP will lose history
of commit and that make more work for reviewers.
I would prefer but still I'm not sure:
Avoid to use
On 09/18/2013 04:04 PM, Stefan Rijnhart (Therp) wrote:
@Guewen: I still think the 3 working days is not very meaningful in a world
wide community, so I would prefer to go the other way and drop this
terminology in favour of 5 calendar days.
Good point. Anyway we should drop one or the other,
5 matches
Mail list logo
