Re: [Openerp-community] Central Project for POS

2013-10-24 Thread Fabien Pinckaers
On 10/23/2013 08:46 AM, Ana Juaristi wrote: +1 Nhomar. I think pos should remain as simple as is possible. I don't find any advantage having such functionality on it Guys, Did you notice that we just launched an indiegogo campaign to clean the current POS module of OpenERP?

Re: [Openerp-community] Proposal to improve communication and make more efficient the inclusion of new branches.

2013-10-24 Thread Fabien Pinckaers
IMHO, the emergency for OCB branches is to fix bugs that have been introduced in these branches. I am not sure if it's tracking the right branches, but it looks like the OCB branches are red on runbot: http://runbot.openerp.com/ocb.html Also, I would suggest every contribution to follow the

Re: [Openerp-community] Proposal to improve communication and make more efficient the inclusion of new branches.

2013-10-24 Thread Pedro Manuel Baeza Romero
Hi, Fabien, thanks for pointing out the problems with runbot. I'm not sure who added this branch and if they are correct, and I'm not very familiar with runbot, but I can check it. Let's wait if someone know about. Is there any documentation for runbot, naming conventions and so on? Regards.

Re: [Openerp-community] Proposal to improve communication and make more efficient the inclusion of new branches.

2013-10-24 Thread Pedro Manuel Baeza Romero
Hi again, Fabien, Thank you very much for the explanation, I will check it as soon as possible to try to see where are the problems. Runbot is one of my pendings ;) Regards. 2013/10/24 Fabien Pinckaers f...@openerp.com On 10/24/2013 06:43 PM, Pedro Manuel Baeza Romero wrote: Hi, Fabien,

Re: [Openerp-community] Proposal to improve communication and make more efficient the inclusion of new branches.

2013-10-24 Thread Fabien Pinckaers
On 10/24/2013 06:43 PM, Pedro Manuel Baeza Romero wrote: Hi, Fabien, thanks for pointing out the problems with runbot. I'm not sure who added this branch and if they are correct, and I'm not very familiar with runbot, but I can check it. Let's wait if someone know about. Is there any

Re: [Openerp-community] Proposal to improve communication and make more efficient the inclusion of new branches.

2013-10-24 Thread Pedro Manuel Baeza Romero
Hi, Ronald, although you are right about how outdated branches are, it doesn't mean that the tests are correct or not, as like Fabien says, they don't merge nothing that breaks tests, so something we have introduced has make this goes red, maybe even one year ago (well, not so far, because OCB

Re: [Openerp-community] Proposal to improve communication and make more efficient the inclusion of new branches.

2013-10-24 Thread Stefan Rijnhart
On 10/24/2013 06:36 PM, Fabien Pinckaers wrote: IMHO, the emergency for OCB branches is to fix bugs that have been introduced in these branches. I am not sure if it's tracking the right branches, but it looks like the OCB branches are red on runbot: http://runbot.openerp.com/ocb.html

Re: [Openerp-community] Fwd: Central Project for POS

2013-10-24 Thread Nhomar Hernández
Gustavo. We really appreciate your enthusiasm, but please, be sure everybody is talking about the same, this thread is the exact place to put Fabien's comment. What is the difference between Fabien Saying hey the base you are using will be improved help us, and somebody else saying Hey We made 3

[Openerp-community-reviewer] [Bug 1237832] Re: [6.1] [7.0] [trunk] [account_budget] doesn't recurse into analytic account's children

2013-10-24 Thread Amit Parik (OpenERP)
Hello Holger, The code look good for me too! But thats better If you provide the proper test case (Use case) for this example. So we can easily accepted your contribution! Thanks and waiting for your reply! ** Changed in: openobject-addons Status: New = Incomplete -- You received this

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/server-env-tools/7.0-report_xls into lp:server-env-tools

2013-10-24 Thread Alexandre Fayolle - camptocamp
Review: Needs Fixing code review, no test Could you take the time to bring this to the 7.0 community addons coding conventions. This includes: * not using the shortcut imports (things in the openerp namespace need to be imported from openerp) * using the from . import xxx for relative imports

Re: [Openerp-community-reviewer] [Merge] lp:~vauxoo/account-financial-report/7.0-report_webkit_afr-_data_dev-jorge into lp:account-financial-report

2013-10-24 Thread Frederic Clementi - Camptocamp.com
Review: Disapprove functionality duplication cf previous post. -- https://code.launchpad.net/~vauxoo/account-financial-report/7.0-report_webkit_afr-_data_dev-jorge/+merge/192050 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list:

[Openerp-community-reviewer] [Bug 1149267] Re: Purchase order lines can be linked to view analytical accounts

2013-10-24 Thread Chirag Dodiya(OpenERP)
Hello, It has been Fixed in https://code.launchpad.net/~openerp-dev/openobject- addons/trunk-bug-1149267-cod. revision-id: c...@tinyerp.com-20131024072928-mt8n488gqve3ktk8 revno: 8955. It will be available in trunk soon. ** Changed in: openobject-addons Status: In Progress = Fix

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/stock-logistic-report/adding_delivery_slip_7 into lp:stock-logistic-report

2013-10-24 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, test Thanks I tested and printed the report it looks fine -- https://code.launchpad.net/~agilebg/stock-logistic-report/adding_delivery_slip_7/+merge/185048 Your team Stock and Logistic Core Editors is requested to review the proposed merge of

Re: [Openerp-community-reviewer] [Merge] lp:~sbi/ocb-addons/7.0-opw-598926-dhr into lp:ocb-addons

2013-10-24 Thread Acsone
Review: Approve code review There is no reason an analytic account of type 'contract' would not allow a parent. -- https://code.launchpad.net/~sbi/ocb-addons/7.0-opw-598926-dhr/+merge/192532 Your team OpenERP Community Backports Team is requested to review the proposed merge of

Re: [Openerp-community-reviewer] [Merge] lp:~sbi/ocb-addons/7.0-opw-598926-dhr into lp:ocb-addons

2013-10-24 Thread Pedro Manuel Baeza
Review: Approve code review, no test LGTM -- https://code.launchpad.net/~sbi/ocb-addons/7.0-opw-598926-dhr/+merge/192532 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

[Openerp-community-reviewer] [Merge] lp:~sbi/ocb-addons/7.0-opw-598926-dhr into lp:ocb-addons

2013-10-24 Thread Acsone
Stéphane Bidoul (Acsone) has proposed merging lp:~sbi/ocb-addons/7.0-opw-598926-dhr into lp:ocb-addons. Requested reviews: Stéphane Bidoul (Acsone) (sbi): code review OpenERP Community Backports Team (ocb) Related bugs: Bug #1237512 in OpenERP Addons: No parent for contract or project

Re: [Openerp-community-reviewer] [Merge] lp:~alejandrosantana/ocb-server/6.1-fix-dbfilter-ignored-in-config-file into lp:ocb-server/6.1

2013-10-24 Thread Stefan Rijnhart (Therp)
Review: Approve Checked the code, and learned that as command line options are processed after the config file is read, having a 'default' parameter masks a value for the same key in the config file. The custom parameter 'my_default' is used as a default value for when the key does not occur

Re: [Openerp-community-reviewer] [Merge] lp:~alejandrosantana/ocb-server/7.0-fix-dbfilter-ignored-in-config-file into lp:ocb-server

2013-10-24 Thread Stefan Rijnhart (Therp)
Review: Approve As per my review on the 6.1 proposal -- https://code.launchpad.net/~alejandrosantana/ocb-server/7.0-fix-dbfilter-ignored-in-config-file/+merge/192444 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~ovnicraft/account-financial-tools/account-financial-tools-inv-voucher-constraints into lp:account-financial-tools

2013-10-24 Thread Cristian Salamea (Gnuthink)
Hi, in fact i consider a bug in openerp and constraint solve this problem: Make and invoice, click on pay all default values are loaded, user can chance amount value, error happens when you pay more, system silent resolve problem and send the difference to payable|receivable account, from

[Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-server/7.0-lp1194893-fix_tests into lp:ocb-server

2013-10-24 Thread Stefan Rijnhart (Therp)
Stefan Rijnhart (Therp) has proposed merging lp:~therp-nl/ocb-server/7.0-lp1194893-fix_tests into lp:ocb-server. Requested reviews: OpenERP Community Backports Team (ocb) Related bugs: Bug #1194893 in OpenERP Community Backports (Server): [7.0] Export creates xml id based on wrong table