Re: [Openerp-community-reviewer] [Openerp-community] New booking chart and web core modules

2013-11-07 Thread Joël Grand-Guillaume
Dear Community, First, I want to thank you Michel for trying to respect the community process and tools. I know it's a bit of work, but it's mandatory to maintain quality. I hope you had all your answer (making a fork and go through Merge Proposal when requesting an update, so the review can

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-add-stock_recompute_availability_on_force-afe into lp:stock-logistic-flows/7.0

2013-11-07 Thread Lionel Sausin - Numérigraphe
Thanks for this very interesting approach. Would it be feasible to base the logic on Stock Moves instead of Pickings? That would take into account the case a single move is forced available. Also, it would be interesting to consider a change in the source location as a forced assignation, but

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-port-product_historical_margin-xml-retab-yvr into lp:margin-analysis

2013-11-07 Thread David BEAL
I vote then for 2 spaces more readeable for new use case (kanban, futures cases) -- https://code.launchpad.net/~camptocamp/margin-analysis/7.0-port-product_historical_margin-xml-retab-yvr/+merge/190350 Your team Margin Analysis Core Editors is subscribed to branch lp:margin-analysis. --

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-add-stock_recompute_availability_on_force-afe into lp:stock-logistic-flows/7.0

2013-11-07 Thread Lionel Sausin - Numérigraphe
I could be useful to give users an indication that other assigned moves will be put to exceptions and need to be re-scheduled. Maybe a warning pop-up would help? -- https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-add-stock_recompute_availability_on_force-afe/+merge/187772 Your

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-reporting-engines/7.0-add-base_report_assembler-yvr into lp:openerp-reporting-engines

2013-11-07 Thread Yannick Vaucher @ Camptocamp
Yannick Vaucher @ Camptocamp has proposed merging lp:~camptocamp/openerp-reporting-engines/7.0-add-base_report_assembler-yvr into lp:openerp-reporting-engines. Requested reviews: OpenERP Community Reviewer (openerp-community-reviewer) For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-reporting-engines/7.0-add-base_report_assembler-yvr into lp:openerp-reporting-engines

2013-11-07 Thread Pedro Manuel Baeza
Review: Needs Information Hi, Yannick, I have tried to use your module, but I'm unable to test it, because I don't find the way to do it. Can you explain to me how to activate it? It would be desirable also to have these instructions on the module description. I have found also a terminology

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-reporting-engines/7.0-add-base_report_assembler-yvr into lp:openerp-reporting-engines

2013-11-07 Thread Yannick Vaucher @ Camptocamp
This module doesn't install configuration for report it is only the base. You can use account_invoice_assemble to test it: https://code.launchpad.net/~camptocamp/account-invoice-report/7.0-add-invoice_report_assemble-yvr --

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-reporting-engines/7.0-add-base_report_assembler-yvr into lp:openerp-reporting-engines

2013-11-07 Thread Yannick Vaucher @ Camptocamp
Assemblage has other meanings than only art purpose: http://dictionary.reference.com/browse/assemblage Assemblage seems more accurate than assembly to me. Assembly is more used for a group of person or a governement entity. --

[Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-tools/account_credit_control_portal_portal_lp1248906 into lp:account-financial-tools

2013-11-07 Thread Acsone
Stéphane Bidoul (Acsone) has proposed merging lp:~acsone-openerp/account-financial-tools/account_credit_control_portal_portal_lp1248906 into lp:account-financial-tools. Commit message: [FIX] fix bug in account_credit_control preventing portal user to view their invoices Requested reviews:

Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-tools/account_credit_control_portal_portal_lp1248906 into lp:account-financial-tools

2013-11-07 Thread Pedro Manuel Baeza
Review: Approve code review, no test LGTM. It's an ugly hack, but for now I don't see better solution. It's up to OpenERP to fix the way account.invoice is queried to avoid giving permissions to all the linked models. Regards. --

[Openerp-community-reviewer] [Merge] lp:~pedro.baeza/ocb-addons/6.1-bug-1061494 into lp:ocb-addons/6.1

2013-11-07 Thread Pedro Manuel Baeza
Pedro Manuel Baeza has proposed merging lp:~pedro.baeza/ocb-addons/6.1-bug-1061494 into lp:ocb-addons/6.1. Requested reviews: OpenERP Community Backports Team (ocb) Related bugs: Bug #1061494 in OpenERP Community Backports (Addons): Purchase order fiscal position

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/add-stock_split_picking-jge into lp:stock-logistic-flows/7.0

2013-11-07 Thread Nicolas Bessi - Camptocamp
Review: Approve no test, code review LGTM -- https://code.launchpad.net/~camptocamp/stock-logistic-flows/add-stock_split_picking-jge/+merge/193605 Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-flows/7.0. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-port-product_historical_margin-xml-retab-yvr into lp:margin-analysis

2013-11-07 Thread Bogdan Stanciu
2 spaces for reasons given above. thanks -- https://code.launchpad.net/~camptocamp/margin-analysis/7.0-port-product_historical_margin-xml-retab-yvr/+merge/190350 Your team Margin Analysis Core Editors is subscribed to branch lp:margin-analysis. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~the-clone-master/oemedical/oemedical into lp:oemedical

2013-11-07 Thread Mario Arias
Hi Vamsi, Yes, official branch is missing new import format, that will be fixed when this branch gets finally merged... As for Hospital Ward error, seems like it is an error on official branch, as we are not modifying hospital ward. We are currently focused on patient/physician/appointment

Re: [Openerp-community-reviewer] [Merge] lp:~the-clone-master/oemedical/oemedical into lp:oemedical

2013-11-07 Thread Federico Manuel Echeverri Choux - ( Vauxoo )
Hi, Mario Could you report a bug, explain it? Regards Federico Manuel Echeverri Choux Vauxoo - OpenERP's Gold Partner mobile: (+521) 444-1-400683 Tel: (+52) 444-8185539 skype: echeverrifm web: http://www.vauxoo.com twitter: @echeverrifm @vauxoo 2013/11/6 Vamsi Krishna Atluri

[Openerp-community-reviewer] [Merge] lp:~agilebg/ocb-addons/7.0-bug-1198250-elbati into lp:ocb-addons

2013-11-07 Thread Lorenzo Battistini - Agile BG
Lorenzo Battistini - Agile BG has proposed merging lp:~agilebg/ocb-addons/7.0-bug-1198250-elbati into lp:ocb-addons. Requested reviews: OpenERP Community Backports Team (ocb) Related bugs: Bug #1198250 in OpenERP Italia: l10n_it_partially_deductible_vat errore con iva totalmente

Re: [Openerp-community-reviewer] [Merge] lp:~elbati/ocb-addons/7.0_fix_1181291_elbati into lp:ocb-addons

2013-11-07 Thread Lorenzo Battistini - Agile BG
On 11/04/2013 09:49 AM, Stefan Rijnhart (Therp) wrote: @Maxime: while this would be OK on regular community projects, on OCB projects modifying the change at merge time could cause a conflict because the proposal on upstream does not contain such modifications. In order to prevent the

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-port-product_historical_margin-xml-retab-yvr into lp:margin-analysis

2013-11-07 Thread Ronald Portier
I also vote for 2 spaces. Also please: if there is more then one attribute, have each attribute on a new line. (Unfortunately OpenERP will break if you spread attributes over multiple lines, even where this would be perfectly logical, as with long domain expressions). Having each attribute on

Re: [Openerp-community-reviewer] [Merge] lp:~openerp-sage50/openerp-sage-50/6.1-exportsage50 into lp:openerp-sage-50

2013-11-07 Thread eh.dem
please fold lines at approx 80 cols There are some ' ' missing after end of sentence '.' (e.g line 213-214) line 399: don't use a dictionary as default argument to a method. Use None and test for None-ness inside if needed line 405: I suggest using a StringIO object rather that using

Re: [Openerp-community-reviewer] [Openerp-community] New booking chart and web core modules

2013-11-07 Thread Pedro Manuel Baeza Romero
You're very right, but I don't know if the team's name can be changed. Please, any of the OCA - Administrative Staffhttps://launchpad.net/~oca-administrative-staffteam, check if it can be changed and, if nobody has something against this, change the name as proposed. Regards. 2013/11/7 Daniel