tagname comes in as parameter, so it always will be defined.
Removing the line completely is to avoid side effects, as tagname is used as a
filter and we don't want that to be reset for the rest of the tree.
--
https://code.launchpad.net/~therp-nl/ocb-server/7.0_lp1188136/+merge/190671
Your
Review: Approve code review, no test
--
https://code.launchpad.net/~therp-nl/ocb-addons/lp1250053/+merge/197404
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
The proposal to merge
lp:~akretion-team/account-financial-tools/70-fiscal-position-check-vat into
lp:account-financial-tools has been updated.
Status: Work in progress = Merged
For more details, see:
Lorenzo Battistini - Agile BG has proposed merging
lp:~agilebg/account-invoice-report/adding_account_invoice_production_lot_7 into
lp:account-invoice-report.
Requested reviews:
Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903): code review
Alexis de Lattre (alexis-via)
Joël
Hello Maxime,
i have removed the file and added the author to the module.
Thanks.
--
https://code.launchpad.net/~agilebg/account-invoice-report/adding_account_invoice_production_lot_7/+merge/191230
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-invoice-report.
Review: Approve
--
https://code.launchpad.net/~agilebg/account-invoice-report/adding_account_invoice_production_lot_7/+merge/191230
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-invoice-report.
--
Mailing list:
Review: Needs Fixing
Dear Etienne,
I do not think it is a good idea to have one merge proposal for two changes
that are nearly totally unrelated. Except for the fact that they modify the
same file. Please put the change of the address selection in a separate
proposal.
As for the ordering
Alexis de Lattre has proposed merging
lp:~akretion-team/account-invoicing/70-add-invoice_fiscal_position_update into
lp:account-invoicing.
Requested reviews:
Account Core Editors (account-core-editors)
For more details, see:
Review: Approve
What a new year present!
Thanks for the changes, Mario. Let's move in this second stage and get the
third ASAP.
Regards.
--
https://code.launchpad.net/~the-clone-master/oemedical/oemedical_module_split_step_two/+merge/200239
Your team OEmedical Commiter is subscribed to branch
My only comment is that is there any reason to include the imports in the mako
template function. Can they not just be declared normally.
But otherwise I can confirm that this module does not work without this patch
on recent source. From memory you get an undeclared char ! traceback. I have
Review: Approve (code review, no test)
To the best of my knowledge a fiscal position is not dependent on a product and
nor is an invoice line. It would be nice if this dependency wasn't there but
recognise the difficulties in implementing consistently if an existing fiscal
position has
Review: Abstain
Alexis,
Very well that when a user changes the fiscal position, there is the
possibility to adapt the taxes and accounts.
Just wondering why the user should need to press a button. Should this not be
an onchange action on the fiscal position?
As for the code itself it mostly
Review: Approve (code review, no test)
LGTM!
--
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
Review: Approve
LGTM, mostly a style and documentation refresh. Just one meaningful change
which looks all good. Only comment is any reason for not importing
from openerp.tools import DEFAULT_SERVER_DATETIME_FORMAT as DT_FORMAT
--
** Tags added: crm todo
--
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is a bug assignee.
https://bugs.launchpad.net/bugs/1256392
Title:
my task form - for leads - missing lead_id
Status in OpenERP Community Backports (Addons):
15 matches
Mail list logo
