Re: [Openerp-community-reviewer] [Merge] lp:~gdgellatly/openerp-product-attributes/partner-pricelist-7 into lp:openerp-product-attributes

2014-01-23 Thread Graeme Gellatly
changed the name to something more appropriate -- https://code.launchpad.net/~gdgellatly/openerp-product-attributes/partner-pricelist-7/+merge/202985 Your team Product Core Editors is requested to review the proposed merge of lp:~gdgellatly/openerp-product-attributes/partner-pricelist-7 into lp:

[Openerp-community-reviewer] [Merge] lp:~gdgellatly/openerp-product-attributes/partner-pricelist-7 into lp:openerp-product-attributes

2014-01-23 Thread Graeme Gellatly
Graeme Gellatly has proposed merging lp:~gdgellatly/openerp-product-attributes/partner-pricelist-7 into lp:openerp-product-attributes. Requested reviews: Product Core Editors (product-core-editors) For more details, see: https://code.launchpad.net/~gdgellatly/openerp-product-attributes/partne

[Openerp-community-reviewer] openerp-community-reviewer joined openerp-program-core-editors

2014-01-23 Thread OpenERP Program Core Editors
Hello OpenERP Community Reviewer/Maintainer, Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) added OpenERP Community Reviewer/Maintainer (openerp-community-reviewer) (which you are a member of) as a member of OpenERP Program Core Editors (openerp-program-core-editors).

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/openerp-product-attributes/7.0-product-customer-code-extraction-improvements into lp:~akretion-team/openerp-product-attributes/7.0-product-customer

2014-01-23 Thread Lorenzo Battistini - Agile BG
Review: Approve code review -- https://code.launchpad.net/~agilebg/openerp-product-attributes/7.0-product-customer-code-extraction-improvements/+merge/202899 Your team Product Core Editors is requested to review the proposed merge of lp:~agilebg/openerp-product-attributes/7.0-product-customer-c

[Openerp-community-reviewer] [Merge] lp:~agilebg/openerp-product-attributes/7.0-product-customer-code-extraction-improvements into lp:~akretion-team/openerp-product-attributes/7.0-product-customer-cod

2014-01-23 Thread Nicola Malcontenti - Agile BG
Nicola Malcontenti - Agile BG has proposed merging lp:~agilebg/openerp-product-attributes/7.0-product-customer-code-extraction-improvements into lp:~akretion-team/openerp-product-attributes/7.0-product-customer-code-extraction. Requested reviews: Lorenzo Battistini - Agile BG (elbati) Produ

[Openerp-community-reviewer] [Merge] lp:~bruno-bottacini/report-print-send/7.0-report_webkit_custom_paper_size into lp:report-print-send

2014-01-23 Thread bruno bottacini
bruno bottacini has proposed merging lp:~bruno-bottacini/report-print-send/7.0-report_webkit_custom_paper_size into lp:report-print-send. Requested reviews: Report Printing and Sending Core Editors (report-print-send-core-editors) For more details, see: https://code.launchpad.net/~bruno-botta

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/stock-logistic-flows/adding_product_customer_code_picking into lp:stock-logistic-flows

2014-01-23 Thread Lorenzo Battistini - Agile BG
Review: Approve code review -- https://code.launchpad.net/~agilebg/stock-logistic-flows/adding_product_customer_code_picking/+merge/202472 Your team Stock and Logistic Core Editors is requested to review the proposed merge of lp:~agilebg/stock-logistic-flows/adding_product_customer_code_picking

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-invoicing/7.0-write-off-refund-date-mdh into lp:account-invoicing

2014-01-23 Thread Pedro Manuel Baeza
Review: Approve code review LGTM -- https://code.launchpad.net/~camptocamp/account-invoicing/7.0-write-off-refund-date-mdh/+merge/202888 Your team Account Core Editors is subscribed to branch lp:account-invoicing. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-invoicing/7.0-write-off-refund-date-mdh into lp:account-invoicing

2014-01-23 Thread Matthieu Dietrich @ camptocamp
Matthieu Dietrich @ camptocamp has proposed merging lp:~camptocamp/account-invoicing/7.0-write-off-refund-date-mdh into lp:account-invoicing. Commit message: [FIX] use refund's date in write-off Requested reviews: Account Core Editors (account-core-editors) For more details, see: https://cod

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/sale-wkfl/adding_product_customer_code_sale_7 into lp:sale-wkfl

2014-01-23 Thread Lorenzo Battistini - Agile BG
Review: Approve code review -- https://code.launchpad.net/~agilebg/sale-wkfl/adding_product_customer_code_sale_7/+merge/202468 Your team Sale Core Editors is requested to review the proposed merge of lp:~agilebg/sale-wkfl/adding_product_customer_code_sale_7 into lp:sale-wkfl. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoicing/adding_product_customer_code_invoice into lp:account-invoicing

2014-01-23 Thread Lorenzo Battistini - Agile BG
Review: Approve code review -- https://code.launchpad.net/~agilebg/account-invoicing/adding_product_customer_code_invoice/+merge/202469 Your team Account Core Editors is requested to review the proposed merge of lp:~agilebg/account-invoicing/adding_product_customer_code_invoice into lp:account

Re: [Openerp-community-reviewer] [Merge] lp:~grupocitec/ocb-addons/report_webkit_custom_paper_size into lp:ocb-addons

2014-01-23 Thread bruno bottacini
i made a module using the GrupoCITEC patch: lp:~bruno-bottacini/+junk/7.0-report_webkit_custom_paper_size -- https://code.launchpad.net/~grupocitec/ocb-addons/report_webkit_custom_paper_size/+merge/195418 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mail

Re: [Openerp-community-reviewer] [Merge] lp:~nemry/partner-contact-management/7.0-partner-firstname into lp:partner-contact-management

2014-01-23 Thread Laurent Mignon (Acsone)
Review: Approve code LGTM. Just a little note, at line 229, I would avoid to use the name 'fields' as a variable since it's also the name of the module probably the most used in openerp. And the cherry on the cake, a MP with automated tests!! -- https://code.launchpad.net/~nemry/partner-conta

[Openerp-community-reviewer] [Merge] lp:~acsone-openerp/stock-logistic-warehouse/7.0-port-stock_available_immediately into lp:stock-logistic-warehouse

2014-01-23 Thread Laurent Mignon (Acsone)
Laurent Mignon (Acsone) has proposed merging lp:~acsone-openerp/stock-logistic-warehouse/7.0-port-stock_available_immediately into lp:stock-logistic-warehouse. Requested reviews: Stock and Logistic Core Editors (stock-logistic-core-editors) For more details, see: https://code.launchpad.net/~a

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/7.0-improvement-cleaning-jge into lp:openerp-rma

2014-01-23 Thread Yannick Vaucher @ Camptocamp
Fixed the MP was in state Merged but not the branch I may have manually changed the MP status and forgot to change branch status -- https://code.launchpad.net/~camptocamp/openerp-rma/7.0-improvement-cleaning-jge/+merge/195387 Your team OpenERP RMA is subscribed to branch lp:openerp-rma. -- Mail

[Openerp-community-reviewer] [Bug 1271912] [NEW] Bug in module stock

2014-01-23 Thread Luis M . Gómez
Public bug reported: I have encountered a problem in the module stock in the branch ocb 6.1 file stock.py The problem that occurs is that when I put an order for a product that your UoM is Units , if I make the purchase in thousands eg , to generate the accounting entries me I find that putting

Re: [Openerp-community-reviewer] [Merge] lp:~eh-dem/partner-contact-management/remove_is_company into lp:partner-contact-management

2014-01-23 Thread Olivier Laurent (Acsone)
Review: Disapprove 1/ It is not redundant, it is a new feature allowing a company to be a child of another one. 2/ The "quality" of the inner form design is solved by https://code.launchpad.net/~nemry/partner-contact-management/7.0-partner-firstname/+merge/202713 -- https://code.launchpad.net/~

[Openerp-community-reviewer] [Merge] lp:~enlightx/openerp-icm/7.0_fix_1180743 into lp:openerp-icm

2014-01-23 Thread Davide Corio @ LS
Davide Corio @ LS has proposed merging lp:~enlightx/openerp-icm/7.0_fix_1180743 into lp:openerp-icm. Requested reviews: openerp-icm (openerp-icm) Related bugs: Bug #1180743 in openerp-icm: "Error creating invoice from settlement" https://bugs.launchpad.net/openerp-icm/+bug/1180743 For more

Re: [Openerp-community-reviewer] [Merge] lp:~enlightx/openerp-icm/7.0_fix_1180743 into lp:openerp-icm

2014-01-23 Thread Davide Corio @ LS
i didn't put attention to pep8 as the module would need a complete review :) -- https://code.launchpad.net/~enlightx/openerp-icm/7.0_fix_1180743/+merge/202804 Your team openerp-icm is requested to review the proposed merge of lp:~enlightx/openerp-icm/7.0_fix_1180743 into lp:openerp-icm. -- Mail