Review: Needs Information code review
This looks to me like someone calls _compute with the wrong precision. I think
http://bazaar.launchpad.net/~ocb/ocb-addons/7.0/view/head:/account/account.py#L2189
is the culprit. Shouldn't we rather fix it there instead of ignoring the
precision we get
Review: Needs Fixing code review
I agree completely.
Only 26ff should be setdefaults for the case somebody wants to init the new
copy with a tracking_id etc.
--
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-duplicate-picking-1281558/+merge/206925
Your team OpenERP Community Backports
Review: Approve code review
--
https://code.launchpad.net/~sbi/ocb-addons/7.0-bug-1281579-sbi/+merge/207378
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Only 26ff should be setdefaults for the case somebody wants to init the new
copy with a tracking_id etc.
I didn't thought of that and it is indeed really better.
--
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-duplicate-picking-1281558/+merge/206925
Your team OpenERP Community
The proposal to merge lp:~camptocamp/ocb-addons/ocb-7.0-fix_1281687-afe into
lp:ocb-addons has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1281687-afe/+merge/207116
--
Review: Approve code review
--
https://code.launchpad.net/~acsone-openerp/ocb-addons/7.0-bug-1278080-revert-8932/+merge/206805
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve code review
thanks!
--
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-duplicate-picking-1281558/+merge/206925
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to
Review: Disapprove
I agree with Pedro.
--
https://code.launchpad.net/~hugosantosred/ocb-addons/7.0-bug-1279249/+merge/206689
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
The proposal to merge lp:~acsone-openerp/ocb-addons/7.0-bug-1278080-revert-8932
into lp:ocb-addons has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~acsone-openerp/ocb-addons/7.0-bug-1278080-revert-8932/+merge/206805
--
The proposal to merge lp:~hugosantosred/ocb-addons/7.0-bug-1279249 into
lp:ocb-addons has been updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~hugosantosred/ocb-addons/7.0-bug-1279249/+merge/206689
--
Review: Approve code review
I took the liberty to link your branch with the bug report you mentioned.
--
https://code.launchpad.net/~savoirfairelinux-openerp/ocb-web/1279885/+merge/206233
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-web.
--
Mailing list:
Review: Needs Information
Hi Robert,
Thanks for the fix. Is there any bug report about this TypeError issue? Can you
link it or create it?
This to improve bug traceability.
Regards
--
https://code.launchpad.net/~rruebner/server-env-tools/7.0_fix_mass_editing/+merge/204711
Your team Server
Review: Approve code review, no tests
--
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-avoid_sale_lines_dropshipping_make_to_order_without_supplierinfos-rde/+merge/205623
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list:
Review: Approve code review, no tests
LGTM
--
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/1279118/+merge/205871
Your team Partner and Contact Core Editors is subscribed to branch
lp:partner-contact-management.
--
Mailing list:
The proposal to merge
lp:~savoirfairelinux-openerp/partner-contact-management/1279118 into
lp:partner-contact-management has been updated.
Status: Needs review = Approved
For more details, see:
The proposal to merge
lp:~savoirfairelinux-openerp/partner-contact-management/1279118 into
lp:partner-contact-management has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/1279118/+merge/205871
Nishant,
Even though it's not been accepted for inclusion as an OCA-reviewed module, I
think you should publish this on a Serpent's Launchpad project. Please post
here where you chose to place it.
--
https://code.launchpad.net/~serpentcs/server-env-tools/7.0-base_synchro/+merge/183102
Your
Review: Approve code review, no tests
LGTM
--
https://code.launchpad.net/~savoirfairelinux-openerp/ocb-web/1279885/+merge/206233
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-web.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve code review, no tests
Thanks
LGTM
--
https://code.launchpad.net/~camptocamp/product-kitting/6.1-backport_bom_stock_fixes-afe/+merge/205997
Your team Product Core Editors is subscribed to branch lp:product-kitting/6.1.
--
Mailing list:
The proposal to merge
lp:~camptocamp/product-kitting/6.1-backport_bom_stock_fixes-afe into
lp:product-kitting/6.1 has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~camptocamp/product-kitting/6.1-backport_bom_stock_fixes-afe/+merge/205997
The proposal to merge
lp:~camptocamp/product-kitting/6.1-backport_bom_stock_fixes-afe into
lp:product-kitting/6.1 has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~camptocamp/product-kitting/6.1-backport_bom_stock_fixes-afe/+merge/205997
--
Daniel, if I understand correctly, it is not the case that the module per se is
rejected for inclusion in a community project. This proposal is rejected in
favour of
https://code.launchpad.net/~gdgellatly/server-env-tools/base-synchro-7.0/+merge/200127,
and I hope we can count on Serpent to
The proposal to merge lp:~serpentcs/web-addons/web_search_alphabetic into
lp:web-addons has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~serpentcs/web-addons/web_search_alphabetic/+merge/202325
--
I didn't understand that, thanks for clarifying Stephan.
--
https://code.launchpad.net/~serpentcs/server-env-tools/7.0-base_synchro/+merge/183102
Your team Server Environment And Tools Core Editors is subscribed to branch
lp:server-env-tools.
--
Mailing list:
Ronald Portier (Therp) has proposed merging
lp:~therp-nl/account-invoice-report/account-invoice-report-7.0_delivery_address
into lp:account-invoice-report.
Requested reviews:
Account Core Editors (account-core-editors)
For more details, see:
Review: Approve code review, no tests
LGTM for the code
However, I don't think we have a proper branch to extend procurement.
Shall we create one?
--
https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/207638
Your team Sale Core Editors is subscribed to branch
The proposal to merge
lp:~akretion-team/stock-logistic-flows/70-picking-invoice-link-enhanced into
lp:stock-logistic-flows has been updated.
Status: Needs review = Approved
For more details, see:
Review: Approve code review, no tests
LGTM
--
https://code.launchpad.net/~akretion-team/stock-logistic-flows/70-picking-invoice-link-enhanced/+merge/205051
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-flows.
--
Mailing list:
The proposal to merge
lp:~akretion-team/stock-logistic-flows/70-picking-invoice-link-enhanced into
lp:stock-logistic-flows has been updated.
Status: Approved = Merged
For more details, see:
Review: Needs Fixing code review
#38 ... when selecting [what?] that ...
#89ff wouldn't the code be more clear if you did
my_new_partner_id = None
if partner_id:
my_new_partner_id =
result = super(my_new_partner_id or partner_id)
if my_new_partner_id != partner_id:
Review: Approve
The pot file looks good, no idea about the Spanish
--
https://code.launchpad.net/~pedro.baeza/account-invoicing/7.0-sale_order_partial_invoice-translation/+merge/205474
Your team Account Core Editors is subscribed to branch lp:account-invoicing.
--
Mailing list:
Review: Approve code review
But it looks like the MP mentioned above is stuck, so we should wait with
merging until that one is done.
--
https://code.launchpad.net/~agilebg/account-invoicing/adding_product_customer_code_invoice/+merge/202469
Your team Account Core Editors is subscribed to
Review: Approve code review
--
https://code.launchpad.net/~camptocamp/account-invoicing/7.0-update-invoice-view-mdh/+merge/196835
Your team Account Core Editors is subscribed to branch lp:account-invoicing.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve code review
--
https://code.launchpad.net/~camptocamp/account-invoicing/7.0-write-off-refund-date-mdh/+merge/202888
Your team Account Core Editors is subscribed to branch lp:account-invoicing.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
The proposal to merge
lp:~camptocamp/account-invoicing/7.0-update-invoice-view-mdh into
lp:account-invoicing has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~camptocamp/account-invoicing/7.0-update-invoice-view-mdh/+merge/196835
--
Review: Approve code review
Good!
One small remark: why is the function _all_invoice_tax_line_computed not in the
invoice class?
To show that it does not use any class or instance data, we can make it a
@staticmethod.
I do not consider this a significant problem though, so I approve in any
The proposal to merge
lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch-user-optional into
lp:stock-logistic-flows has been updated.
Status: Approved = Merged
For more details, see:
The proposal to merge
lp:~camptocamp/account-invoicing/7.0-add-swedish_rounding-yvr into
lp:account-invoicing has been updated.
Status: Needs review = Work in progress
For more details, see:
https://code.launchpad.net/~camptocamp/account-invoicing/7.0-add-swedish_rounding-yvr/+merge/201598
There is no bug report since imho the 'Description of Change' is clear :
General Ledger should include accounting move lines in close opening
periods.
Without this fix, you don't get a complete history of all moves in a certain
fiscal year.
Regards,
Luc
www.noviat.com
Rusatiralaan 1, 1083
I have only copied the solution provided by OpenERP S. A. on trunk, testing
that it's working on v7, but without checking the source of the problem. Do you
think it can be more generic patching what you say?
Regards.
--
Holger, thanks for the review!
I repaired the mangled module description and simplified the code. The
complexity was on purpose to try and restart the inheritance chain with the new
partner, but that would not have worked anyway as onchange overrides typically
would inject their changes on the
Moved _all_invoice_tax_line_computed inside invoice class
--
https://code.launchpad.net/~camptocamp/account-invoicing/7.0-add-swedish_rounding-yvr/+merge/201598
Your team Account Core Editors is subscribed to branch lp:account-invoicing.
--
Mailing list:
Review: Approve code review
Thanks Yannick!
--
https://code.launchpad.net/~camptocamp/account-invoicing/7.0-add-swedish_rounding-yvr/+merge/201598
Your team Account Core Editors is subscribed to branch lp:account-invoicing.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Yannick Vaucher @ Camptocamp has proposed merging
lp:~camptocamp/account-invoicing/7.0-add-swedish_rounding-yvr into
lp:account-invoicing.
Requested reviews:
Leonardo Pistone - camptocamp (lpistone): code review
Yannick Vaucher @ Camptocamp (yvaucher-c2c)
Frederic Clementi - Camptocamp
Review: Approve code review
--
https://code.launchpad.net/~therp-nl/account-invoicing/7.0-add_account_invoice_partner/+merge/180694
Your team Account Core Editors is subscribed to branch lp:account-invoicing.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Merged Guewen's work
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_dispatch-output-file-yvr/+merge/202444
Your team Stock and Logistic Core Editors is requested to review the proposed
merge of
Yannick Vaucher @ Camptocamp has proposed merging
lp:~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_dispatch-output-file-yvr
into lp:carriers-deliveries with
lp:~camptocamp/carriers-deliveries/7.0-add-delivery_carrier_label_dispatch-yvr
as a prerequisite.
Requested reviews:
Joël Grand-Guillaume @ camptocamp has proposed merging
lp:~camptocamp/stock-logistic-flows/add-variant-dispach-report-jge into
lp:stock-logistic-flows.
Commit message:
[IMP] Add the variant in the dispatch report
Requested reviews:
Stock and Logistic Core Editors
Review: Approve code review, no tests
LGTM
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-base_delivery_carrier_label-tracking_ids/+merge/207199
Your team Stock and Logistic Core Editors is subscribed to branch
lp:carriers-deliveries.
--
Mailing list:
The proposal to merge
lp:~camptocamp/openerp-reporting-engines/7.0-add-base_report_assembler-yvr into
lp:openerp-reporting-engines has been updated.
Status: Needs review = Merged
For more details, see:
The proposal to merge
lp:~camptocamp/account-invoicing/7.0-add-swedish_rounding-yvr into
lp:account-invoicing has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~camptocamp/account-invoicing/7.0-add-swedish_rounding-yvr/+merge/201598
--
Review: Needs Information
Description was completely removed is that on purpose ?
--
https://code.launchpad.net/~echeverrifm/oemedical/oemedical_socioeconomics/+merge/205523
Your team OEmedical Commiter is subscribed to branch lp:oemedical.
--
Mailing list:
Merged Guewen's improvements with tracking_ids
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-add-delivery_carrier_label_postlogistics_shop_logo-yvr/+merge/196859
Your team Stock and Logistic Core Editors is subscribed to branch
lp:carriers-deliveries.
--
Mailing list:
Review: Approve code review, no tests
LGTM Thanks !
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_postlogistics-tracking_ids/+merge/207202
Your team Stock and Logistic Core Editors is subscribed to branch
lp:carriers-deliveries.
--
Mailing list:
Review: Approve code review, no tests
LGTM
--
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-duplicate-picking-1281558/+merge/206925
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post
Description was completely removed is that on purpose ?
Hello Yannick
Sorry i forgot description, because this module have old description of
oemedical.
But i now put this description module for oemedical socioeconomics
Regrads and thank for your time
--
Georges Racinet has proposed merging lp:~anybox/ocb-server/7.0-test-report into
lp:ocb-server.
Requested reviews:
OpenERP Community Backports Team (ocb)
For more details, see:
https://code.launchpad.net/~anybox/ocb-server/7.0-test-report/+merge/207978
The core of OpenERP already has a system
The proposal to merge lp:~echeverrifm/oemedical/7.0_oemedical_emr into
lp:oemedical has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~echeverrifm/oemedical/7.0_oemedical_emr/+merge/204149
--
Review: Needs Fixing
152 +'views/oemedical_socioeconomics_view.xml', # view has errors,
please correct before enabling
You may want to remove the comment ?
Otherwise looks good.
--
https://code.launchpad.net/~echeverrifm/oemedical/oemedical_socioeconomics/+merge/205523
Your
152 +'views/oemedical_socioeconomics_view.xml', # view has errors,
please correct before enabling
You may want to remove the comment ?
Otherwise looks good.
Hello Yannick
i removed that
Regards
--
Hi Georges,
thanks, this is a great help in identifying failed tests! I'd love to have this
available. However, the OCB-policy dictates that this patch would also be
proposed to upstream OpenERP. Do you have such a proposal ready? To be able to
quickly identify the status of this change in all
Sandy Carter (http://www.savoirfairelinux.com) has proposed merging
lp:~savoirfairelinux-openerp/ocb-addons/7.0_mail_thread_translate_bug1262000
into lp:ocb-addons.
Requested reviews:
OpenERP Community Backports Team (ocb)
For more details, see:
Review: Approve code review
Very good catch! I have experienced this trouble in my installations.
Please attach the branch to the bug report and track the status for the OCB
branch.
Regards.
--
Review: Approve
--
https://code.launchpad.net/~pedro.baeza/ocb-addons/7.0-fix-1258237/+merge/197939
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Needs Information
@Pedro, I think Guewen means: proposed to trunk, not 7.0. This should not be
limited by the bug policy. Or does the issue not apply to trunk anymore?
--
https://code.launchpad.net/~pedro.baeza/ocb-addons/7.0-fix-1258237/+merge/197939
Your team OpenERP Community
Review: Needs Fixing
Hi Sandy, thanks for picking this up.
I'm afraid that your solution does not work in every case. Calling _() on a
variable does not really make sense as it will be a matter of coincidence if
the translation can be found. You see, internally this call gets translated to
Hi Stefan,
thanks for kindly explaining policy ! I started indeed developing the change in
OCB context (where it is useful now).
--
https://code.launchpad.net/~anybox/ocb-server/7.0-test-report/+merge/207978
Your team OpenERP Community Backports Team is requested to review the proposed
merge
but I believe even in runbot, that could prove useful (don't know what's in
current trunk, though)
--
https://code.launchpad.net/~anybox/ocb-server/7.0-test-report/+merge/207978
Your team OpenERP Community Backports Team is requested to review the proposed
merge of
The proposal to merge
lp:~savoirfairelinux-openerp/knowledge-addons/document_multiple_records into
lp:knowledge-addons/7.0 has been updated.
Status: Needs review = Work in progress
For more details, see:
Alexis de Lattre has proposed merging
lp:~akretion-team/ocb-addons/70-addons-fix-payment-acls-bank into lp:ocb-addons.
Requested reviews:
OpenERP Community Backports Team (ocb)
For more details, see:
Review: Needs Fixing
Hello Alexis,
I would gladly approve the merge if:
1) it was linked to a bug report
2) there would be a MP for the official addons too as OCB policy requires
That looks like a horrible bureaucracy and at some point it is, but I think we
should enforce OCB policy until
Well, I put the corresponding patch in the bug report, because OpenERP never
use foreign branches for MPs, and they get older very soon, so I think that
it's the best way to get the fix patched on trunk/v7, don't you think?
Regards.
--
Review: Needs Fixing
Oh I see, there is a patch. Still, I have the impression that MPs are the
preferred format and it's an explicit requirement of OCB that such a branch be
submitted to upstream OpenERP. Setting to 'Needs fixing' for that reason.
And they do merge branches sometimes, just not
Hi, Stefan, I have made then two MPs: one for v7 and another for trunk.
Regards.
--
https://code.launchpad.net/~pedro.baeza/ocb-addons/7.0-fix-1258237/+merge/197939
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list:
Review: Abstain
@Yannick, the odd view changes have been removed and the proposed modules have
been reduced into a single, simpler one.
--
You have been requested to review the proposed merge of
lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_passport_passport_partner
into lp:partner-contact-management.
For more details, see:
You have been requested to review the proposed merge of
lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_passport_passport_partner
into lp:partner-contact-management.
For more details, see:
@Stefan, I am not sure I understand you.
I have been using this patch on my own projects and it will always translate
the created object as long as _() has been put around the _description of the
model and the required translation has been exported.
as for stock_picking_in in stock/stock.py,
as long as _() has been put around the _description of the model and the
required translation has been exported
Yes, you could put it this way because this requirement is not fulfilled
for any model by default. So your solution does not work for anyone
else, except by chance. That is why I
as long as _() has been put around the _description of the model and the
required translation has been exported
Or you make it a part of the patch that this be updated in every model.
You should discuss with Olivier Dony cause this would solve the problem
in other places as well.
--
80 matches
Mail list logo
