Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk into lp:ocb-server

Not sure what you mean there. Do you think my suggestions are not a good idea? -- https://code.launchpad.net/~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk/+merge/212736 Your team OpenERP Community Backports is subscribed to branch lp:ocb-server. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-invoice-report/account-invoice-webkit-line-description-vre into lp:account-invoice-report

Review: Approve code review LGTM, Romain -- https://code.launchpad.net/~camptocamp/account-invoice-report/account-invoice-webkit-line-description-vre/+merge/217929 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list:

[Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-product_get_cost_field-standard_price-1308584 into lp:margin-analysis

The proposal to merge lp:~camptocamp/margin-analysis/7.0-product_get_cost_field-standard_price-1308584 into lp:margin-analysis has been updated. Status: Needs review = Approved For more details, see:

[Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-product_get_cost_field-standard_price-1308584 into lp:margin-analysis

The proposal to merge lp:~camptocamp/margin-analysis/7.0-product_get_cost_field-standard_price-1308584 into lp:margin-analysis has been updated. Status: Approved = Merged For more details, see:

[Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-product_price_history-index-1301847 into lp:margin-analysis

The proposal to merge lp:~camptocamp/margin-analysis/7.0-product_price_history-index-1301847 into lp:margin-analysis has been updated. Status: Needs review = Merged For more details, see:

[Openerp-community-reviewer] [Merge] lp:~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls into lp:account-financial-report/6.1

The proposal to merge lp:~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls into lp:account-financial-report/6.1 has been updated. Status: Needs review = Approved For more details, see:

[Openerp-community-reviewer] [Merge] lp:~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls into lp:account-financial-report/6.1

The proposal to merge lp:~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls into lp:account-financial-report/6.1 has been updated. Status: Approved = Merged For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/server-env-tools/7.0-monitoring into lp:server-env-tools

On load stress, I was able to produce SERIALIZATION_FAILURE errors, but not sure if this is rather an oe-server performance limitaion instead of a problem specific of the module. (I opened several browser windows and loaded in all of them a page that takes several seconds). 2014-05-02

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs into lp:account-invoice-report

Review: Disapprove Bug #1208389: [7.0] invoice_webkit - invoice line does not print line description Is better fixed here: https://code.launchpad.net/~camptocamp/account-invoice-report/account-invoice-webkit-line-description-vre/+merge/217929 I disapprove as it still replace css --

[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-invoice-report/account-invoice-webkit-line-description-vre into lp:account-invoice-report

The proposal to merge lp:~camptocamp/account-invoice-report/account-invoice-webkit-line-description-vre into lp:account-invoice-report has been updated. Status: Approved = Merged For more details, see:

[Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs into lp:account-invoice-report

The proposal to merge lp:~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs into lp:account-invoice-report has been updated. Status: Needs review = Work in progress For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs into lp:account-invoice-report

Have you tried word-wrap: break-word and table-layout: fixed ? I merged Vincent MP so it seems the last bug to resolve is https://bugs.launchpad.net/account-invoice-report/+bug/1277024 --

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs into lp:account-invoice-report

Yannick wrote: Have you tried word-wrap: break-word and table-layout: fixed ? Hi Yannick, yes I tried, but it doesn't seem to work. I merged Vincent MP Thank you. so it seems the last bug to resolve is https://bugs.launchpad.net/account-invoice-report/+bug/1277024 Yes, it's right. --

[Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-barcode/7.0-product_multi_ean-migr into lp:stock-logistic-barcode

The proposal to merge lp:~camptocamp/stock-logistic-barcode/7.0-product_multi_ean-migr into lp:stock-logistic-barcode has been updated. Status: Needs review = Approved For more details, see:

[Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-barcode/7.0-product_multi_ean-migr into lp:stock-logistic-barcode

The proposal to merge lp:~camptocamp/stock-logistic-barcode/7.0-product_multi_ean-migr into lp:stock-logistic-barcode has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~camptocamp/stock-logistic-barcode/7.0-product_multi_ean-migr/+merge/209661 --

[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/credit_control_report_improvement_vre into lp:account-financial-tools

The proposal to merge lp:~camptocamp/account-financial-tools/credit_control_report_improvement_vre into lp:account-financial-tools has been updated. Status: Needs review = Rejected For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix into lp:account-financial-tools

Review: Needs Fixing Hello Pedro, There are conflicts in translations ll.223-231 ll.244-257 ll.265-273 ll.298-305 ll.381-392 Can you resolve them ? -- https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix/+merge/214832 Your team OpenERP Community

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-stock-picking-duplication-fix-regression-from-v7port-and-add-a-test_rde into lp:carriers-deliveries

Review: Approve code review, no test LGTM -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-stock-picking-duplication-fix-regression-from-v7port-and-add-a-test_rde/+merge/212878 Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries. --

[Openerp-community-reviewer] [Bug 1315367] [NEW] [6.1] Project task work creates timesheet entry containing 'False' instead of empty label

Public bug reported: When the user registers task work without a summary, the timesheet line contains the python term 'False' ** Affects: ocb-addons Importance: Undecided Status: New ** Affects: openobject-addons Importance: Undecided Status: New ** Affects:

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-consolidation/7.0-bug-1296740-elbati into lp:account-consolidation/7.0

Review: Needs Fixing centralized is defined in account-financial-report/account_financial_report_webkit/account.py It seams there is no dependancy on it and I think no dependancy should be there. But simply removing it will break compatibility with account_financial_report_webkit However, a

[Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/7.0-lp1315367-task_work_timesheet_lines_False into lp:ocb-addons

Stefan Rijnhart (Therp) has proposed merging lp:~therp-nl/ocb-addons/7.0-lp1315367-task_work_timesheet_lines_False into lp:ocb-addons. Requested reviews: OpenERP Community Backports (ocb) Related bugs: Bug #1315367 in OpenERP Community Backports (Addons): [6.1] Project task work creates

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/sale-wkfl/sale_dropshipping_translation into lp:sale-wkfl

Review: Needs Fixing french Hello Philippe, I found some errors and few sentences that could be improved in french translations, could you replace them? Thanks: l36 s/Caché/Cacher la/ l42 s/Est-ce que cette commande est lié à un bon de commande? Comment cela sera livré et facturé

[Openerp-community-reviewer] [Merge] lp:hr-timesheet/6.1 into lp:hr-timesheet

The proposal to merge lp:hr-timesheet/6.1 into lp:hr-timesheet has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~hr-core-editors/hr-timesheet/6.1/+merge/213140 -- https://code.launchpad.net/~hr-core-editors/hr-timesheet/6.1/+merge/213140

Re: [Openerp-community-reviewer] [Merge] lp:hr-timesheet/6.1 into lp:hr-timesheet

Review: Disapprove Rejected as it seems to be a wrong move. -- https://code.launchpad.net/~hr-core-editors/hr-timesheet/6.1/+merge/213140 Your team HR Core Editors is subscribed to branch lp:hr-timesheet/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7 into lp:carriers-deliveries

Review: Approve code review, no test Thanks for this module. Having an additionnal delivery cost is a pain, your module make it optional it's ok for me. LGTM -- https://code.launchpad.net/~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7/+merge/213867 Your team Stock and

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7 into lp:carriers-deliveries

Thanks Sébastien for your approval. -- https://code.launchpad.net/~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7/+merge/213867 Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-tools/7.0-account_chart_update-enhanced into lp:account-financial-tools

Review: Needs Fixing code review, no test Hello thanks, I see a lot of improvements here. My remarks: Why renaming tax_template to tax_templ? Readability counts. And it makes me wish I could auto complete those while reading the code. It seams strange to me that you removed required=True of

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk into lp:ocb-server

Sorry. I didn't explain very well. I have MPs for OCB, 7.0 and trunk for this bug. OE trunk doesn't have both MP (server and web) because it too much, therefore web doesn't have an MP. As for server, commits up to r5297 ([FIX] Fixed instance of ValidateError not being translated) have been

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/partner-contact-management/partner_firstname_vre_firstname_crm into lp:partner-contact-management

Review: Needs Fixing pep8 crm_firstname/__openerp__.py:22:1: O603 Manifest license key is missing crm_firstname/__openerp__.py:35:19: E231 missing whitespace after ',' crm_firstname/__openerp__.py:37:11: E126 continuation line over-indented for hanging indent crm_firstname/__openerp__.py:39:11:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-mrp-reports/7.0-add_serpentcs_mrp_repair_webkit-afe into lp:openerp-mrp-reports

Review: Abstain -- https://code.launchpad.net/~camptocamp/openerp-mrp-reports/7.0-add_serpentcs_mrp_repair_webkit-afe/+merge/209044 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:openerp-mrp-reports. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-invoice-report/7.0-translation-templates into lp:account-invoice-report

Review: Approve code review, no test LGTM -- https://code.launchpad.net/~pedro.baeza/account-invoice-report/7.0-translation-templates/+merge/202156 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/partner_category_description into lp:partner-contact-management

Review: Needs Information Was this proposed in openobject-server for trunk? It seams a good it to be able to give details about a category. -- https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner_category_description/+merge/213697 Your team Partner and Contact

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/sale-wkfl/7.0-add-sale_group into lp:sale-wkfl

.pot added, is that OK for you now? as a reminder, once we do this merge, we will also be able to proceed with that other one: https://code.launchpad.net/~akretion-team/sale-wkfl/7.0-add-sale_import_lines/+merge/201021 --

Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-invoice-report/7.0-translation-templates into lp:account-invoice-report

Review: Approve LGTM -- https://code.launchpad.net/~pedro.baeza/account-invoice-report/7.0-translation-templates/+merge/202156 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/sale-wkfl/70-add-sale_order_revision into lp:sale-wkfl

Hello, I did the 'sale_order_revision/i18n/purchase_order_revision.pot' = 'sale_order_revision/i18n/sale_order_revision.pot' rename as requested by Lorenzo. I also fixed and enabled the tests. Is it ok for you now? --

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/6.1-lp1315367-task_work_timesheet_lines_False into lp:ocb-addons/6.1

Review: Approve LGTM -- https://code.launchpad.net/~therp-nl/ocb-addons/6.1-lp1315367-task_work_timesheet_lines_False/+merge/218060 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :