Thanks a lot to you all!
On Sun, May 4, 2014 at 6:50 PM, Sandy Carter
sandy.car...@savoirfairelinux.com wrote:
+1 we can always use active contributors as reviewers!
--
Sandy
- Original Message -
From: Stefan Rijnhart ste...@therp.nl
To:
The proposal to merge
lp:~numerigraphe-team/ocb-addons/7.0-inventory-dummy-moves-test into
lp:ocb-addons has been updated.
Status: Needs review = Work in progress
For more details, see:
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-inventory-dummy-moves-test/+merge/215453
--
Stefan you're probably right, I'll look into this and let you know.
--
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-inventory-dummy-moves-test/+merge/215453
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list:
Holger, using search with an offset is cooler when you expect to never load the
end of the list (like displaying it for users).
In the case here, it would only trade python-server memory consumption for SQL
round-trips. Is it worth?
--
Thanks Stefan for the bug report and the excellent fix, as usual!
Your patch was merged in 7.0 at revision 10031 rev-id
o...@openerp.com-20140505075129-hv4evrdw5v7crtmw.
** Changed in: openobject-addons
Importance: Undecided = Low
** Changed in: openobject-addons
Status: New = Fix
The proposal to merge lp:~camptocamp/ocb-web/7.0-fix_1190236_opw-595981-msh
into lp:ocb-web has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~camptocamp/ocb-web/7.0-fix_1190236_opw-595981-msh/+merge/216664
--
Review: Approve code review
--
https://code.launchpad.net/~therp-nl/web-addons/7.0-add_percentage_widget/+merge/217602
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve code review
LGTM.
Thanks.
--
https://code.launchpad.net/~alhashash/ocb-addons/7.0-alhashash-bug1179705/+merge/217681
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
I have added again series in OCB project, because a patch has been
proposed for 7.0.
Regards.
** Also affects: ocb-addons/6.1
Importance: Undecided
Status: New
** Also affects: ocb-addons/7.0
Importance: Undecided
Status: New
** Changed in: ocb-addons/7.0
Status: New
The proposal to merge lp:~pedro.baeza/ocb-addons/fix-lp_1254631 into
lp:ocb-addons has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~pedro.baeza/ocb-addons/fix-lp_1254631/+merge/216728
--
The proposal to merge lp:~scigghia/ocb-addons/7.0_prop_supplier_invoice_number
into lp:ocb-addons has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~scigghia/ocb-addons/7.0_prop_supplier_invoice_number/+merge/208934
--
The proposal to merge
lp:~camptocamp/ocb-addons/6.1-fix_1311004_account_move_line_index-afe into
lp:ocb-addons/6.1 has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~camptocamp/ocb-addons/6.1-fix_1311004_account_move_line_index-afe/+merge/216820
You're right, it's not. But still I suggest doing the stepping part not by hand
but as a parameter for range()
--
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fill-inventory-OOM/+merge/217049
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
The proposal to merge
lp:~numerigraphe-team/ocb-addons/7.0-inventory-lines-sorted into lp:ocb-addons
has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-inventory-lines-sorted/+merge/210467
--
Review: Approve code review
--
https://code.launchpad.net/~therp-nl/ocb-addons/7.0-lp1315367-task_work_timesheet_lines_False/+merge/218059
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to
Review: Approve code review
LGTM.
Regards.
--
https://code.launchpad.net/~therp-nl/ocb-addons/7.0-lp1315367-task_work_timesheet_lines_False/+merge/218059
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list:
Review: Approve code review
--
https://code.launchpad.net/~pedro.baeza/ocb-addons/7.0-lp1122155/+merge/217629
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve code review
--
https://code.launchpad.net/~alhashash/ocb-addons/7.0-alhashash-bug1179705/+merge/217681
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
The proposal to merge lp:~alhashash/ocb-addons/7.0-alhashash-bug1179705 into
lp:ocb-addons has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~alhashash/ocb-addons/7.0-alhashash-bug1179705/+merge/217681
--
Review: Approve code review
--
https://code.launchpad.net/~therp-nl/ocb-addons/6.1-lp1315367-task_work_timesheet_lines_False/+merge/218060
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post
The proposal to merge
lp:~therp-nl/ocb-addons/6.1-lp1315367-task_work_timesheet_lines_False into
lp:ocb-addons/6.1 has been updated.
Status: Needs review = Approved
For more details, see:
Review: Approve code review
Thanks
--
https://code.launchpad.net/~akretion-team/sale-wkfl/70-add-sale_order_revision/+merge/202735
Your team Sale Core Editors is requested to review the proposed merge of
lp:~akretion-team/sale-wkfl/70-add-sale_order_revision into lp:sale-wkfl.
--
Mailing
I have merge last changes of the repository to solve conflicts.
Regards.
--
https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix/+merge/214832
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Review: Needs Information
Maybe the wildcard could be made configurable.
This way, Spanish accountants could use a dot (.), as they are so used to. And
in other countries it could be configured to be other character, like asterisk
(*) or any other.
Also, the pattern to search could be
Review: Needs Fixing
There are some indentation to fix in account_renumber/wizard/wizard_renumber.py
to be PEP8 compliant.
--
https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix/+merge/214832
Your team OpenERP Community Reviewer/Maintainer is subscribed
Personally, I have been practicing accounting in UK, France and Switzerland and
I have never used a search based on dots. So +1 for something more configurable
(hence, more generic and potentially used by more people).
If not possible, like Stefan said, we should give a more specific name (like
Review: Needs Fixing
except_osv is depricated, please use except_orm
l.213 missing context propagation
l.276 POSSIBLE SQL INJECTION with filenames which contain quotes, please use
appropriate code escapes from the library (don't write your own)
No Unittests
Flake8:
cmis/cmis_model.py:25:1: F401
Review: Needs Fixing
This MP should have a prerequisite branch:
lp:~savoirfairelinux-openerp/knowledge-addons/cmis
l.301 missing context propagation
No unittests
Flake8
cmis_write/ir_attachment.py:73:45: W291 trailing whitespace
cmis_write/ir_attachment.py:74:53: W291 trailing whitespace
Review: Needs Fixing
Missing security model for cmis.backend
--
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis/+merge/212258
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:knowledge-addons/7.0.
--
Mailing list:
Review: Needs Fixing
l.377 osv.TransientModel should be orm.TransientModel
l.504 POSSIBLE SQL INJECTION: (with quotes in a filename) please use the
library's code escapes, don't write your own
Flake8:
cmis_read/wizard/document_wizard.py:102:9: F841 local variable 'file_name' is
assigned to but
@scaerter: thanks for comments
--
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_read/+merge/212260
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:knowledge-addons/7.0.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
@scarter: thanks for comments
--
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_write/+merge/213940
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:knowledge-addons/7.0.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Review: Needs Fixing
openerp.modules.loading: The transient model ir.attachment.dms
(ir.attachment.dms) should not have explicit access rules!
--
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_read/+merge/212260
Your team OpenERP Community Reviewer/Maintainer is
Review: Needs Information code review and test
Hi, Raphaël, thanks for the contribution. It works like intended, and it's very
useful. I think it can be even more useful if cancelled orders with a revision
are hidden by default from quotations screens, don't you think?
Regards.
--
Hi, Yannick,
I have done the requested changes.
Regards.
--
https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix/+merge/214832
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list:
Review: Approve code review
Hi, Jordi,
Thank you very much for the changes and the patience.
Regards.
--
https://code.launchpad.net/~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055/+merge/212286
Your team Department Core Editors is subscribed to branch lp:department-mgmt.
--
l.504 : it is a cmis query
--
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_read/+merge/212260
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:knowledge-addons/7.0.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post
@Sandy Carter: fixing your comments
--
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis/+merge/212258
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:knowledge-addons/7.0.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Injection is still possible. It is an entry point for malicious queries or
accidental breaks.
--
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_read/+merge/212260
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:knowledge-addons/7.0.
--
39 matches
Mail list logo
