Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep into lp:purchase-wkfl

2014-05-07 Thread Leonardo Pistone - camptocamp
highlights from the similar MP on trunk: Olivier Dony said they will merge on the core in trunk but not in 7.0, so this extra addon for 7.0 makes sense. Olivier made some remarks I agree with, they'll be fixed here as well ASAP. thanks! --

Re: [Openerp-community-reviewer] [Merge] lp:~ajite/web-addons/7.0-web-addons-add-0001 into lp:web-addons

2014-05-07 Thread Augustin Cisterne-Kaas - www.elico-corp.com
Yes, Exactly ! Thanks for answering :) -- https://code.launchpad.net/~ajite/web-addons/7.0-web-addons-add-0001/+merge/210620 Your team Web-Addons Core Editors is subscribed to branch lp:web-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into lp:purchase-wkfl

2014-05-07 Thread Lorenzo Battistini - Agile BG
Review: Approve code review -- https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~lmi/ocb-addons/7.0-opw-596916-rgo into lp:ocb-addons

2014-05-07 Thread Stefan Rijnhart (Therp)
Review: Approve code review Thanks for the backport! Launchpad will tell you that the branch is stacked invalidly. This should be harmless, and is fixed in the latest commits to lp-community-utils. -- https://code.launchpad.net/~lmi/ocb-addons/7.0-opw-596916-rgo/+merge/218476 Your team

[Openerp-community-reviewer] [Bug 1214866] Re: [7.0][addons] no multicompany support for lots

2014-05-07 Thread Stefan Rijnhart (Therp)
** Also affects: ocb-addons/7.0 Importance: Undecided Assignee: Laurent Mignon (Acsone) (lmi) Status: New ** Changed in: ocb-addons/7.0 Status: New = Fix Committed -- You received this bug notification because you are a member of OpenERP Community Backports, which is

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep into lp:purchase-wkfl

2014-05-07 Thread martin
Review: Needs Fixing I would suggest that both _key_fields_for_grouping and _key_fields_for_grouping_lines do a return['a','b']. At the moment I get the message that the functions return tuples. If they return lists, a simple res.append('c') is sufficient to add custom fields. --

Re: [Openerp-community-reviewer] [Merge] lp:~lmi/ocb-addons/7.0-opw-596916-rgo into lp:ocb-addons

2014-05-07 Thread Laurent Mignon (Acsone)
Stefan, Thanks for the information. I have indeed discovered the fix after the backport. Regards, lmi -- https://code.launchpad.net/~lmi/ocb-addons/7.0-opw-596916-rgo/+merge/218476 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list:

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/7.0-crm_claim_rma-fix-lp1317045_rde into lp:openerp-rma

2014-05-07 Thread Romain Deheele - Camptocamp
Romain Deheele - Camptocamp has proposed merging lp:~camptocamp/openerp-rma/7.0-crm_claim_rma-fix-lp1317045_rde into lp:openerp-rma. Requested reviews: OpenERP RMA (openerprma) Related bugs: Bug #1317045 in OpenERP RMA: when we create a return product, selected partner_id on picking is

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep into lp:purchase-wkfl

2014-05-07 Thread Leonardo Pistone - camptocamp
Martin, I am not convinced we need mutability here. Couldn't we still do return res + ('c',)? -- https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep into lp:purchase-wkfl

2014-05-07 Thread martin
Leonardo, you are right. Both methods will work. -- https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report

2014-05-07 Thread Nicolas Bessi - Camptocamp
Thanks I will have a look on https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix2/+merge/216380 ASAP --

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/change-button-to-send-email-in-draftpo into lp:openerp-humanitarian-ngo/purchase-wkfl

2014-05-07 Thread noreply
The proposal to merge lp:~camptocamp/openerp-humanitarian-ngo/change-button-to-send-email-in-draftpo into lp:openerp-humanitarian-ngo/purchase-wkfl has been updated. Status: Needs review = Merged For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/purchase-wkfl/purchase_profit_forecast-missing-security-access into lp:purchase-wkfl

2014-05-07 Thread Sandy Carter (http://www.savoirfairelinux.com)
Review: Needs Fixing code review, no test l.288 looks like you forgot to put anything in for group_id:id purchase_profit_forecast/__openerp__.py: Manifest license key is missing Deprecated Manifest key ('active') Deprecated Manifest key ('certificate') Flake8: report/analytic.py:3:1: E302

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/purchase-wkfl/pallet-delivery-missing-security-access into lp:purchase-wkfl

2014-05-07 Thread Sandy Carter (http://www.savoirfairelinux.com)
Review: Needs Fixing code review, pep8 l.112,464,2878 You can remove these empty files Flake8 delivery_editable_dates/__openerp__.py:22:1: O603 Manifest license key is missing delivery_editable_dates/__openerp__.py:28:5: O600 Warning unknown Manifest key ('caterogy')

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde into lp:stock-logistic-flows

2014-05-07 Thread Yannick Vaucher @ Camptocamp
Review: Needs Fixing code review, no test Shouldn't *_to_done private method be *_to_do or _to_be_done ? Here are few remarks about translations: * After installatation on fresh install with last code Wizard fields and label aren't translated. (But this may not be related to this MP) * In

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis into lp:knowledge-addons/7.0

2014-05-07 Thread Sandy Carter (http://www.savoirfairelinux.com)
Review: Needs Fixing Flake8: cmis/connector.py:23:1: F401 'fields' imported but unused cmis/connector.py:23:1: F401 'orm' imported but unused l.270 you still need to escape literals http://wiki.alfresco.com/wiki/CMIS_Query_Language#Literals

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde into lp:openerp-rma

2014-05-07 Thread Romain Deheele - Camptocamp
Romain Deheele - Camptocamp has proposed merging lp:~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde into lp:openerp-rma. Requested reviews: OpenERP RMA (openerprma) For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/7.0-web_tree_many2one_clickable into lp:web-addons

2014-05-07 Thread Pedro Manuel Baeza
Review: Approve code review and test Please change description to fit in correct english to: - This addon provides a widget to allow many2one fields in a tree view to open the linked resource: but I have tried and it works correctly, so I'm not going to block MP. Have you considered to have