Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into lp:purchase-wkfl

2014-05-13 Thread Lorenzo Battistini - Agile BG
Ok, thanks. What about the amount_untaxed, amount_tax, amount_total fields repeated 2 times? -- https://code.launchpad.net/~pedro.baeza/purchase-wkfl/7.0-purchase_discount/+merge/217030 Your team Purchase Core Editors is requested to review the proposed merge of

Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into lp:purchase-wkfl

2014-05-13 Thread Pedro Manuel Baeza
You're right. I don't know how can I overpassed that! I have corrected. Thanks. Regards. -- https://code.launchpad.net/~pedro.baeza/purchase-wkfl/7.0-purchase_discount/+merge/217030 Your team Purchase Core Editors is requested to review the proposed merge of

Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into lp:purchase-wkfl

2014-05-13 Thread Omar (Pexego)
Review: Approve code review no test Thanks Pedro, I had long wanted to propose this module on the branch. -- https://code.launchpad.net/~pedro.baeza/purchase-wkfl/7.0-purchase_discount/+merge/217030 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list:

[Openerp-community-reviewer] [Bug 1291903] Re: [OCB] sale_stock: property_ids set on procurement.order

2014-05-13 Thread Lionel Sausin - Numérigraphe
** Changed in: ocb-addons Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of OpenERP Community Backports, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1291903 Title: [OCB] sale_stock:

[Openerp-community-reviewer] [Bug 1079548] Re: Message field(char) too short to allow long messages

2014-05-13 Thread Lionel Sausin - Numérigraphe
** Changed in: ocb-addons/7.0 Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of OpenERP Community Backports, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1079548 Title: Message

[Openerp-community-reviewer] [Bug 691534] Re: [trunk] Inventory analysis displays lines with quantity is zero

2014-05-13 Thread Lionel Sausin - Numérigraphe
** Changed in: ocb-addons/7.0 Assignee: Lionel Sausin - Numérigraphe (lionel-sausin) = Numérigraphe (numerigraphe-team) -- You received this bug notification because you are a member of Stock and Logistic Core Editors, which is subscribed to the bug report.

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-web/7.0-hide-oe_read_only into lp:ocb-web

2014-05-13 Thread Lionel Sausin - Numérigraphe
Review: Disapprove I'm abandoning this proposal, but not deleting it to keep the interesting comments. I can't mark it rejected myself but feel free to do it. -- https://code.launchpad.net/~numerigraphe-team/ocb-web/7.0-hide-oe_read_only/+merge/213016 Your team OpenERP Community Backports is

[Openerp-community-reviewer] [Merge] lp:~akretion-team/openerp-rma/add-crm-claim-rma-repair into lp:openerp-rma

2014-05-13 Thread Joël Grand-Guillaume
The proposal to merge lp:~akretion-team/openerp-rma/add-crm-claim-rma-repair into lp:openerp-rma has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~akretion-team/openerp-rma/add-crm-claim-rma-repair/+merge/215976 --

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde into lp:openerp-rma

2014-05-13 Thread Joël Grand-Guillaume
Review: Approve code review, no tests -- https://code.launchpad.net/~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde/+merge/218666 Your team OpenERP RMA is subscribed to branch lp:openerp-rma. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/rma-fix-lp1311520_rde into lp:openerp-rma

2014-05-13 Thread Joël Grand-Guillaume
Review: Approve code review, no tests Hi Romain, Thanks for this improvements. LGTM ! Regards, -- https://code.launchpad.net/~camptocamp/openerp-rma/rma-fix-lp1311520_rde/+merge/216839 Your team OpenERP RMA is subscribed to branch lp:openerp-rma. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/7.0-crm_claim_rma-fix-lp1317045_rde into lp:openerp-rma

2014-05-13 Thread Joël Grand-Guillaume
Review: Approve code review + test Hi Romain, Thanks for the fix, after testing and looking with other customers uses cases, I approve this improvement. Regards -- https://code.launchpad.net/~camptocamp/openerp-rma/7.0-crm_claim_rma-fix-lp1317045_rde/+merge/218595 Your team OpenERP RMA is

[Openerp-community-reviewer] [Merge] lp:~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays into lp:hr-timesheet

2014-05-13 Thread noreply
The proposal to merge lp:~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays into lp:hr-timesheet has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays/+merge/162124 --

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/department-mgmt/add-account-department-fix-default-anyltic-jge into lp:department-mgmt

2014-05-13 Thread Daniel Reis
Review: Approve I believe this covers the distinct user cases better than Jordi's MP. So I would prefer for this one to be merged. Anyway, I invited him for this review. On the syle side, it's just a personal preference, but for: employee_ids = employee_obj.search(cr, uid,

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-web/7.0-hide-oe_read_only into lp:ocb-web

2014-05-13 Thread Leonardo Pistone - camptocamp
Lionel, I rejected this following your comments. Thanks -- https://code.launchpad.net/~numerigraphe-team/ocb-web/7.0-hide-oe_read_only/+merge/213016 Your team OpenERP Community Backports is subscribed to branch lp:ocb-web. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post

[Openerp-community-reviewer] [Merge] lp:~camptocamp/department-mgmt/add-account-department-fix-default-anyltic-jge into lp:department-mgmt

2014-05-13 Thread noreply
The proposal to merge lp:~camptocamp/department-mgmt/add-account-department-fix-default-anyltic-jge into lp:department-mgmt has been updated. Status: Needs review = Merged For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~jb.eficent/department-mgmt/department-mgmt-bugfixes_analytic into lp:department-mgmt

2014-05-13 Thread Joël Grand-Guillaume
Review: Disapprove code review + test Hi, As this MP :https://code.launchpad.net/~camptocamp/department-mgmt/add-account-department-fix-default-anyltic-jge/+merge/218807 Has been merged, I mark this one as disapproved. Reply in there if anything wrong with that. Regards, Joël --

[Openerp-community-reviewer] [Merge] lp:~jb.eficent/department-mgmt/department-mgmt-bugfixes_analytic into lp:department-mgmt

2014-05-13 Thread Joël Grand-Guillaume
The proposal to merge lp:~jb.eficent/department-mgmt/department-mgmt-bugfixes_analytic into lp:department-mgmt has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~jb.eficent/department-mgmt/department-mgmt-bugfixes_analytic/+merge/212299 --

[Openerp-community-reviewer] [Merge] lp:~camptocamp/project-service/project_service_project_closing_vre into lp:project-service

2014-05-13 Thread Vincent Renaville@camptocamp
Vincent Renaville@camptocamp has proposed merging lp:~camptocamp/project-service/project_service_project_closing_vre into lp:project-service. Requested reviews: Project Core Editors (project-core-editors) For more details, see:

[Openerp-community-reviewer] [Bug 1290820] Re: report_webkit not thread-safe: risk of document corruption

2014-05-13 Thread Yannick Vaucher @ Camptocamp
Here is the second MP: https://code.launchpad.net/~camptocamp/openobject- addons/7.0-fix-1319109/+merge/219406 ** Also affects: ocb-addons Importance: Undecided Status: New ** Also affects: ocb-addons/7.0 Importance: Undecided Status: New ** Branch linked: