Hello Romain,
I think your change is right, it's good to put the partner who send the product
in the field partner_id.
There is one use case that we might consider.
If we want to create a delivery label that the customer can print to return the
product, in this case we don't have the
** Changed in: ocb-server/7.0
Status: Fix Committed = Invalid
--
You received this bug notification because you are a member of OpenERP
Community Backports, which is subscribed to OpenERP Community Backports
(Server).
https://bugs.launchpad.net/bugs/1049653
Title:
--unaccent option
Yann Papouin has proposed merging
lp:~yann-papouin/ocb-server/7.0-bug-1319285-translation-overwrite-module-update
into lp:ocb-server.
Requested reviews:
OpenERP Community Backports (ocb)
Related bugs:
Bug #1319285 in OpenERP Community Backports (Server): Module update does not
overwrite
Public bug reported:
If the server is started with the --i18n-overwrite option, it is entirely
ignored when updating module in these two cases:
- update from command line
- update from module view
In tools/config.py, following is stated:
the i18n-overwrite option cannot be used without the
Review: Approve code review
LGTM
Regards.
--
https://code.launchpad.net/~yann-papouin/ocb-server/7.0-bug-1319285-translation-overwrite-module-update/+merge/219468
Your team OpenERP Community Backports is subscribed to branch lp:ocb-server.
--
Mailing list:
Yannick Vaucher @ Camptocamp has proposed merging
lp:~camptocamp/ocb-addons/7.0-fix-1319109 into lp:ocb-addons.
Requested reviews:
OpenERP Community Backports (ocb)
Related bugs:
Bug #1319109 in OpenERP Community Backports (Addons): webkit_report - webkit
parser is not thread safe because
The proposal to merge lp:~camptocamp/ocb-addons/7.0-fix-1319109 into
lp:ocb-addons has been updated.
Description changed to:
Transmit parser_instance using partial function for mako translation callback.
This to remove parser_instance from attribute as it can cause race condition on
cursors.
Yannick Vaucher @ Camptocamp has proposed merging
lp:~camptocamp/ocb-addons/7.0-fix-1319095 into lp:ocb-addons.
Requested reviews:
OpenERP Community Backports (ocb)
Related bugs:
Bug #1290820 in OpenERP Community Backports (Addons): report_webkit not
thread-safe: risk of document corruption
*** This bug is a duplicate of bug 1290820 ***
https://bugs.launchpad.net/bugs/1290820
** Also affects: ocb-addons
Importance: Undecided
Status: New
** Also affects: ocb-addons/7.0
Importance: Undecided
Status: New
--
You received this bug notification because you are a
Hi Pedro,
Might you change needs fixing to approve if it's ok ?
and then merge ?
--
https://code.launchpad.net/~akretion-team/sale-wkfl/sale-wkfl-sale-multi-journal/+merge/215440
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list:
Review: Approve no test, code review
Thanks for providing the patch as disscussed.
Just a little
little indent
49 uid,
50 self.name2,
51 context=context)
else
LGTM
--
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1319109/+merge/219473
Your team OpenERP Community Backports is
Review: Approve code review, no test
LGTM
thanks for fixing this
--
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1319109/+merge/219473
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Review: Approve no test, code review
Thanks for the fix.
LGTM
This patch will not be backportable as is to version 6.1, 6.0 as it is not
Python 2.5 compliant
Regards
Nicolas
--
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1319095/+merge/219476
Your team OpenERP Community
The proposal to merge lp:~camptocamp/lp-community-utils/nag-user-specific-info
into lp:lp-community-utils has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~camptocamp/lp-community-utils/nag-user-specific-info/+merge/209665
--
Review: Approve tests
Ok translations works now
Thanks for the changes.
--
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde/+merge/214568
Your team Stock and Logistic Core Editors is subscribed to branch
Review: Needs Fixing code review, no test
This fix will not work on Windows.
out_filename is opened on line 11 of the file, and then the pdf converter will
try to open a file with the same name while the file is still open in OpenERP
which will fail on windows
Good catch
--
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1319095/+merge/219476
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Thanks for the review and the explanations.
This has been fixed.
--
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1319095/+merge/219476
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
I've made a quick regarding the index, it seems not very useful - once the rows
are filtered on inventory_id, PG prefers to simply do a table scan + sort
rather than an index scan.
The only point I see in this index would be to let the DBA schedule a CLUSTER
on it to speed up the table scan,
Review: Approve code review, no test
LGTM
Thanks
--
https://code.launchpad.net/~yann-papouin/ocb-server/7.0-bug-1319285-translation-overwrite-module-update/+merge/219468
Your team OpenERP Community Backports is subscribed to branch lp:ocb-server.
--
Mailing list:
Review: Approve code review, no test
LGTM thanks for the fix
--
https://code.launchpad.net/~akretion-team/hr-timesheet/70-fix-timesheet-task-bug1316456/+merge/218364
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:hr-timesheet.
--
Mailing list:
The proposal to merge
lp:~akretion-team/hr-timesheet/70-fix-timesheet-task-bug1316456 into
lp:hr-timesheet has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~akretion-team/hr-timesheet/70-fix-timesheet-task-bug1316456/+merge/218364
--
The proposal to merge
lp:~akretion-team/hr-timesheet/70-fix-timesheet-task-bug1316456 into
lp:hr-timesheet has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~akretion-team/hr-timesheet/70-fix-timesheet-task-bug1316456/+merge/218364
--
Sylvain LE GAL (GRAP) has proposed merging
lp:~sylvain-legal/server-env-tools/7.0-fix-1319391 into lp:server-env-tools.
Commit message:
[FIX] bug #1319391;
[ADD] Tests;
Requested reviews:
Server Environment And Tools Core Editors (server-env-tools-core-editors)
Related bugs:
Bug #1319391 in
Thanks for the review.
I made the fixes.
I have also rewritten the exception handling, thought it does exactly the same
thing. I have to use nested exception to ensure the rollback is played in
anycase. Then I want to complete informations on the orm exceptions.
--
s/thought/though
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-threaded-dispatch-label-generation/+merge/215184
Your team Stock and Logistic Core Editors is requested to review the proposed
merge of
lp:~camptocamp/carriers-deliveries/7.0-threaded-dispatch-label-generation
Review: Needs Information
l.225,259 can you please explain what you do here. It seems you attempt to
write to a directory to test if you have write permission, surely there are
safer ways of doing this.
In you unittest, can you test more of your functions, I know there is a
challenge of not
Review: Approve
--
https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-fix-1319391/+merge/219530
Your team Server Environment And Tools Core Editors is subscribed to branch
lp:server-env-tools.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Needs Fixing
l.469,502: Queries are still not fully sanitized, any quotes or percent sizes
in the input will result in unexpected behaviour. This is a security risk and a
major bug potential.
I highly recommend you to add a function to sanitize input in the cmis module
for queries and
The proposal to merge
lp:~camptocamp/carriers-deliveries/7.0-stock-picking-duplication-fix-regression-from-v7port-and-add-a-test_rde
into lp:carriers-deliveries has been updated.
Status: Needs review = Merged
For more details, see:
The proposal to merge lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into
lp:purchase-wkfl has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061
--
The proposal to merge lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into
lp:purchase-wkfl has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061
--
martin, can you change your status here ? Or is it intended to let it in Needs
Fixing ?
--
https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
--
Mailing list:
Review: Disapprove
As Lorenzo said seems main dev is
lp:~serpentcs/hotel-management-system/hotel-7.0
As those fixes were made in lp:~serpentcs/hotel-management-system/hotel-7.0
I'll disapprove it.
--
The proposal to merge
lp:~agilebg/hotel-management-system/7.0-bug-1308639-hurrinico into
lp:hotel-management-system/7.0 has been updated.
Status: Needs review = Rejected
For more details, see:
Review: Approve code review, test
LGTM.
Sorry for the late.
+++
--
https://code.launchpad.net/~acsone-openerp/web-addons/bug-1303944-sbi/+merge/216422
Your team Web-Addons Core Editors is requested to review the proposed merge of
lp:~acsone-openerp/web-addons/bug-1303944-sbi into
Review: Needs Fixing
Hello,
I think you can even use float_compare instead of float_is_zero. That way you
can do the whole teste in one if.
http://bazaar.launchpad.net/~openerp/openobject-server/7.0/view/head:/openerp/tools/float_utils.py#L99
if float_compare(float_end_time,
Public bug reported:
Addons revno 10181
SQL view created for report _name = 'report.stock.lines.date' is not
supported by Postgresql 9.0 or older.
That's what I've found out:
* Revision 10142 added a new field for this SQL view active (ref:
Review: Needs Fixing formal nitpicking
First off, some formal comments:
- in.txt and out.pdf should probably be left out
- README is empty, either remove it or write something in it please
- please add a copyright note at the top of your files, I think they're useful
to avoid ambiguity
- in
Hi Sylvain, thanks for the review.
What do you think about the logos. In practice they don't display properly with
non admin users and I see no way out of that. Should we remove them?
-sbi
--
https://code.launchpad.net/~acsone-openerp/web-addons/bug-1303944-sbi/+merge/216422
Your team
So this a modularization of something that is much easier to do as a patch to
the core addons...
Have you been proposing your initial patch for the official addons trunk yet?
If not, I humbly suggest you do (I'll review your proposal there too).
--
Hi Stéphane,
I don't have a precise idea about that.
I'm pretty in favor to keep that feature because :
- it works for admin user and doesn't bug with non-admin users;
- It works if admin user decide to change default ACL;
I'm agree : it's not very clean. (but OpenERP Core is not very clean in
I'm fine with your view. It does not crash indeed and users don't complain. So
let's keep it that way for now.
Thanks again for this neat module!
-sbi
--
https://code.launchpad.net/~acsone-openerp/web-addons/bug-1303944-sbi/+merge/216422
Your team Web-Addons Core Editors is requested to review
Please ignore my comment about PEP8 for the copied/pasted part of the module.
However you need to update your copy of generate_pdf() because patches have
been applied to it upstream.
--
Review: Needs Fixing copied code is out-of-date
--
https://code.launchpad.net/~bruno-bottacini/report-print-send/7.0-report_webkit_custom_paper_size/+merge/202892
Your team Report Printing and Sending Core Editors is requested to review the
proposed merge of
Hi Yannick,
I updated code as you advised : very large lines, brackets instead of update,
active_id checking, view type.
I'm agree with other tips, but:
- majority of methods are core stock addon overrides without call to super
(because of no possibility to easily hook them)
There is here a
Daniel Reis has proposed merging lp:~dreis-pt/project-service/7.0-fixcounters
into lp:project-service.
Requested reviews:
Project Core Editors (project-core-editors)
For more details, see:
https://code.launchpad.net/~dreis-pt/project-service/7.0-fixcounters/+merge/219558
In v7, Project
Alex Comba - Agile BG has proposed merging
lp:~agilebg/openerp-manufacturing/adding_mrp_production_properties_7 into
lp:openerp-manufacturing.
Commit message:
[ADD] module mrp_production_properties
Requested reviews:
Manufacture Core Editors (manufacture-core-editors)
For more details, see:
Review: Approve code review
LGTM, thanks.
Regards.
--
https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-fix-1319391/+merge/219530
Your team Server Environment And Tools Core Editors is subscribed to branch
lp:server-env-tools.
--
Mailing list:
Review: Approve code review
Hi, Alex, thanks for the MP.
LGTM, and PEP8 compliant.
Regards.
--
https://code.launchpad.net/~agilebg/openerp-manufacturing/adding_mrp_production_properties_7/+merge/219559
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
50 matches
Mail list logo
