Lionel Sausin - Numérigraphe has proposed merging
lp:~numerigraphe-team/report-print-send/7.0-improve-prefs-ui-ls into
lp:report-print-send.
Requested reviews:
Report Printing and Sending Core Editors (report-print-send-core-editors)
For more details, see:
Review: Approve code review
LGTM.
Regards.
--
https://code.launchpad.net/~numerigraphe-team/report-print-send/7.0-improve-prefs-ui-ls/+merge/219787
Your team Report Printing and Sending Core Editors is subscribed to branch
lp:report-print-send.
--
Mailing list:
The branches attached seem to work, is it worth merging them in OCB ?
** Also affects: ocb-addons
Importance: Undecided
Status: New
** Also affects: ocb-server
Importance: Undecided
Status: New
** Also affects: ocb-server/7.0
Importance: Undecided
Status: New
**
Yann Papouin has proposed merging
lp:~yann-papouin/ocb-addons/6.1-bug-1008513-dav-import-error into
lp:ocb-addons/6.1.
Requested reviews:
OpenERP Community Backports (ocb)
Related bugs:
Bug #1008513 in OpenERP Community Backports (Addons): [6.1]document_webdav -
pywebdav import error if
Review: Needs Fixing code review
I think you may keep osv.except_osv in case both imports fail, or put an
external dependency on manifest.
Regards.
--
https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-1008513-dav-import-error/+merge/219794
Your team OpenERP Community Backports is
** Summary changed:
- document_webdav - pywebdav import error if pywebdav=0.9.8
+ [6.1]document_webdav - pywebdav import error if pywebdav=0.9.8
** Also affects: ocb-addons
Importance: Undecided
Status: New
** Changed in: ocb-addons
Importance: Undecided = Low
** Changed in:
Alex Comba - Agile BG has proposed merging
lp:~agilebg/stock-logistic-flows/adding_picking_line_description_7 into
lp:stock-logistic-flows.
Commit message:
[ADD] module picking_line_description
Requested reviews:
Stock and Logistic Core Editors (stock-logistic-core-editors)
For more
Hi Holger, good work. Question. Is there any integration between this cash
discount and payment orders? When i make a payment order on time then discount
can be extracted. When im passed my discount days it can't. Curious if this
exists or is in planning. Thanks.
--
You're right. Fixed!
--
https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-1008513-dav-import-error/+merge/219794
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve code review
Thanks for the changes!
Regards.
--
https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-1008513-dav-import-error/+merge/219794
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1.
--
Mailing list:
The proposal to merge
lp:~camptocamp/partner-contact-management/add-base_partner_merge into
lp:partner-contact-management has been updated.
Status: Needs review = Approved
For more details, see:
As Maxime's remarks should have been addressed, I proceed with the merge.
Thank you
--
https://code.launchpad.net/~camptocamp/partner-contact-management/add-base_partner_merge/+merge/189616
Your team Partner and Contact Core Editors is subscribed to branch
lp:partner-contact-management.
--
The proposal to merge
lp:~camptocamp/partner-contact-management/add-base_partner_merge into
lp:partner-contact-management has been updated.
Status: Approved = Merged
For more details, see:
Review: Approve
Thanks, I was aware of the problem and the fix looks good.
--
https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-1008513-dav-import-error/+merge/219794
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1.
--
Mailing list:
Review: Approve code review
ok, thanks
--
https://code.launchpad.net/~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde/+merge/218666
Your team OpenERP RMA is subscribed to branch lp:openerp-rma.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Needs Fixing nitpicking
Looks good from code point of view, not tested because I don't use this module.
Now for the nitpicking:
- multiline docstrings should have the short description on the first line, and
the details in the following lines. This lets IDEs show the first line as a
Thanks Lionel, I updated it.
--
https://code.launchpad.net/~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde/+merge/218666
Your team OpenERP RMA is subscribed to branch lp:openerp-rma.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve code review, not test
--
https://code.launchpad.net/~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde/+merge/218666
Your team OpenERP RMA is subscribed to branch lp:openerp-rma.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Lionel Sausin - Numérigraphe has proposed merging
lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_budget_limit into
lp:purchase-wkfl.
Requested reviews:
Romain Deheele - Camptocamp (romaindeheele): code review
Loïc Bellier - Numérigraphe (lb-b)
Purchase Core Editors
Review: Needs Fixing code review
Hi,
Several flake8 suggestions:
7.0-add-purchase_budget_limit/purchase_budget_limit/purchase.py:69:25: E128
continuation line under-indented for visual indent
7.0-add-purchase_budget_limit/purchase_budget_limit/purchase.py:76:30: E128
continuation line
Review: Needs Information code review
Hello Pedro,
Can you explain the use case where you need to enter time on tasks in other
state than done?
Domains such as this one may vary from a company to another, but I thought
allowing only open tasks was a good default?
Thanks!
--
PEP8 compliance fixed.
--
https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_budget_limit/+merge/219829
Your team Purchase Core Editors is requested to review the proposed merge of
lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_budget_limit into
lp:purchase-wkfl.
The proposal to merge
lp:~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde into
lp:openerp-rma has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde/+merge/218666
--
I think now in two possible scenarios:
- Bad configured project provokes that initial state of a task is not set.
- There is a third person that inputs all times. I'm thinking now that tasks
can be also even in done state, because inputation is done afterwards.
Do you think there is a better
Review: Needs Fixing
In that case I would change de domain in an additional module that is perhaps
specific to your use case, because I believe current users of hr_timesheet_task
expect to see only open tasks.
--
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
The proposal to merge lp:~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep into
lp:purchase-wkfl has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745
--
The proposal to merge lp:~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep into
lp:purchase-wkfl has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745
--
I have reverted back to original domain. Please review rest of the changes.
Regards.
--
https://code.launchpad.net/~pedro.baeza/hr-timesheet/7.0-hr_timesheet_task-imp/+merge/219821
Your team HR Core Editors is requested to review the proposed merge of
The proposal to merge lp:~pedro.baeza/hr-timesheet/7.0-hr_timesheet_task-imp
into lp:hr-timesheet has been updated.
Description changed to:
[FIX] hr_timesheet_sheet: Fix error if there is no project associated to task.
[FIX] hr_timesheet_sheet: Tree view for hr.analytic.timesheet inherited
Review: Approve code review, no test
LGTM
Cheers.
--
https://code.launchpad.net/~luc-demeyer/openerp-reporting-engines/7.0-report_xls-tz_fix/+merge/219267
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:openerp-reporting-engines.
--
Mailing list:
Review: Needs Fixing
Please don't add AUTHOR.txt file and add Contributors in __openerp__.py
For who did exaclty what there is the CVS
--
https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date/+merge/211374
Your team Purchase Core Editors is subscribed
Review: Needs Fixing code review, test
Thanks, other details:
-l.454 s/dificulties/difficulties
-Maybe you could precise that we need to check Analytic accounting for
purchases in settings/configuration/Purchases or check it directly during
addon install.
Otherwise, it seems ok.
Romain
--
It does not seems to be simple to parameterize this query.
Maybe this change could be made in another proposal and this one could be
merged now ?
--
https://code.launchpad.net/~yann-papouin/ocb-addons/7.0-bug-1169074-pricelist-category-depth/+merge/210163
Your team OpenERP Community Backports is
The proposal to merge lp:~sylvain-legal/server-env-tools/7.0-fix-1319391 into
lp:server-env-tools has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-fix-1319391/+merge/219530
--
The proposal to merge lp:~sylvain-legal/server-env-tools/7.0-fix-1319391 into
lp:server-env-tools has been updated.
Commit Message changed to:
[ADD] Regression Tests;
[FIX] Uncaught error is raised when the admin user tries to connect with a bad
login and his password;
[ADD] Test for the fixed
Already merged
--
https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-fix-1319391/+merge/219530
Your team Server Environment And Tools Core Editors is subscribed to branch
lp:server-env-tools.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Lionel Sausin - Numérigraphe has proposed merging
lp:~numerigraphe-team/account-financial-tools/7.0-add-account_budget_purchase
into lp:account-financial-tools.
Requested reviews:
Loïc Bellier - Numérigraphe (lb-b)
Account Core Editors (account-core-editors)
For more details, see:
Review: Needs Fixing
MP Description : ''
MP Commit message : ''
__openerp__.py 'description': ,
My remarks : '''?'''
Please fix this lack of information about this module
--
https://code.launchpad.net/~savoirfairelinux-openerp/purchase-wkfl/pallet-delivery/+merge/216325
Your team Purchase
Review: Approve code review
Ok for me too !
--
https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_budget_limit/+merge/219829
Your team Purchase Core Editors is requested to review the proposed merge of
lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_budget_limit
The proposal to merge lp:~sylvain-legal/server-env-tools/7.0-fix-1319391 into
lp:server-env-tools has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-fix-1319391/+merge/219530
--
Please next time explain what you do in your commit message.
Fix bug XY is not really understandable at a first glance.
To link the bug --fixes=lp:XY is there
--
https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-fix-1319391/+merge/219530
Your team Server Environment And Tools Core
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~pedro.baeza/hr-timesheet/7.0-hr_timesheet_task-imp/+merge/219821
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:hr-timesheet.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Review: Approve code review
--
https://code.launchpad.net/~numerigraphe-team/account-financial-tools/7.0-add-account_budget_purchase/+merge/219849
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list:
Review: Needs Information
Wouldn't it be cleaner to add a hook in report_webkit to create the command ?
--
https://code.launchpad.net/~bruno-bottacini/report-print-send/7.0-report_webkit_custom_paper_size/+merge/202892
Your team Report Printing and Sending Core Editors is subscribed to branch
Dear community,
After the announcement of the brand new odoo instead of OpenERP, the main
changes for contributors currently is the switch to Github. As I know, most
of you waited for such a move ! Now it's done :) Though it remain a quite
huge question : How the hell do we, as the community,
Review: Approve code review, no test
LGTM
Thanks for the tests
--
https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-fix-1319391/+merge/219530
Your team Server Environment And Tools Core Editors is subscribed to branch
lp:server-env-tools.
--
Mailing list:
Loïc Bellier - Numérigraphe has proposed merging
lp:~numerigraphe-team/openerp-product-attributes/7.0-add-bremskrel-modules into
lp:openerp-product-attributes.
Requested reviews:
Product Core Editors (product-core-editors)
For more details, see:
Hi Joel !
On Fri, May 16, 2014 at 10:16 AM, Joël Grand-Guillaume
joel.grandguilla...@camptocamp.com wrote:
Dear community,
After the announcement of the brand new odoo instead of OpenERP, the main
changes for contributors currently is the switch to Github. As I know, most
of you waited
Pedro,
Just install the module and add duplicate=false to the definition of the
view that you want you modify.
Thanks for the icon.
2014-05-15 19:35 GMT-04:30 Pedro Manuel Baeza pedro.ba...@gmail.com:
Review: Needs Fixing test
Hi, Aristóbulo, thanks for the contribution.
I didn't get to
Thanks Romain, I fixed it. Not sure why account_budget does not activate
analytic accounting on sales purchase, I don't think you can enter a budget
without that.
So I only added in the module description
--
Review: Needs Fixing code review
Please include then this info on module description, and a example of usage.
Regards.
--
https://code.launchpad.net/~aristobulo/web-addons/web-addons/+merge/217277
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.
--
Mailing list:
Yannick yes it would be much cleaner, but the problem is the same as with what
was initially proposed: unfortunately it won't be accepted in stable releases.
So for v7 we can only
- either take this white-box reuse module
- or refuse it and ask those interested to patch their installation on
Hi Joël,
Maybe I don't understand, but having one addon per repo does that mean
that when an API change requires a change in all the banking addons (for
instance), that I have to make a pull request for all those repos?
I'd be in favour of keeping OCA projects in bzr for 7.0 and in GitHub
for
I vote for a) as the quickest and easiest option to arrive to the full
split for v8. (unless someone can manage to do the split of v7 in a few
days, but I suppose that's not possible).
On Fri, May 16, 2014 at 5:31 PM, Ovnicraft ovnicr...@gmail.com wrote:
Hi Joel !
On Fri, May 16, 2014 at
I think Stefan raises an interesting approach: let v7 as is on Launchpad,
and move quietly to GitHub for v8 modules (one module migration, a module
that is tested on v8 and works, etc) in the form 1 module/1 repo.
About the other problem, I don't know exactly GitHub, but I think you can
propose a
vote : A
Big thanks to Joel for this mail ;)
2014-05-16 17:16 GMT+02:00 Joël Grand-Guillaume
joel.grandguilla...@camptocamp.com:
Dear community,
After the announcement of the brand new odoo instead of OpenERP, the main
changes for contributors currently is the switch to Github. As I
We agree with Stefan here.
--
Maxime Chambreuil
+1 (514) 276-5468 #126
- Mail original -
Stefan's approach has my vote. Keep = 7.0 on lauchpad and use github for =
8.0.
Cheers,
-sbi
On Fri, May 16, 2014 at 5:51 PM, Stefan Rijnhart ste...@therp.nl wrote:
Hi Joël,
On Fri, May 16, 2014 at 10:51 AM, Stefan Rijnhart ste...@therp.nl wrote:
Hi Joël,
Maybe I don't understand, but having one addon per repo does that mean
that when an API change requires a change in all the banking addons (for
instance), that I have to make a pull request for all those
Review: Approve code review and test
I have tried and it works like intended.
Thanks for the fix.
Regards.
--
https://code.launchpad.net/~therp-nl/ocb-web/7.0-form_destroy_buttons/+merge/216898
Your team OpenERP Community Backports is subscribed to branch lp:ocb-web.
--
Mailing list:
Review: Approve code review and partial testing
Approve
Code review and ported the code to 7.0 to test. Working there, so will submit
merge proposal for 7.0 as well.
--
https://code.launchpad.net/~yann-papouin/ocb-web/6.1-bug-1261322-useful-report-filename/+merge/27
Your team OpenERP
Ronald Portier (Therp) has proposed merging
lp:~therp-nl/ocb-web/7.0_lp1261332_better_report_name into lp:ocb-web.
Requested reviews:
OpenERP Community Backports (ocb)
Related bugs:
Bug #1261322 in OpenERP Web: [6.1][7.0][trunk] Default report filename is
useless in daily use
62 matches
Mail list logo
