Review: Resubmit
Holger, Lorenzo made the requested correction (thanks Lorenzo :) )., merge
approved for me, see diff of the mp:
https://code.launchpad.net/~agilebg/account-invoicing/add_module_account_payment_term_month_improvements/+merge/221124
--
Something new to merge this commit?
--
https://code.launchpad.net/~factorlibre/carriers-deliveries/carriers-deliveries-es-translation/+merge/217395
Your team Stock and Logistic Core Editors is subscribed to branch
lp:carriers-deliveries.
--
Mailing list:
Hi, Alberto, you didn't correct my comments. As soon as you do it, I'll merge
the proposal.
Regards.
--
https://code.launchpad.net/~factorlibre/carriers-deliveries/carriers-deliveries-es-translation/+merge/217395
Your team Stock and Logistic Core Editors is subscribed to branch
Review: Approve
Sorry, review type was approve not resubmit (Lorenzo told me the difference
:) )
--
https://code.launchpad.net/~nicolariolini/account-invoicing/add_module_account_payment_term_month/+merge/212400
Your team Account Core Editors is subscribed to branch lp:account-invoicing.
--
Translation updated
--
https://code.launchpad.net/~factorlibre/carriers-deliveries/carriers-deliveries-es-translation/+merge/217395
Your team Stock and Logistic Core Editors is subscribed to branch
lp:carriers-deliveries.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post
Review: Approve code review
Well, translation has still some of the errors I have remarked, but I will
correct them on merge time.
Regards.
--
https://code.launchpad.net/~factorlibre/carriers-deliveries/carriers-deliveries-es-translation/+merge/217395
Your team Stock and Logistic Core Editors
The proposal to merge
lp:~factorlibre/carriers-deliveries/carriers-deliveries-es-translation into
lp:carriers-deliveries has been updated.
Status: Needs review = Merged
For more details, see:
David BEAL has proposed merging
lp:~akretion-team/carriers-deliveries/7-base-delivery-carrier-dbl into
lp:carriers-deliveries.
Requested reviews:
Yannick Vaucher @ Camptocamp (yvaucher-c2c)
For more details, see:
Review: Needs Fixing code review
Hi, David, docstring convention says that you have to put one-line doc with
three .
Regards.
--
https://code.launchpad.net/~akretion-team/carriers-deliveries/7-base-delivery-carrier-dbl/+merge/221226
Your team Stock and Logistic Core Editors is subscribed to
Hi Pedro,
Thanks for the review, I fixed it
Here is a use case of sender customization
http://bazaar.launchpad.net/~akretion-team/+junk/sale-multi-shop/view/head:/shop_sender/stock.py
--
https://code.launchpad.net/~akretion-team/carriers-deliveries/7-base-delivery-carrier-dbl/+merge/221226
Review: Needs Fixing code review
Thanks for the changes. I'm thinking that if the method is intended for
customizing sender address, you should return a dictionary that it's written on
base module, because in this way, you have to do it your way in your custom
module and inheritance is not
Lorenzo Battistini - Agile BG has proposed merging
lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-reference-is-not-defined
into lp:hr-timesheet.
Requested reviews:
HR Core Editors (hr-core-editors)
For more details, see:
Review: Approve code review
LGTM.
Regards.
--
https://code.launchpad.net/~agilebg/hr-timesheet/fix-hr_attendance_analysis-reference-is-not-defined/+merge/221250
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:hr-timesheet.
--
Mailing list:
Hi Pedro,
You're right, it's cleaner to have a real return and set a default behavior.
I changed my code to return a partner.
The code is cleaner in shop_sender module.
Thanks for your advices
Regards
--
Review: Needs Information code review
Hi again, David, one thing I don't see is where you use the value returned by
this method. Is there something I'm missing?
Regards.
--
https://code.launchpad.net/~akretion-team/carriers-deliveries/7-base-delivery-carrier-dbl/+merge/221226
Your team Stock
Lorenzo Battistini - Agile BG has proposed merging
lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-bracket into
lp:hr-timesheet.
Requested reviews:
Alex Comba - Agile BG (tafaru)
HR Core Editors (hr-core-editors)
For more details, see:
Pedro,
here is the use case
http://bazaar.launchpad.net/~akretion-team/carriers-deliveries/7-delivery-carrier-coliposte/view/head:/delivery_carrier_colipostefr/stock.py#L119
Regards
--
https://code.launchpad.net/~akretion-team/carriers-deliveries/7-base-delivery-carrier-dbl/+merge/221226
Your
Review: Needs Information code review
Hi, Lorenzo, don't you think it's better to use store triggers to recompute
needed data?
Regards.
--
https://code.launchpad.net/~agilebg/hr-timesheet/fix-hr_attendance_analysis-bracket/+merge/221278
Your team OpenERP Community Reviewer/Maintainer is
18 matches
Mail list logo
