Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-bracket into lp:hr-timesheet

2014-05-29 Thread Lorenzo Battistini - Agile BG
Hello Pedro, what do you mean by store triggers? I'm triggering recomputing because 'action' is in the store dictionary: 'hr.attendance': (_get_attendances, ['name', 'action', 'employee_id'], 20), --

[Openerp-community-reviewer] [Merge] lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-bracket into lp:hr-timesheet

2014-05-29 Thread Lorenzo Battistini - Agile BG
The proposal to merge lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-bracket into lp:hr-timesheet has been updated. Description changed to: [FIX] wrong opening bracket due to PEP8 restyle: http://bazaar.launchpad.net/~hr-core-editors/hr-timesheet/7.0/revision/40.2.21 [ADD]

[Openerp-community-reviewer] [Merge] lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-report-timezone into lp:hr-timesheet

2014-05-29 Thread Lorenzo Battistini - Agile BG
Lorenzo Battistini - Agile BG has proposed merging lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-report-timezone into lp:hr-timesheet. Requested reviews: HR Core Editors (hr-core-editors) Alex Comba - Agile BG (tafaru) For more details, see:

[Openerp-community-reviewer] [Merge] lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-report-timezone into lp:hr-timesheet

2014-05-29 Thread Lorenzo Battistini - Agile BG
You have been requested to review the proposed merge of lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-report-timezone into lp:hr-timesheet. For more details, see: https://code.launchpad.net/~agilebg/hr-timesheet/fix-hr_attendance_analysis-report-timezone/+merge/221374 [FIX]

[Openerp-community-reviewer] [Merge] lp:~dreis-pt/sale-wkfl/7.0-sale_noinvoice-dr into lp:sale-wkfl

2014-05-29 Thread Daniel Reis
Daniel Reis has proposed merging lp:~dreis-pt/sale-wkfl/7.0-sale_noinvoice-dr into lp:sale-wkfl. Requested reviews: Sale Core Editors (sale-core-editors) For more details, see: https://code.launchpad.net/~dreis-pt/sale-wkfl/7.0-sale_noinvoice-dr/+merge/221383 A neat module to just skip the

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-report-timezone into lp:hr-timesheet

2014-05-29 Thread Pedro Manuel Baeza
Review: Needs Information code review Hi, Lorenzo, I think your fix has a problem with times that after been converted to correct timezone change its date. For example: 29/05/2014 00:12 GMT+2 28/05/2014 22:12 UTC. Regards. --