Review: Approve code review
--
https://code.launchpad.net/~agilebg/account-invoice-report/7_fix_1221570/+merge/223781
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-invoice-report.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to
Hi,
s
Following a discussion with Christophe Simonis at Opendays, an alternative to
the migration script for fresh install has been implemented
(https://github.com/odoo/odoo/commit/4105b5f0285821d8056c721b5fd50b9cae902988and)
and merged for V8. For V7 the system will remain unchanged. It's now
The proposal to merge
lp:~camptocamp/stock-logistic-barcode/7.0-fix_1330459-sge+afe into
lp:stock-logistic-barcode has been updated.
Description changed to:
Rename hight to height
Integrate and enhance Sébastien Gendre's fix, add a migration script.
For more details, see:
Review: Approve code review
Thank you very much for the MP and the migration script.
LGTM.
Regards.
--
https://code.launchpad.net/~camptocamp/stock-logistic-barcode/7.0-fix_1330459-sge+afe/+merge/223866
Your team Stock and Logistic Core Editors is subscribed to branch
Review: Approve
LGTM, also proceeding with the merge now as pending merge was just processed
and as we got 2 approvals here.
--
https://code.launchpad.net/~agilebg/account-invoicing/adding_product_customer_code_invoice/+merge/202469
Your team Account Core Editors is subscribed to branch
The proposal to merge
lp:~agilebg/account-invoicing/adding_product_customer_code_invoice into
lp:account-invoicing has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~agilebg/account-invoicing/adding_product_customer_code_invoice/+merge/202469
Review: Approve
LGTM, pending merges have been processed now
--
https://code.launchpad.net/~agilebg/stock-logistic-flows/adding_product_customer_code_picking/+merge/202472
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-flows.
--
Mailing list:
Thanks for your review Pedro! I basically rewrote the code, you might want to
have another test.
The two colons are rst for preformatted text:
http://docutils.sourceforge.net/docs/user/rst/quickref.html#literal-blocks
--
Review: Needs Fixing code review
I have made some comments inline, and I wonder if the module name wouldn't be
better as stock_picking_product_customer_code to follow current core
conventions (more or less, you know that there is no written rules).
Regards.
Diff comments:
=== added
Review: Approve code review no tests
LGTM thanks
--
https://code.launchpad.net/~camptocamp/stock-logistic-barcode/7.0-fix_1330459-sge+afe/+merge/223866
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-barcode.
--
Mailing list:
Nicola Malcontenti - Agile BG has proposed merging
lp:~agilebg/sale-reports/7_fix_1331541 into lp:sale-reports.
Requested reviews:
Sale Core Editors (sale-core-editors)
For more details, see:
https://code.launchpad.net/~agilebg/sale-reports/7_fix_1331541/+merge/223871
In order to solve
Review: Approve code review, test
LGTM
Thanks
--
https://code.launchpad.net/~camptocamp/account-budgeting/vre-budget-responsible-group/+merge/223705
Your team Account Core Editors is subscribed to branch lp:account-budgeting.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
The proposal to merge
lp:~camptocamp/stock-logistic-barcode/7.0-fix_1330459-sge+afe into
lp:stock-logistic-barcode has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~camptocamp/stock-logistic-barcode/7.0-fix_1330459-sge+afe/+merge/223866
--
Review: Approve code review
--
https://code.launchpad.net/~agilebg/sale-reports/7_fix_1331541/+merge/223871
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:sale-reports.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve code review, no tests
LGTM
--
https://code.launchpad.net/~agilebg/account-invoice-report/7_fix_1221570/+merge/223781
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-invoice-report.
--
Mailing list:
The proposal to merge lp:~agilebg/account-invoice-report/7_fix_1221570 into
lp:account-invoice-report has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~agilebg/account-invoice-report/7_fix_1221570/+merge/223781
--
Review: Approve code review, no test
Thanks
LGTM
--
https://code.launchpad.net/~agilebg/account-invoice-report/7_fix_1221570/+merge/223781
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-invoice-report.
--
Mailing list:
The proposal to merge lp:~agilebg/account-invoice-report/7_fix_1221570 into
lp:account-invoice-report has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~agilebg/account-invoice-report/7_fix_1221570/+merge/223781
--
Thanks again Lorenzo, will be a time saver.
--
https://code.launchpad.net/~agilebg/account-invoice-report/7_fix_1221570/+merge/223781
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-invoice-report.
--
Mailing list:
The proposal to merge lp:~agilebg/sale-reports/7_fix_1331541 into
lp:sale-reports has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~agilebg/sale-reports/7_fix_1331541/+merge/223871
--
Review: Approve code review
--
https://code.launchpad.net/~agilebg/sale-reports/7_fix_1331541/+merge/223871
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:sale-reports.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Hi,
It seems nice.
I left a few comments in the diff. I won't really block on them but you should
have a look.
Diff comments:
=== added directory 'cmis_read'
=== added file 'cmis_read/__init__.py'
--- cmis_read/__init__.py 1970-01-01 00:00:00 +
+++ cmis_read/__init__.py
Thanks for the patch
--
https://code.launchpad.net/~agilebg/sale-reports/7_fix_1331541/+merge/223871
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:sale-reports.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
The proposal to merge
lp:~yann-papouin/ocb-addons/6.1-bug-1008513-dav-import-error into
lp:ocb-addons/6.1 has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-1008513-dav-import-error/+merge/219794
--
Review: Approve code review
--
https://code.launchpad.net/~pedro.baeza/ocb-addons/7.0-lp1122155/+merge/217629
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
The proposal to merge lp:~pedro.baeza/ocb-addons/7.0-lp1122155 into
lp:ocb-addons has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~pedro.baeza/ocb-addons/7.0-lp1122155/+merge/217629
--
Review: Needs Fixing
/data/ should be /data
--
https://code.launchpad.net/~agilebg/sale-reports/7_fix_1331541/+merge/223871
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:sale-reports.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Fixed in merge
--
https://code.launchpad.net/~agilebg/sale-reports/7_fix_1331541/+merge/223871
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:sale-reports.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Hi, this was done on purpose because loading all the records at once
brings the server to an out-of-memory condition when there are lots of
stock moves involved. So the loop is here to protect from that by
processing only a limited number of them at a time.
** Changed in: ocb-addons
Nicola Malcontenti - Agile BG has proposed merging
lp:~agilebg/stock-logistic-report/7_fix_1331543 into lp:stock-logistic-report.
Requested reviews:
Stock and Logistic Core Editors (stock-logistic-core-editors)
For more details, see:
Lionel Sausin - Numérigraphe has proposed merging
lp:~numerigraphe-team/stock-logistic-warehouse/7.0-fix-decimal-precision into
lp:stock-logistic-warehouse.
Requested reviews:
Loïc Bellier - Numérigraphe (lb-b)
Stock and Logistic Core Editors (stock-logistic-core-editors)
For more details,
Review: Needs Fixing
Hi,
I left some diff comments.
I'm also annoyed by the incompatibily introduced by this module (override of
amount_all and amount_line), but on the other hand there is maybe no other way
to do that.
Thanks Pedro
Diff comments:
=== added directory 'purchase_discount'
Review: Approve code review
LGTM.
Regards.
--
https://code.launchpad.net/~agilebg/stock-logistic-report/7_fix_1331543/+merge/223878
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-report.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Lionel Sausin - Numérigraphe has proposed merging
lp:~numerigraphe-team/purchase-wkfl/7.0-fix-decimal-precision into
lp:purchase-wkfl.
Requested reviews:
Purchase Core Editors (purchase-core-editors)
For more details, see:
No, it seems there is a logical error in the algoritm:
Current implementation:
for i in range(0, 25, 5):
... print %s:%s % (i * 5, (i+1) * 5)
...
0:5
25:30
50:55
75:80
100:105
Suggested fix:
for i in range(0, 25, 5):
... print %s:%s % (i,i + 5)
...
0:5
5:10
10:15
15:20
20:25
**
The proposal to merge
lp:~yann-papouin/ocb-server/7.0-bug-1319285-translation-overwrite-module-update
into lp:ocb-server has been updated.
Status: Needs review = Merged
For more details, see:
Review: Approve code review, no test
--
https://code.launchpad.net/~agilebg/stock-logistic-report/7_fix_1331543/+merge/223878
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-report.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to
Review: Disapprove duplicate feature and perfs regression
We don't need this anymore, it is superseded by our other proposal regarding
exhaustive inventories.
And it would be a burden on stock moves, not good for performance.
Loïc and I used to use this in v6 but we're abandoning it in v7.
Review: Approve code review
Good catch!
LGTM.
Regards.
--
https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-fix-decimal-precision/+merge/223883
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
--
Mailing list:
Review: Approve code review
LGTM.
Regards.
--
https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-fix-decimal-precision/+merge/223881
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-warehouse.
--
Mailing list:
** Also affects: ocb-server/6.1
Importance: Undecided
Status: New
** Also affects: ocb-server/7.0
Importance: Undecided
Status: New
** Changed in: ocb-server/7.0
Status: New = Fix Released
--
You received this bug notification because you are a member of OpenERP
Review: Needs Fixing
Hello,
I see some little mistake that I correct in :
http://bazaar.launchpad.net/~acsone-openerp/stock-logistic-warehouse/7.0-inventory-hierarchical-fill2-lga/revision/40
Hi, Guewen, thanks for the review.
I have fixed your remarks.
I don't like also to overwrite function fields methods, but I assure you that
there's no other way for now. I'm going to propose a hook method for purchase
line base price on core to see if we can improve this module for next
laetitia-gangloff you're right, Loïc had to split the proposal in 2 branches to
make the review easier but I forgot to push back the fixes he an you made to
the modules in this branch.
I'll fix it now.
--
laetitia-gangloff,
Can you please explain this change in your branch? I don't see the point
because ids is already sure to be Iterable. Does it really have to be a list?
@@ -285,11 +285,11 @@
def write(self, cr, uid, ids, vals, context=None):
Refuse write if an inventory is being
It is to avoid a RuntimeError: maximum recursion depth exceeded when change
location_id.
ids was just assigned in ids_to_check so, when ids_to_check change, ids change
too and the write is not done with right parameter, an we get the above error.
With list(ids) we create a new list, so ids and
Review: Approve code review
Great, thanks!
--
https://code.launchpad.net/~pedro.baeza/purchase-wkfl/7.0-purchase_discount/+merge/217030
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
laetitia-gangloff, right you are again.
I propose to write it explicitly this way, is it OK for you?
if not isinstance(ids, Iterable):
ids_to_check = [ids]
else:
# Copy the date to avoid changing 'ids', it would trigger an
infinite recursion
The proposal to merge lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into
lp:purchase-wkfl has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~pedro.baeza/purchase-wkfl/7.0-purchase_discount/+merge/217030
--
I meant copy the datA, not copy the date of course...
--
https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location/+merge/223880
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-warehouse.
--
Mailing list:
Your proposition is OK for me.
Maybe, can you take test of this problem ?
--
https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location/+merge/223880
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-warehouse.
--
Mailing
l. 509/l. 516 : raise osv.except_osv
Is it not better to use orm.except_orm ?
--
https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location/+merge/223880
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-warehouse.
--
laetitia-gangloff: that part of the code was backported from trunk-wms at the
time, and I wanted to ease the migration to v8.
But eventually Odoo's Quentin Di Paoli changed his mind about that feature and
removed it from odoo/master. But he still uses osv.except_osv all over the WMS
code.
So I
Review: Needs Fixing tried to install and run the tests
This looks like a great module. However it needs some work before further
review is done:
1. this module will cause a crash at server startup if it is present in the
addons path (not necessarily installed) and the connector module is not
Review: Approve code review
--
https://code.launchpad.net/~agilebg/stock-logistic-report/7_fix_1331543/+merge/223878
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-report.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Needs Information code review, no tests
Could you update the description of the module to make it clear that there is
no magic done in the module.
Suggestion:
'description': Defines a user to be used for automatic action
This module adds a field 'automatic_action_user_id'
on the
Review: Approve code, test, functional test
Thank you for the explanation.
I have no idea what's best.
I retested this module and it seems now OK.
--
https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location/+merge/223880
Your team Stock and Logistic Core
Hi Pedro,
thank you for your review and for your precious hints!
I made the changes as you suggested us. In addition I fixed a bug in rev.58.
Cheers.
--
https://code.launchpad.net/~agilebg/stock-logistic-flows/adding_product_customer_code_picking/+merge/202472
Your team Stock and Logistic
The proposal to merge
lp:~agilebg/openerp-manufacturing/adding_mrp_production_properties_7 into
lp:openerp-manufacturing has been updated.
Status: Needs review = Merged
For more details, see:
Thank you for your review, Guewen, I learned a few things.
Diff comments:
=== added directory 'cmis_read'
=== added file 'cmis_read/__init__.py'
--- cmis_read/__init__.py 1970-01-01 00:00:00 +
+++ cmis_read/__init__.py 2014-06-12 19:57:17 +
@@ -0,0 +1,25 @@
+# -*- encoding:
Lionel Sausin - Numérigraphe has proposed merging
lp:~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM into
lp:ocb-addons.
Requested reviews:
OpenERP Community Backports (ocb)
For more details, see:
Loïc Bellier - Numérigraphe has proposed merging
lp:~numerigraphe-team/ocb-addons/7.0-fill_inventory_zero_qty into lp:ocb-addons.
Requested reviews:
OpenERP Community Backports (ocb)
Related bugs:
Bug #1229646 in OpenERP Community Backports (Addons): Wizard Fill
inventory does not respect
Review: Approve
That will fix the bug, thanks!
--
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM/+merge/223928
Your team OpenERP Community Backports is requested to review the proposed merge
of
** Changed in: ocb-addons/6.1
Status: Fix Committed = Fix Released
--
You received this bug notification because you are a member of OpenERP
Community Backports, which is subscribed to OpenERP Community Backports
(Addons).
https://bugs.launchpad.net/bugs/1008513
Title:
Review: Approve code review
LGTM
--
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM/+merge/223928
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post
Review: Approve code review
Great !
--
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM/+merge/223928
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
The proposal to merge lp:~pedro.baeza/hr-timesheet/7.0-hr_timesheet_task-imp
into lp:hr-timesheet has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~pedro.baeza/hr-timesheet/7.0-hr_timesheet_task-imp/+merge/219821
--
Review: Approve
+1
--
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM/+merge/223928
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
The proposal to merge lp:~mikel-martin/purchase-wkfl/6.1-purchase_landed_costs
into lp:purchase-wkfl/6.1 has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~mikel-martin/purchase-wkfl/6.1-purchase_landed_costs/+merge/199587
--
Hello Sébastien,
some PEP8 improvements here
https://code.launchpad.net/~agilebg/server-env-tools/binary_field_pep8/+merge/223935
--
https://code.launchpad.net/~akretion-team/server-env-tools/server-env-tools/+merge/91
Your team Server Environment And Tools Core Editors is subscribed to
Review: Abstain
Hi.
Sorry, I totally forgot to review again that MP.
--
https://code.launchpad.net/~ajite/web-addons/7.0-web-addons-add-0001/+merge/210620
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.
--
Mailing list:
The proposal to merge lp:~ajite/web-addons/7.0-web-addons-add-0001 into
lp:web-addons has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~ajite/web-addons/7.0-web-addons-add-0001/+merge/210620
--
Review: Approve code review
Hi Augustin,
LGTM finally!
Thanks for you work.
Since Sylvain's comments have been addressed, I'll merge it.
--
https://code.launchpad.net/~ajite/web-addons/7.0-web-addons-add-0001/+merge/210620
Your team Web-Addons Core Editors is subscribed to branch
Review: Approve code
Thank you !
--
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM/+merge/223928
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post
The proposal to merge
lp:~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM into
lp:ocb-addons has been updated.
Status: Needs review = Approved
For more details, see:
The proposal to merge
lp:~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM into
lp:ocb-addons has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM/+merge/223928
--
** Changed in: ocb-addons
Status: Fix Committed = Fix Released
--
You received this bug notification because you are a member of OpenERP
Community Backports, which is subscribed to OpenERP Community Backports
(Addons).
https://bugs.launchpad.net/bugs/1329342
Title:
stock.fill.inventory
Review: Abstain i'm a contributor
--
https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location/+merge/223880
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-warehouse.
--
Mailing list:
Review: Abstain i'm a contributor
--
https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-hierarchical/+merge/223882
Your team Stock and Logistic Core Editors is requested to review the proposed
merge of
79 matches
Mail list logo
