Review: Needs Information
Why using traceback module ??
--
https://code.launchpad.net/~therp-nl/server-env-tools/6.1-web_base_url_freeze/+merge/225651
Your team Server Environment And Tools Core Editors is subscribed to branch
lp:server-env-tools/6.1.
--
Mailing list:
The proposal to merge
lp:~numerigraphe-team/account-financial-tools/7.0-add-account_budget_purchase
into lp:~account-core-editors/account-financial-tools/7.0 has been updated.
Status: Needs review = Rejected
For more details, see:
The proposal to merge
lp:~akretion-team/account-financial-tools/account-financial-tools-check-deposit
into lp:~account-core-editors/account-financial-tools/7.0 has been updated.
Status: Needs review = Rejected
For more details, see:
The project has moved to Github https://github.com/OCA/account-financial-tools.
Please resubmit your MP on github using following procedure
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub.
I put this MP in rejected in the meanwhile.
Regards
--
The project has moved to Github https://github.com/OCA/account-financial-tools.
Please resubmit your MP on github using following procedure
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub.
I put this MP in rejected in the meanwhile.
Regards
--
The proposal to merge
lp:~camptocamp/account-financial-tools/7.0_override_menu_for_search_improvement_mdh
into lp:~account-core-editors/account-financial-tools/7.0 has been updated.
Status: Needs review = Rejected
For more details, see:
Review: Approve
LGTM
--
https://code.launchpad.net/~camptocamp/sale-reports/vre-sale_order_proformat/+merge/223563
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:sale-reports.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve
--
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde/+merge/214568
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-flows.
--
Mailing list:
Review: Approve
--
https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account_invoice_currency-fix/+merge/211845
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list:
LGTM
--
https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account_invoice_currency-fix/+merge/211845
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to
Review: Approve
LGTM
--
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-github-650/+merge/223727
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve
LGTM
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-threaded-dispatch-label-generation/+merge/215184
Your team Stock and Logistic Core Editors is requested to review the proposed
merge of
Review: Needs Fixing
Need fixing.
Set has a better performance than list and it should avoid duplicate.
Please see inline comment
Diff comments:
=== added directory 'picking_dispatch_wave'
=== added file 'picking_dispatch_wave/__init__.py'
--- picking_dispatch_wave/__init__.py 1970-01-01
https://wiki.python.org/moin/TimeComplexity
--
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde/+merge/214568
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-flows.
--
Mailing list:
Review: Approve
LGTM
--
https://code.launchpad.net/~camptocamp/account-financial-report/7.0-account_export_csv-select-periods/+merge/222806
Your team Account Report Core Editors is subscribed to branch
lp:account-financial-report.
--
Mailing list:
Hello thanks for the review.
I fixed you remarks.
for l145 as I'm copying data, I want to stay polite and do not remove an
expected key ba an other piece of code.
Regards
Nicolas
--
https://code.launchpad.net/~camptocamp/account-financial-tools/add-manual-line-and-fees-nbi/+merge/218584
Nicolas Bessi - Camptocamp has proposed merging
lp:~camptocamp/partner-contact-management/7.0-add_birthdate_nbi into
lp:partner-contact-management.
Requested reviews:
Partner and Contact Core Editors (partner-contact-core-editors)
For more details, see:
https://code.launchpad.net/~camptocamp
Review: Approve no test, code review
Thanks for providing the patch as disscussed.
Just a little
little indent
49 uid,
50 self.name2,
51 context=context)
else
LGTM
--
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1319109/+merge/219473
Your team OpenERP Community Backports is
Review: Approve no test, code review
Thanks for the fix.
LGTM
This patch will not be backportable as is to version 6.1, 6.0 as it is not
Python 2.5 compliant
Regards
Nicolas
--
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1319095/+merge/219476
Your team OpenERP Community
Good catch
--
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1319095/+merge/219476
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Needs Fixing
Hello,
Thank for the patch
Small PEP8 in manifest also noticed that
the title underline is not correct
[Link module] Carrier labels - Picking dispatch
Thanks I will have a look on
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix2/+merge/216380
ASAP
--
I can confirm I got the same bug as Daniel.
--
https://code.launchpad.net/~camptocamp/server-env-tools/7.0-monitoring/+merge/215138
Your team Server Environment And Tools Core Editors is subscribed to branch
lp:server-env-tools.
--
Mailing list:
Review: Disapprove
--
https://code.launchpad.net/~camptocamp/account-financial-tools/credit_control_report_improvement_vre/+merge/201920
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list:
Nicolas Bessi - Camptocamp has proposed merging
lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-improve-preq-cancel-nbi
into lp:openerp-humanitarian-ngo/purchase-wkfl.
Requested reviews:
OpenERP for Humanitarian Core Editors (humanitarian-core-editors)
For more details, see:
https
The proposal to merge
lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-improve-preq-cancel-nbi
into lp:openerp-humanitarian-ngo/purchase-wkfl has been updated.
Description changed to:
Fix and improve the process of cancelling a purchase requisition
For more details, see:
Nicolas Bessi - Camptocamp has proposed merging
lp:~camptocamp/purchase-wkfl/7.0-fix-agreement-trigger-nbi into
lp:purchase-wkfl.
Requested reviews:
Purchase Core Editors (purchase-core-editors)
For more details, see:
https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-fix-agreement
Nicolas Bessi - Camptocamp has proposed merging
lp:~camptocamp/ocb-addons/fix-1308364-nbi into lp:ocb-addons.
Requested reviews:
OpenERP Community Backports Team (ocb)
Related bugs:
Bug #1308364 in OpenERP Addons: [7.0] [trunk] report_webkit precise mode
does not take in account set_context
Hello,
Thank for the fixes.
The UPDATE NO WAIT will lock the selected rows at postgres database level.
It will avoid a process using the base_location data to alter flushed entries.
It will also avoiding having many concurrent instance of the wizard running on
the same rows.
In this case I
Review: Needs Fixing
Oups I missed that.
Actually, I do not agrees with you, but I won't argue too long on this as for
me the branch organisation problem is more deep. Let's see what other think
about it.
Some comments Belows:
Some PEP8 in manifest:
328 +_(The content of
Review: Approve no test, code review
LGTM
--
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-595240-opw-skh_fix_1192115-afe/+merge/211264
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list:
Review: Approve
LGTM
--
https://code.launchpad.net/~camptocamp/ocb-server/7.0-fix_1305653-afe/+merge/215121
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-server.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Needs Fixing
Hello,
Thanks for the module, it is really a valuable tool.
Some comments below:
Some PEP8 error in manifest
728+ name = '%s.%s' % (cls.__module__, cls.__name__)
There is a logical risk that cls is not initialized if it is not an old/new
style class.
729 +
hello,
Any news on this one
--
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717
Your team Account Report Core Editors is subscribed to branch
lp:account-financial-report.
--
Mailing list:
Review: Approve
Ahh tests, I'm feeling better now.
Thanks for the fixes LGTM :-D
--
https://code.launchpad.net/~camptocamp/server-env-tools/7.0-monitoring/+merge/215138
Your team Server Environment And Tools Core Editors is subscribed to branch
lp:server-env-tools.
--
Mailing list:
LGTM
--
https://code.launchpad.net/~camptocamp/purchase-report/purchase_report_carriage_return_vre/+merge/214030
Your team Purchase Core Editors is subscribed to branch lp:purchase-report.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve
--
https://code.launchpad.net/~camptocamp/purchase-report/purchase_report_carriage_return_vre/+merge/214030
Your team Purchase Core Editors is subscribed to branch lp:purchase-report.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Needs Information
Hello thanks for the patch.
Is there a good reason not to merge it here:
https://launchpad.net/geospatial-addons ?
Some tests would also be a nice addition.
--
Review: Needs Fixing
Sorry I have to withdraw my approve,
After proofreading the credit communication code I can not accept you patch.
A credit communication is an aggregation of credit lines per partner per policy
level.
That means related credit lines can be related to many invoices that
Alexandre,
As for all webkit report if you do not set explicitly path to wkhtml2pdf in an
ir.config.parameter you have to have a wkhtml2pdf command in your executable
path.
Nicolas
--
https://code.launchpad.net/~camptocamp/account-financial-report/add_aged_partner_ledger-nbi/+merge/211040
Frederic
The reports are functional on addons branch, only the tests failed because on
official addons in demo data all periods are special.
--
https://code.launchpad.net/~camptocamp/account-financial-report/add_aged_partner_ledger-nbi/+merge/211040
Your team Account Report Core Editors is
Review: Approve no test, code review
LGTM
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-base_delivery_carrier_label-tracking_ids/+merge/207199
Your team Stock and Logistic Core Editors is subscribed to branch
lp:carriers-deliveries.
--
Mailing list:
Review: Approve no test, code review
A lot of code repretition but no real clean alternative with those
out/in/internal stock picking model.
LGTM
Nicolas
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-base_delivery_carrier_label-change-carrier/+merge/208367
Your team Stock
I would add more precision on manifest description.
When will the shop logo will be used
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-add-delivery_carrier_label_postlogistics_shop_logo-yvr/+merge/196859
Your team Stock and Logistic Core Editors is subscribed to branch
Hello,
Stéphan is right,
Test runs perfectly on OCB, that is the branches I used to developp communitiy
addons.
Regards
Nicolas
2014-03-18 15:53:58,357 27853 INFO test_aged_partner openerp.modules.loading:
module account_financial_report_webkit: loading tests/aged_trial_balance.yml
Hello Stefan,
I prefer to do it in an other MP, in order to fix the case of plain password as
soon as possible.
Also the refactoring using the passlib will probably be done against the trunk
branch as there is some difference in implementation and I'm not sure at the
current time they are
The proposal to merge lp:~camptocamp/ocb-addons/improve_auth_crypt-nbi into
lp:ocb-addons has been updated.
Status: Needs review = Work in progress
For more details, see:
https://code.launchpad.net/~camptocamp/ocb-addons/improve_auth_crypt-nbi/+merge/206364
--
Ho I got your point Stefan,
I missed the answer of Olivier on addons MP
For this part, your init() method looks fine, but there are already multiple
instances of the salting+hashing dance. As you're adding one more, it seems a
good opportunity to refactor a bit and extract that pattern into a
I have done the small refactor proposed by Olivier (not the one with passlib).
Please redo a quick review before merging.
Regards
Nicolas
--
https://code.launchpad.net/~camptocamp/ocb-addons/improve_auth_crypt-nbi/+merge/206364
Your team OpenERP Community Backports Team is subscribed to branch
Nicolas Bessi - Camptocamp has proposed merging
lp:~camptocamp/ocb-addons/improve_auth_crypt-nbi into lp:ocb-addons.
Requested reviews:
Nicolas Bessi - Camptocamp (nbessi-c2c)
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c): code review, no test
Stefan Rijnhart (Therp) (stefan-therp
Hello,
The parameter/fallback solution seems reasonable assuming that period parameter
is not mandatory.
For me you can update the MP with that solution.
Also as the change will alter data structure the revision number of the module
must be increased in MP.
I'm putting the MP in work in
Review: Approve
LGTM
--
https://code.launchpad.net/~openerp-community/server-env-tools/7.0-modules-from-openobject-extension/+merge/200744
Your team Server Environment And Tools Core Editors is requested to review the
proposed merge of
Review: Approve code review, no test
LGTM, Thanks
--
https://code.launchpad.net/~camptocamp/account-financial-tools/credit_control_report_improvement_vre/+merge/201920
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list:
Review: Needs Fixing
--
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717
Your team Account Report Core Editors is subscribed to branch
lp:account-financial-report.
--
Mailing list:
Hello,
Fixes done and basic tests added
--
https://code.launchpad.net/~camptocamp/account-financial-report/add_aged_partner_ledger-nbi/+merge/211040
Your team Account Report Core Editors is subscribed to branch
lp:account-financial-report.
--
Mailing list:
Nicolas Bessi - Camptocamp has proposed merging
lp:~camptocamp/account-financial-report/add_aged_partner_ledger-nbi into
lp:account-financial-report.
Commit message:
[ADD] Aged Partner Balance webkit report. Report inherit Open Invoice Report
and uses previously computed ledger lines
The proposal to merge
lp:~camptocamp/account-financial-tools/7.0-fix-credit-control-scenarios-nbi
into lp:account-financial-tools has been updated.
Description changed to:
Fix credit control scenario:
Force scenarios to be done on exercice 2013 as they are based on base finance
setup porvided
Nicolas Bessi - Camptocamp has proposed merging
lp:~camptocamp/account-financial-tools/7.0-fix-1287072 into
lp:account-financial-tools.
Requested reviews:
Account Core Editors (account-core-editors)
For more details, see:
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix
Review: Approve no test, code review
LGTM
--
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-post-deleted-move-lep/+merge/208360
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list:
Review: Approve no test, code review
LGTM
--
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-batch-validate-log-more-lep/+merge/208420
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list:
Review: Approve no test, code review
LGTM
--
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-batch-validate-replace-menuitem-lep/+merge/208412
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list:
Review: Approve no test, code review
This one is funny :)
LGTM
--
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-batch_validate-delay-delaying-second-attempt-lep/+merge/208614
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
Review: Approve code review, no test
Just fixed some PEP8 issues.
LGTM
--
https://code.launchpad.net/~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge/+merge/198960
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list:
I would greatly appreciate some tests on the module, before merging it.
--
https://code.launchpad.net/~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge/+merge/198960
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list:
Nicolas Bessi - Camptocamp has proposed merging
lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-fix-domain-nbi into
lp:openerp-humanitarian-ngo/purchase-wkfl.
Requested reviews:
OpenERP for Humanitarian Core Editors (humanitarian-core-editors)
For more details, see:
https
Review: Approve no test, code review
LGTM
--
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1281687-afe/+merge/207116
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/ngo-addons-small-xml-improvement-rde/+merge/205711
Your team OpenERP for Humanitarian Core Editors is subscribed to branch
lp:openerp-humanitarian-ngo.
--
Mailing list:
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~camptocamp/sale-reports/7.0-conditional_discount_print-rde/+merge/206678
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:sale-reports.
--
Mailing list:
Review: Approve code review, no test
Ok, there is no test on module, my fault.
LGTM
--
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-avoid_sale_lines_dropshipping_make_to_order_without_supplierinfos-rde/+merge/205623
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Review: Approve
LGTM
--
https://code.launchpad.net/~camptocamp/sale-reports/typo_groups_id-rde/+merge/206874
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:sale-reports.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Nicolas Bessi - Camptocamp has proposed merging
lp:~camptocamp/purchase-wkfl/7.0-fix-missing-trigger-nbi into lp:purchase-wkfl.
Requested reviews:
Purchase Core Editors (purchase-core-editors)
For more details, see:
https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-fix-missing-trigger
Nicolas Bessi - Camptocamp has proposed merging
lp:~camptocamp/openerp-humanitarian-ngo/addons-backport-fix-copy-nbi into
lp:openerp-humanitarian-ngo/addons-backport.
Requested reviews:
OpenERP for Humanitarian Core Editors (humanitarian-core-editors)
For more details, see:
https
Nicolas Bessi - Camptocamp has proposed merging
lp:~camptocamp/openerp-humanitarian-ngo/addons-backport-fix-copy-nbi into
lp:openerp-humanitarian-ngo/addons-backport.
Requested reviews:
OpenERP for Humanitarian Core Editors (humanitarian-core-editors)
For more details, see:
https
The proposal to merge
lp:~camptocamp/openerp-humanitarian-ngo/addons-backport-fix-copy-nbi into
lp:openerp-humanitarian-ngo/addons-backport has been updated.
Status: Needs review = Work in progress
For more details, see:
Nicolas Bessi - Camptocamp has proposed merging
lp:~camptocamp/ocb-addons/improve_auth_crypt-nbi into lp:ocb-addons.
Commit message:
[IMP] module auth_crypt use sha256 by default to encrypt password. The
modification keeps retro compatibility.
[IMP] Add an init function on res.users to encrypt
Review: Approve no test, code review
LGTM
--
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-595239-opw-skh+afe/+merge/201016
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to
Review: Approve no test, code review
LGTM
--
https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/7.0-purchase-wkfl-adds-rde/+merge/205712
Your team OpenERP for Humanitarian Core Editors is subscribed to branch
lp:openerp-humanitarian-ngo/purchase-wkfl.
--
Mailing list:
The proposal to merge
lp:~alejandrosantana/openerp-humanitarian-ngo/7.0-purchase-wkfl--fix-1277236
into lp:openerp-humanitarian-ngo/purchase-wkfl has been updated.
Status: Needs review = Merged
For more details, see:
Nicolas Bessi - Camptocamp has proposed merging
lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-fix-typo-nbi into
lp:openerp-humanitarian-ngo/purchase-wkfl.
Requested reviews:
OpenERP for Humanitarian Core Editors (humanitarian-core-editors)
For more details, see:
https
Yes it works and is already in agreement form view
Regards
Nicolas
--
https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-fix-button-visibility/+merge/205304
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
--
Mailing list:
Review: Approve code review, no test
LGTM
Thanks
--
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-add_reorderable_lines-afe/+merge/197175
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Needs Information
Hello,
Thanks for the review. I will try the it ASAP.
Some remark so:
Some PEP8 here and there.
Can you give us more details about this line:
self.httprequest.url.replace('://', '://logout@')
I'm not sure to understand the use this redirection
Regards
Nicolas
--
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-fix_copy_origin-rde/+merge/203584
Your team OpenERP for Humanitarian Core Editors is subscribed to branch
lp:openerp-humanitarian-ngo/purchase-wkfl.
--
Mailing list:
The proposal to merge
lp:~camptocamp/openerp-humanitarian-ngo/ngo-addons-add_other_procurement_method-nbi
into lp:openerp-humanitarian-ngo has been updated.
Status: Needs review = Work in progress
For more details, see:
Nicolas Bessi - Camptocamp has proposed merging
lp:~camptocamp/openerp-humanitarian-ngo/fix-unmerged-dependency into
lp:openerp-humanitarian-ngo.
Requested reviews:
OpenERP for Humanitarian Core Editors (humanitarian-core-editors)
For more details, see:
https://code.launchpad.net/~camptocamp
Review: Needs Fixing code review, no tests
Hello,
Thanks for the work.
You should check code with a lynter and correct PEP8 etc.
You may add your authorship in manifest and file header of partner.py
# * if firstname change in the new name: lastname is set to new name,
firstname is reset
You
Review: Needs Fixing
Hello,
Just a point I just think of you, should check the case of final laste name
value as white string (' ') and replace it with False or raise an exception in
_write_name
Regards
Nicolas
--
Review: Approve code review, no test
LGTM.
Fixed some neat picks
--
https://code.launchpad.net/~camptocamp/openerp-reporting-engines/7.0-add-base_report_assembler-yvr/+merge/194304
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:openerp-reporting-engines.
--
Mailing
base_report_assembler is approved still need an other positive advice
--
https://code.launchpad.net/~camptocamp/account-invoice-report/7.0-add-invoice_report_assemble-yvr/+merge/194204
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-invoice-report.
--
Mailing
Review: Approve code review, no test
Thanks for the MP.
Fixed some neat pick and added module in category Accounting.
LGTM
--
https://code.launchpad.net/~camptocamp/account-invoice-report/7.0-add-invoice_report_assemble-yvr/+merge/194204
Your team OpenERP Community Reviewer/Maintainer is
Review: Approve code review, no test
Hello,
Pedro I do not get the meaning of your question.
Do you mean why they replace the whole header tag?
else for the current MP it looks good to me
Regards Nicolas
--
Review: Needs Fixing code review, no test
Hello,
Thanks for the MP.
Some doc string on _min_max_date_planned would be welcome.
Also Manifest description is quite laconic you should put commit message inside
:)
line 123: You forgot a print statement.
line 130: if name.startswith('min'):
Is
Review: Needs Fixing no test, code review
Hello,
Some neat picks:
PEP8 in __openerp__.py
Some trailing white space here and there.
Here I'm not sure of this expression:
domain = (
['', ('id', '=', res_id)] +
Hello,
In this case I prefere safe eval it is the standard way to do it and should be
more portable.
Regards
--
https://code.launchpad.net/~therp-nl/server-env-tools/7.0-add_email_template_conditional_attachment/+merge/202740
Your team Server Environment And Tools Core Editors is subscribed
Review: Approve
LGTM
--
https://code.launchpad.net/~camptocamp/purchase-report/purchase_report_port_date_planned_fix_vre/+merge/202640
Your team Purchase Core Editors is subscribed to branch lp:purchase-report.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Add a bid selected state on PO
Fix confirmation of cost estimate. PO in state bid will be cancel too
--
https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/add-bid_selected_state_on_po-nbi/+merge/200799
Your team OpenERP for Humanitarian Core Editors is requested to review the
The proposal to merge
lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-fix_confirm-nbi into
lp:openerp-humanitarian-ngo/purchase-wkfl has been updated.
Status: Needs review = Rejected
For more details, see:
Review: Disapprove
Deprecated by
https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/add-bid_selected_state_on_po-nbi/+merge/200799
--
https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-fix_confirm-nbi/+merge/197918
Your team OpenERP for Humanitarian Core
Hello,
Pedro idea is not bad but it goes against readability and lead to future error.
This is more a core openerp design flaw/bug, and it should be reported as a
server bug (if not allready done).
It should be handeld by the tree graphing behavior (or the poor man's solution
an helper)
from openerp.addons.report_xls.utils import rowcol_to_cell, _render is faulty
it import from an addons that is not in same branch and is not in a try catch.
This may prevent server to start
--
1 - 100 of 132 matches
Mail list logo
