[Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/adding_purchase_order_revision_7 into lp:purchase-wkfl

2014-01-10 Thread noreply
The proposal to merge lp:~agilebg/purchase-wkfl/adding_purchase_order_revision_7 into lp:purchase-wkfl has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~agilebg/purchase-wkfl/adding_purchase_order_revision_7/+merge/193778 --

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/adding_purchase_order_revision_7 into lp:purchase-wkfl

2013-12-24 Thread Lorenzo Battistini - Agile BG
On 12/20/2013 09:07 PM, Guewen Baconnier @ Camptocamp wrote: Is there a special reason you call orm.Model.copy() and not copy() of self? I think you did not that without a reason, which could be interesting to comment in the code. I made some improvements. Thanks --

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/adding_purchase_order_revision_7 into lp:purchase-wkfl

2013-12-24 Thread Guewen Baconnier @ Camptocamp
Review: Approve code review On 12/20/2013 09:07 PM, Guewen Baconnier @ Camptocamp wrote: Is there a special reason you call orm.Model.copy() and not copy() of self? I think you did not that without a reason, which could be interesting to comment in the code. I made some improvements.

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/adding_purchase_order_revision_7 into lp:purchase-wkfl

2013-12-20 Thread Joël Grand-Guillaume
Review: Approve code review, no tests Thanks, LGTM now. -- https://code.launchpad.net/~agilebg/purchase-wkfl/adding_purchase_order_revision_7/+merge/193778 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/adding_purchase_order_revision_7 into lp:purchase-wkfl

2013-12-20 Thread Guewen Baconnier @ Camptocamp
Is there a special reason you call orm.Model.copy() and not copy() of self? I think you did not that without a reason, which could be interesting to comment in the code. This is my sole point, apart that, lgtm Thanks --

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/adding_purchase_order_revision_7 into lp:purchase-wkfl

2013-12-20 Thread Guewen Baconnier @ Camptocamp
Review: Needs Fixing Forgot the review type. -- https://code.launchpad.net/~agilebg/purchase-wkfl/adding_purchase_order_revision_7/+merge/193778 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/adding_purchase_order_revision_7 into lp:purchase-wkfl

2013-11-18 Thread Lorenzo Battistini - Agile BG
On 11/15/2013 04:15 PM, Joël Grand-Guillaume @ camptocamp wrote: Review: Needs Fixing code review, no tests Hi Lorenzo, Hello Joël, - You just missed at line 27 : from . import purchase - Please add the .pot file and i18n folder for translation Done. Thanks --

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/adding_purchase_order_revision_7 into lp:purchase-wkfl

2013-11-15 Thread Joël Grand-Guillaume
Review: Needs Fixing code review, no tests Hi Lorenzo, Thanks for this contribs ! It looks good to me, even tests included ! Just 2 remarks: - You just missed at line 27 : from . import purchase - Please add the .pot file and i18n folder for translation Regards, Joël --

[Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/adding_purchase_order_revision_7 into lp:purchase-wkfl

2013-11-04 Thread Lorenzo Battistini - Agile BG
Lorenzo Battistini - Agile BG has proposed merging lp:~agilebg/purchase-wkfl/adding_purchase_order_revision_7 into lp:purchase-wkfl. Requested reviews: Purchase Core Editors (purchase-core-editors) For more details, see: