The proposal to merge
lp:~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_postlogistics-imp-licenses-yvr
into lp:carriers-deliveries has been updated.
Status: Approved = Merged
For more details, see:
Review: Approve
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_postlogistics-imp-licenses-yvr/+merge/202334
Your team Stock and Logistic Core Editors is subscribed to branch
lp:carriers-deliveries.
--
Mailing list:
The proposal to merge
lp:~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_postlogistics-imp-licenses-yvr
into lp:carriers-deliveries has been updated.
Status: Needs review = Approved
For more details, see:
Review: Approve code review
Yes Yannick, I was asking about that!
So if you reckon we handle the empty field properly, I approve.
Thanks!
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_postlogistics-imp-licenses-yvr/+merge/202334
Your team Stock and
Review: Needs Information
Yannick,
is the field picking.carrier_id required?
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_postlogistics-imp-licenses-yvr/+merge/202334
Your team Stock and Logistic Core Editors is requested to review the proposed
merge
carrier_id isn't required.
If you are asking for that line:
151 +license = picking.carrier_id.postlogistics_license_id
orm.browse_null
Implements __getattr__ that way.
def __getattr__(self, name):
return None # XXX: return self ?
So even if carrier_id returns
Jenkins PEP8 errors addressed in
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_postlogistics-pep8/+merge/205631
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_postlogistics-imp-licenses-yvr/+merge/202334
Your team
Yannick Vaucher @ Camptocamp has proposed merging
lp:~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_postlogistics-imp-licenses-yvr
into lp:carriers-deliveries.
Requested reviews:
Stock and Logistic Core Editors (stock-logistic-core-editors)
For more details, see:
The proposal to merge
lp:~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_postlogistics-imp-licenses-yvr
into lp:carriers-deliveries has been updated.
Status: Needs review = Merged
For more details, see:
The proposal to merge
lp:~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_postlogistics-imp-licenses-yvr
into lp:carriers-deliveries has been updated.
Status: Merged = Needs review
For more details, see:
Yannick Vaucher @ Camptocamp has proposed merging
lp:~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_postlogistics-imp-licenses-yvr
into lp:carriers-deliveries.
Requested reviews:
Stock and Logistic Core Editors (stock-logistic-core-editors)
For more details, see:
11 matches
Mail list logo