Review: Approve code review
You're right Pedro, sorry for not coming back. I update my review, just for the
record.
--
https://code.launchpad.net/~camptocamp/partner-contact-management/remove_trailing_space_partner_mdh/+merge/197400
Your team Partner and Contact Core Editors is subscribed to
As Leonardo comment is already corrected, I proceed with the merge.
Regards.
--
https://code.launchpad.net/~camptocamp/partner-contact-management/remove_trailing_space_partner_mdh/+merge/197400
Your team Partner and Contact Core Editors is subscribed to branch
lp:partner-contact-management.
--
The proposal to merge
lp:~camptocamp/partner-contact-management/remove_trailing_space_partner_mdh
into lp:partner-contact-management has been updated.
Status: Needs review = Merged
For more details, see:
Review: Approve code review
--
https://code.launchpad.net/~camptocamp/partner-contact-management/remove_trailing_space_partner_mdh/+merge/197400
Your team Partner and Contact Core Editors is subscribed to branch
lp:partner-contact-management.
--
Mailing list:
Review: Needs Fixing code review, no tests
Hello thanks for the fix
I would just suggest a little change to do the same as we did in
https://code.launchpad.net/~camptocamp/partner-contact-management/7.0-fix-lastnameempty/+merge/167906
Something like:
names = (record.lastname,
Review: Needs Fixing code review, no test
Thanks Matthieu, Yannick,
Agree with Yannick. To keep everything between unicode and avoid automatic
encode/decode, I suggest u .join...
--
Duly noted, and fixed accordingly.
--
https://code.launchpad.net/~camptocamp/partner-contact-management/remove_trailing_space_partner_mdh/+merge/197400
Your team Partner and Contact Core Editors is requested to review the proposed
merge of
Review: Approve code review, no tests
Thanks
LGTM
--
https://code.launchpad.net/~camptocamp/partner-contact-management/remove_trailing_space_partner_mdh/+merge/197400
Your team Partner and Contact Core Editors is requested to review the proposed
merge of
Matthieu Dietrich @ camptocamp has proposed merging
lp:~camptocamp/partner-contact-management/remove_trailing_space_partner_mdh
into lp:partner-contact-management.
Commit message:
[FIX] remove trailing space from display name if only the lastname is defined
Requested reviews:
Partner and
9 matches
Mail list logo