The proposal to merge
lp:~savoirfairelinux-openerp/partner-contact-management/city-move into
lp:partner-contact-management has been updated.
Status: Needs review = Rejected
For more details, see:
Review: Approve
Hello.
I verified and we have some different issues.
1.- I approve the merge because it is basically a Basic Geographical Model,
well documented and explicit.
2.- The base_location and city will be broken by default between them, the
unique convergence is take off the zip
Guys, just a word to tell: please wait for my review too, we do have some
specific requirements here to. I'll do it as soon as possible. Thank you very
much for bringing this on the table again.
--
Don't forget where you are from. There is no state in France ;)
--
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/city-move/+merge/196023
Your team Partner and Contact Core Editors is subscribed to branch
lp:partner-contact-management.
--
Mailing list:
Review: Disapprove
Hi all, sorry for the late replay, but I'm having hard days...
Although the convergence of both modules is desired, I have also to disagree
technically with this MP because:
- It makes a direct replacing of the field city, which breaks automatically any
existing
Review: Needs Information
@Raph:
http://bazaar.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/city-move/revision/31
Our original implementation was with State Id but I don't understand yet why it
was remove by @Sandy. @Sandy can you help us with you reasons please.
Delete the runbot part.
About the compatibility, let me tell you we test it with runbot some time
ago Several time ago and it is green:
http://runbot.openerp.com/openerp-mexico-maintainer.html
It is red today working on it ;-)
--
Review: Disapprove
@Pedro,
I agree with your 4 objections to the current merge:
1) It makes a direct replacing of the field city, which breaks automatically
any existing installation with data in city field, because there are string in
the DB on that field, and with this module, it is expected
2013/12/12 Raphaël Valyi - http://www.akretion.com rva...@gmail.com
As for having a city m2o country, well at least for us we don't need it. I
think the problem might more be with Vauxoo and Savoir Faire who opted for
a m2o to the country before I said I would need it to the state.
Just to
So, here it is:
https://code.launchpad.net/~pedro.baeza/partner-contact-management/7.0-base_location-imp/+merge/198840
With this new version of the module base_location, you have all the needed
things: you can enter only the city without the zip code, and select if you put
state, country, or
@Pedro,
so I just tested your new better_zip MP. But I don't get it.
So again, Savoir Faire, Vauxoo and us Akretion have thousands of zips per city.
So what do you propose? To de-normalize the city data (state_id, city code...)
over all the millions of zip entries?
So say for us in Brazil,
@Pedro,
or the only way I see it working would be: that res.better.zip would in fact be
city object. And Vauxoo, Savoir Faire en us would have an other object that
will be the real address zip and that would lead to the city (res.better.zip
then) selection.
Relationally speaking, that would
@Raphaël,
With the new version, you don't have to fill the zip, so you will have 5000
records of res.better.zip model without the ZIP, one per city.
When you are in the partner screen, you will fill the autocomplete field
(zip_id) with the name of the city, and city, state and country fields
@Pedro,
all right, our two last posts crossed... The way you just presented is what I
was suggesting in my last previous post too.
Then that will indeed work relationally speaking.
Now, Vauxoo, Savoir Faire and us would probably need to use the zip (the 6
millions of them in Brazil) as the
@Pedro
all right, as for me you convinced me to use better_zip as the city model for
our localization. I suggest to the others here to consider make the move or
explain why not else.
Thank you for you time Pedro. I think this is absolutely great if everybody
standardize on that common city
@Pedro, one last comment:
so I see that in
http://bazaar.launchpad.net/~openerp-spain-team/openerp-spain/7.0/view/head:/l10n_es_toponyms/wizard/l10n_es_toponyms_zipcodes.xml
you went for the denormalization of the cities into the zip codes. But as you
explained
I agree with Pedro base_location provides the base data model to manage this
problematic.
The major difference is the entry point that goes from zip to city.
It is also True we can adapt the base_location to support city entry point.
It is also True it will add a small layer of complexity on a
Hello Pedro,
Your module is based on the scenario where the user enters the zip, and other
fields (city, state and country) are set automatically.
Our scenario is the user chooses among a list of cities in our travel module.
We don't care about the zip.
--
Sandy Carter (http://www.savoirfairelinux.com) has proposed merging
lp:~savoirfairelinux-openerp/partner-contact-management/city-move into
lp:partner-contact-management.
Requested reviews:
Pedro Manuel Baeza (pedro.baeza)
Nhomar - Vauxoo (nhomar)
Maxime Chambreuil
Review: Approve code review
--
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/city-move/+merge/196023
Your team Partner and Contact Core Editors is subscribed to branch
lp:partner-contact-management.
--
Mailing list:
Review: Approve
It is __only__ move the code.
Approved in a first stage for me.
Thanks.
--
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/city-move/+merge/196023
Your team Partner and Contact Core Editors is subscribed to branch
lp:partner-contact-management.
The proposal to merge
lp:~savoirfairelinux-openerp/partner-contact-management/city-move into
lp:partner-contact-management has been updated.
Status: Needs review = Rejected
For more details, see:
Pedro.
I am really wonder when it was done.
I look for base_better_zip in apps and it is not available, can you point us to
this module to be sure we are talking about the same.
BTW: The name is base_better_zip, it shouldn't improve the zip not the city
field?
Regards.
--
Pedro,
base_location deals with ZIP code. We only want to have a dropdown list for
cities in the address.
That's exactly what this module is providing. Maybe base_location should depend
on this one...
--
https://www.openerp.com/apps/7.0/base_location/
--
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/city-move/+merge/196023
Your team Partner and Contact Core Editors is subscribed to branch
lp:partner-contact-management.
--
Mailing list:
I look for base_better_zip in apps and it is not available, can you point us
to this module to be sure we are talking about the same.
Nhomar, the correct name is better_zip, sorry, but this is because we keep a
symbolic link in the repository for backwards compatibility. It's the same as
@Sandy
Let's test base_location tomorrow morning if it does the job.
@Pedro
We will get back to you after our tests.
Thanks.
--
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/city-move/+merge/196023
Your team Partner and Contact Core Editors is subscribed to
OK, I set back the status of the MP to Work in progress until that.
Regards.
--
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/city-move/+merge/196023
Your team Partner and Contact Core Editors is subscribed to branch
lp:partner-contact-management.
--
Mailing
28 matches
Mail list logo
