Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/account-financial-report/6.1-analytic_entries_report_fiscalyear into lp:account-financial-report/6.1

Review: Approve code review Nothing wrong Holger! I would appreciate just a little comment that says that the query is identical, to save time to people evaluating the module in the future. I'm not blocking it though, thanks for your work! --

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/account-financial-report/6.1-analytic_entries_report_fiscalyear into lp:account-financial-report/6.1

Review: Needs Fixing code review Holger, It looks good, with a few small remarks: * I would expand further the description in __openerp__.py, stating explicitly that we are overriding the existing report from the account module. Furthermore: apart from the period, the query is the same as the

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/account-financial-report/6.1-analytic_entries_report_fiscalyear into lp:account-financial-report/6.1

Thanks for your input Leonardo! I took all your suggestions, but I don't understand your question about the query not being changed? It is the same, is there anything wrong with this? --

[Openerp-community-reviewer] [Merge] lp:~therp-nl/account-financial-report/6.1-analytic_entries_report_fiscalyear into lp:account-financial-report/6.1

Holger Brunn (Therp) has proposed merging lp:~therp-nl/account-financial-report/6.1-analytic_entries_report_fiscalyear into lp:account-financial-report/6.1. Requested reviews: Account Report Core Editors (account-report-core-editor) Related bugs: Bug #987038 in OpenERP Addons: Analytic