The proposal to merge lp:~initos.com/partner-contact-management/7.0 into
lp:partner-contact-management has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~initos.com/partner-contact-management/7.0/+merge/195066
--
Review: Approve code review
--
https://code.launchpad.net/~initos.com/partner-contact-management/7.0/+merge/195066
Your team Partner and Contact Core Editors is subscribed to branch
lp:partner-contact-management.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to
Thanks for the hint, I address this issue in my last commit.
--
https://code.launchpad.net/~initos.com/partner-contact-management/7.0/+merge/195066
Your team Partner and Contact Core Editors is subscribed to branch
lp:partner-contact-management.
--
Mailing list:
I have finally managed to shorten the lines so that the code now is PEP-8
compliant.
--
https://code.launchpad.net/~initos.com/partner-contact-management/7.0/+merge/195066
Your team Partner and Contact Core Editors is subscribed to branch
lp:partner-contact-management.
--
Mailing list:
Review: Needs Fixing
Thanks for the PEP8! Checking again the code for the final inclusion, I have
seen another potential problem: on the line 'if not default.get('ref')...' from
the copy, this means that if the original record hasn't got ref, it is assigned
a new one, but what we have to do is
On 11/18/2013 11:26 PM, Pedro Manuel Baeza wrote:
About is_company flag, it's very common that someone create a customer or a
supplier and don't check this flag, but for the system, it will behave the
same way as if you have ticked it, so I vote for stay as is.
Thank you for your response. I
On 11/19/2013 10:31 AM, Pedro Manuel Baeza wrote:
I think we are mixing 'is_company' and 'is_customer'/is_supplier meanings.
Yes, apparently my use case is for commercial partners, and your use
case is for partners marked as customer/suppliers. I must admit that my
use case is probably
On 11/19/2013 10:31 AM, Pedro Manuel Baeza wrote:
I think we are mixing 'is_company' and 'is_customer'/is_supplier
meanings.
Yes, apparently my use case is for commercial partners, and your use
case is for partners marked as customer/suppliers. I must admit that my
use case is probably
I have approved the MP to this branch because I see the changes very correct.
Thanks for proposing them.
Thomas, please take in consideration this proposition.
Regards.
--
https://code.launchpad.net/~initos.com/partner-contact-management/7.0/+merge/195066
Your team Partner and Contact Core
Review: Approve
Thanks for reviewing and taking my suggestions!
--
https://code.launchpad.net/~initos.com/partner-contact-management/7.0/+merge/195066
Your team Partner and Contact Core Editors is subscribed to branch
lp:partner-contact-management.
--
Mailing list:
Review: Needs Fixing
Hi Thomas, thanks!
l.176 The get() method of ir.sequence is deprecated. I think 'next_by_code'
should be used instead.
l.58 You claim authorship of the module, but I think 'Tiny' was the author.
Maybe share the credits like you share the copyright?
l.195 I'm wondering if
Thanks again for the hints. The new revision assigns codes to customers and
suppliers only. I also clarified the documentation.
--
https://code.launchpad.net/~initos.com/partner-contact-management/7.0/+merge/195066
Your team Partner and Contact Core Editors is subscribed to branch
Review: Needs Fixing
Hi, Thomas, sorry for bothering you again, but there is other things you can
improve:
- On __init__.py, instead of import partner, please put from . import
partner.
- On __openerp__.py, you put on description that the sequence is for customer,
but the code what makes is
Hi Pedro,
Thank you for your suggestions. I hope the new revision is more appropriate for
merging.
Best,
Thomas.
--
https://code.launchpad.net/~initos.com/partner-contact-management/7.0/+merge/195066
Your team Partner and Contact Core Editors is subscribed to branch
14 matches
Mail list logo
