Review: Abstain
--
https://code.launchpad.net/~trobz/web-addons/web-unleashed/+merge/195542
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Review: Approve
--
https://code.launchpad.net/~trobz/web-addons/web-unleashed/+merge/195542
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Thanks for your changes concerning context, they seem fine to me.
--
https://code.launchpad.net/~trobz/web-addons/web-unleashed/+merge/195542
Your team Web-Addons Core Editors is requested to review the proposed merge of
lp:~trobz/web-addons/web-unleashed into lp:web-addons.
--
Mailing list:
Hi Holger,
I did some changes on sources according to your comments, you can get
them on lp:~trobz/web-addons/web-unleashed
https://code.launchpad.net/%7Etrobz/web-addons/web-unleashed branch.
To resume my changes:
- 13
Dear Holger,
It's an honor that you have looked at my code so deeply, glad to know
you're liking it :)
About your questions:
*- your js tests will run twice, once from the web module, once triggered from
tests/test_js.py. Is this possibly a leftover from development?**
*
I did this because i
Looks pretty good! I'm yet to try it in a serious project, but for the time
being: Well done!
Some nits so far:
- your js tests will run twice, once from the web module, once triggered from
tests/test_js.py. Is this possibly a leftover from development?
- any reason to deviate from putting
just to inform you that I'm reading your code every now and then, but as it's a
lot of it, a review will take time...
--
https://code.launchpad.net/~trobz/web-addons/web-unleashed/+merge/195542
Your team Web-Addons Core Editors is requested to review the proposed merge of
Thanks for taking the time and feel free to ask me any questions :)
On 12/02/2013 09:02 PM, Holger Brunn (Therp) wrote:
just to inform you that I'm reading your code every now and then, but as it's
a lot of it, a review will take time...
--
8 matches
Mail list logo
