[Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-tools/account_partner_required-sbi into lp:account-financial-tools

2014-06-25 Thread noreply
The proposal to merge lp:~acsone-openerp/account-financial-tools/account_partner_required-sbi into lp:account-financial-tools has been updated. Status: Needs review = Merged For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-tools/account_partner_required-sbi into lp:account-financial-tools

2014-06-06 Thread Omar (Pexego)
Review: Approve code review LGTM -- https://code.launchpad.net/~acsone-openerp/account-financial-tools/account_partner_required-sbi/+merge/216442 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-tools/account_partner_required-sbi into lp:account-financial-tools

2014-05-09 Thread Joël Grand-Guillaume
Review: Approve code review, no tests Hi Stéphane, Thanks for the contrib, and as usual, thanks for providing tests :) LGMT, Regards, Joël -- https://code.launchpad.net/~acsone-openerp/account-financial-tools/account_partner_required-sbi/+merge/216442 Your team OpenERP Community

Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-tools/account_partner_required-sbi into lp:account-financial-tools

2014-04-29 Thread Lorenzo Battistini - Agile BG
Review: Approve code review Ok :-) -- https://code.launchpad.net/~acsone-openerp/account-financial-tools/account_partner_required-sbi/+merge/216442 Your team Account Core Editors is requested to review the proposed merge of lp:~acsone-openerp/account-financial-tools/account_partner_required-sbi

Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-tools/account_partner_required-sbi into lp:account-financial-tools

2014-04-25 Thread Acsone
Hello Lorenzo, About the constraints. This module is heavily inspired by account_analytic_required which used the same technique. I must confess I did not question the approach. Initially account_analytic_required was working mainly on the vals dictionary so it would have been faster than

Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-tools/account_partner_required-sbi into lp:account-financial-tools

2014-04-22 Thread Lorenzo Battistini - Agile BG
Review: Needs Information Hello Stéphane, why not using '_constraints' member instead of overriding create and write methods? Is there any technical reason to avoid YAML tests? Thanks! --

[Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-tools/account_partner_required-sbi into lp:account-financial-tools

2014-04-18 Thread Acsone
Stéphane Bidoul (Acsone) has proposed merging lp:~acsone-openerp/account-financial-tools/account_partner_required-sbi into lp:account-financial-tools. Requested reviews: Account Core Editors (account-core-editors) For more details, see: