The proposal to merge
lp:~acsone-openerp/account-financial-tools/account_partner_required-sbi into
lp:account-financial-tools has been updated.
Status: Needs review = Merged
For more details, see:
Review: Approve code review
LGTM
--
https://code.launchpad.net/~acsone-openerp/account-financial-tools/account_partner_required-sbi/+merge/216442
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list:
Review: Approve code review, no tests
Hi Stéphane,
Thanks for the contrib, and as usual, thanks for providing tests :)
LGMT,
Regards,
Joël
--
https://code.launchpad.net/~acsone-openerp/account-financial-tools/account_partner_required-sbi/+merge/216442
Your team OpenERP Community
Review: Approve code review
Ok :-)
--
https://code.launchpad.net/~acsone-openerp/account-financial-tools/account_partner_required-sbi/+merge/216442
Your team Account Core Editors is requested to review the proposed merge of
lp:~acsone-openerp/account-financial-tools/account_partner_required-sbi
Hello Lorenzo,
About the constraints. This module is heavily inspired by
account_analytic_required which used the same technique. I must confess I did
not question the approach. Initially account_analytic_required was working
mainly on the vals dictionary so it would have been faster than
Review: Needs Information
Hello Stéphane,
why not using '_constraints' member instead of overriding create and write
methods?
Is there any technical reason to avoid YAML tests?
Thanks!
--
Stéphane Bidoul (Acsone) has proposed merging
lp:~acsone-openerp/account-financial-tools/account_partner_required-sbi into
lp:account-financial-tools.
Requested reviews:
Account Core Editors (account-core-editors)
For more details, see:
7 matches
Mail list logo