The proposal to merge lp:~agilebg/openerp-mrp-reports/adding_mrp_webkit into
lp:openerp-mrp-reports has been updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~agilebg/openerp-mrp-reports/adding_mrp_webkit/+merge/207471
--
Review: Disapprove
I did the MP again, using bazaar extractor to preserve the original authors.
--
https://code.launchpad.net/~agilebg/openerp-mrp-reports/adding_mrp_webkit/+merge/207471
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:openerp-mrp-reports.
--
Ciao Nico
you should remove mrp_webkit/.DS_Store
and run a PEP8 validator
When importing Python modules from the same addon, use explicit relative
import rather than absolute import, example in __init__.py, do not use:
import sale
But
from . import sale
line 552: osv is
Review: Needs Fixing
line 418: added file 'mrp_webkit/report/.DS_Store'
line 594: there's something wrong with symlink
--
https://code.launchpad.net/~agilebg/openerp-mrp-reports/adding_mrp_webkit/+merge/207471
Your team OpenERP Community Reviewer/Maintainer is requested to review the
proposed
Review: Needs Fixing
Ciao Nico
you should remove mrp_webkit/.DS_Store
and run a PEP8 validator
When importing Python modules from the same addon, use explicit relative import
rather than absolute import, example in __init__.py, do not use:
import sale
But
from . import sale
line
Nicola Malcontenti - Agile BG has proposed merging
lp:~agilebg/openerp-mrp-reports/adding_mrp_webkit into lp:openerp-mrp-reports.
Requested reviews:
OpenERP Community Reviewer/Maintainer (openerp-community-reviewer)
For more details, see:
6 matches
Mail list logo
