Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/stock-logistic-flows/adding_product_customer_code_picking into lp:stock-logistic-flows

2014-07-03 Thread Alexandre Fayolle - camptocamp
Review: Resubmit The source code management for this project has been moved to https://github.com/OCA/stock-logistics-workflow Could you resubmit this MP on the new site? -- https://code.launchpad.net/~agilebg/stock-logistic-flows/adding_product_customer_code_picking/+merge/202472 Your team

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/stock-logistic-flows/adding_product_customer_code_picking into lp:stock-logistic-flows

2014-07-03 Thread Alex Comba - Agile BG
Alexandre, I'll do it asap. Cheers. -- https://code.launchpad.net/~agilebg/stock-logistic-flows/adding_product_customer_code_picking/+merge/202472 Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-flows. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/stock-logistic-flows/adding_product_customer_code_picking into lp:stock-logistic-flows

2014-07-03 Thread Alex Comba - Agile BG
Alexandre, you can find the related PR on github here: https://github.com/OCA/stock-logistics-workflow/pull/2 -- https://code.launchpad.net/~agilebg/stock-logistic-flows/adding_product_customer_code_picking/+merge/202472 Your team Stock and Logistic Core Editors is subscribed to branch

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/stock-logistic-flows/adding_product_customer_code_picking into lp:stock-logistic-flows

2014-06-23 Thread Lorenzo Battistini - Agile BG
2014-06-22 23:10 GMT+02:00 Alex Comba - Agile BG alex.co...@agilebg.com: Lorenzo, please have a look at my last commit, now it should be ok. Thanks Alex, maybe we could handle even more particular cases by using the address_get method to retrieve the company? --

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/stock-logistic-flows/adding_product_customer_code_picking into lp:stock-logistic-flows

2014-06-22 Thread Alex Comba - Agile BG
Lorenzo, please have a look at my last commit, now it should be ok. Cheers. -- https://code.launchpad.net/~agilebg/stock-logistic-flows/adding_product_customer_code_picking/+merge/202472 Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-flows. -- Mailing

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/stock-logistic-flows/adding_product_customer_code_picking into lp:stock-logistic-flows

2014-06-20 Thread Raphaël Valyi - http : //www . akretion . com
Review: Approve LGTM, pending merges have been processed now -- https://code.launchpad.net/~agilebg/stock-logistic-flows/adding_product_customer_code_picking/+merge/202472 Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-flows. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/stock-logistic-flows/adding_product_customer_code_picking into lp:stock-logistic-flows

2014-06-20 Thread Pedro Manuel Baeza
Review: Needs Fixing code review I have made some comments inline, and I wonder if the module name wouldn't be better as stock_picking_product_customer_code to follow current core conventions (more or less, you know that there is no written rules). Regards. Diff comments: === added

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/stock-logistic-flows/adding_product_customer_code_picking into lp:stock-logistic-flows

2014-06-20 Thread Alex Comba - Agile BG
Hi Pedro, thank you for your review and for your precious hints! I made the changes as you suggested us. In addition I fixed a bug in rev.58. Cheers. -- https://code.launchpad.net/~agilebg/stock-logistic-flows/adding_product_customer_code_picking/+merge/202472 Your team Stock and Logistic

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/stock-logistic-flows/adding_product_customer_code_picking into lp:stock-logistic-flows

2014-01-23 Thread Lorenzo Battistini - Agile BG
Review: Approve code review -- https://code.launchpad.net/~agilebg/stock-logistic-flows/adding_product_customer_code_picking/+merge/202472 Your team Stock and Logistic Core Editors is requested to review the proposed merge of

[Openerp-community-reviewer] [Merge] lp:~agilebg/stock-logistic-flows/adding_product_customer_code_picking into lp:stock-logistic-flows

2014-01-21 Thread Nicola Malcontenti - Agile BG
Nicola Malcontenti - Agile BG has proposed merging lp:~agilebg/stock-logistic-flows/adding_product_customer_code_picking into lp:stock-logistic-flows. Requested reviews: Stock and Logistic Core Editors (stock-logistic-core-editors) For more details, see: