Review: Approve code review, no tests
Just one inline comment
Otherwise LGTM
--
https://code.launchpad.net/~akretion-team/carriers-deliveries/7-split-default-option-state-from-deliv-method-dbl/+merge/224027
Your team Stock and Logistic Core Editors is subscribed to branch
Review: Approve
Ok failed my inline comment
l.102 field name=code readonly=1/
You can remove readonly here as you setted it on model
--
https://code.launchpad.net/~akretion-team/carriers-deliveries/7-split-default-option-state-from-deliv-method-dbl/+merge/224027
Your team Stock
l102 fixed, ready to merge
thanks to all
--
https://code.launchpad.net/~akretion-team/carriers-deliveries/7-split-default-option-state-from-deliv-method-dbl/+merge/224027
Your team Stock and Logistic Core Editors is subscribed to branch
lp:carriers-deliveries.
--
Mailing list:
Review: Needs Fixing
Hi
You don't have to test if available_option.mandatory is True but you can only
use if available_option.mandatory as it's a boolean the is True is useless.
--
@sebastien,
fix done, thank you for review
--
https://code.launchpad.net/~akretion-team/carriers-deliveries/7-split-default-option-state-from-deliv-method-dbl/+merge/224027
Your team Stock and Logistic Core Editors is subscribed to branch
lp:carriers-deliveries.
--
Mailing list:
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~akretion-team/carriers-deliveries/7-split-default-option-state-from-deliv-method-dbl/+merge/224027
Your team Stock and Logistic Core Editors is subscribed to branch
lp:carriers-deliveries.
--
Mailing list:
Review: Approve code review
Hi, David, thanks for the improvement.
You have to change module version number and provide a proper migration script
for those that have previously the module installed.
Regards.
--
Migrate script works for me.
I think it could merge
Only miss Yannick review
--
https://code.launchpad.net/~akretion-team/carriers-deliveries/7-split-default-option-state-from-deliv-method-dbl/+merge/224027
Your team Stock and Logistic Core Editors is subscribed to branch
David BEAL (ak) has proposed merging
lp:~akretion-team/carriers-deliveries/7-split-default-option-state-from-deliv-method-dbl
into lp:carriers-deliveries.
Requested reviews:
Yannick Vaucher @ Camptocamp (yvaucher-c2c)
For more details, see:
9 matches
Mail list logo