setting the MP as work in progress. Please set it back to needs review when
requested changes are made.
--
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community
Review: Needs Fixing
I set as need fixing after Frederic's comment
--
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
Review: Needs Information
Maybe the wildcard could be made configurable.
This way, Spanish accountants could use a dot (.), as they are so used to. And
in other countries it could be configured to be other character, like asterisk
(*) or any other.
Also, the pattern to search could be
Personally, I have been practicing accounting in UK, France and Switzerland and
I have never used a search based on dots. So +1 for something more configurable
(hence, more generic and potentially used by more people).
If not possible, like Stefan said, we should give a more specific name (like
Guewen and Frederic, do the responses satisfy your information requests? Also,
anyone else has an opinion about the name of the module?
--
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your
Review: Needs Information
Code looks good to me, and it's working fine. It looks to me like a very
specific use case, which also does not apply to Dutch accounting habits but it
may be broader than just Spanish (you never know, right?) so I think having the
module here is fine.
What bothers
@Frederic
OK, tested and also took a look at the code again. Right now, when using a dot
in the search it serves as a wildcard for zeroes.
So in your example if you search 101.0, you would find: 101.0, 1010, 1010,
101(any number of zeroes or the dot itself)0, but not 1001.
Also, if you
Review: Needs Information
Is it something only used in spain? Do you have an idea?
(If yes wouldn't it be better to put it in the Spanish localization?)
--
Hi, Guewen, it is used in Spain, but it's a generic tool useful for anyone that
has complex account charts (some countries on South America, and so on).
Regards.
--
Review: Approve (code review, no test)
LGTM!
--
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
Review: Needs Fixing
Hi, Alejandro, there is still some stuff from the previous functionality: you
can safely remove account_account_view.xml file, because it contains only
reference to chart_template_id stuff and it's not referenced in manifest file.
As I told you in another message,
Review: Resubmit
Done.
--
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list:
Review: Approve
Perfect! Thank you very much.
Regards
--
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
Always welcome.
Alejandro Santana
alejandrosant...@anubia.es
~
ANUBÍA, soluciones en la nube, S.L.
www.anubia.es
El 30/12/2013 15:37, Pedro Manuel Baeza pedro.ba...@gmail.com escribió:
Review: Approve
Perfect! Thank you very much.
Regards
--
Review: Resubmit
Changes made.
Yet I am not able to load module description translation after installing it.
--
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community
Yeah, that is!
--
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list:
Review: Needs Fixing code review
Alejandro, please fix these things:
- Remove all the chart template stuff, that doesn't belong to this module.
- Change module name and description in manifest file accordingly.
- Restart the version numbering to 1.0.
- Remove comment about templates at the
17 matches
Mail list logo
