Review: Approve
--
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-fix-product_historical_margin-no-product-yvr/+merge/211354
Your team Margin Analysis Core Editors is subscribed to branch
lp:margin-analysis.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post
The proposal to merge
lp:~camptocamp/margin-analysis/7.0-fix-product_historical_margin-no-product-yvr
into lp:margin-analysis has been updated.
Status: Needs review = Merged
For more details, see:
@Pedro I checked and found no way to have the read method gives a False or an
empty list when giving a valid id to it.
--
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-fix-product_historical_margin-no-product-yvr/+merge/211354
Your team Margin Analysis Core Editors is subscribed to
Review: Approve code review, test
LGTM
--
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-fix-product_historical_margin-no-product-yvr/+merge/211354
Your team Margin Analysis Core Editors is subscribed to branch
lp:margin-analysis.
--
Mailing list:
Yannick Vaucher @ Camptocamp has proposed merging
lp:~camptocamp/margin-analysis/7.0-fix-product_historical_margin-no-product-yvr
into lp:margin-analysis.
Requested reviews:
Margin Analysis Core Editors (margin-analysis-core-editors)
Related bugs:
Bug #1293612 in Financial controlling and
Review: Needs Information code review
Why do you need to re-read product record? You can make:
product = obj.product_id
Or there is something I'm missing?
Regards.
--
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-fix-product_historical_margin-no-product-yvr/+merge/211354
Your
6 matches
Mail list logo
