The proposal to merge
lp:~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge into
lp:sale-wkfl has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge/+merge/214719
--
The proposal to merge
lp:~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge into
lp:sale-wkfl has been updated.
Status: Needs review = Work in progress
For more details, see:
https://code.launchpad.net/~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge/+merge/198960
--
Thanks! LGTM
--
https://code.launchpad.net/~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge/+merge/214719
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve
l.120 is CamelCase the standard now?
--
https://code.launchpad.net/~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge/+merge/214719
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
@Sandy I often use CamelCase in my modules and this for past 2 years. No
decision was made on mailing list though a majority of people were for
CamelCase. For now I would say we are still in a non settled area of
convention. So I took the risk to stick to CamelCase for this one.
--
@Yannick Good to know, thank you.
--
https://code.launchpad.net/~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge/+merge/214719
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Joël Grand-Guillaume @ camptocamp has proposed merging
lp:~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge into
lp:sale-wkfl.
Commit message:
[ADD] sale_jit_on_services module that provide the mrp_jit feature but only on
product of type service.
Requested reviews:
Sandy Carter
Review: Approve
--
https://code.launchpad.net/~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge/+merge/198960
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Fixed typos
--
https://code.launchpad.net/~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge/+merge/198960
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Thanks Sandy
--
https://code.launchpad.net/~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge/+merge/198960
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
The proposal to merge
lp:~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge into
lp:sale-wkfl has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge/+merge/198960
--
Review: Approve code review
LGTM
--
https://code.launchpad.net/~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge/+merge/198960
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
The proposal to merge
lp:~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge into
lp:sale-wkfl has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge/+merge/198960
--
Review: Needs Fixing
--
https://code.launchpad.net/~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge/+merge/198960
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Missed Guewen's comment
It should be better using workflow some work still needed
--
https://code.launchpad.net/~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge/+merge/198960
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list:
Review: Approve code review, no test
Just fixed some PEP8 issues.
LGTM
--
https://code.launchpad.net/~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge/+merge/198960
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list:
I would greatly appreciate some tests on the module, before merging it.
--
https://code.launchpad.net/~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge/+merge/198960
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list:
Regarding the second remark, I think it's ok not to filter on only buy one
cause I just run the button. As this module is called JIT on service, I think
it's ok to automatically run the procurement related to them.
--
Review: Needs Fixing code review
Just wondering if the logging is supposed to be there or just there for
debugging purposes.
If that's the case, you might want to remove it.
Some PEP8 issues:
__init__.py:3:2: W291 trailing whitespace
__init__.py:19:75: W291 trailing whitespace
19 matches
Mail list logo
