The proposal to merge
lp:~therp-nl/account-financial-tools/7.0-add_move_line_no_default_search_period_journal
into lp:account-financial-tools has been updated.
Status: Needs review = Merged
For more details, see:
Review: Approve code review
We thought about doing the same module - we are annoyed by this default
behavior - and you did it! So nice ;-)
LGTM
Thanks
--
https://code.launchpad.net/~therp-nl/account-financial-tools/7.0-add_move_line_no_default_search_period_journal/+merge/207841
Your team
The proposal to merge
lp:~therp-nl/account-financial-tools/7.0-add_move_line_no_default_search_period_journal
into lp:account-financial-tools has been updated.
Status: Needs review = Work in progress
For more details, see:
Turns out I need to resolve the following issue: the icon path in the module
table can only contain 64 chars, while
move_line_no_default_search_period_journal/static/src/img/icon.png is 66
characters :-(
--
I suggest to change name to account_move_line_no_default_search:
- It includes account prefix for account related stuff.
- It's descriptive enough
- It's shorter than previous name.
--
Agreed.
--
https://code.launchpad.net/~therp-nl/account-financial-tools/7.0-add_move_line_no_default_search_period_journal/+merge/207841
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list:
Renamed the module and updated references to the module name in data and code.
Thanks for the name suggestion, Pedro!
Also reported https://code.launchpad.net/bugs/1278204 and suggested a fix for
the underlying problem.
--
Stefan Rijnhart (Therp) has proposed merging
lp:~therp-nl/account-financial-tools/7.0-add_move_line_no_default_search_period_journal
into lp:account-financial-tools.
Requested reviews:
Pedro Manuel Baeza (pedro.baeza)
For more details, see:
Review: Approve code review and test
Hi, Stefan,
I have tested the module and now I see no reason for the new menu I proposed,
because it only changes default values. It doesn't remove combo-boxes, which is
what I understand at the beginning.
It works perfectly.
Thanks for the contribution.
Hi Pedro, thanks for your input. I have a feeling that having an additional
view and menu item would feel cramped and could easily confuse people so I
think that having this optional module to change the default search setting for
every user of the database is the right level.
--
Stefan Rijnhart (Therp) has proposed merging
lp:~therp-nl/account-financial-tools/7.0-add_move_line_no_default_search_period_journal
into lp:account-financial-tools.
Requested reviews:
Account Core Editors (account-core-editors)
For more details, see:
11 matches
Mail list logo
