Review: Approve code review, no tests
LGTM now, thanks !
--
https://code.launchpad.net/~yannick-buron/contract-management/contract-management/+merge/207630
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:contract-management.
--
Mailing list:
Review: Approve code review
Thanks Yannick, agree with others on for not diverging for a backport. I would
be happier backporting something that has tests, but that's not your fault,
Yannick :)
--
https://code.launchpad.net/~yannick-buron/contract-management/contract-management/+merge/207630
I'm really sorry guys, I took so long for answering even if you answered right
away... I guess I missed the notice email.
1) It was a oversight, I copy/paste another file of my own module, I corrected
line 10 but forgot line 68. I didn't planned to add my name on this module, but
you're right
Hi Ronald and Yannick,
Ok, after coming back on this one, I agree with you Ronald. We should leave it
as is, so fixes will be much easier to port !
So @Yannick, if you can just correct 1st and 4th point and it ok for me.
Regards,
Joël
--
Hi, Joël,
I would say contributors section instead of author for your first point,
doesn't it?
Regards.
--
https://code.launchpad.net/~yannick-buron/contract-management/contract-management/+merge/204718
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
YannickB has proposed merging
lp:~yannick-buron/contract-management/contract-management into
lp:contract-management.
Requested reviews:
Contract Management Core Editors (contract-management-core-editors)
For more details, see:
As for the 2nd and 3rd points: in this case I think it is best to leave the
backported code as is.
If there are any enhancements in the code in trunk, it will be much easier to
adopt them when the backport is really a backport.
If we really would like to have a module fashioned after community
7 matches
Mail list logo
