Review: Approve code review
--
https://code.launchpad.net/~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7/+merge/213987
Your team Account Core Editors is subscribed to branch lp:account-invoicing.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to
Pedro and Lorenzo,
FYI, after your approve, I still added the file icon.png (ver. #49).
Cheers.
--
https://code.launchpad.net/~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7/+merge/213987
Your team Account Core Editors is subscribed to branch lp:account-invoicing.
--
Thanks for the info, Alex,
Also FYI, if you feel that any other change needs a revision, you can click on
Resubmit proposal to reset reviews.
Regards.
--
https://code.launchpad.net/~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7/+merge/213987
Your team Account Core Editors
Thanks for the tip about Resubmit proposal, Pedro.
Cheers.
--
https://code.launchpad.net/~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7/+merge/213987
Your team Account Core Editors is subscribed to branch lp:account-invoicing.
--
Mailing list:
Hi Pedro,
now it should be ok, please have a look at it, thank you.
Cheers.
--
https://code.launchpad.net/~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7/+merge/213987
Your team Account Core Editors is subscribed to branch lp:account-invoicing.
--
Mailing list:
Hi, Pedro, thanks a lot for your review.
I made the changes as you suggested, please have a look at them.
About:
Don't you think that it's convenient to copy incoterm (if any) from sale
order to picking?
This module depends on 'stock_invoice_picking' and has been designed on purpose
when
Review: Needs Fixing code review
Hi, Alex,
Thank you for the changes you have made, and the explanation about the sale to
invoice procedure.
One more thing before the approval: please check again multi-line texts. They
are still bad constructed and split wiht a lot of spaces on translations.
Review: Needs Fixing code review
Hi, Alex, thank you very much for the contribution. Some remarks:
- l.137: Please close string before \ to avoid that spaces on translations (you
will have to export again translations):
help=International Commercial Terms are a series of predefined \
8 matches
Mail list logo